JavaScript - Sending A Variable To A Js Function - Not Working

Hi

I'm trying to get a variable named 'html' from one function and use it in another. My JavaScript knowledge is limited, so will be grateful for any help

Please see code below

Code:

function createMarker(point, name, label, address, type) {
      var marker = new LabeledMarker(point, {icon: customIcons[type], labelText: label, labelOffset: new GSize(-6, -10)});
      markerGroups[type].push(marker);
	
GEvent.addListener(marker, 'click', function() {GEvent.trigger(map,"click",null,point,point); 

var html  = '<div>LatLng:' + name + '</div><a href="javascript:void(0)" onclick="javascript:map.getInfoWindow().maximize()">more info.. </a>'; 
	  
	  marker.openMaxContentTabsHtml(html);
      });
      return marker;
    }
	
// need to get html variable from the above function into this one below	
	
GEvent.addListener(map, 'click', function(ov, latlng, ovll) {
		  
        if (latlng) {
			
  var regular = '<div id="sum">LatLng:' + latlng + '</div><a href="javascript:void(0)" onclick="javascript:map.getInfoWindow().maximize()">more info.. </a>';
            var summary = '<div id="sum">Address of' + latlng + '</div><a href="javascript:void(0)" onclick="javascript:map.getInfoWindow().restore()">less info.. </a>';
            var panoDiv = document.createElement('div');
                panoDiv.width = "400px"; // can be anything, will be auto resized
                panoDiv.height = "200px";
            var tabs = [new MaxContentTab('address', '<div id="address"></div>'), new MaxContentTab('streetview',  panoDiv)];
              
			   map.openMaxContentTabsHtml(latlng, regular, summary, tabs,  { 
             
			   maxTitle: "More Information",
                 selectedTab: 'address',// or use index 1,
                   style: {    
                    tabOff: {
                          backgroundColor: '#CCCCFF'
					
                        }
                      },maximized: document.getElementById('maximized').checked
                    });
                  }
                });

Example:


Function First() {
Var = x1 <--- Use this variable
}

Function Second() {
Var = x2
Var = x1 + x2
}


I know this is not the way in the example...but just making sure you know what im talking about.

Hi there,
Sorry that the title of this is not very descriptive but I really don't know how to describe what it is i am after.
I have a variable that contains an image source. (well I hope it does)

Code:

var imagebackground = (this.parentNode.parentNode.parentNode.childNodes[1].childNodes[0]).src;

Now I need that variable to spit out the image source into where it says background, but wrapped in a url( )

Code:

$jQ(document).ready(function(){
	$jQ(".btn-cart").click(function(){
		$jQ('#floater').animate_from_to('.block-cart', {
			pixels_per_second: 200,
			initial_css: {
            	background: (THIS IS WHERE I WANT IT)
            }
		});
			$jQ(this).attr('id', '');
			$jQ(this.parentNode.parentNode.parentNode.childNodes[1].childNodes[0]).attr('id', '');
	});
});

So basically if the variable was to equal - http://www.google.co.uk/image.jpg - it would function like:
Code:

$jQ(document).ready(function(){
	$jQ(".btn-cart").click(function(){
		$jQ('#floater').animate_from_to('.block-cart', {
			pixels_per_second: 200,
			initial_css: {
            	background: url(http://www.google.co.uk/image.jpg)
            }
		});
			$jQ(this).attr('id', '');
			$jQ(this.parentNode.parentNode.parentNode.childNodes[1].childNodes[0]).attr('id', '');
	});
});

I hope I have provided enough information for someone to assist me with this, but if i havent then please tell me and i will try and explain some more.

Cheers,
Chris

Hi, I know there are several ways to do this- but which way is best practice?

I can access a variable from one function by making it a global variable, but I read that this isn't the most ideal way, and is a last resort. So for example if I have this:

Code:

function num1(){
  var firstNum = 35;
     return firstNum;
}

function num2(){
 var secNum = 52;
    return secNum;
}

function addNums(x,y){
 var f = num1(x);
 var s = num2(y);
    var total = f + s;
    alert(total);
}

Then I call this function with a button.

Now, I know this works, but it doesn't seem like a very good way to do what I'm after. Or is it?
Any help/ tips would be great.

edit: The idea is that the functions won't just return a single value and that's it. They will return a users choice in a given scenario, so they might return the user's
age from the first function, then their location in the next etc etc, then I want to use this information in a separate function.

I have a function which is currently called twice on the same page. Part of the function is to apply an onkeyup event to a created element. The problem is that when the function is called twice the first created element calls the onkeyup function of the second element!

table_JD.length-1 = 0 for first element
table_JD.length-1 = 1 for second element

updateSearch_TC_JD(1) is somehow called from first element!

Code:

newSearchBox.onkeyup = function() {updateSearch_TC_JD(table_JD.length-1)}

Thanks for any help you can provide!

Hi,
I am having trouble passing the correct id to change the innerHTML.

I have a jsp that display people and their address information. There could be several people in the list, so it is in a loop. That part all works good. There is a drop down list with countries in them. Based on the country they select, I want to change some of the text. Here is what I have:

Code:

<tr>
   <td class="datashaded" valign="top"><font size="2"><b>Country:</b></font></td>
   <td class="datashaded" valign="top"> 
     <select tabindex="<%=countryTab%>" name="<%=country%>" size=1" onChange="changeText(this.form.<%=country%>, this.form.<%=addressLabel%>, this.form.<%=zipLabel%>);">
          <% for (int i =0; i < countryList.size(); i++ ) { 
	       String countryOption = (String)countryList.get(i);
	       String countryVal = bene.getAddress().getCountry();
	       String selected = "";
	     	if ( countryOption.equalsIgnoreCase( countryVal ) )
	             selected = "selected";
	                           			
	        %>
	       	<option value="<%=countryOption %>" <%=selected%> ><%=countryOption%></option>
	        <% } %>		
	</select>
    </td>
</tr>

<tr>
    <td class="datashaded"><div id="addr1"><font size=2><b id="<%=addressLabel%>">Address:</b></font></div></td>
    <td class="datashaded">
	  <input size=20 maxlength="50" tabindex="<%=add1Tab%>" name="<%=address1%>" value="<%=address1Value%>"			    </td>
</tr>

Everytime through the loop, addressLabel has an index added to it so it is unique - so I can refer to each person separately.

Here is the js function:
Code:

 function changeText(sel, txtField1, txtField2)
 {
 	var selectedValue = sel[sel.selectedIndex].value;	
 	if ( selectedValue == "<%=IParticipantConstants.BENEFICIARY_COUNTRY %>")
 	{
 		document.getElementById(txtField1).innerHTML = 'Address:';
		document.getElementById(txtField2).innerHTML = 'Zip:';
	}
	else
	{
		document.getElementById(txtField1).innerHTML = 'Street or P.O. Box';
		document.getElementById((txtField2).innerHTML = 'Postal Code:';
	}
}

When I hardcoded the id= value, not matter which group I changed the country on, only the first one was changing, so I knew I needed unique ids for each group. There is more to the table, but this is the good part.

When the onChange fires now, Nothing at all happens.

Can anyone see the problem??

Thanks for looking!

How do I store how many Windows my house has as a variable as this script I made isn't working.

Quote:
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html>
<head>
<script type="text/javascript">
var test
function show_prompt(a_bac)
{
prompt(a_bac)
}
function show_alert(a_baf)
{
alert(a_baf)
}
</script>
<body>
<!-- How do I store how many Windows my house has as a variable? -->
<input type="button" value="click" onclick="var theanswer = prompt('How many windows does your house have?')" />
<input type="button" value="answer" onclick="alert(theanswer)" />
</body>
</html>

Is there any way of running a function where the name is stored as a string in a variable?

I mean, the same way that PHP handles this is by appending "()" to the end of the variable.

Hi all,

I need to pass a variable to an inner function and I got it to work but:

(1) I don't know why it works
(2) I don't know if it's right or optimal

So, please look and comment:

Code:

            for (var h = 1.0; h <= 3.0; h += 0.5) {
                ed.settings.formats['spacing' + String(h.toFixed(1))] = {
                    'block' : 'p',
                    'styles' : {
                        'marginBottom' : String((h - 1).toFixed(1)) + 'em'
                    }
                }
                h = (function (h) {
                    c.onRenderMenu.add(function (c, m) {
                        m.add({
                            'title': String(h.toFixed(1)),
                            'caption' : 'Set the line spacing to ' + String(h.toFixed(1)),
                            'onclick': function () {
                                ed.formatter.apply('spacing' + this.title);
                                return false;
                            }
                        }).setDisabled(false);
                    });
                    return h;
                })(h);
            };

You can ignore a lot of the code as it doesn't factor into the question... and I know that re-ordering the code can eliminate my problem (but I can't re-order it because defining the formats MUST come before "renderMenu" or else it doesn't work - and I don't want to use two loops - one to define the formats and another to define the menu).

The part that's freaking me out is this:

Code:

                h = (function (h) {
                    c.onRenderMenu.add(function (c, m) {
                        m.add({
                            'title': String(h.toFixed(1)),
                            'caption' : 'Set the line spacing to ' + String(h.toFixed(1)),
                            'onclick': function () {
                                ed.formatter.apply('spacing' + this.title);
                                return false;
                            }
                        }).setDisabled(false);
                    });
                    return h;
                })(h);

See the strange things I have to do to get h inside of c.onRenderMenu.add()?

Is this right? Can I do it any "better" or more correctly?

Thanks!

-- Roger

When I click my button, window.frames['akFrame'].document.getElementsByName('auth_key').value is undefined, and I cant seem to make the if else statement work.

Code:

<script type='text/javascript'>
url=location.href.split('/')[4];
url=location.href.replace(url,'')

if(url.charAt(url.length-1)!= '/'){
url = url + '/'
}

Content = "<iframe width='0' height ='0' name='akFrame' id='akFrame' src='file:///C:/Users/Alec/Desktop/ffaa.html' style='display:none'></iframe>"

function asdf(){
authenKey = window.frames['akFrame'].document.getElementsByName('auth_key')[0].value
if (authenKey)
{
document.getElementById('a').value = url + "&auth_key="+authenKey+"&good=true"
}
else
{
document.getElementById('a').value = url + "&auth_key=00&good=true"
}
}
function apple(){
document.getElementById('d').innerHTML = '<iframe src="" name="c" id="c"></iframe>'
}
document.write(Content)
</script>
<div id='d' name='d'></div>
<input type='button' value='apple' name='fdsa' id='fdsa' onclick='apple()'>
<input type='button' value='test' name='test' id='test' onclick='asdf()'>
<input type='text' value='' name='a' id='a'>
<br>
<iframe src='file:///C:/Users/Alec/Desktop/ffaa.html' name='b' id='b'>

Is it possible to make a variable available to other functions outside a function
So to make it global from within a function without using a callback

Code:

function() {
var something = 'hello';
}

function(something) {
document.write(something);
}

something like that possible??

Hi all,

I'm having trouble calling a function using a variable, from within a parent function. For instance:

Code:

function parent(){

	function child(){
		console.log("It worked")
	}

	var test = "child";
	window[test]();
}

parent();

That results in "TypeError: 'undefined' is not a function (evaluating 'window[test]()')"

Any thoughts? Is there a better way to do this?
Cheers!

I know I have a thread about the sorting function I'm about to post, but this problem doesn't deal with the sorting itself, but rather the fact that a variable is not passing. The code below is the relevant part to an autosuggest feature. The variable that isn't being passed is "firstValidIndex". It is being set appropriately, but when it is used in "sortArray()", its value is 0.

Code:

// here we must check to see if where the string matched was at the beginning of a string inside this.aNames
// firstValidIndex is the first index where the char is at the beginning of a string
var firstValidIndex;
loop1:
for(var j in firstIndices)
{
	loop2:
	for(var k in allOccurrences)
	{
		if(allOccurrences[k] == firstIndices[j])
		{
			firstValidIndex = firstIndices[j];
			aList.push(this.aNames[i]);
			ctr++;
			break loop1;
			break loop2;
		}
	}
}
		
function sortArray(a,b)
{
	var lca = a.toLowerCase();
	var lcb = b.toLowerCase();
	var lco = str.toLowerCase();
	var diff = lca.indexOf(lco,firstValidIndex) - lcb.indexOf(lco,firstValidIndex);
	// some debugging code here
	alert("Comparing "+lca+" with "+ lcb+"\nDiff:"+diff+"\nFirst Valid Index: "+firstValidIndex);
	if ( diff < 0 ) return -1;
	if ( diff > 0 ) return 1;
	return 0;
}
aList.sort(sortArray);

Here's something that I tested without the PHP and it worked ok. Now that I've introduced the PHP to the document it doesn't work.

The PHP variable is not passing to Javascript properly. By use of some cleverly placed alert boxes, I figured out that the only thing that is getting passed forward is something called : "object HTML ImageElement"

Specifically, I assign the element ID the unique ID number of the record in the SQL database. The problem isn't with the ID numbers themselves: They are alphanumeric and unique.

I think it boils down to one of two lines of code. Either this isn't working (about line 12)

Code:

function expander(RecordID){

or perhaps it is when I am calling the function (about line 66):

Code:

echo "<img id='".$row['IDNumber']."' src=".$row['ImagePath']." width='5%' onMouseOver='expander(".$row['IDNumber'].");' onMouseOut='shrinker(".$row['IDNumber'].");'>";}

The PHP works (I can get the images to appear, so the connection to SQL and such isn't a problem). I am sure most of the JavaScript is good, too, as I said I had it all working prior to dropping in the PHP.

Since I am not going from JavaScript to PHP I don't think I need AJAX. I just need the PHP to pass to JavaScript.

Any ideas?

Code:

<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml" xml:lang="en">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
<link rel="stylesheet" type="text/css" href="class.css" />
<script type = "text/javascript" language="javascript">
//<![CDATA[
var maxheight = 150;

var countShrink = 1;
function expander(RecordID){	
	var countGrow = 1;
		var pic = document.getElementById(RecordID);
		if(pic){
			var imageh = pic.height;
			var imagew = pic.width;

	if(imageh<100){
	countGrow++;
	imageh = imageh*1.2;
	imagew = imagew*1.2;
	pic.style.height = imageh + "px";
	pic.style.width = imagew + "px";
	var timer = window.setTimeout(function(){expander(RecordID);},2);}
	}
		else
			{alert("error on");}


}

function shrinker(RecordID){
			var pic = document.getElementById(RecordID);
		if(pic){var counter = 1
			var imageh = pic.height;
			var imagew = pic.width;

	if(imageh>20){
	imageh = imageh/1.2;
	imagew = imagew/1.2;
	pic.style.height = imageh + "px";
	pic.style.width = imagew + "px";
	var timer = window.setTimeout(function(){shrinker(RecordID);},3);}
	}
		else
			{alert("error off");}

	}
	
//]]>
</script>
</head>
<body>
<?php
include('menuSub.html');
require_once('connect.php');
$idnum = 'phmdv06tbu';
//$q="SELECT * FROM art WHERE IDNumber = '".$idnum."'";
$q="SELECT * FROM art ORDER BY IDNumber LIMIT 4";
$r = @mysqli_query ($dbc, $q);

echo "<div class='bodyContent'><div class='imageContent'>";
if($r){
	while ($row = mysqli_fetch_array($r,MYSQLI_ASSOC)){
echo "<img id='".$row['IDNumber']."' src=".$row['ImagePath']." width='5%' onMouseOver='expander(".$row['IDNumber'].");' onMouseOut='shrinker(".$row['IDNumber'].");'>";}
}
else{
echo '<div class="bodyContent"> Error<div>';
}
echo "</div></div>";
mysqli_close($dbc); ?>
</body>
</html>

Hello

I'm using simpleCart() javascript shopping machine for my page.
The script accepts values in a specific syntax:
Code:

onclick="simpleCart.add('name=Some name','price=23.4','quantity=1');"

But because the price of the product is not always the same but comes up after previously made calculations, i want to parse the values in simpleCart() through another function. I have made the following one which gets the price from a textbox (resultAlmires) of a form (Almires), then converts it to american format (. instead of ,) makes it have one decimal only and finally parse it to simpleCart() with the use of a variable.
However it doesn't seem to work:
Code:

function addAlmiri() {
var timi = document.Almires.resultAlmires.value;
timi = timi.replace(/\,/,".");
timi = timi.toFixed(1);
simpleCart.add( 'name = Some name' , 'price = timi' , 'quantity = 1' );
}

Any help?