JavaScript - Windows.open - Pop Up And Return Some Value

I am getting double Alert prompts for a single form: The alert pops up the first time, then when I click OK, the same one pops open again. I think my code should do the alert once when it hits "else window.alert(sameWarning) and the stop when it reaches "return false()"; but it seems return false() is causing the alert twice. Maybe because I have two forms on one page; yet, they have two separate function names ("signinForm()" and "saveSignUp()")and call two separate forms (forms[0] and forms[1])? I think my code is correct, but I can't figure it out at this point. Any help would be appreciated. Thanks in advance!

Code:

      <script type="text/javascript">
    //FIRST FUNCTION FOR FORMS[0]
    function signinForm(){
    
    		// var sameWarning = "The required fields were not submitted for the following error(s).  \n \n";
    		var warningLogin = "The following field(s) require an entry: \n \n";
    		var sameWarning = warningLogin;
    		
    		var userName = document.forms[0].userName.value;
    		var pswd = document.forms[0].pswd.value;
    		
    		if(userName == ""){ 
    		sameWarning += " - First Name \n";
    		}
    		
    		if(pswd == ""){ 
    		sameWarning += " - Password \n";
    		}
    
    		if (warningLogin == sameWarning){ 
    			return true; 
    			}
    		
    		else  { 
    			window.alert(sameWarning); 	
    		}
        return false;	
       }
     
  //SECOND FUNCTION CALL FOR FORMS[1] 
    function saveSignUp(){
    
    		// var warning = "The required fields were not submitted for the following error(s).  \n \n";
    		var warning = "The following field(s) require an entry: \n \n";
    		var same = warning;
    		
    		var firstName = document.forms[1].firstName.value;
    		var lastName = document.forms[1].lastName.value;
    		var email = document.forms[1].email.value;
    		var phone = document.forms[1].phoneNumber.value;
    		
    		if(firstName == ""){ 
    		//firstName.style.backgroundColor="red";
    		warning += " - First Name \n";
    		}
    		
    		if(lastName == ""){ 
    		warning += " - Last Name \n";
    		}
    
    		if(email == ""){ 
    		warning += " - Email \n";
    		}
    
    		if(phone == ""){ 
    		warning += " - Work Phone \n";
    		}
    		
    		if(phone < 5 ){
    			warning += " - Must be a numberssss \n";
    			}
    
    		if (warning == same){
    			return true; 
    		} 
    		
    		else  { 
    			alert(warning); 		
    		}
    	return false;
       }
       
    </script>

HTML

Code:

    <h1>Login</h1>
    <form method="post" onsubmit="return signinForm();" action="" >
        <input type="text" placeholder="Username/Email" name="userName">
        <input type="password" placeholder="Password" name="pswd" id="pswd">
        <input type="submit" onclick="signinForm();" value="Sign In">
    </form>
    <h1>Sign Up!</h1>
        <form method="post" onsubmit="return saveSignUp()" action="" >
        <input type="text" placeholder="First Name" name="firstName">
        <input type="text" placeholder="Last Name" name="lastName">
        <input type="text" placeholder="Email" name="email">
        <input type="text" placeholder="Phone Number" name="phoneNumber">
        <input type="submit" onclick="saveSignUp();" class="button wide" value="Request an Account">		
</form>

*UPDATE
Fixed! After I removed the onclick in the button, the double alerts went away. Apparently, I was I was firing off two events (calling the javascript twice) with both the onsubmit and the onclick.

Just wondering:
1. Is "onsubmit" a special event handler just for button "type=submit" vs onlclick can be used for any element?
2. Is there a preference among developers to use onclick vs. onsubmit?
3. Is there an order of precedence for method calls over submit calls (the onclick goes first, then it automatically fires the submit call to the function too)?

This is a pet peeve of mine and I'm still looking for a solution.

If I have designated a specific size dimension for a popup window to open with (as one must, otherwise why even use a pop-up window?) then it should be obvious that the window needs to open up at 100% (normal) magnification, otherwise the contents of the window will not be displayed properly.

It seems to me current browsers are struggling with this problem, as Firefox, Safari, and Opera all handle it differently. For example, Firefox applies magnification settings defined by the user to dimensions of the pop-up window but not to the contents (an odd solution!); Opera retains the correct dimensions but applies magnification to the contents. Only Safari handles it correctly: even if you have applied magnification to a web page it will still open pop-up windows at default 100% magnification and honor the dimensions specified in the HTML code by the page designer.

Thanks for any help you can provide.

I don't understand the logic of Break, Return False, Return True. It was never really covered in our college class, and I see everyone using it. I got an A in the class, if that 'proves' that I really tried to apply myself.

NOTE: I understand what the function is doing. I just don't understand WHEN to use break, return false or return true if the the translator can determine the conditional statements.


PHP Code:
function submitForm(){
var ageSelected = false;

for (var i=0; i<5; ++1){
if (document.forms[0].ageGroup[i].checked == true) {
ageSelected = true;
break; 
  }
}

if (ageSelected == false){
window.alert("You must select your age group");
return false;
}

else
return false;
} 




if the the translator can determine the conditional statements, why not write it like this:

PHP Code:
function submitForm(){
var ageSelected = false;

for (var i=0; i<5; ++1){
if (document.forms[0].ageGroup[i].checked == true) {
ageSelected = true;
break; // what's the point for the 'break'? Won't the rest of the code be ignored since it passed the first condition?
  }
}

if (ageSelected == false){
window.alert("You must select your age group");
return false;
}
// why not leave the last else out? is it just a 'safety' catch, in case something other than true or false is inputted?
else
return false; // what's the point?
} 




Questions:
Why use return true, if the translator knows it's ture? Why use "return false" if the translator knows it's false and the alert window has already gone up? why not use "break" to stop the code? Why use the "return false" at the end "else" statement?

Hi room,

Hey, I opened up the source code for this page in google chrome and since i'm learning javascript, i wanted see if i could "read" it and figure out what was going on. I'm am having the hardest time understanding "return false" and "return true". Could someone step me through this via interpreting this code (in bold typeface):

Code:

	var DefaultValue = 'Search';						
	function clearSearch() {
	  if (document.searchForm.q.value == DefaultValue) {
		document.searchForm.q.value = '';
	  }
	}						
	function validateSearchHeader() {
		if ( document.searchForm.q.value == '' || document.searchForm.q.value.toLocaleLowerCase() == DefaultValue.toLocaleLowerCase() ) {
			alert('Please enter at least one keyword in the Search box.');
			document.searchForm.q.focus();
			return false;
		}
	  return true;
	}

Thanks!

Hi,

I want to restrict opening my popup window if it is already opened. For simple scenario, it is quite possible to do but in my case --

1) When parent page is opening popup window, it is getting refreshed (required from client for some reason).

2) Once submit button is clicked from popup window, again parent page is getting refreshed (again its a requirement from client side).

With these 2 conditions, I lost my saved value from variable and hence new popup is keep coming when the action is same.

Currently I am using below code to open popup

[CODE]
function OpenWindow()
{
if(winPop && !winPop.closed)
{
alert("Popup is already open");
}
else
{
winPop = window.open('MyPopupPage.aspx');
}
}
[CODE]

Please help me to get rid of this problem.
Thanks in advance.

- Bhasker