JavaScript - Object Array And Using Splits

The following code snippet:
(this.inputArray is already defined and initialized prior to this code sequence)
if(this.inputArray.length >= 0)
{
this.inputArray[this.inputArray.length] = new Object();
this.inputArray[this.inputArray.length].type = 'pcDisp';
this.inputArray[this.inputArray.length].data = a;
}
the first line in the code block should create a new array item and initialize
it with the various assigments in the next lines.
But Firefox complains
"this.inputArray[this.inputArray.length] is not defined".
This is very disconcerting because the code has to create array items
with different data based on conditionals. So I must be able to automatically create new items as necessary. I thought that javascript had 'late binding', but maybe that doesn't apply here.

So, does anyone have a clue for me?

I have an array of objects that I would like to sort through and "join" objects that are the same. And if they are the same, I need to sum up the number value given for those two items.

So I guess Im sorting through and maybe even recreating this array to get rid of duplicates while I tally quantities.

Please see the screenshot of my array of objects to help understand better. The highlighted 'sPSPN' would indicate that it is a duplicate item and its 'fUnits' need to be totalled.

in the end I would have a total of 3 objects, because 'sPSPN'= BT-221-44 would now be only one object with 'fUnits' = 35.

Thanks!

Hello,

I've made a JS code that declare events based on year, month and days.
Each date represents an event.
The code works well but I'd like to improve the declaration when several days with the same description are following to reduce declaration lines.

Here's the actual working code:

var events = [

>> {year: '2011', month: '11',day: '1',description: "test description",url: '',newpage: false,mark_as_event: false},
>> {year: '2011', month: '11',day: '2',description: "test description",url: '',newpage: false,mark_as_event: false},
>> {year: '2011', month: '11',day: '3',description: "test description",url: '',newpage: false,mark_as_event: false},
>> {year: '2011', month: '11',day: '4',description: "test description",url: '',newpage: false,mark_as_event: false},
//I would like replace the 4 lines here above by something like this:
>>>>> {year: '2011', month: '11',(day: '1','2','3'),description: "test description",url: '',newpage: false,mark_as_event: false},

{year: '2011', month: '11',day: '11',description: "11 november",url: '',newpage: false,mark_as_event: false},
{year: '2012', month: '4',day: '30',description: "easter",url: '',newpage: false,mark_as_event: false},
{year: '2012', month: '5',day: '1',description: "1 mai",url: '',newpage: false,mark_as_event: false},
{year: '', month: '',day: '',description: "",url: '',newpage: true,mark_as_event: true}
];

var temp_date=new Array(); //init current month data
var temp_url=new Array();
var temp_newpage=new Array();
var temp_mark_as_event=new Array();

for (var i = 0; i < events.length; i++) { //Current month data are used here
if (events[i].year==cal_year && events[i].month==(cal_month + 1)){
temp_date[events[i].day]=events[i].description;
temp_url[events[i].day]=events[i].url;
temp_newpage[events[i].day]=events[i].newpage;
temp_mark_as_event[events[i].day]=events[i].mark_as_event;
}
}


Is it possible and how ?
Thank you very much

Gino

Hi I need help with spawning in my game.

I have this code:

Code:

function spawnEnemy()
{
    var shapes = [LeftBlock, RightBlock, middleRightBlock, middleLeftBlock, middleBlock];
    var shape = shapes[Math.floor(Math.random() * shapes.length)];
    var RandomBlock = new THREE.Object3D();
    RandomBlock.add(shape);
    blocks.push(RandomBlock);

     for (var i = 0; i < blocks.length; i++) {
        RandomBlock = blocks[i];
        scene.add(RandomBlock);
        hit = false; 
        
     }

}


function startSpawningEnemies()
{

  repeater = setInterval(function() {
      spawnEnemy();
      newBlock = false;
  }, 1000);


}

Basically it chooses a random object in the array 'shapes' and it adds the shape to the scene every second.

But the problem is that when I have, for example a 'Leftblock' on screen and it randomly gets called again, Leftblock will get reset to the starting position, so basically I cant have 2 of the same type of block on screen at once.

So I want want every block in the array to be an entirely new instance of a block, rather than the same.

Here is a code pen so you can see what is happening My Codepen

Thanks in advance





Reply With Quote




01-31-2015, 12:06 PM #2
Lesshardtofind View Profile View Forum Posts Visit Homepage

New Coder Join Date Sep 2013 Location Houston Posts 20 Thanks 0 Thanked 4 Times in 4 Posts

Hey I apologize in advance this will probably be a long post, but to get to the root of your problem it takes a bit of explaining to show how I fixed it. If you don't want to read about all the changes and why I did them if you scroll to the bottom of this post the last code snippet is the new working code.

Firstly I'd like to make a few comments.
1. Try to avoid using so many globals that is what is confusing the whole thing.
2. Even though JavaScript isn't a classical language. Using some OOP approaches can simplify your code quite a bit.

Now to what your actual problem was. You only had one instance of meshes for each type of block/paddle or whatever you call it. Even though you created new 3d objects you still were just passing it the values of the current existing Meshes.

In order to get around this I simplified your code a lot. I removed around 200 lines of code and created a few objects to make things easier. I don't know that I can explain every single thing I did, but creating objects is very useful for instance instead of making a ton of variables for each box you can make an Object called Box and then create a new instance of it. Since your Box also needs a mesh you can create that inside of the box as well.

Code:

function Box(w, h, d, q, m){
    var CoreInfo = {
        width: w,
        height: h,
        depth: d,
        quality: q,
        material: m
    };
    var Mesh = GetNewMesh(CoreInfo);
    this.setMeshY = function(y){
        Mesh.position.y = y;
    }
    this.setMeshX = function(x){
        Mesh.position.x = x;
    }
    this.getCoreInfo = function(key){
        return CoreInfo[key];
    }
    this.setCoreInfo = function(key, val){
        CoreInfo[key] = val;
    }
    this.getAllInfo = function(){
        return CoreInfo;
    }
    this.getMesh = function(){
        return Mesh;
    }
    this.setShadows = function(r, c){
        Mesh.receiveShadow = r;
        Mesh.castShadow = c;
    }
}
// you will notice that it calls this to get a MESH instead of using 5+ serperate calls you can now wrap it into a function that takes an assoc array.
function GetNewMesh(info){
    var Q = info["qaulity"];
    return new THREE.Mesh(
        new THREE.BoxGeometry(
            info["width"],
            info["height"],
            info["depth"],
            Q, Q, Q),
        info["material"]);
}

With this object you can create new instances of boxes just by passing all the variables it needs and save it into a new object.
example use:

Code:

var BlockMat = new THREE.MeshLambertMaterial({color: 0x3c00ff});
var Abox = new Box(10, 160, 10, 1, BlockMat);

As you can see the Box requires 5 arguments to construct. They are width, height, depth, quality, and material;
You will also notice there are functions inside of the Box to call functionality they are
setMeshY(y): This sets the Y position of the mesh as the y value passed to it;
setMeshX(x): This sets the X position of the mesh as the x value passed to it;
getCoreInfo(key): This gets some CoreInfo based on a string or "key" that you pass it. EX use Box.getCoreInfo("width");
setCoreInfo(key, value): This sets some CoreInfo based on a string or "key" that you pass it. EX use Box.setCoreInfo("width", 100);
getAllInfo(): Returns ALL CoreInfo in an assoc array that is accessed by a "key." EX use var AllInfo = Box.getAllInfo(); AllInfo["width"];
getMesh: Returns The mesh object
setShadows: Allows you to set shadows by passing true or false for the receive and cast arguments.

Now some of your enemy boxes needed two boxes so I further created a object called Double Box;

These are very much the same as a box. Just all methods need to be passed an index as well. These are identical to your original objects as Paddle1 is now at index 0, and Paddle2 is at index1 for each respective object.

With those objects created we can Delete a TON of your global variables and clean some stuff up. As a matter of fact the more I looked at it you didn't even NEED globals for your set enemy paddle types at all. I was able to wrap them all up into a function that will return an object like you wanted by being passed a string.

Code:

function GetBlock(type){
    if(type == "m"){
        var temp = new DoubleBox(10, 75, 10, 1, BlockMat, 10, 75, 10, 1, BlockMat);
        var obj = new THREE.Object3D();
        obj.add(temp.getMesh(0));
        obj.add(temp.getMesh(1))
        temp.setMeshX(0, fieldWidth/2);
        temp.setMeshY(0, -60);
        temp.setMeshX(1, fieldWidth/2);
        temp.setMeshY(1, 60);
        return obj;
    }
    else if(type == "mr"){
        var temp = new DoubleBox(10, 30, 10, 1,BlockMat, 10, 110, 10, 1,BlockMat);
        var obj = new THREE.Object3D();
        obj.add(temp.getMesh(0));
        obj.add(temp.getMesh(1));
        temp.setMeshX(0, fieldWidth/2);
        temp.setMeshY(0, -80);
        temp.setMeshX(1, fieldWidth/2);
        temp.setMeshY(1, 40);
        return obj;
    }
    else if(type == "ml"){
        var temp = new DoubleBox(10, 30, 10, 1, BlockMat, 10, 110, 10, 1, BlockMat);
        var obj = new THREE.Object3D();
        obj.add(temp.getMesh(0));
        obj.add(temp.getMesh(1));
        temp.setMeshX(0, fieldWidth/2);
        temp.setMeshY(0, 80);
        temp.setMeshX(1, fieldWidth/2);
        temp.setMeshY(1, -40);
        return obj;
    }
    else if(type == "l"){
        var temp = new Box(10, 160, 10, 1, BlockMat);
        var obj = new THREE.Object3D();
        obj.add(temp.getMesh());
        temp.setMeshX(fieldWidth/2);
        temp.setMeshY(20);
        return obj;
    }
    else if(type == "r"){
        var temp = new Box(10, 160, 10, 1, BlockMat);
        var obj = new THREE.Object3D();
        obj.add(temp.getMesh());
        temp.setMeshX(fieldWidth/2);
        temp.setMeshY(-20);
        return obj;
    }
}

While this could be cleaned up and do some extra error checking it now does EXACTLY what you need it to. You can call this function and pass it a string for each type of block you want. It will return a NEW instance of that type of block without sharing meshes as you had previously programmed it to.

now you can call this function in the spawn enemy function
Code:

function spawnEnemy() //total enemies starts at 0 and every-time you add to array
{
    var shapes = ["l", "r", "mr", "ml", "m"];  // these are the strings that pass to the GetBlock(type) function as type
    var shape = shapes[Math.floor(Math.random() * shapes.length)];
    blocks.push(new THREE.Object3D().add(GetBlock(shape))); // now you just pass the function to the THREE.Object3d().add() accepting shape as a parameter.

    for (var i = 0; i < blocks.length; i++) {
        RandomBlock = blocks[i];
        scene.add(RandomBlock);
        hit = false;
    }

}

I know I made a lot of changes and there are still plenty more that could reduce your code even further, but when I finally got to a point where it was working the way you wanted to I figured I'd hand it back over to you.

HERE is the final code that works if you want to copy paste it over to test it.

Code:

//scene object variables
var renderer, scene, camera, pointLight, spotLight;

var hit;
var newBlock = false;
//field variables
var fieldWidth = 500, fieldHeight = 200;

function GetNewMesh(info){
    var Q = info["qaulity"];
    return new THREE.Mesh(
        new THREE.BoxGeometry(
            info["width"],
            info["height"],
            info["depth"],
            Q, Q, Q),
        info["material"]);
}

function Box(w, h, d, q, m){
    var CoreInfo = {
        width: w,
        height: h,
        depth: d,
        quality: q,
        material: m
    };
    var Mesh = GetNewMesh(CoreInfo);
    this.setMeshY = function(y){
        Mesh.position.y = y;
    }
    this.setMeshX = function(x){
        Mesh.position.x = x;
    }
    this.getCoreInfo = function(key){
        return CoreInfo[key];
    }
    this.setCoreInfo = function(key, val){
        CoreInfo[key] = val;
    }
    this.getAllInfo = function(){
        return CoreInfo;
    }
    this.getMesh = function(){
        return Mesh;
    }
    this.setShadows = function(r, c){
        Mesh.receiveShadow = r;
        Mesh.castShadow = c;
    }
}

function DoubleBox(B1w, B1h, B1d, B1q, B1m, B2w, B2h, B2d, B2q, B2m) {
    var Boxes = [];
    Boxes[0] = new Box(B1w, B1h, B1d, B1q, B1m);
    Boxes[1] = new Box(B2w, B2h, B2d, B2q, B2m);
    this.setMeshY = function (index, y) {
        Boxes[index].setMeshY(y);
    }
    this.setMeshX = function (index, x) {
        Boxes[index].setMeshX(x);
    }
    this.getCoreInfo = function (index, key) {
        return Boxes[index].getCoreInfo(key);
    }
    this.setCoreInfo = function (index, key, val) {
        Boxes[index].setCoreInfo(key, val);
    }
    this.getAllInfo = function (index) {
        return Boxes[index].getAllInfo();
    }
    this.getMesh = function (index) {
        return Boxes[index].getMesh();
    }
    this.setShadows = function (index, r, c) {
        Boxes[index].setShadows(r, c);
    }
}

var BlockMat = new THREE.MeshLambertMaterial({color: 0x3c00ff});

var Player = new Box(10, 30, 10, 1, new THREE.MeshLambertMaterial({color: 0x4AA02C}));
function GetBlock(type){
    if(type == "m"){
        var temp = new DoubleBox(10, 75, 10, 1, BlockMat, 10, 75, 10, 1, BlockMat);
        var obj = new THREE.Object3D();
        obj.add(temp.getMesh(0));
        obj.add(temp.getMesh(1))
        temp.setMeshX(0, fieldWidth/2);
        temp.setMeshY(0, -60);
        temp.setMeshX(1, fieldWidth/2);
        temp.setMeshY(1, 60);
        return obj;
    }
    else if(type == "mr"){
        var temp = new DoubleBox(10, 30, 10, 1,BlockMat, 10, 110, 10, 1,BlockMat);
        var obj = new THREE.Object3D();
        obj.add(temp.getMesh(0));
        obj.add(temp.getMesh(1));
        temp.setMeshX(0, fieldWidth/2);
        temp.setMeshY(0, -80);
        temp.setMeshX(1, fieldWidth/2);
        temp.setMeshY(1, 40);
        return obj;
    }
    else if(type == "ml"){
        var temp = new DoubleBox(10, 30, 10, 1, BlockMat, 10, 110, 10, 1, BlockMat);
        var obj = new THREE.Object3D();
        obj.add(temp.getMesh(0));
        obj.add(temp.getMesh(1));
        temp.setMeshX(0, fieldWidth/2);
        temp.setMeshY(0, 80);
        temp.setMeshX(1, fieldWidth/2);
        temp.setMeshY(1, -40);
        return obj;
    }
    else if(type == "l"){
        var temp = new Box(10, 160, 10, 1, BlockMat);
        var obj = new THREE.Object3D();
        obj.add(temp.getMesh());
        temp.setMeshX(fieldWidth/2);
        temp.setMeshY(20);
        return obj;
    }
    else if(type == "r"){
        var temp = new Box(10, 160, 10, 1, BlockMat);
        var obj = new THREE.Object3D();
        obj.add(temp.getMesh());
        temp.setMeshX(fieldWidth/2);
        temp.setMeshY(-20);
        return obj;
    }
}

//ball variables
var reftBlock, lightBlock, middleRightBlock, middleLeftBlock, middleBlock, RandomBlock;

//game-related variables
var score = 0;

var repeater;
var blocks = [];

var collidableMeshList = [];

function setup()
{
//	update the board to reflect the max score for match win
    document.getElementById("winnerBoard").innerHTML = "Move in the gaps!";

//	set up all the 3D objects in the scene
    createScene();

//	and let's get cracking!
    draw();
}

function createScene()
{
//	set the scene size
    var WIDTH = 640,
        HEIGHT = 360;

//	set some camera attributes
    var VIEW_ANGLE = 50,
        ASPECT = WIDTH / HEIGHT,
        NEAR = 0.1,
        FAR = 10000;

    var c = document.getElementById("gameCanvas");

//	create a WebGL renderer, camera
//	and a scene
    renderer = new THREE.WebGLRenderer({antialias:true});
    renderer.setClearColorHex(0xffffff);

    camera =
        new THREE.PerspectiveCamera(
            VIEW_ANGLE,
            ASPECT,
            NEAR,
            FAR);

    scene = new THREE.Scene();

//	add the camera to the scene
    scene.add(camera);

//	set a default position for the camera
//	not doing this somehow messes up shadow rendering
    //camera.position.z = 320;

//	start the renderer
    renderer.setSize(WIDTH, HEIGHT);

//	attach the render-supplied DOM element
    c.appendChild(renderer.domElement);

//	set up the playing surface plane
    var planeWidth = fieldWidth,
        planeHeight = fieldHeight,
        planeQuality = 10;

//	create the plane's material
    var planeMaterial =
        new THREE.MeshLambertMaterial(
            {
                color: 0xffffff
            });
//	create the table's material
    var tableMaterial =
        new THREE.MeshLambertMaterial(
            {
                color: 0x3c00ff
            });
//	create the ground's material
    var groundMaterial =
        new THREE.MeshLambertMaterial(
            {
                color: 0xffffff
            });


//	create the playing surface plane
    var plane = new THREE.Mesh(

        new THREE.PlaneGeometry(
            planeWidth * 1.25,	// 95% of table width, since we want to show where the ball goes out-of-bounds
            planeHeight,
            planeQuality,
            planeQuality),

        planeMaterial);

    scene.add(plane);
    plane.receiveShadow = true;

    var table = new THREE.Mesh(

        new THREE.BoxGeometry(
            planeWidth * 1.15,	// this creates the feel of a billiards table, with a lining
            planeHeight * 1.04,
            100,	// an arbitrary depth, the camera can't see much of it anyway
            planeQuality,
            planeQuality,
            1),

        tableMaterial);
    table.position.z = -51;	// we sink the table into the ground by 50 units. The extra 1 is so the plane can be seen
    scene.add(table);
    table.receiveShadow = true;

    scene.add(Player.getMesh());
    startSpawningEnemies();


    Player.setShadows(true, true)

    /*collidableMeshList.push(MiddleBlock.getMesh(0), MiddleBlock.getMesh(1),
        MiddleLeftBlock.getMesh(0), MiddleLeftBlock.getMesh(1), MiddleRightBlock.getMesh(0),
        MiddleRightBlock.getMesh(1), RightBlock.getMesh(), LeftBlock.getMesh());*/


//	set paddles on each side of the table
    Player.setMeshX(-fieldWidth/2 + Player.getCoreInfo("width"));

    //collidableMeshList.push(RandomBlock);

//	finally we finish by adding a ground plane
//	to show off pretty shadows
    var ground = new THREE.Mesh(

        new THREE.BoxGeometry(
            1000,
            1000,
            3,
            1,
            1,
            1 ),

        groundMaterial);
    // set ground to arbitrary z position to best show off shadowing
    ground.position.z = -132;
    ground.receiveShadow = true;
    scene.add(ground);

//	// create a point light
    pointLight =
        new THREE.PointLight(0xffffff);

//	set its position
    pointLight.position.x = -1000;
    pointLight.position.y = 0;
    pointLight.position.z = 1000;
    pointLight.intensity = 2.9;
    pointLight.distance = 10000;
//	add to the scene
    scene.add(pointLight);

//	add a spot light
//	this is important for casting shadows
    spotLight = new THREE.SpotLight(0xffffff);
    spotLight.position.set(0, 0, 460);
    spotLight.intensity = 1.5;
    spotLight.castShadow = true;
    scene.add(spotLight);

//	MAGIC SHADOW CREATOR DELUXE EDITION with Lights PackTM DLC
    renderer.shadowMapEnabled = true;


}

function draw()
{
//	draw THREE.JS scene
    renderer.render(scene, camera);
//	loop draw function call
    requestAnimationFrame(draw);

    cameraPhysics();
    playerPaddleMovement();
    enemyPaddleMovement();
    collision();
    //addScore();
}

function addScore()
{
   if (RandomBlock.position.x < Pad.getMesh().position.x*2 && newBlock == false) {
        console.log("pass");
        newBlock = true;
        if (hit == false) {
            score++;
        }
        else {
            score--
        }
        document.getElementById("scores").innerHTML = score;
    }
}

function enemyPaddleMovement()
{
    if(score < 10)
    {
        for (var i = 0; i < blocks.length; i++) {

            blocks[i].position.x -= 3;
        }
    }

    if(score >= 10)
    {
        for (var i = 0; i < blocks.length; i++) {

            blocks[i].position.x -= 5;
        }

    }

}


function playerPaddleMovement()
{
    if (Key.isDown(Key.D))
        Player.setMeshY(80);
    else if (Key.isDown(Key.F))
        Player.setMeshY(40);
    else if (Key.isDown(Key.H))
        Player.setMeshY(0);
    else if (Key.isDown(Key.J))
        Player.setMeshY(-40);
    else if (Key.isDown(Key.K))
        Player.setMeshY(-80);
}

//Handles camera and lighting logic
function cameraPhysics()
{

//	move to behind the player's paddle
    camera.position.x = Player.getMesh().position.x - 100;
    camera.position.y += (Player.getMesh().position.y - camera.position.y) * 0.05;
    camera.position.z = Player.getMesh().position.z + 100 + 0.04 * (Player.getMesh().position.x);

//	rotate to face towards the opponent
    camera.rotation.y = -60 * Math.PI/180;
    camera.rotation.z = -90 * Math.PI/180;
}

//Handles paddle collision logic
function collision()
{
    var originPoint = Player.getMesh().position.clone();

    for (var vertexIndex = 0; vertexIndex < Player.getMesh().geometry.vertices.length; vertexIndex++)
    {

        var ray = new THREE.Raycaster( originPoint, Player.getMesh().geometry.vertices[vertexIndex] );
        var collisionResults = ray.intersectObjects( collidableMeshList );
        if ( collisionResults.length > 0)
        {
            console.log("true");
            hit = true;
        }
    }
}


function resetBall()
{

}

//checks if either player or opponent has reached 7 points
function matchScoreCheck()
{

}

function spawnEnemy() //total enemies starts at 0 and every-time you add to array
{
    var shapes = ["l", "r", "mr", "ml", "m"];
    var shape = shapes[Math.floor(Math.random() * shapes.length)];
    blocks.push(new THREE.Object3D().add(GetBlock(shape)));

    for (var i = 0; i < blocks.length; i++) {
        RandomBlock = blocks[i];
        scene.add(RandomBlock);
        hit = false;
    }

}


function startSpawningEnemies()
{

    repeater = setInterval(function() {
        spawnEnemy();
        newBlock = false;
    }, 1000); //this calls spawnEnemy every spawnRate
    /////////spawn 'spawnAmount' enemies every 2 seconds

}

I also commented out your addScore() function because it references RandomBlock which is not defined in its scope and the error message was annoying for debugging. I also commented out the collision as you will need to think of a new method for doing that. Most likely just build a function that accepts an array and then just pass it your blocks array and let it loop through it.

Overall cool game good luck to ya. Don't hesitate to reach out if you have any other questions.





Reply With Quote

Users who have thanked Lesshardtofind for this post: TeaAnyOne (01-31-2015)



01-31-2015, 02:31 PM #3
TeaAnyOne View Profile View Forum Posts

New to the CF scene Join Date Jan 2015 Posts 4 Thanks 2 Thanked 0 Times in 0 Posts

Wow! I didn't expect such a huge reply, it seems that my original code has changed a lot and I will have to give it a hard look through it to understand it.

I will contact you if I have any questions, I have a lot of work ahead of me.

Thanks a lot





Reply With Quote

01-31-2015, 04:45 PM #4
TeaAnyOne View Profile View Forum Posts

New to the CF scene Join Date Jan 2015 Posts 4 Thanks 2 Thanked 0 Times in 0 Posts

I suppose I do have one more question.

How do I get the position.x of the Randomblocks. I tried using a for loop like this:

for (var i = 0; i < blocks.length; i++) {
if (blocks[i].position.x === Player.getMesh().position.x*2 && newBlock === false) {
console.log("pass");
newBlock = true;
if (hit === false) {
score++;
}
else {
score--;
}
}

document.getElementById("scores").innerHTML = score;
}
}

it works but it seems kind of buggy as it stops counting to 10 when it changes speed.

Is there another way to retrieve the position?





Reply With Quote

01-31-2015, 07:43 PM #5
Lesshardtofind View Profile View Forum Posts Visit Homepage

New Coder Join Date Sep 2013 Location Houston Posts 20 Thanks 0 Thanked 4 Times in 4 Posts

That should work for getting the position since the Blocks are objects of type THREE.Object3d so any methods they have should work for you.

You may be having problems because you never despawn enemies ultimately getting a huge number of 3d objects in your array blocks, or you may find your position requirement doesn't mathematically work with your speed up.

Sometimes just using a few extra console.logs to track your numbers inside of functions that don't seem to be working can help you to get an idea of what values it is seeing for the numbers and when. It might make the problem super obvious. This more like shotgun debugging which is discouraged by many, but I found it to help a lot when I was first learning code. Ultimately you want to understand your logic in each function and how it can fail when you program it, and then use error checking to make sure no parameters get outside of your allowed variance.





Reply With Quote

Users who have thanked Lesshardtofind for this post: TeaAnyOne (01-31-2015)



01-31-2015, 08:27 PM #6
TeaAnyOne View Profile View Forum Posts

New to the CF scene Join Date Jan 2015 Posts 4 Thanks 2 Thanked 0 Times in 0 Posts

OK ill see if I can get it working.

Thanks for all your help! It helped me a lot.





Reply With Quote

01-31-2015, 08:31 PM #7
Old Pedant View Profile View Forum Posts

Supreme Master coder! Join Date Feb 2009 Posts 28,310 Thanks 82 Thanked 4,754 Times in 4,716 Posts


Originally Posted by Lesshardtofind
Ultimately you want to understand your logic in each function and how it can fail when you program it, and then use error checking to make sure no parameters get outside of your allowed variance.



Very well said!

I have an array "arr" that is an array of objects. Each object has the same 7 properties.

I want to find the index of the object with a property that matches a certain value x in the array arr. How can i accomplish this?

The array has hash tables associated with it.

arr [ obj [ i ] . property1 + "_" + obj [ i ] . property2 ] = arr [ i ] ;

so whats the index of the object where .property1 = x ?

Thanks, g

Hello All,

I have a string array in a class file that contains 5 values, which I need to display on the jsp page.

but when I send it to the javascript it prints [Ljava.lang.String;@104f8b8 .

what do i do about it. I am a new to javascript.

Is there a way to get my array data from the response object.

Please help.

Hi, every time I try and alert:

[ { number:0, secondnumber:0 }, { number:2, secondnumber:1 }, { number:1, secondnumber:2 } ]

it just shows [object object], [object object], [object object].

Why is this and what can I do to make the record be shown as it is above in an alert?

Thanks.

I can't get any info from Firebug except that one line, uncaught exception [object Object]. The code fully worked, then I needed to make it dynamically create Sortables from the scriptaculous library based on how many X were in a table in my database, which I've done, and I'm thinking it may be a simple slight parse error of some type, I'm not too good with Javascript, because now my script barely works. I've double checked the script's source code, the PHP variables are exactly what they should be.

Code:

print<<<HERE
               Sortable.create('sortlist$box', { tag: 'img', overlap:'horizontal',constraint:false, containment: $list, dropOnEmpty: true, 
                onChange: function(item) {
                    var list = Sortable.options(item).element;
                    
                    if(changeEffect) changeEffect.cancel();
                    changeEffect = new Effect.Highlight('changeNotification', {restoreColor:"transparent" });
                },
            
            
            
            onDrop: function(item) {
            var thing=Sortable.options(item).element.identify();
            
            var anchors = document.getElementById(thing).childNodes.length-2;
            
            if(anchors > 20){
            alert('This box had 20 creatures in it already, your last action has not been saved.');
            window.location.reload();
            }
            else{
            
            new Ajax.Request("saveImageOrder.php", {
                        method: "post",
                        parameters: { data: Sortable.serialize("sortlist$box") }
                    });
               }   
}               
            });
               
HERE;
$box++;

}
?>
          
        });
    </script>

if you solve this I'll send ya $10 via paypal

I created a method for displaying an object's properties:

Code:

renderfunction 	= false;

function showProperty (object, property)
{
	document.write  ('<td class="type">' + (typeof object[property])  + '</td>' 
					+ '<td class="name">' + property + '</td>');
	
	document.writeln('<td class="value">' + 
						(
								(typeof object[property] != 'function')
								? object[property]
								:(
										(property != 'showProperties')
										? (
											renderfunction
											? object[property]()
											: ('<span class="self">NOT RENDERED</span>')
											)
										: ('<span class="self">THIS</span>')
								 )
						) 
					+ '</td>');

	
	document.writeln('<td class="hasOwnProperty" >'  
							+ (
									object.hasOwnProperty(property)
									? "Local"
									: "Inherited"
								)
					 	+ '</td>');

	if (typeof object[property] == 'function')
	{
		document.writeln ('<td class="function">' + object[property] + '</td>');
	}
	else
	{
		document.writeln ('<td class="function"> </td>');
	}

}

As long as renderfunction = false, the object is fine coming out of this function.

However, if I change renderfunction to true, all my properties become undefined.

Why isn't this working as I expect it to?

How should I fix it?

Thanks in advance,

-Brian.

Hello together!

I generate html code with jsp. In that jsp there a several framesets and frames. And yes i know, frames are not really up to date but it's an old program and i have to deal with it now. Anyway, in the top frameset i have an onload attribute like onload="load()".

In the function load i want to access the Element.prototype object. But unfortunately typeof Element gives me "undefined". So i looked a little deeper and found that window.toString() gives me "[object]" and not as expected "[object window]" so somehow my window doesn't know that its construcor is Window. window.construcor is "undefined" as well. And i don't have access to the Element object. I really don't know where the error could be. When the page is loaded and i access the same window over the console, then everything is right. But in my function a can't get access to the objects i need.

I also don't know what part of the code could be useful to post here, but maybe someone had a similar problem before? i should say that this problem only occurs in IE8. In IE9 it works perfectly.

Has anyone any idea??

Hi all,

I'm stumped on finding a way in javascript to create an object factory whose instances are also object factories. In short I want something like that below, but no joy ... any clues?


Code:

function createClass () {
	return new createClass()
	function createClass() {
		return new createInstance ()
		function createInstance () {
			//Default properties, values and methods which might later be extended
		}
	}
}

var createDoor = createClass();
var door1 = createDoor();
var door2 = createDoor();

var createChair = createClass();
var chair1 = createChair ();
var chair2 = createChair ();

Ignore post (if mod, please delete)

Hello.

Is there any way to get the variable name of an object from inside the object?

E.g.

PHP Code:
function Bla(){

    this.write = function(){
    document.write(<objectname>);

    }

}

obj1 = new Bla();
obj1.write(); //Outputs obj1 



Here is my script:

PHP Code:
function myTimer(seconds, obj){
    this.seconds = seconds;
    this.obj = obj;
    this.startTimer = function(){
        if(this.seconds>0){
            this.seconds--;
            this.obj.innerHTML = this.seconds;
            this.timer = setTimeout("Timer.start()",1000);
        }
    }

}
Timer = new Timer(10, obj);
Timer.startTimer(); 



Now the problem is that the variable that contains the object must be named "Timer".

This way I cannot create new timer objects with different variable names

I have tried:
this.timer = setTimeout("this.start()",1000);
but it doesn't work.

That's why it would be good to detect the variable name and instead use something like this:
this.timer = setTimeout(varname+".start()",1000);

I would rather not have to pass the variable name through a parameter like this:
Timer1 = new Timer(10, obj, "Timer1");

Thanks in advance.

Quote:
menu: function( a, b ) {
$( b ).observe( 'click', function( event ) {
event.stop();
if( $( a ).visible() ) {
$( a ).hide();
$( b ).removeClassName( 'selected' );
document.stopObserving( 'click' );
} else {
$( a ).show();
$( b ).addClassName( 'selected' );
document.observe( 'click', function( e ) {
if( e.target.id != a && e.target.id != b && !Element.descendantOf( e.target, $( a ) ) ) {
$( a ).hide();
$( b ).removeClassName( 'selected' );
document.stopObserving( 'click' );
}
});
}
});

$$( '#' + b + ' > a' ).each( function( element ) {
element.observe( 'click', function( event ) {
$( a ).hide();
$( b ).removeClassName( 'selected' );
document.stopObserving( 'click' );
});
});
}
This work's perfrect accept when i use it with others on the menu it leaves the other ones open, how do i get it to close the open one when i open a new menu..

Thanks.

I am trying to troubleshoot my javascript function below.

Code:

<script type="text/javascript">
function txtboxfill(fillobj) {
    var rChar=String.fromCharCode(13);	
    var myVal = "To: " + this.form.to.value + rChar;
    myVal = myVal + "From: " + this.form.from.value + rChar;
    myVal = myVal + "Subj: " + this.form.subj.value + rChar + rChar;
    myVal = myVal + "Message: ";
    fillobj.value = myVal;
}
</script>

Then I have a text box input field with an Code:

<input type="text" id="tp" name="to" size="34" class="totext" onkeyup="txtboxfill(this.form.msg_area);">

and when I enter text in this field it gives me a 'this.form.to' is null or not an object and does not populate the textarea. BTW, msg_area is the id of my textarea.

Thank you.