JavaScript - Validation Not Working?!

Hello:

I am using javascript validation for submitting a form. All the other fields are working except for the Terms of Use checkbox. It sends and alert and says it wasn't checked whether or not you check it. It also submits the form whether or not it is checked immediately after the alert. The field is called df_Terms. Can anyone see anything I am missing?

Code:

 
<script>

    //submit after validation functionality
    function submit_onclick() {

        var proceed = false;
        if (typeof validateForm == "function") {

            proceed = validateForm();
        }
        else {

            proceed = true;
        }
        return proceed;
    }

    //validation functionality

    function validateForm() {





        if ((document.form1.df_Plans[0].checked == false) && (document.form1.df_Plans[1].checked == false)) {
            alert("Please select Your Plan");
            document.form1.df_Plans[0].focus();
            return false;
        }


        if ("" == document.form1.df_first_Name1.value) {

            alert("Please enter your First Name");
            document.form1.df_first_Name1.focus();
            return false;
        }

        if ("" == document.form1.df_last_Name1.value) {

            alert("Please enter your Last Name.");
            document.form1.df_last_Name1.focus();
            return false;
        }

        if ("" == document.form1.df_email1.value) {

            alert("Please enter your email.");
            document.form1.df_email1.focus();
            return false;
        }

        validRegExp = /^[^@]+@[^@]+.[a-z]{2,}$/i;
        strEmail = document.form1.df_email1.value;

        if (strEmail.search(validRegExp) == -1) {
            alert("A valid e-mail address is required.");
            document.form1.df_email1.focus();
            return false;
        }

        if (!document.form1.df_Terms.checked == 1) {

            alert("Please agree to the Terms of Use.");
            document.form1.df_Terms.focus();
            return false;
        }


    }

    //reset field functionality
    function reset_onclick() {

        for (i = 0; i < document.form1.elements.length; i++) {

            if (document.form1.elements[i].type == "text") {

                document.form1.elements[i].value = "";
            }
            if (document.form1.elements[i].type == "checkbox") {

                document.form1.elements[i].checked = false;
            }
            if (document.form1.elements[i].type == "radio") {

                document.form1.elements[i].checked = false;
            }
            if (document.form1.elements[i].type == "select-one") {

                document.form1.elements[i].selectedIndex = 0;
            }
        }
    }

    //redirect functionality
    function redirect_onclick(urlString) {

        window.open("http://" + urlString);
    }

</script>

It does not work in ie7! Here is my code and my link... I have been trying to fix for 2 hours now! Please help. I tried using jquery 1.6.1, 1.5.2, min.validation, regular validation, i changed the buttons to input type="submit" and did everything else I could find but nothing works.

When you click submit, it does not validate. It goes straight to my thank you page and I get a blank form in return.

I do not know much jquery, just enough to know what I copy and paste and make some minimal changes. Thanks!

http://www.denver-website-designer.com/quote.html

<script type="text/javascript">
$().ready(function() {
var erroralert = $("#quoteForm").bind("invalid-form.validate", function() {
$("#erroralert");
});
});

$.metadata.setType("attr", "validate");

$.validator.addMethod("ninja", function(value) {
return value == "ninja";
}, 'Can a robot spell "ninja"');

$().ready(function() {
$("#quoteForm").validate({
errorContainer: $("#erroralert"),
rules: {
fullname: {
required:true,
minlength:2,
},
email: {
required:true,
email:true,
},
phone: {
required:true,
minlength:10,
maxlength:15,
},
pages: {
required:true,
minlength:1,
maxlength:10,
number:true
},
whyrate: {
required:true,
minlength:10,
},
ninja: "ninja",
},
messages: {
email: "Please enter a valid email address",
pages: "Numeric values only",
}
});
});
</script>

This is straight out of an O'Riley book, everything looks good to me but for some reason the script does nothing when I try to submit an empty form.

Code:

// Validate Registration Form

function validate(form) {
	fail  = validateUsername (form.uname.value)
	fail += validateUpass (form.upass.value)
	fail += validatePassword (form.password.value)
	fail += validateFname (form.fname.value)
	fail += validateLname (form.lname.value)
	fail += validateID	  (form.ID.value)
	fail += validateEmail (form.email.value)
	if (fail =="") return true
	else {alert(fail); return false }
}

function validateUsername (field) {
	if (value==null||value=="") return "Please enter username.\n"
	return ""
}

function validateUpass (field) {
	if (field =="") return "Please enter password.\n"
	return ""
}

function validatePassword (field) {
	if (value == "") return "Please confirm password. \n"
	return ""
}

function validateFname (field) {
	if (value =="") return "Please enter a first name.\n"
	return""
}

function validateLname (field) {
	if (value=="") return "Please enter a last name.\n"
	return""
}

function validateID (field) {
	if (value=="") return "Please enter your USAC license number.\n"
	return ""
}

function validateEmail (field) {
	if (value=="") return "Please enter your email address.\n"
	else if (!((field.indexof(".")>0) && 
			(field.indexOf("@") > 0)) ||
			 /[^a-zA-Z0-9.@_-]/.test(field))
	return "The Email address is invalid.\n"
	return""
}

Code:

<script src="includes/js/validate-registration-form.js"></script>
</head>

<body>
<div id="wrap">
<h1>CritTracker.com Registration page</h1>
<?php include('includes/nav.php');?>
<div id="content_wrap">
<div id="center_content">
<div id="register">
<form class="register" method="post" action="register.php" onSubmit="return validate(this)">
<fieldset>
<legend>Register to CritTracker</legend>
<ol>
<li>
<label for="uname">Username</label> <input type="text" name="uname" /><br />
</li>
<li>
<label for="upass">Password</label> <input type="password" name="upass" /><br />
</li>
<li>
<label for="upass">Confirm Password</label>  <input type="password" /><br />
</li>
<li>
<label for="fname">First Name</label>  <input type="text" name="fname" /><br />
</li>
<li>
<label for="lname">Last Name</label> <input type="text" name="lname" /><br />
</li>
<li>
<label for="ID">USA Cycling License</label> <input type="text" name="ID" />
<select name="cat">
  <option name="cat" value="5">Cat 5</option>
  <option name="cat" value="4">Cat 4</option>
  <option name="cat" value="3">Cat 3</option>
  <option name="cat" value="2">Cat 2</option>
  <option name="cat" value="1">Cat 1</option>
</select>
</li>
<li>
  <label for="email">Email</label> <input type="text" name="email" /><br />
  
  <input type="submit" value="Register to CritTracker.com" />
</li>
</ol>
</fieldset>
</form>
</div></div>

Hi,
So I think I can't see the trees for the forest.
I'm pretty good at code and usually work out the answer myself.
I am doing some work for a client, working on some code written by someone else.
It is a form, and for some reason the validation isn't working. The form sends with or without data entered into the mandatory fields.
I can't look at the code anymore..
Is this the correct place I would ask for help with such a thing?

Thanks kindly.

Hi guys,

Been stuck for a few days with this scenario.
Any help?
The alert box appears on an error.
But the submitting won't stop.
The details are submitted and the form is processed.
Any help is greatly appreciated...

Code:

    <html>
    <head>
    <script type="text/javascript" src="email_helper/jscripts/tiny_mce/tiny_mce.js"></script>
    <script type="text/javascript">
        tinyMCE.init({
            // General options
            mode : "textareas",
            theme : "simple"
        });
    </script>
    <script language="javascript">
     
    function MM_openBrWindow(theURL,winName,features) {
        window.open(theURL,winName,features);
    }
    function err_check(){
        var email = document.getElementById('to_email').value;
        if(email.length==0){
            alert('Please Enter Email Address');
            return false;
        }
        var AtPos = email.indexOf("@")
        var StopPos = email.lastIndexOf(".")
        if (AtPos == -1 || StopPos == -1) {
            alert("Please Enter Valid Email Address");
            document.getElementById('email').focus();
            return false;
        }
        email = document.getElementById('cc_email').value;
        if(email.length != 0){
            var AtPos = email.indexOf("@")
            var StopPos = email.lastIndexOf(".")
            if (AtPos == -1 || StopPos == -1) {
                alert("Please Enter Valid Email Address");
                document.getElementById('email').focus();
                return false;
            }
        }
        var answer = confirm ("Send E-Mail?");
        if (!answer){
            return false;
        }
    }
    </script>
    <!-- /TinyMCE -->
     
     
    <style type="text/css">
    body, table, td, th{
        background-color:#CCCCCC;
        font-family: Arial;
        font-size:14px;
    }
    .que{
        font-weight:bold;
    }
    </style>
    </head>
    <body>
    <form method="post" enctype="multipart/form-data">
    <?php
    include 'library/database.php';
    include 'library/opendb.php';
    $query = mysql_query("SELECT email,contact,mobile FROM users WHERE user_id='$uid'") or die(mysql_error());
    $row = mysql_fetch_row($query);
    $from_email = $row[0];
    $from_person = $row[1];
    $from_mobile = $row[2];
    $query = mysql_query("SELECT customer_id FROM campaign_summary WHERE camp_id='$camp_id'") or die(mysql_error());
    $row = mysql_fetch_row($query);
    $cusid = $row[0];
    $query = mysql_query("SELECT email FROM client_info WHERE comp_id='$cusid'") or die(mysql_error());
    $row = mysql_fetch_row($query);
    $toer = $row[0];
    include 'library/closedb.php';
    ?>
    <table width="100%" border="0">
    <tr><td rowspan="4"><input type="submit" name="send_email" id="send_email" style="height:50px; width:100px;" value="SEND" onClick="return err_check();" /></td><td><span class="que">From : </span></td><td colspan="3"><?php echo $from_email; ?><input type="hidden" name="from_mail" id="from_mail" /><input type="hidden" name="camp_id" id="camp_id" value="<?php echo $camp_id;?>"/></td></tr>
    <tr><td><span class="que">To : </span></td><td colspan="3"><input name="to_email" id="to_email" style="width:250px;" value="<?php echo $toer;?>"/></td></tr>
    <tr><td><span class="que">CC : </span></td><td colspan="3"><input name="cc_email" id="cc_email" style="width:250px;"/></td></tr>
    <tr><td><span class="que">Subject : </span></td><td colspan="3"><input style="width:300px;" name="subject" id="subject" /></td></tr>
    <tr><td rowspan="1" colspan="2">&nbsp;</td><td><input type="checkbox" name="ori_pdf" id="ori_pdf" checked /> PDF Quotation</td><td>&nbsp;</td><td>&nbsp;</td></tr><tr><td colspan="2"><span class="que">Credit Application</span></td><td><input type="checkbox" name="corporate" id="corporate"/>Corporate</td><td><input type="checkbox" name="individual" id="individual" />Individual</td><td><input type="checkbox" name="cash" id="cash" />Cash Account</td>
    </tr>
    <tr>
    <td colspan="2" rowspan="3"></td><td><input type="checkbox" name="tabloid" id="tabloid" />Tabloid Example</td>
    <td><input type="checkbox" name="broadsheet" id="broadsheet" />Broadsheet Example</td></tr>
    <tr><td><input type="checkbox" name="colmt" id="colmt" />Column Sizes Tabloid</td>
     
    <td><input type="checkbox" name="colmb" id="colmb" />Column Sizes Broadsheet</td></tr>
    <tr><td><input type="checkbox" name="maps" id="maps" />Maps / Distribution</td><td colspan="2" align="right">External Attachments&nbsp;&nbsp;<input id="upload_file" name="upload_file" type="file"/> </td></tr>
     
    <tr><td colspan="2"><span class="que">Message :</span></td><td colspan="3">
        <textarea id="elm1" name="elm1" rows="15" cols="80" style="width: 100%">
        <?php
         echo "<br><br><br>" . $from_person . "<br>" . $from_mobile; 
          ?>
        </textarea>
    </td></tr>
    </table>
    </form>
    </body>
    </html>

Hey all.

I have a simple validation I need to do. I need to just make sure that a Checkbox is checked, and that a Text field has content. Sounds simple but I cannot find any thing that has a check and a text field.

Here what I have. Can I modify this script to do this? A Checkbox MUST be checked and Text field MUST be filled out. This currently does the text field fine, but no Checkbox obviously.

How can I add a checkbox validation to this?

Thats it. Any help is appreciated.

Code:

<script type="text/javascript">

var textFields = ["digsig"]; 

function validateForm( )
{
    var oops = ""; // must initialize this!
    var form = document.sig;

        for ( var t = 0; t < textFields.length; ++t )
        {
              var field = form[textFields[t]];
              var value = field.value.replace(/^\s+/,"").replace(/\s+$/,""); // trim the input
              if ( value.length < 1 ) 
              {
                    oops += "You MUST enter your Digital Signature";
              }
        }
        if ( oops != "" )
        {
            alert("ERROR:" + oops);
            return false;
        }
    }


}

</script>

Hello all, new here Seems like a very nice place to be apart of.

I have my website www.gebcn.com. If you view source you will see all that I have done, but more importantly my problem. I have the JS code at the top there and I am unable to W3C validate my HTML because of the JS. I am using XHTML strict and would like to stay using it.

The JS I have at the top is my form validation code. I am able to do any validating that I need with this "snippet" of code, I have shrank it from my library version just to use for this newsletter. Until now W3C validating was not important now for some reason it is and I am faced with this problem.

I am not a Javascript guy more of a HTML/CSS guy and I can manipulate JS to suit my needs.

<problem>
I have tried to make this "snippet" of JS code an external file but receive multiple errors with the JS calling for the FORM NAME as it is not on the same page. The form NAME=NEWSLETTER is another problem, as W3C says I am unable to use attribute "NAME" in this location.
<problem>

I would like to keep the JS close to how it is now as I have a library to use this JS over and over again.

Any pointers in the right direction or solutions to my problem would be greatly appreciated.

Thanks! Hopefully it is not to hard huh

If there is anything anyone needs, the code pasted here, or anything else please let me know. Thanks again!

Hi All,

I have two sites using zeroclipboard (hosted at google code) one works only in firefox and barely, the other is not working at all. It does use Flash, but I think the issue is on the js side of things.

On both links, clicking the filename below the thumbnail will copy and add the link as an IMG code to a div below.

*working* link
http://pics.boasbysatyra.com/access/spiders.php
This one only works in FF, and the clip area is offset badly.

Here is the template for the zc code:

Code:

<div class="photo" style="float: left; padding: 4px;">
<div class="exif"><a href="[~41~]?dir=[+images_dir+]&file=[+filename+]" rel="shadowbox[exif_[+content_id+]]" title="exif data for [+filename+]" alt="exif data for [+filename+]">EXIF Data</a></div>
           <a class="thumb" rel="shadowbox[[+content_id+]]" href="[+images_dir+][+filename+]" title="[+title+] | [+description+]">
                <img src="[+thumbs_dir+][+filename+]" alt="[+title+]" />
            </a>
 <div class="filecode" id="d_clip_button[+filename+]">[+filename+]
       <script language="JavaScript">
           var clip = new ZeroClipboard.Client();
           clip.setText( 'http://pics.boasbysatyra.com[+images_dir+][+filename+]' );
           clip.glue( 'd_clip_button[+filename+]' );
           clip.addEventListener( 'onComplete', my_complete );

        function my_complete( client, text ) {
                $('.picklist').append('<div class="piclinks">[IMG]' + text + '[/IMG]</div>');
        }
       </script>
</div>
</div>

And the JS for the page:

Code:

var needRef;
//flag for page reload
function pEdit(){
needRef = 1;
}

Shadowbox.init({
    handleOversize: "resize",
    modal: true,
    initialHeight: 32,
    initialWidth: 400,
    overlayOpacity: 0.85,
        onClose: function(){//check for reload flag and reload
if (needRef == 1){window.location.href=window.location.href;}
}
});
ZeroClipboard.setMoviePath('/js/zc/ZeroClipboard10.swf');
function initMenu() {
    $('#menu ul').hide();
    $('#menu ul:first').show();
    $('#menu li a').click(function() {
        var checkElement = $(this).next();
        if ((checkElement.is('ul')) && (checkElement.is(':visible'))) {
            //return false;
            }
        if ((checkElement.is('ul')) && (!checkElement.is(':visible'))) {
            $('#menu ul:visible').slideUp('normal');
            checkElement.slideDown('normal');
            return false;
        }
    });
}
$(document).ready(function() {
    initMenu();
});

Now on to the totally broken one - it creates the elements required, but gives them a 0x0 area!

http://jb.boasbysatyra.com/forum-pic...cs/nature.html

Code:

div class="photo" style="float: left; margin: 4px;">
<div class="exif"><a href="[~133~]?dir=[+images_dir+]&file=[+filename+]" rel="shadowbox[exif_[+content_id+]]" title="exif data for [+filename+]" alt="exif data for [+filename+]">EXIF Data</a></div>
           <a class="thumb" rel="shadowbox[[+content_id+]]" href="[+images_dir+][+filename+]" title="[+title+] | [+description+]">
                <img src="[+thumbs_dir+][+filename+]" alt="[+title+]" />
            </a>
<div id="d_clip_container[+filename+]" style="position:relative; width: 120px; height: 0.5em;">
 <div class="filecode" id="d_clip_button[+filename+]">[+filename+]
       <script language="JavaScript">
           var clip = new ZeroClipboard.Client();
           clip.setText( 'http://jb.boasbysatyra.com[+images_dir+][+filename+]' );
           clip.glue( 'd_clip_button[+filename+]','d_clip_container[+filename+]' );
           clip.addEventListener( 'onComplete', my_complete );

        function my_complete( client, text ) {
                $('.picklist').append('<div class="piclinks">[IMG]' + text + '[/IMG]</div>');
        }
       </script>
</div>
</div>
</div>

On this one I wrapped it as suggested on the zc site, I originally started with the code for the other site - it didn't work, so I went tweaking...

Here is the JS:

Code:

var needRef;
//flag for page reload
function pEdit(){
needRef = 1;
}
Shadowbox.init({
    handleOversize: "resize",
    modal: true,
    initialHeight: 32,
    initialWidth: 400,
    overlayOpacity: 0.85,
        onClose: function(){//check for reload flag and reload
if (needRef == 1){needRef = 0; window.location.href=window.location.href;}
}
});
ZeroClipboard.setMoviePath('/js/zc/ZeroClipboard10.swf');

$(document).ready(function() {
$(".dim img").fadeTo("slow", 0.65);
$(".dim img").hover(function(){
$(this).fadeTo("slow", 1.0);
},function(){
$(this).fadeTo("slow", 0.65);
});
$('#mainContent').hide().fadeIn(1200);
        //When page loads...
        $(".tab_content").hide(); //Hide all content
//      $("ul.tabs li:first").addClass("active").show(); //Activate first tab
//      $(".tab_content:first").show(); //Show first tab content

        //On Click Event
        $("ul.tabs li").click(function() {

                $("ul.tabs li").removeClass("active"); //Remove any "active" class
                $(this).addClass("active"); //Add "active" class to selected tab
                $(".tab_content").hide(); //Hide all tab content

                var activeTab = $(this).find("a").attr("href"); //Find the href attribute value to identify the active tab + content
                $(activeTab).fadeIn(); //Fade in the active ID content
                return false;
        });

});
(function($) {
   $(document).ready(function(){
 $('.menu1').ptMenu();
       $('.menu2').ptMenu({vertical:true});
   });
})(jQuery);

I have taken a look at this for a few days and tried many things with no luck, any help is appreciated.

Thanks!

Ok, here's the page as it is right now:
http://www.crackin.com/dev/index.php

The paganation for the top 3 images is Sweet Pages: http://tutorialzine.com/2010/05/swee...tion-solution/
The content loading below is a page-replace script I got he http://css-tricks.com/dynamic-page-replacing-content/
And I'm also trying to integrate shadowbox (or lightbox, whichever will work) into the lower set of images.

I have 2 problems right now I can't figure out, and I'm sure it somehow has to do with the fact I'm trying to mash 3 different JS addons into a single page, I'm still pretty new to this whole JS thing...

First problem I'm having is that IE7 and Opera don't like the links in the upper images. Clicking a gallery image does not load the associated page below from those 2 browsers, however IE8 and FF seem to work fine.

Second problem is getting shadowbox/lightbox to work on those lower images. I tried a couple different things but main thing I did is make sure the script is actually working by setting the header text to a link with shadowbox attached and that worked. That same link doesn't work when applied to the lower images (loads image in new window). Lightbox does the same thing.

Thanks for any help.

I hope I have this post in the right place! Any help would be very much appreciated...

I have a feature on my website that allows users to choose the website background (using alternate css sheets) and then uses an externally linked javascript file to store the background choice as a cookie so it is consistent throughout the website.

This works perfectly locally (i.e. when previewing my website on my computer) but now it is uploaded to my host it doesn't appear to be working. (with the same browser)

My javascript is he
http://www. b r p - e n v .com/javascript/backgroundchange.js (with no spaces)

The website that the javascript file is linked to is http://www. b r p - e n v .com (with no spaces)

In the head I have:
<script type="text/javascript" src="../javascript/backgroundchange.js"></script>

...then I have: <body onload="set_style_from_cookie()">

...and for users to choose which background:
<form>
<input type="image" src="../images/white-background-thumb.jpg"
onclick="switch_style('bg1');return false;"
name="theme" value="White" id="bg1">
etc...
</form>

My problem is: The background reverts back to the default when moving to a different page. This would indicate that the background choice is not being saved in cookies. But this works locally!

I have tried putting the javascript directly onto each page but I still had the same problem.

I hope someone can help, I will be so grateful if I can get this to work.

Many thanks indeed!

hereis the html file and javascripton click of this button a
html *****************************
<table class=matcolor id=topnav cellspacing=0
cellpadding=0 width=550 border=0 bgcolor="#FFCCCC">
<tbody>
<tr align=middle>
<td id=menu1
onMouseOver="this.className='mPrimaryOn';showmenu(this);"
onClick="this.document.location.href=''"
onMouseOut="this.className='mPrimaryOff';hidemenu(this);" class="mat" height="20">
<div align="center"><font color="#FF0000">Desk Top Publishing </font></div>
</td>
<td width=1 bgcolor=#ff9900 class="mat"></td>
<td id=menu2
onMouseOver="this.className='mPrimaryOn';showmenu(this);"
onClick="this.document.location.href=''"
onMouseOut="this.className='mPrimaryOff';hidemenu(this);" class="mat" height="20">
<div align="center"><font color="#FF0000">Transcription</font></div>
</td>
<td width=1 bgcolor=#ff9900 class="mat"></td>
<td id=menu3
onMouseOver="this.className='mPrimaryOn';showmenu(this);"
onClick="this.document.location.href=''"
onMouseOut="this.className='mPrimaryOff';hidemenu(this);" class="mat" height="20">
<div align="center"><font color="#FF0000">Accounts Processing </font></div>
</td>
</tr>
</tbody>
</table>
*****************************************

<script language=JavaScript>
ix = document.getElementById('tblmenu1').getBoundingClientRect();
new ypSlideOutMenu("menu1", "right",ix.left + ix.right ,ix.bottom + 10);
</script>
**any thing i have to alter to work in firefox
please help

I have a usercontrol which get inputs from the user and show the slideshows. I have added jquery.js and jqfancytransitions.js to the control. when i apply the effects dynamically it is working on local iis but the same coding is not working on iis server. The link for the page is http://www.gloriatech.com/slideshow.aspx . Actually it display the images but no effects are applied. I also checked the js files, it is in right path only.When i checked this page in firebug , it shows the error which is " Sys is undefined". I dont know how to solve it. Can anyone help me?

Thanx in advance.

Hello,

I dont know if I am going about this the right way, but.. I am trying to validate an email address. If the email is a valid looking email address, it will render the submit button disabled to prevent dupe's while the rest of the script processes.

The email validation portion works, but, the part where it renders the form submit button disabled does not:

<script type="text/javascript">
function validate_email(field,alerttxt)
{
with (field)
{
apos=value.indexOf("@");
dotpos=value.lastIndexOf(".");
if (apos<1||dotpos-apos<2)
{alert(alerttxt);return false;}
else {return true; submit.disabled = true;}
}
}

function validate_form(thisform)
{
with (thisform)
{
if (validate_email(email,"Please enter a valid email address.")==false)
{email.focus();return false;}
}
}
</script>

Any guidance or help would be apreciated.

In my project i have a from which have several fields. The form is
<form name="reg" action="payment.jsp" method="post">
-----------
<tr> <td>First name:</td> <td><input type="text" name="firstname"/></td></tr>
--------------------------
<input type="submit" value="Next" onclick="fun()" />
------------
</form>
Then to validate the fields i have used JavaScript.They are validating rightly using a alert box. But when i am pressing ok of the alert box the control is passing to the page i have written in action of the form.I want when i will press ok it should come back to the same page.Only if all fields are then it should go to the page refereed in action. Can anyone help me?
The JavaScript code is
<script type="text/javascript">
function fun()
{
var x=document.forms["reg"]["firstname"].value;

if (x==null || x=="")
{
alert("First name must be filled out");


}

Hello to everyone

i need to validate a form Based on radio buttons and text box

my code so far
Code:

<html>
<head>
<title>My Page</title>
<script type="text/javascript">
function validate(thisform) {
document.getElementByName("bank");//text box
// validate myradiobuttons
   
radio = -1;
for (i=thisform.day.length-1; i > -1; i--) {
if (thisform.day[i].checked) {
radio = i; i = -1;
}
}
if (radio == -1) {
alert("You must select all values for the clock !");
return false;
}
 else
    {
    return true;
    }
	}
//bank code validation
if (document.getElementByName("bank").value.length>=6) {
 return true;
    }
else
    {
  alert("you must input maximum 6 digit (123456) !");
   return false;
    }
	}	

	</script>
</head>
	<body>
<form action="form-output.php" method="post" id="form">

          <input type="radio" name="day" value="f" onclick="dayofweek(this)" /> Sunday (default)
          <input type="radio" name="day" value="s" onclick="dayofweek(this)" /> Sun </p>

	        <input type="radio" name="month" value="a" onclick="dateformat(this)" /> 28th March 2010 (default) 
			<input type="radio" name="month" value="b" onclick="dateformat(this)" /> 28 March 2010 
			<input type="radio" name="month" value="c" onclick="dateformat(this)" /> 28th Mar 2010 
			<input type="radio" name="month" value="d" onclick="dateformat(this)" /> 28 Mar 2010 
			<input type="radio" name="month" value="e" onclick="dateformat(this)" /> 28/03/2010  
			<input type="radio" name="month" value="f" onclick="dateformat(this)" /> 28th March 10
			<input type="radio" name="month" value="g" onclick="dateformat(this)" /> 28 March 10
			<input type="radio" name="month" value="h" onclick="dateformat(this)" /> 28th Mar 10  <br/>

			<input type="radio" name="month" value="i" onclick="dateformat(this)" /> 28 Mar 10 
			<input type="radio" name="month" value="j" onclick="dateformat(this)" /> 28/03/10
			<input type="radio" name="month" value="k" onclick="dateformat(this)" /> 28th March 
			<input type="radio" name="month" value="l" onclick="dateformat(this)" /> 28 March 
			<input type="radio" name="month" value="m" onclick="dateformat(this)" /> 28th Mar
			<input type="radio" name="month" value="o" onclick="dateformat(this)" /> 28 Mar 
			<input type="radio" name="month" value="p" onclick="dateformat(this)" /> 28/03 </p>
			
			<input type="radio" name="time" value="a" onclick="timeformat(this)" /> 5:28:12 am (Default) 
			<input type="radio" name="time" value="b" onclick="timeformat(this)" /> 5:28 am 
			<input type="radio" name="time" value="c" onclick="timeformat(this)" /> 5:28:12 
			<input type="radio" name="time" value="d" onclick="timeformat(this)" /> 5:28 
			<input type="radio" name="time" value="e" onclick="timeformat(this)" /> 17:28:12 
			<input type="radio" name="time" value="f" onclick="timeformat(this)" /> 17:28 </p>
			 Input a short Bank Code
    <input type="text" name="bank" size="10"  onblur="JavaScript:alert('You must insert a Bank Code')"  /></br>

<input type="submit" name="submit" onclick="validate(form);return false;" value="Submit" />
<input type="reset" name="reset" value="reset" />
</form> 
</body>
</html>

i need on submit to validate if user select values from 3 radio groups and insert the proper data to text box.
if not i want to return the proper alerts
in text box also i want when lose focus to validate so i put this
Code:

onblur="JavaScript:alert('You must insert a Bank Code')"

it's ok?

Thanks in Advance