JavaScript - Jslint - What's Important, What's Not

Here is sampling from a JSLinting of one "core" js file, with some requests for help ... (Btw it runs OK on my machine and is IE only to work with Sketchup web dialogs)

Code:

Problem at line 15 character 5: 'window' is not defined.

window.location = "skp:" + callback + "@" + params.join(';');

This seems very odd to me; surely it cannot be bad!

Code:

Problem at line 29 character 9: 'nameDown' is not defined.

nameDown(params);

nameDown is a function in another file; any problem with that? There will be other similar calls.

Code:

Problem at line 103 character 65: Be careful when making functions within a loop. Consider putting the function in a closure.

o.onmousedown = function() { coreDown(this , c , dv ); };

This one is more difficult. Here is the relevant part of the function:

Code:

// o is a div

o.className = p + cn;
o.onmousedown = function() { coreDown(this , c , dv ); };
s = o.style;
s.width = "100%";
s.height = ch;

Is the recommendation relevant, possible?

Code:

Problem at line 141 character 5: Bad line breaking

... ,interval); in this code (Actually my last thread here)

Code:

function coreAnimate(obj, elm, begin, end, duration, fps) {
	var change,interval,steps,i;
	change      = end-begin;
	interval    = Math.ceil(1000/fps);
	steps		= Math.ceil(duration/interval);
	if(obj.coreStop){
		window.clearInterval(obj.coreStop);
	}
	i = 0;
    obj.coreStop = window.setInterval(
	function() { 
		obj.last = linearTween(i, begin, change, steps);
		obj.style[elm]  = obj.last + 'px'; 
		i+=1;
		if (i > steps){
			window.clearInterval(obj.coreStop);
		}
	} 
	,interval);
}

It certainly does not look good but is it bad?


Code:

Problem at line 148 character 14: 'ActiveXObject' is not defined.

fs = new ActiveXObject("Scripting.FileSystemObject");

I guess this is the same as window as noted in the last bit of the report:


Code:

Implied global: window 7,15,130,133,139, nameDown 29, Refresh 63, ActiveXObject 148,162,171

Any help and suggestions gratefully received.

Chris