JavaScript - Registration Script

This is a bit of a lazy post but hey,

Currently i have an awful lot of checks that run the same check on different variables.

Simple Request... Can anyone see an obvious way (which i have clearly missed) to clean up and reduce the amount of code in the below.

Code:

<?

// required code for every page.

require($_SERVER['DOCUMENT_ROOT'] . '/scripts/required.php');

// end of required code for every page

if(isset($_POST['sbmt']))
	{
		// get variables
		$new_user = trim($_POST['user']);
		$new_pass = $_POST['newpass'];
		$con_pass = $_POST['conpass'];
		$new_fname = trim($_POST['fname']);
		$new_email = $_POST['email'];
		$con_email = $_POST['conemail'];
		$agree = $_POST['agree'];
		$level = $_POST['level'];
		$ip = @$_SERVER['REMOTE_ADDR'];
		
		// add slashes
		$new_user = addslashes($new_user);
		
		// encrypt
		$new_pass_e = hash('ripemd160',$new_pass);
		$con_pass_e = hash('ripemd160',$con_pass);
		
		// check username exists
		// connect to database
		$con = mysql_connect(DBHOST, DBUSER, DBPASS);
		if(!$con) { die('Could not connect: ' . mysql_error());}
		mysql_select_db(DBNAME, $con);
	
		// get row for user
		$result = mysql_query("SELECT * FROM tUsers WHERE username='$new_user'");
		$row = mysql_fetch_array($result);
	
		// kill connection
		mysql_close($con);
		
		// check username exists
		if($row['username']!=null)
			$user_error = 'Username already in use.<br />';
		else
			$user_error = null;

		// check email is available		
		// connect to database
		$con = mysql_connect(DBHOST, DBUSER, DBPASS);
		if(!$con) { die('Could not connect: ' . mysql_error());}
		mysql_select_db(DBNAME, $con);
	
		// get row for user
		$result = mysql_query("SELECT * FROM tUsers WHERE email='$new_email'");
		$row = mysql_fetch_array($result);
	
		// kill connection
		mysql_close($con);
		
		// check email is available
		if($row['email']!=null)
			$email_error = 'Email already in use.<br />';
		else
			$email_error = null;
		
		// check lengths
		if(strlen($new_user)<3)
			$user_len_error = 'Username must be at least 3 characters<br />';
		else
			$user_len_error = null;
		if(strlen($new_pass)<6)
			$pass_len_error = 'Password must be at least 6 characters<br />';
		else
			$pass_len_error = null;
		if(strlen($new_fname)<6)
			$fname_len_error = 'Your name must be at least 6 characters<br />';
		else
			$fname_len_error = null;
		
		// preg matches
		if(!preg_match('/^[a-zA-Z0-9_]+([.][a-zA-Z0-9_]+)*[@][a-zA-Z0-9_]+([.][a-zA-Z0-9_]+)*[.][a-zA-Z]{2,4}$/', $new_email)) 
			$email_preg_error = "Email is not valid.<br />";
		else
			$email_preg_error = null;
		if(!preg_match('/[a-zA-Z]+\s+[a-zA-Z]+/',$new_fname))
			$fname_preg_error = 'Name must containt at least one space.<br />';
		else
			$fname_preg_error = null;
			
		// check matches
		if($new_pass != $con_pass)
			$pass_match_error = 'The passwords do not match.<br />';
		else
			$pass_match_error = null;
		if($new_email != $con_email)
			$email_match_error = 'The emails do not match.<br />';
		else
			$email_match_error = null;
		
		// build error list
		$errorlist = $user_error;
		$errorlist .= $email_error;
		$errorlist .= $user_len_error;
		$errorlist .= $pass_len_error;
		$errorlist .= $fname_len_error;
		$errorlist .= $email_preg_error;
		$errorlist .= $fname_preg_error;
		$errorlist .= $pass_match_error;
		$errorlist .= $email_match_error;
		
		// set expirey to a month
		$expire = 0;
								
		// set error list cookie
		setcookie('errorlist',$errorlist,$expire,'/');
		
		// reload register.php
		header('Location:' . URL . '/register.php');
		
	}
	
?>

The required file is just a series of defines for items like the dbhost, dbusername, dbname, url etc etc.

Cheers

p.s.

I want to add an if statement for if $errorlist=null then do bla else bla... in order for errorlist to be null... do i actually need to define the individual error messages as null.

That could get rid of a lot of:


else
$<error name>=null;


I'm pretty sure I can but i'd like to check first.

Anybody help to start out this code:

Create a "nag" counter that tells users to register. Save the counter in a cookie and display a message reminding users to register every fifth time they visit your site.

There are four other parts to this task that I know how to do. I cannot find anything close to this in our book referencing a nag-counter or something similar to it.

Thanks, in advance. Regards,

AO5431

Hello,
i got a problem with form like this:
https://www2.giocarena.com/it-IT/Register/Start.aspx

It's possible to set the field Cod Referent?????

I've tried with this:

<form name="aspForm" method="post" action="https://www2.giocarena.com/it-IT/Register/Start.aspx" target="_blank">
<input type="hidden" name="ctl00$cphBaseContainer$ctl00$txt_code" value="44411122224322445"></input>
<button type="submit"> Nome </button>
</form>

Thank you!Thank you, thank you!

<?php
require('connect.php');
if($_POST['reg1']=="Register")
{
$stmt1="insert into regtable(fname,lname,c_addr,p_addr,phno,email,dob,gender,qual,wexp,usertype,btype,uname,pwd) values('$name1','$name2','$add1','$add2','$phno1','$email1','$dob1','$gend1','$qual1','$wexp1','$uty pe','$batch1','$user','$upwd')";
$res1=mysql_query($stmt1,$con);}
?>
<html>
<head>
<script type="text/javascript">
function validate()
{
f=0;
if(document.getElementById('fname').value=="")
{
document.frm1.fname.style.border='1px solid red';
//document.frm1.fname.style.background='#FFFFCC';
document.frm1.fname.focus();
document.getElementById('d_fname').style.visibility="visible";
document.getElementById('d_fname').innerHTML="Enter First Name";
}
else
{
f++;
}
if(document.getElementById('lname').value=="")
{
document.frm1.lname.style.border='1px solid red';
document.frm1.lname.focus();
document.getElementById('d_lname').style.visibility="visible";
document.getElementById('d_lname').innerHTML="Enter Last Name";
}
else
{
f++;
}

if(document.getElementById('addr1').value=="")
{
document.frm1.addr1.style.border='1px solid red';
document.frm1.addr1.focus();
document.getElementById('d_cadd').style.visibility="visible";
document.getElementById('d_cadd').innerHTML="Enter Contact Address";
}
else
{
f++;
}
if(document.getElementById('pno').value=="")
{document.frm1.pno.style.border='1px solid red';
document.frm1.pno.focus();
document.getElementById('d_pno').style.visibility="visible";
document.getElementById('d_pno').innerHTML="Enter Phone Number";
}
else
{
f++;
}
if(document.getElementById('emid').value=="")
{document.frm1.emid.style.border='1px solid red';
document.frm1.emid.focus();
document.getElementById('d_emid').style.visibility="visible";
document.getElementById('d_emid').innerHTML="Enter Email Id";
}
else
{f++;
}

if(document.getElementById('day').value=="0")
{
document.frm1.day.style.border='1px solid red';
document.getElementById('d_dob').style.visibility="visible";
document.getElementById('d_dob').innerHTML="Invalid Date";
}
else
{
f++;
}
if(document.getElementById('month').value=="0")
{
document.frm1.month.style.border='1px solid red';
document.getElementById('d_dob').style.visibility="visible";
document.getElementById('d_dob').innerHTML="Invalid Date";
}
else
{

f++;
}
if(document.getElementById('year').value=="0")
{
document.frm1.year.style.border='1px solid red';
document.getElementById('d_dob').style.visibility="visible";
document.getElementById('d_dob').innerHTML="Invalid Date";
}
else
{f++;
}

if((document.getElementById("gender1").checked!=true) && (document.getElementById("gender2").checked!=true))
{
//document.frm1.gender.style.border='1px solid red';
document.getElementById('d_gender').style.visibility="visible";
document.getElementById('d_gender').innerHTML="Select Gender";
}
else
{ f++;
}

if((document.getElementById("qual1").checked!=true) && (document.getElementById("qual2").checked!=true) && (document.getElementById("qual3").checked!=true) && (document.getElementById("qual4").checked!=true))
{
//document.frm1.gender.style.border='1px solid red';
document.getElementById('d_qual').style.visibility="visible";
document.getElementById('d_qual').innerHTML="Select Qualification";
}
else
{f++;
}

if(document.getElementById('wexp').value=="")
{
document.frm1.wexp.style.border='1px solid red';
//document.frm1.emid.focus();
document.getElementById('d_wexp').style.visibility="visible";
document.getElementById('d_wexp').innerHTML="Select Work Experience";
}
else
{f++;}
if(document.getElementById('utype').value=="")
{
document.frm1.utype.style.border='1px solid red';
document.getElementById('d_utype').style.visibility="visible";
document.getElementById('d_utype').innerHTML="Select Usertype";
}
else
{f++;
}

if(document.getElementById('btype').value=="")
{
document.frm1.btype.style.border='1px solid red';
//document.frm1.emid.focus();
document.getElementById('d_btype').style.visibility="visible";
document.getElementById('d_btype').innerHTML="Select Batch";
}
else
{f++;
}

if(document.getElementById('uname').value=="")
{
document.frm1.uname.style.border='1px solid red';
document.frm1.uname.focus();
document.getElementById('d_uname').style.visibility="visible";
document.getElementById('d_uname').innerHTML="Enter Username";
}
else
{f++;
}

if(document.getElementById('pwd').value=="")
{
document.frm1.pwd.style.border='1px solid red';
document.frm1.pwd.focus();
document.getElementById('d_pwd').style.visibility="visible";
document.getElementById('d_pwd').innerHTML="Enter Password";
}
else
{f++; }
if(document.getElementById('rpwd').value=="")
{
document.frm1.rpwd.style.border='1px solid red';
document.frm1.rpwd.focus();
document.getElementById('d_rpwd').style.visibility="visible";
document.getElementById('d_rpwd').innerHTML="Retype Password";
}
else
{ f++; }
if(f==15)
{return true;}
else
{
return false;} }
/*function nameval()
{
var fnm=document.getElementById('fname').value;
var pat=/\d\g;
if(fnm.match(pat))
{
alert("Only characters are allowed");
}

}*/
function phonval()
{
var ph=document.getElementById("pno").value;
var pat=/\s/g;
var ex=/\D/g;
str="";
if(ph.match(ex))
{
// alert ("Invalid Phone");
str=str+ "Phone number should be digits";
document.getElementById('pno').value="";
}
else if(ph.length!=10)
{
str=str+"Phone number should be of 10 digits"
//alert("Phone number should be of 10 digits");
}
/*else if(ph.match(pat))
{
str=str+"Phone number cannot have blank spaces";
//alert("Phone number cannot have blank spaces");
}
*/
if(str.length!=0)
{
alert(str);}
}
function emailval()
{
var reg = /^([A-Za-z0-9_\-\.])+\@([A-Za-z0-9_\-\.])+\.([A-Za-z]{2,4})$/;
var address = document.getElementById('emid').value;
if(reg.test(address) == false)
{
alert('Invalid Email Address');
return false;
}
} </script>
</head>
<body id="www-url-cz" onload="inactive()">

<h2><img src="design/icon-registration.png" height="70px" \>Registration Form</h2>
<form name="frm1" method="post">
<table style="padding-top:50px;">
<tr>
<th align="left">First Name</th>
<td><input type="text" name="fname" id="fname" size="27" class="border"></td>
<td class='err'><div id="d_fname"></div></td>
</tr>

<tr></tr>

<tr>
<th align="left">Last Name</th>
<td><input type="text" name="lname" id="lname" size="27" class="border"></td>
<td class='err'><div id="d_lname"></div></td>
</tr>

<tr></tr>

<tr>
<th align="left">Contact Address</th>
<td><textarea rows="5" cols="20" name="addr1" id="addr1" class="border"></textarea></td>
<td class="err"><div id="d_cadd"></div></td>
</tr>

<tr></tr>

<tr>
<th align="left">Permanent Address</th>
<td><textarea rows="5" cols="20" name="addr2" id="addr2" class="border"></textarea></td>
<td class='err'><div id="d_padd"></div></td>
</tr>

<tr></tr>

<tr>
<th align="left">Phone Number</th>
<td><input type="text" name="pno" id="pno" size="27" class="border" onblur="phonval()"></td>
<td class='err'><div id="d_pno"></div></td>
</tr>

<tr></tr>

<tr>
<th align="left">Email id</th>
<td><input type="text" name="emid" id="emid" size="27" class="border" onblur="return emailval()"></td>
<td class='err'><div id="d_emid"></div></td>
</tr>

<tr></tr>

<tr>
<th align="left">Date of Birth</th>
<td colspan="3">
<select name="day" id="day" class="border" onchange="dat_day()">
<option value="0">Day</option>
<script type="text/javascript">
for(i=1;i<=31;i++)
{
document.write("<option value="+i+">"+i+"</option>");
}
</script>
</select>

<select name="month" id="month" class="border" onchange="dat_month()">
<option value="0">Month</option>
<option value="1">Jan</option>
<option value="2">Feb</option>
<option value="3">Mar</option>
<option value="4">Apr</option>
<option value="5">May</option>
<option value="6">June</option>
<option value="7">Jul</option>
<option value="8">Aug</option>
<option value="9">Sep</option>
<option value="10">Oct</option>
<option value="11">Nov</option>
<option value="12">Dec</option>
</select>

<select name="year" id="year" class="border" onchange="dat_year()">
<option value="0">Year</option>
<script type="text/javascript">
for(i=1975;i<=1996;i++)
{
document.write("<option value="+i+">"+i+"</option>")
}
</script>
</select><div class="err" id="d_dob"></div>
</td>
<!--<td class="err"><div id="d_dob"></div></td>-->
</tr>

<tr></tr>

<!--<tr>
<th align="left">Age</th>
<td><input type="text" name="age id="age" size="27" class="border"></td>
</tr>-->

<tr>
<th align="left">Gender</th>
<td colspan="3">
Male<input type="radio" value="male" name="gender" id="gender1">
Female<input type="radio" value="female" name="gender" id="gender2">
<div class="err" id="d_gender"></div>
</td>
<!--<td class='err'><div id="d_gender"></div></td>-->
</tr>

<tr></tr>

<tr>
<th align="left">Qualification</th>
<td colspan="5">
SSLC<input type="radio" value="sslc" name="qual" id="qual1">
Plus Two<input type="radio" value="plus_two" name="qual" id="qual2">
Degree<input type="radio" value="degree" name="qual" id="qual3">
PG<input type="radio" value="pg" name="qual" id="qual4">
<div class="err" id="d_qual"></div>
</td>
<!--<td class='err'><div id="d_qual"></div></td>-->
</tr>

<tr></tr>

<tr>
<th align="left">Work Experience(in years)</th>
<td colspan="2"><select name="wexp" id="wexp" class="border">
<option value=''>Select One</option>
<script type="text/javascript">
for(var i=0;i<=15;i++)
{
document.write("<option value="+i+">"+i+"</option>");
}
</script>
<option>More than 15 years</option>
</select>
<div id="d_wexp" class="err"></div>
</td>
<!--<td class='err'><div id="d_wexp"></div></td>-->
</tr>

<tr></tr>

<tr>
<th align="left">User Type</th>
<td><select name="utype" id="utype" class="border">
<option value=''>Select One</option>
<option value='admin'>Administrator</option>
<option value='trainer'>Trainer</option>
<option value='trainee'>Trainee</option>
</select>
</td>
<td class='err'><div id="d_utype"></div></td>
</tr>

<tr></tr>

<tr>
<th align="left">Batch Type</th>
<td><select multiple="multiple" size="0" name="btype" id="btype" class="border">
<option value=''>Select One</option>
<?php
while($row=mysql_fetch_array($result))
{

?>
<option value="<?php echo $row['batchtypeid']?>"><?php echo $row['batchtype'] ?></option>
<?php

}
?>
</select>
</td>
<td class='err'><div id="d_btype"></div></td>
</tr>

<tr></tr>

<!-- <tr>
<th align="left">Batch Code</th>
<td>
<select multiple="multiple" size="0" name="bcode" id="bcode" class="border">-->
<!--<option value="">Select One</option>-->
<!--</select>
</td>
<td class='err'><div id="d_bcode"></div></td>
</tr>-->

<tr></tr>

<tr>
<th align="left">Username</th>
<td><input type="text" name="uname" id="uname" size="27" class="border"></td>
<td class='err'><div id="d_uname"></div></td>
</tr>

<tr></tr>

<tr>
<th align="left">Password</th>
<td><input type="password" name="pwd" id="pwd" size="27" class="border"></td>
<td class='err'><div id="d_pwd"></div></td>
</tr>

<tr></tr>


<tr>
<th align="left">Retype Password</th>
<td><input type="password" name="rpwd" id="rpwd" size="27" class="border"></td>
<td class='err'><div id="d_rpwd"></div></td>
</tr>

<tr>
<td></td>
</tr>
<tr></tr>

<tr>
<td></td>
<td><input type="submit" value="Register" name="reg1" id="reg1" onclick="return validate()" ></td>
</tr>
</table></form></div>

I have a piece of JavaScript code that should validate that a username field is not empty or null and that a telephone field is in the correct format using event handler registration. It seems to be validating fine but if there is an error it still manages to submit.

HTML

Code:

<html>
    <head> 
        <script type = "text/javascript"  src = "js/validator.js" >
        </script>
    </head>

    <body>

        <form id = "decorForm" action = "">
            <table border = "0">
                <tr>
                    <th>Username: </th>
                    <td>
                        <input type = "text"  id = "myUserName" size = "15" maxlength = "15"/>
                    </td>
                </tr>

                <tr>
                    <th>Telephone: </th>
                    <td>
                        <input type = "text" id = "telephone" name = "telephone" size = "15" maxlength = "13"/>
                        <br />
                        (999)999-9999
                    </td>
                </tr>

                <tr>
                    <td>
                        <input type = "submit" value = "Submit" />
                    </td>
                    <td>
                        <input type = "reset" value = "Reset" />
                    </td>
                </tr>

            </table>

        </form>

        <script type = "text/javascript"  src = "js/validatorr.js" >
        </script>

    </body>
</html>

JAVASCRIPT (validator.js)


Code:

function chkUser() {
// Verifies that the UserName field is not empty.
    var myUserName = document.getElementById("myUserName");
    if (myUserName.value == ""  || myUserName.value == null) {
        alert ("Please enter a Username!");
        return false;
    } else {
        return true;
    }
}

function chkTelephone() {
// Verifies that the Telephone field value is in the correct format.
    var tel = document.getElementById("telephone");
    var pos = tel.value.search(/^\(\d{3}\)\d{3}-\d{4}$/);
    if (pos != 0) {
        alert ("Please enter telephone number in the following format: (999)999-9999");
        return false;
    } else {
        return true;
    } 
}

function chkFields() {
// Verifes all fields and returns boolean to event handler
// The event handler function
    if (chkUser() && chkTelephone()) {
        return true;
    } else {
        return false;
    }
}

JAVASCRIPT (validatorr.js)

Code:

//Register the event handlers for validator.js
document.getElementById("decorForm").onSubmit = chkFields;

I am trying to use this as an example.