PHP - Singleton Inside Functions

I have a singleton class that I am revamping and need a little help with. I want to use the following syntax for my queries without having to declare a global object. Below is my current code:

  Code: [Select]
   /**
     * The db database object
     *
     * @access private
     * @var object
     */
    private $db;
 
    /**
     * MySQLi database object
     *
     * @access private
     * @var object
     */
    private static $instance;
 
    /**
     * Current result set
     *
     * @access private
     * @var object
     */
    private $result;
 
    /**
     * The last result (processed)
     *
     * @access private
     * @var array
     */
    private $last_result;
 
    /**
     * The number of rows from last result
     *
     * @access private
     * @var int
     */
    private $row_count;
 
    /**
     * Last error
     *
     * @access private
     * @var string
     */
    private $last_error;
 
    /**
     * PHP5 Constructor
     *
     * Making this function 'private' blocks this class from being directly created.
     *
     * @access private
 
     */
    private function __construct() { }
 
    /**
     * Creates and references the db object.
     *
     * @access public
     * @return object MySQLi database object
     */
    public static function instance() {
        if ( !self::$instance )
            self::$instance = new db();
        return self::$instance;
    }
 
    /**
     * Connect to the MySQL database.
     *
     * @param string $host MySQL hostname
     * @param string $user MySQL username
     * @param string $password MySQL password
     * @param string $name MySQL database name
     * @return bool True if successful, false on error.
     */
    public function connection($host, $user, $password, $name) {
        // Connect to the database
        $this->db = new mysqli($host, $user, $password, $name);
        // Check connection
        if ( mysqli_connect_errno() ) {
            $this->last_error = mysqli_connect_error();
            return false;
        }
        return true;
    }

    public function query($sql) {
        $this->result = $this->db->query($sql);
        return $this->result;
    }
So then, what would I need to change in my class so that I will not have to declare a global variable for other classes and functions to use like db::query->();? Thanks in advance for your help.

Hi, i made a singleton class to make connecting to the db easyer. I got some questions. 1: is this the right way i wrote this class? 2: how can i easy implement mysqli prepare in this class? I've looked everywhere but prepared staments need more lines of code to make it work and i don't know how to implement that in the singleton class.

<?php
	require_once(dirname(dirname(__FILE__)) . "/config.php");
	
	class Database {
		public static $instance;
		private $mysqli,
				$query,
				$results,
			    $count = 0;
	 
		public static function getInstance() {
			if (!self::$instance) {
				self::$instance = new Database();
			}
			return self::$instance;
		}
			
		public function __construct() {
			$this->mysqli = new mysqli(DB_SERVER, DB_USERNAME, DB_PASSWORD, DB_DATABASE);
			if ($this->mysqli->connect_error) {
				die($this->mysqli->connect_error);
			}
		}

		public function query($sql) {
			if ($this->query = $this->mysqli->query($sql)) {
				while ($row = $this->query->fetch_assoc()) {
					$this->results[] = $row;
				}
				$this->count = $this->query->num_rows;
			}
			return $this;
		}
		
		public function results() {
			return $this->results;
		}

		public function count() {
			return $this->count;
		}
	 
	 
	}
?>

usage:

<?php
 include('database.php');
 $r = Database::getInstance()->query('SELECT * FROM users');
foreach ($r->results() as $row) {
   echo $row['name'] . '</br>';
}
echo $r->count();
?>

I'm looking for some clarification here from different viewpoints to understand real world applications.

In a previous thread, I suggested to someone that they read up on singleton methods to restrict class duplication (oops!), I was quickly (and rightfully) shot down. I did this after having read through blog posts that also suggested singleton design to stop multiple MySQL connections. At the time I didn't consider that could be useful to some people.. fair enough.

Thankfully I don't use singleton methods within my own code, but I do use static methods for most things. Reading through numerous blog posts, tutorials, etc.., it seems like static methods can also be considered anti-design and is something to avoid.

So now it seems I'm at a point where I need to rewrite my existing framework & CMS, probably using dependency injection within my classes. I understand how this works, and why it makes sense.

What I'm struggling with is understanding how to use dependency injection within a (personal) CMS application.

For example -  I have a config.ini file I have a class that reads the .ini file, stores the variables, and provides me methods to access them I have a content class that selects the relevant page/component from the DB (db & config dependency), then displays it via my template engine. Within the included view files I call component classes (articles, contact, etc..), each of these require a connection to the DB, which has a config dependency. Here's some code to explain it better -
index.php

<?php
$settings = '/config/config.ini';

$config = new Config($settings);

$db = new Database($config);

$content = new Content( $db ); // Config may also be passed for content config - keeping it simple for example
print $content->loadPage($_GET['page']); // This would now include the code below
?>

Let's say that this then loads the article index (through $content->loadPage()). The view would look something like this -
article_index.php

<?php
// Duplicated code
$settings = '/config/config.ini';

$config = new Config($settings);

$db = new Database($config);

// Article code
$articles = new Articles_Model($db);
return $articles->getArticles(0,15);
?>

Now my problem is that I'm duplicating the config and db class calls for no reason.

Is the sollution to store these within a registry class? But then I'm creating globals, which again seems anti-design. Or is the problem how I load the active page?

Any insights would be much appreciated.

I want to create a singleton class that read multidimensional array from txt file and flatten the array retrieved.

I have a script I am putting together that simulate a cricket game. The only issue is, that there are a huge number of functions because there doesn't seem to be any other way to do this properly. As well as this, there a while() loop and all this seems to be leading to the page reaching a max 30 second timeout when generating the result.

My code is attached below, it is quite messy at the moment because i've just be working on it, but I was wondering if anyone has any solutions of how I can speed this up or change to prevent a timeout:

<?php
// Error reporting
error_reporting(E_ALL);

// Connect DB
mysql_connect("wickettowicket.adminfuel.com", "rockinaway", "preetha6488") or die(mysql_error());

// Select DB
mysql_select_db("wickettowicket") or die(mysql_error());

// MySQL queries to find batsmen and bowlers 
$array_batsmen = mysql_query('SELECT id, name, ability, strength FROM wtw_players WHERE team_id = 1 ORDER BY id ASC');
$array_bowlers = mysql_query('SELECT id, name, ability, strength FROM wtw_players WHERE team_id = 2');

// Start table for data 
$data = '<table width="600px">';

// Create blank scorecard
while ($array_bat = mysql_fetch_array($array_batsmen))
{
$data .= '<tr><td>'.$array_bat['name'].'</td><td></td><td></td><td>0</td></tr>';
}

// Set up arrays for players 
$current_batsman = $current_bowler = array();

// Reset query
mysql_data_seek($array_batsmen,0);

$in_one = $in_two = $it = '';

function currentBatsman($id, $name, $ability, $strength, $out, $in, $runs)
{
global $current_batsman;


$current_batsman = array (
'id' => $id,
'name' => $name,
'ability' => $ability,
'strength' => $strength,
'out' => $out,
'in' => $in,
'runs' => $runs
);

echo 'set current';
}

// Set up arrays of batsmen
while ($array = mysql_fetch_array($array_batsmen))
{

if ($it < 3 && $in_one == '') 
{
currentBatsman($array['id'], $array['name'], $array['ability'], $array['strength'], 0, 1, 0);

$batsmen[$array['id']] = array (
'id' => $array['id'],
'name' => $array['name'],
'ability' => $array['ability'],
'strength' => $array['strength'],
'out' => 0,
'in' => 1,
'runs' => 0
);

$in_one = $array['id'];
$current = $array['id'];
$it++;
}
else if ($it < 3 && $in_two == '') 
{
$batsmen[$array['id']] = array (
'id' => $array['id'],
'name' => $array['name'],
'ability' => $array['ability'],
'strength' => $array['strength'],
'out' => 0,
'in' => 1,
'runs' => 0
);

$in_two = $array['id'];
$it++;
}
else 
{
$batsmen[$array['id']] = array (
'id' => $array['id'],
'name' => $array['name'],
'ability' => $array['ability'],
'strength' => $array['strength'],
'out' => 0,
'in' => 0,
'runs' => 0
);
}

}

// Bowler Array
while ($array = mysql_fetch_array($array_bowlers))
{
$bowlers[] = array (
'name' => $array['name'],
'ability' => $array['ability'],
'strength' => $array['strength']
);

}

// Reset both queries
mysql_data_seek($array_bowlers,0);
mysql_data_seek($array_batsmen,0);



function changeBatsman($just_out)
{
global $array_batsmen, $batsmen; 

//Update array
$batsmen[$just_out] = array (
'in' => 1,
'out' =>  1
);

while ($array = mysql_fetch_array($array_batsmen))
{
if ($just_out != $array['id'] && $batsmen[$array['id']]['out'] != 0) currentBatsman($array['id'], $array['name'], $array['ability'], $array['strength'], 0, 1, 0);
}

// Reset query
mysql_data_seek($array_batsmen,0);

echo 'change batsman';
}

function swapBatsman($other_batsman)
{
global $array_batsmen, $batsman; 

while ($array = mysql_fetch_array($array_batsmen))
{
if ($other_batsman != $array['id'] && $batsman[$array['id']]['out'] != 0 && $batsman[$array['id']]['in'] == 1) currentBatsman($array['id'], $array['name'], $array['ability'], $array['strength'], 0, 1, 0);
}

// Reset query
mysql_data_seek($array_batsmen,0);

echo 'swap batsman';
}

$runs = $outs = $balls = $overs = 0;

$played = array();

function selectBowler()
{
global $bowlers, $current_bowler;

// Select random bowler
$choose_bowler = array_rand($bowlers, 1);

$current_bowler = array (
'name' => $bowlers[$choose_bowler]['name'],
'ability' => $bowlers[$choose_bowler]['ability'],
'strength' => $bowlers[$choose_bowler]['strength']
);

 

}

/*
function selectBatsman();
{
global $array_batsmen;

while ($array_batsmen[]['out'] != 1)
{


}*/

function bowl()
{
global $batsmen, $bowlers, $current_bowler, $current_batsman, $data, $balls, $outs, $runs;

if ($current_batsman['out'] == 0)
{
echo 'bowling';
// Set the initial number
$number = rand(0, 190);

// Ability of batsman
if ($current_batsman['ability'] > 90) $number += 30;
else if ($current_batsman['ability'] > 70) $number += 15;
else if ($current_batsman['ability'] > 50) $number += 2;
else $number = $number;

// Strength of batsman
if ($current_batsman['strength'] > 90) $number += 15;
else if ($current_batsman['strength'] > 70) $number += 10;
else if ($current_batsman['strength'] > 50) $number += 5;
else $number = $number;

// Depending on overs
if ($balls > 270) $number += 30;
else if ($balls > 120) $number -= 10;

// Ability
if ($current_bowler['ability'] > 90) $number -= 30;
else if ($current_bowler['ability'] > 70) $number -= 15;
else if ($current_bowler['ability'] > 50) $number -= 2;
else $number = $number;

// If batsman has made a huge total of runs, we need to knock some numbers off - more likely to get out
if ($current_batsman['runs'] > 200) $number -= 70;
else if ($current_batsman['runs'] > 100) $number -= 30;

// Finally sort out runs
if ($number > 190) $run = 6;
else if ($number > 170) $run = 4;
else if ($number > 160) $run = 3;
else if ($number > 100) $run = 2;
else if ($number > 50) $run = 1;
else if ($number > 10) $run = 0;
else if ($balls > 120 && $number > 0) $run = 0;
else $run = -1;

// Increase number of balls
$balls += 1;

// Are they out?
if ($run == -1)
{
$current_batsman['out'] = 1;

$played[] = $current_batsman['id'];
$find = '<tr><td>'.$current_batsman['name'].'</td><td></td><td></td><td>0</td></tr>';
$replace = '<tr><td>'.$current_batsman['name'].'</td><td></td><td>'.$current_bowler['name'].'</td><td>'.$current_batsman['runs'].'</td></tr>';

$data = str_replace($find, $replace, $data);


changeBatsman($current_batsman['id']); 



echo 'out';

}
else
{
$current_batsman['runs'] += $run;
$runs += $run;

if ($run == 1 || $run == 3)
{
swapBatsman($current_batsman['id']);
echo 'time to swap';
}

echo $run;


}

// Count outs
if ($current_batsman['out'] == 1)
$outs += 1;


}
}

function game()
{
global $main, $batsmen, $bowlers, $data, $batted, $balls, $outs, $current_batsman;

// Check if possible
while ($balls <= 295 && $outs < 10)
{

selectBowler();

// Actually bowl now

bowl();


}


}


game();



echo $data;

The Script:

$desired_width = 110;

if (isset($_POST['submit'])) {
    $j = 0; //Variable for indexing uploaded image

    for ($i = 0; $i < count($_FILES['file']['name']); $i++) {//loop to get individual element from the array
        $target_path = $_SERVER['DOCUMENT_ROOT'] . "/gallerysite/multiple_image_upload/uploads/"; //Declaring Path for uploaded images

        $validextensions = array("jpeg", "jpg", "png");  //Extensions which are allowed
        $ext = explode('.', basename($_FILES['file']['name'][$i]));//explode file name from dot(.) 
        $file_extension = end($ext); //store extensions in the variable

        $new_image_name = md5(uniqid()) . "." . $ext[count($ext) - 1];
		$target_path = $target_path . $new_image_name;//set the target path with a new name of image
        $j = $j + 1;//increment the number of uploaded images according to the files in array       
      
	  if (($_FILES["file"]["size"][$i] < 100000) //Approx. 100kb files can be uploaded.
                && in_array($file_extension, $validextensions)) {
            if (move_uploaded_file($_FILES['file']['tmp_name'][$i], $target_path)) {//if file moved to uploads folder
                echo $j. ').<span id="noerror">Image uploaded successfully!.</span><br/><br/>';

                $tqs = "INSERT INTO images (`original_image_name`, `image_file`, `date_created`) VALUES ('" . $_FILES['file']['name'][$i] . "', '" . $new_image_name  . "', now())";
                $tqr = mysqli_query($dbc, $tqs);

                // Select the ID numbers of the last inserted images and store them inside an array.
                // Use the implode() function on the array to have a string of the ID numbers separated by commas.
                // Store the ID numbers in the "image_file_id" column of the "thread" table.

                $tqs = "SELECT `id` FROM `images` WHERE `image_file` IN ('$new_image_name')";
                $tqr = mysqli_query($dbc, $tqs) or die(mysqli_error($dbc));

                $fetch_array = array();
                $row = mysqli_fetch_array($tqr);
                $fetch_array[] = $row['id'];


                /*
                 * This prints e.g.:
                    Array ( [0] => 542 )

                    Array ( [0] => 543 )

                    Array ( [0] => 544 )
                 */
                print_r($fetch_array);

                // Goes over to create the thumbnail images.
                $src = $target_path;
                $dest = $_SERVER['DOCUMENT_ROOT'] . "/gallerysite/multiple_image_upload/thumbs/" . $new_image_name;

                make_thumb($src, $dest, $desired_width);


            } else {//if file was not moved.
                echo $j. ').<span id="error">please try again!.</span><br/><br/>';
            }
        } else {//if file size and file type was incorrect.
            echo $j. ').<span id="error">***Invalid file Size or Type***</span><br/><br/>';
        }
    }
}

Hey, sorry that I am posting this darn image upload script again, I have this almost finished and I am not looking to ask more questions when it comes to this script specifically.   With the script above I have that part where the script should store the ID numbers (the auto_increment column of the table) of the image files inside of one array and then the "implode()" function would get used on the array and then the ID numbers would get inserted into the "image_file_id" column of the "thread" table.   As you can see at the above part the script prints the following:

                    Array ( [0] => 542 )

                    Array ( [0] => 543 )

                    Array ( [0] => 544 )

And I am looking to insert into the column of the table the following:

542, 543, 544

I thought of re-writing the whole image upload script since this happens inside the for loop, though I thought maybe I could be having this done with the script as it is right now.   Any suggestions on how to do this?

This topic has been moved to JavaScript Help.

http://www.phpfreaks.com/forums/index.php?topic=316454.0

I teaching myself php, but I am coming from java and other compiled languages, so the process has been a little bumpy. I am trying to do something like this:

Code: [Select]
class my_class
{

  function one ()
  {
     $two = two ();

     $three = three ();

     $five = $two + $three;

     return $five;
  }

  function two ()
  {
     $two = 2;

    return $two;
  }
 
  function three ()
  {
     $three = 3;

     return $three;
  }
}


Unfortunately, I keep getting an error message saying that my call to two () is an undefined function. I am gathering from this that the scope of one () is not aware of the existence of two (). Is there a way to get around this so I can call two () and three () from one ()?

I'm trying to pull results from a database (using php) to populate a javascript "top news rotation" script I found.

The problem is that I'm getting the "java is disabled" message that is in the code...instead of the results I'm expecting.

Here's the code:

Code: [Select]


<!-- create a element in your HTML like the following -->
<div id="quotetext" >
Text will go here. Be sure to add initial text here for users with JavaScript disabled.
</div>


<!-- The easiest way is to place the below JavaScript code after the above HTML. The better
     way would be to add in the <head> section of the document and call the rotatequote() function through the window.onload event. However this can cause problems if you have other scripts that use the
     window onLoad settings -->
<script type="text/javascript" >
var myquotes = new Array(


<?php
$link = mysql_pconnect($host, $username, $password);  
mysql_select_db('briansch_brn',$link);
$sql = "SELECT * FROM story WHERE ORDER BY date DESC LIMIT 4";
$rs = mysql_query($sql,$link);  
$matches = 0; 
while ($row = mysql_fetch_assoc($rs))  {
$matches++;
 
echo "'<strong>$row[headline]</strong><br />(posted $row[date]) - $row[short_story]<br /><a href='/pages/$row[keyword]'>READ MORE</a>'";

if($matches < 4) {
        echo ',';
        }
if($matches == 4) {
        echo '';
        }



}  
if (! $matches) { 
echo (""); 
}  
echo "";  
?>

);

function rotatequote()
{
thequote = myquotes.shift(); //Pull the top one
myquotes.push(thequote); //And add it back to the end

document.getElementById('quotetext').innerHTML = thequote;
// This rotates the quote every 10 seconds.
// Replace 10000 with (the number of seconds you want) * 1000
t=setTimeout("rotatequote()",10000);
}

// Start the first rotation.
rotatequote();
</script>

I know that javascript inside php is hard to make work...and I know that php inside javascript is hard to make work.  Any ideas?

Thanks!

I have a function to get some data from the database. However it always comes back with:

Code: [Select]
Notice: Undefined variable: db in C:\wamp\www\ASF A Simple Forum\functions\functions.php on line 233

Fatal error: Call to a member function query() on a non-object in C:\wamp\www\ASF A Simple Forum\functions\functions.php on line 233
here is the code:


require_once(ASF_ROOT."includes/init.php"); // this is where the db connection is

function get_db_info($type, $select, $table, $where="", $order="DESC", $limit="")
{
if (empty($type) || empty($select) || empty($table))
{
try
{
throw new emptyArgs();
}
catch (emptyArgs $invalid)
{
echo "<div style=\"border:1px solid #f00;
padding:5px;
width:350px;
line-height:10px;\">";

echo "<b>$invalid</b>";
echo "<p>get_info() needs atleast 3 arguments (Type, Select and Table) - none supplied</p>";
echo "</div>";
}
}
else
{
if ($type == "num")
{
$query = $db->query("
SELECT $select 
FROM ".TBL_PREFIX."$table
$where
$order
$limit
") or die($db->error());
$result = $db->num_rows(MYSQLI_NUM);
return $result;
}
else
{
$query = $db->query("
SELECT $select 
FROM ".TBL_PREFIX."$table
$where
$order
$limit
");
$result = $query->fetch_array(MYSQL_ASSOC);
return $result;
}

}
}

I have a function for mysqli_real_escape_string above this function and it works with no errors.

Have i done something wrong? as you can see i am including the file which holds the connection but it doesnt seem to use it. every other file that uses the connection works fine.

Hi, I could use a little guidance here. 1) is a function with
values to be sent to 2).

1) <!-- use ajax - OnCalc function to send data to your database. -->
function OnCalc(value1,op,value2,total)
  {

2) php file using above function values
<?php
  header( "refresh:5;url='http://localhost/hom...lcprint.php'");
  echo 'You\'ll be redirected in about 5 secs. If not, click <a

href="http://localhost/hom...hp">here</a>.';

echo '<script type="text/javascript">'
   , 'OnCalc();'
   , '</script>';
No error but code not working?

Can someone tell me by looking at the following code why function pcust() does not work, I am new to programming? 


Code: [Select]
$firstname = "chris";
$surname = "reynolds";
$address1 = "12 birch end";
$town = "Wallington";
$county = "surrey"; 
$postcode = "wh20 3bg";
$telephone = "01372 854785";
$cust_details = fix_cust($firstname, $surname, $address1,$town, $county, $postcode,  $telephone   );
function fix_cust($n1, $n2, $n3, $n4, $n5, $n6, $n7)
{
$n1 = ucfirst(strtolower($n1));
$n2 = ucfirst(strtolower($n2));
$n3 = ucwords(strtolower($n3));
$n4 = ucfirst(strtolower($n4));
$n5 = ucfirst(strtolower($n5));
$n6 = ucfirst(strtoupper($n6));
$n7 = ucfirst(strtolower($n7));
return array($n1, $n2, $n3, $n4, $n5, $n6, $n7);


}


echo $cust_details[0] . " " . $cust_details[1];
echo "<br />";
echo $cust_details[2];
echo "<br />";
echo $cust_details[3];
echo "<br />";
echo $cust_details[4];
echo "<br />";
echo $cust_details[5];
echo "<br />";
echo $cust_details[6];
echo "<br />";

function pcust(){
$length = count($cust_details );
for ($i = 0; $i < $length; $i++) {
  echo $cust_details[$i];
  echo "<br />";
}
}
pcust();

OK, so if I've got this in my one of my class files:
public function userr($user)
{

$thisquery = mysql_query("SELECT * FROM users WHERE username='". $user ."'");
if(mysql_num_rows($thisquery) == 1)
{
return true;
}

return false;
}

Could I use something like this:
if($class->userr($user)) { // Something } 
If not, how would I go about doing something like it?

And is there any way I could use a mysql_fetch_assoc in a function?

Hi.  I am trying to write a function but they are new to me and confusing me.  On multiple pages I am requesting users details.  I thought instead of writing out the query every time I want to do this I would include a functions page with the query in it.  The only variable I carry from the user is the user name as a session when they log in.  The user name is the email address of the person signed in.

so here is my first function.  As im sure you can see it doesn't work but I don't understand why or how to call it properly.  Can someone please explain....

function GetUser($user = "")

 {

$qFindUser = "SELECT * FROM members WHERE email = '$user'";

 

$rFindUser = mysql_query($qFindUser) or die (mysql_error());

  

$UserInfo = mysql_fetch_array($rFindUser);

  }

calling the function to return all details of a member as an array.
<?php  
$Name = $_SESSION['MM_Username'];
$UserInfo = GetUser($Name);


echo $UserInfo['forename'];
?>

Hey guys.
Can anyone tell me what this means?
function foo 
{
}


It is basic php but I don't get it. Should it be called for execution, or does it work automatically, or both?
The php manual at w3schools and php.net are too tough for me. That's why I posted here.

Thanks!