PHP - Optimization For Uncalled Functions.

Can someone please double check my search query to make sure it is the minimum and most efficient coding. My goal is an exact match search of field1 from my database table and list field1, field2, field3, field4 and field5 if the part number is in the database or no results if it is not. The query works as is but I have a feeling it could be done more efficiently or professionally and minimum work for my poor little server. Thanks in advance.
Code: [Select]
<?php
//connect to the database
include("./databaseconnect.php");
//get query
$q=$_GET['q'];
//convert query to uppercase & remove all spaces and special charactars
$q=strtoupper(preg_replace("/[^A-Za-z0-9]/","",$q));
//if blank query
if ($q == "")
{
echo "You did not enter a search term";
} else {
//exact match only query
$query  = "SELECT * FROM ".$dbtable." WHERE field1 like \"$q\"";
$result = mysql_query($query);
//if query returns no results
if(mysql_num_rows($result)==0)
{  
echo "<span class=\"noresults\">There were no results for your search</span>";
//display database results
} else {
while($row = mysql_fetch_array($result, MYSQL_ASSOC))
{
echo "<span class=\'results\'>SEARCH RESULTS</span><br />
<span class=\'list\'>Part Number: ".$row['field1']."<br />
Manufacturer: ".$row['field2']."<br />
Cost per unit: ".$row['field3']."<br />
Warehouse Location: ".$row['field4']."<br />
Quantity Available: ".$row['field5']."<br />
Notes: ".$row['field6']."<br />
</span>";
}
}
}
?>

Hi I am presently writing a code which does the following steps given a site
1) get some keywords (written a function for it)
2) search google for these keywords (I have used curl and getURL functions for these)
3) perform keyword search in the first page of googles results.

Presently I have used curl and curl_multi_getcontent but when i run the code it consumes 100% of my server.
My server will not respond in this case if someone else pings.

I have been trying to do pcntl_fork, but could you let me know how to optimize this code by threading and forking.

I am a newbe in PHP please let me know the structure of how to invoke multiple threads and process the same.
If you have someother suggestions please let me know that too.

Hi Guys and Gals,

I run a simple fansite for some of my fellow MTG Tactics players at www.onlinegamekey.com

I recently made a Booster Page value page he http://www.onlinegamekey.com/booster-packs.php

And it seems the page loads really slow, but I kind of understand that since its doing a lot of math and dealing with a lot of data.

I am wondering if there is a way to possibly optimize the page and querys in such a way that it doesn't take so long to load.

I'm basically using 4 queries to get the value of each pack and 1 function to average the query data. And I add them up as I go.

This is my function to find average values
Code: [Select]
///AVERAGE FUNCTION
function calculate_average($arr) {
    $count = count($arr); //total numbers in array
    foreach ($arr as $value) {
        $total = $total + $value; // total value of array numbers
    }
    $average = ($total/$count); // get average value
    return $average;
}
These are the queries to get the Average Values
Code: [Select]
<?php
///SETTING THE DAY
$today = date("Y/m/d");
///ALTERING DAY QUERY TIME (20 Days of Data)
$minusday = mktime(0,0,0,date("m"),date("d")-20,date("Y"));
///SETTING THE DAY FOR THE QUERIES
$queryday = date("Y/m/d",$minusday);

///DATA SET FOR BOOSTER PACK 1
//GET THE MYTHIC AVERAGE VALUE
$sqlMythic=mysql_query("SELECT AVG( ab.Price_Per ) AS Aaverage
FROM auctions AS ab
INNER JOIN cardlist AS c ON c.card_name = ab.Card_Name
WHERE ab.Day >= '$queryday'
AND c.rarity = 'Mythic Rare'
AND c.set = '1'
GROUP BY c.card_name, ab.Card_Name") or die;
while ($row=mysql_fetch_array($sqlMythic)) {
$MythicValues[]=$row['Aaverage'];
}
///MYTHIC VALUE IS 10% OF AVERAGE VALUE
$Mythic = calculate_average($MythicValues) * .1;

//GET THE RARE AVERAGE VALUE
$sqlRare=mysql_query("SELECT AVG( ab.Price_Per ) AS Aaverage
FROM auctions AS ab
INNER JOIN cardlist AS c ON c.card_name = ab.Card_Name
WHERE ab.Day >= '$queryday'
AND c.rarity = 'Rare'
AND c.set='1'
GROUP BY c.card_name, ab.Card_Name") or die;
while ($row=mysql_fetch_array($sqlRare)) {
$RareValues[]=$row['Aaverage'];
}
///RARE VALUE IS 90% OF AVERAGE RARE VALUE
$Rare = calculate_average($RareValues) *.9;
///TOTAL CONTRIBUTION TO PACK 100% IS 10% MYTHIC + 90% RARE
$raremythic= $Mythic + $Rare;

///GET THE UNCOMMON AVERAGE VALUE
$sqlUncommon=mysql_query("SELECT AVG( ab.Price_Per ) AS Aaverage
FROM auctions AS ab
INNER JOIN cardlist AS c ON c.card_name = ab.Card_Name
WHERE ab.Day >= '$queryday'
AND c.rarity = 'Uncommon'
AND c.set='1'
GROUP BY c.card_name, ab.Card_Name") or die;
while ($row=mysql_fetch_array($sqlUncommon)) {
$ucValues[]=$row['Aaverage'];
}
///UNCOMMON VALUE IS VALUE * 3
$Uncommon = calculate_average($ucValues);
$urm= ($Uncommon * 3) + $raremythic;

///GET THE COMMON VALUE
$sqlCommon=mysql_query("SELECT AVG( ab.Price_Per ) AS Aaverage
FROM auctions AS ab
INNER JOIN cardlist AS c ON c.card_name = ab.Card_Name
WHERE ab.Day >= '$queryday'
AND c.rarity = 'Common'
AND c.set='1'
GROUP BY c.card_name, ab.Card_Name") or die;
while ($row=mysql_fetch_array($sqlCommon)) {
$cValues[]=$row['Aaverage'];
}
///COMMON VALUE IS VALUE * 10
$common = calculate_average($cValues);
//TOTAL SET 1 VALUE IS ALL VALUES ADDED UP
$curm= ($common * 10) + $urm;
?>
But I'm not real sure where the strain is coming from. The page seems to load really slow, and I'm not sure if I should just try and write all these queries as a separate function then have it write the data to a separate table, or if there is another way to optimize this code.

I'm still have a lot to learn so I would appreciate any thoughts or ideas you folks can offer me.

Many thanks

This is a two parter... mostly a discussion as I am currently not employing the purpose of these "things"   I am creating an autoparsing webapp that has unlimited use... whatever a person can think of   It accesses camera, microphone, gyro/accelerometer, flash etc... mostly it takes in data and does something to it according to the parsing tool   I'm not saying this is new, in fact I spent a while using Touch Develop which is a scripting "thing" by Microsoft, the problem was lag   That is another thing that concerns me, without web access the web-app is useless right? So I'm wondering if it is possible to copy your current setup and either translate it to the mobile languages like Java, C#/XML, Objective C or somehow a platform independent alternative   Anyway...   I'm not sure if I can access front end code, like <div class="whatever"> safely using injection   Well injection you just bind parameters but what if the incoming string is literally malicious ?   Also as far as autoparsing optimization goes, what I mean by that is I intended to create a character by character comparison, obviously or at least to me, starting with easier stuff first like   for example a link is entered   http://www.something.com   then the autoparser compares each character one at a time from left to right   |1|2|3|4|5|6|7|8|9|10| |h|t|t|p|:|/|/|w|w|w|...etc...   But I would check for existing formats starting with the shortest first and also checking from right and left, eg. .mp4 is obvious as a file type   I'll have more once I actually know what I need just looking to discuss I suppose... sorry if that is not appropriate feel free to delete this thread   In the future the users who have modified their personal accounts would benefit from an "AI" thing that is specific to their personalities based on what they have enabled
Edited by greenace92, 28 December 2014 - 09:37 AM.

I have a script I am putting together that simulate a cricket game. The only issue is, that there are a huge number of functions because there doesn't seem to be any other way to do this properly. As well as this, there a while() loop and all this seems to be leading to the page reaching a max 30 second timeout when generating the result.

My code is attached below, it is quite messy at the moment because i've just be working on it, but I was wondering if anyone has any solutions of how I can speed this up or change to prevent a timeout:

<?php
// Error reporting
error_reporting(E_ALL);

// Connect DB
mysql_connect("wickettowicket.adminfuel.com", "rockinaway", "preetha6488") or die(mysql_error());

// Select DB
mysql_select_db("wickettowicket") or die(mysql_error());

// MySQL queries to find batsmen and bowlers 
$array_batsmen = mysql_query('SELECT id, name, ability, strength FROM wtw_players WHERE team_id = 1 ORDER BY id ASC');
$array_bowlers = mysql_query('SELECT id, name, ability, strength FROM wtw_players WHERE team_id = 2');

// Start table for data 
$data = '<table width="600px">';

// Create blank scorecard
while ($array_bat = mysql_fetch_array($array_batsmen))
{
$data .= '<tr><td>'.$array_bat['name'].'</td><td></td><td></td><td>0</td></tr>';
}

// Set up arrays for players 
$current_batsman = $current_bowler = array();

// Reset query
mysql_data_seek($array_batsmen,0);

$in_one = $in_two = $it = '';

function currentBatsman($id, $name, $ability, $strength, $out, $in, $runs)
{
global $current_batsman;


$current_batsman = array (
'id' => $id,
'name' => $name,
'ability' => $ability,
'strength' => $strength,
'out' => $out,
'in' => $in,
'runs' => $runs
);

echo 'set current';
}

// Set up arrays of batsmen
while ($array = mysql_fetch_array($array_batsmen))
{

if ($it < 3 && $in_one == '') 
{
currentBatsman($array['id'], $array['name'], $array['ability'], $array['strength'], 0, 1, 0);

$batsmen[$array['id']] = array (
'id' => $array['id'],
'name' => $array['name'],
'ability' => $array['ability'],
'strength' => $array['strength'],
'out' => 0,
'in' => 1,
'runs' => 0
);

$in_one = $array['id'];
$current = $array['id'];
$it++;
}
else if ($it < 3 && $in_two == '') 
{
$batsmen[$array['id']] = array (
'id' => $array['id'],
'name' => $array['name'],
'ability' => $array['ability'],
'strength' => $array['strength'],
'out' => 0,
'in' => 1,
'runs' => 0
);

$in_two = $array['id'];
$it++;
}
else 
{
$batsmen[$array['id']] = array (
'id' => $array['id'],
'name' => $array['name'],
'ability' => $array['ability'],
'strength' => $array['strength'],
'out' => 0,
'in' => 0,
'runs' => 0
);
}

}

// Bowler Array
while ($array = mysql_fetch_array($array_bowlers))
{
$bowlers[] = array (
'name' => $array['name'],
'ability' => $array['ability'],
'strength' => $array['strength']
);

}

// Reset both queries
mysql_data_seek($array_bowlers,0);
mysql_data_seek($array_batsmen,0);



function changeBatsman($just_out)
{
global $array_batsmen, $batsmen; 

//Update array
$batsmen[$just_out] = array (
'in' => 1,
'out' =>  1
);

while ($array = mysql_fetch_array($array_batsmen))
{
if ($just_out != $array['id'] && $batsmen[$array['id']]['out'] != 0) currentBatsman($array['id'], $array['name'], $array['ability'], $array['strength'], 0, 1, 0);
}

// Reset query
mysql_data_seek($array_batsmen,0);

echo 'change batsman';
}

function swapBatsman($other_batsman)
{
global $array_batsmen, $batsman; 

while ($array = mysql_fetch_array($array_batsmen))
{
if ($other_batsman != $array['id'] && $batsman[$array['id']]['out'] != 0 && $batsman[$array['id']]['in'] == 1) currentBatsman($array['id'], $array['name'], $array['ability'], $array['strength'], 0, 1, 0);
}

// Reset query
mysql_data_seek($array_batsmen,0);

echo 'swap batsman';
}

$runs = $outs = $balls = $overs = 0;

$played = array();

function selectBowler()
{
global $bowlers, $current_bowler;

// Select random bowler
$choose_bowler = array_rand($bowlers, 1);

$current_bowler = array (
'name' => $bowlers[$choose_bowler]['name'],
'ability' => $bowlers[$choose_bowler]['ability'],
'strength' => $bowlers[$choose_bowler]['strength']
);

 

}

/*
function selectBatsman();
{
global $array_batsmen;

while ($array_batsmen[]['out'] != 1)
{


}*/

function bowl()
{
global $batsmen, $bowlers, $current_bowler, $current_batsman, $data, $balls, $outs, $runs;

if ($current_batsman['out'] == 0)
{
echo 'bowling';
// Set the initial number
$number = rand(0, 190);

// Ability of batsman
if ($current_batsman['ability'] > 90) $number += 30;
else if ($current_batsman['ability'] > 70) $number += 15;
else if ($current_batsman['ability'] > 50) $number += 2;
else $number = $number;

// Strength of batsman
if ($current_batsman['strength'] > 90) $number += 15;
else if ($current_batsman['strength'] > 70) $number += 10;
else if ($current_batsman['strength'] > 50) $number += 5;
else $number = $number;

// Depending on overs
if ($balls > 270) $number += 30;
else if ($balls > 120) $number -= 10;

// Ability
if ($current_bowler['ability'] > 90) $number -= 30;
else if ($current_bowler['ability'] > 70) $number -= 15;
else if ($current_bowler['ability'] > 50) $number -= 2;
else $number = $number;

// If batsman has made a huge total of runs, we need to knock some numbers off - more likely to get out
if ($current_batsman['runs'] > 200) $number -= 70;
else if ($current_batsman['runs'] > 100) $number -= 30;

// Finally sort out runs
if ($number > 190) $run = 6;
else if ($number > 170) $run = 4;
else if ($number > 160) $run = 3;
else if ($number > 100) $run = 2;
else if ($number > 50) $run = 1;
else if ($number > 10) $run = 0;
else if ($balls > 120 && $number > 0) $run = 0;
else $run = -1;

// Increase number of balls
$balls += 1;

// Are they out?
if ($run == -1)
{
$current_batsman['out'] = 1;

$played[] = $current_batsman['id'];
$find = '<tr><td>'.$current_batsman['name'].'</td><td></td><td></td><td>0</td></tr>';
$replace = '<tr><td>'.$current_batsman['name'].'</td><td></td><td>'.$current_bowler['name'].'</td><td>'.$current_batsman['runs'].'</td></tr>';

$data = str_replace($find, $replace, $data);


changeBatsman($current_batsman['id']); 



echo 'out';

}
else
{
$current_batsman['runs'] += $run;
$runs += $run;

if ($run == 1 || $run == 3)
{
swapBatsman($current_batsman['id']);
echo 'time to swap';
}

echo $run;


}

// Count outs
if ($current_batsman['out'] == 1)
$outs += 1;


}
}

function game()
{
global $main, $batsmen, $bowlers, $data, $batted, $balls, $outs, $current_batsman;

// Check if possible
while ($balls <= 295 && $outs < 10)
{

selectBowler();

// Actually bowl now

bowl();


}


}


game();



echo $data;

I teaching myself php, but I am coming from java and other compiled languages, so the process has been a little bumpy. I am trying to do something like this:

Code: [Select]
class my_class
{

  function one ()
  {
     $two = two ();

     $three = three ();

     $five = $two + $three;

     return $five;
  }

  function two ()
  {
     $two = 2;

    return $two;
  }
 
  function three ()
  {
     $three = 3;

     return $three;
  }
}


Unfortunately, I keep getting an error message saying that my call to two () is an undefined function. I am gathering from this that the scope of one () is not aware of the existence of two (). Is there a way to get around this so I can call two () and three () from one ()?

Hi.  I am trying to write a function but they are new to me and confusing me.  On multiple pages I am requesting users details.  I thought instead of writing out the query every time I want to do this I would include a functions page with the query in it.  The only variable I carry from the user is the user name as a session when they log in.  The user name is the email address of the person signed in.

so here is my first function.  As im sure you can see it doesn't work but I don't understand why or how to call it properly.  Can someone please explain....

function GetUser($user = "")

 {

$qFindUser = "SELECT * FROM members WHERE email = '$user'";

 

$rFindUser = mysql_query($qFindUser) or die (mysql_error());

  

$UserInfo = mysql_fetch_array($rFindUser);

  }

calling the function to return all details of a member as an array.
<?php  
$Name = $_SESSION['MM_Username'];
$UserInfo = GetUser($Name);


echo $UserInfo['forename'];
?>

Hi,

I've got 3 different upload forms in one form.  I'm making a function so it just one piece of code.

I'm having a bit of a problem changing some of the code so it works for all 3.

Here is the function




function loadImages ($action, $position)
{
 $link = mysql_connect("","","");
if (!$link)
{
die('Error: could not connect: ' . mysql_error());
}

$db_select = mysql_select_db("",$link);
if (!$db_select)
{
die ("Error: database selection failed: " . mysql_error());
}
$page = ($_POST["pageName"]);
if ((($_FILES["bfile"]["type"] == "image/gif")
|| ($_FILES["bfile"]["type"] == "image/jpeg")
|| ($_FILES["bfile"]["type"] == "image/pjpeg"))
&& ($_FILES["bfile"]["size"] < 9000000))
{
if ($_FILES["bfile"]["error"] > 0)
{
echo "Return Code: " . $_FILES["bfile"]["error"] . "<br />";
}
else
{
 $success = '<p style="font-weight: bold; color: #C00">Upload successful<br />';
// move uploaded temporary file to final destination
move_uploaded_file($_FILES["bfile"]["tmp_name"],
"uploads/" . $_FILES["bfile"]["name"]);

// update database with new filename
 $filename = $_FILES["bfile"]["name"];
 $sql = "UPDATE images 
 SET filename= '$filename'
 where page = '$page'
 and position = '$position'";

if (!mysql_query($sql,$link))
{
die('Error: ' . mysql_error());
}

}
}
else
{
 $fail = '<p style="font-weight: bold; color: #C00">Invalid file';
}
mysql_close($link);
}


Now the $action is the bit that will determine whether it's updateTop updateMiddle or updateBottom.  $position finds out if it's top middle or bottom


if (isset($_POST['updateTop'])) 
    {
loadImages ($_POST['updateTop'], "top");
}


Here is a sample of the html, it's in a switch

case "Products":
                              echo "<p>Image Top</p>
                                    <input type=\"file\" name=\"file\" id=\"file\" />  <input type=\"submit\" name=\"updateTop\" value=\"Update $page Top\" />
                                    <p>Image Middle</p>
                                    <input type=\"file\" name=\"mfile\" id=\"mfile\" />  <input type=\"submit\" name=\"updateMiddle\" value=\"Update $page Middle\" />
                                    <p>Image Bottom</p>
                                    <input type=\"file\" name=\"bfile\" id=\"bfile\" />  <input type=\"submit\" name=\"updateBottom\" value=\"Update $page Bottom\" />
                                    ";
                              break;


What I need to do is get $_FILES["bfile" into a variable to see whether it's "bfile" "mfile" or "file" but not sure how to write it.

Thanks for the help.

When in OOP I have been watching tutorials and some have functions just written like Code: [Select]
class user
{
 public $user;

 public function __construct($u)
 {
   $this->user = $u;
 }

}
do I need to type public before the function or is it better practice to just put

Code: [Select]
class user
{
 public $user;

 function __construct($u)
 {
   $this->user = $u;
 }

}


Thanks!

Can someone tell me by looking at the following code why function pcust() does not work, I am new to programming? 


Code: [Select]
$firstname = "chris";
$surname = "reynolds";
$address1 = "12 birch end";
$town = "Wallington";
$county = "surrey"; 
$postcode = "wh20 3bg";
$telephone = "01372 854785";
$cust_details = fix_cust($firstname, $surname, $address1,$town, $county, $postcode,  $telephone   );
function fix_cust($n1, $n2, $n3, $n4, $n5, $n6, $n7)
{
$n1 = ucfirst(strtolower($n1));
$n2 = ucfirst(strtolower($n2));
$n3 = ucwords(strtolower($n3));
$n4 = ucfirst(strtolower($n4));
$n5 = ucfirst(strtolower($n5));
$n6 = ucfirst(strtoupper($n6));
$n7 = ucfirst(strtolower($n7));
return array($n1, $n2, $n3, $n4, $n5, $n6, $n7);


}


echo $cust_details[0] . " " . $cust_details[1];
echo "<br />";
echo $cust_details[2];
echo "<br />";
echo $cust_details[3];
echo "<br />";
echo $cust_details[4];
echo "<br />";
echo $cust_details[5];
echo "<br />";
echo $cust_details[6];
echo "<br />";

function pcust(){
$length = count($cust_details );
for ($i = 0; $i < $length; $i++) {
  echo $cust_details[$i];
  echo "<br />";
}
}
pcust();

As painfully simple as this may be, I seem to be doing something wrong as always. New to php and decided to start using functions. I'm trying to add functions from an external functions.php file to my other pages and then call the functions where necessary. How should I go about it? I tried something like this:

Functions.php:
Code: [Select]
<?php
function field() {
echo 'text heherh';
}
?>

and then when calling it to when needed for example:
include 'includes/functions.php'; // at the top of the page
Code: [Select]
<?php
// and when trying to call the function on a specific line 
if (!$sname)
$errorstring = $errorstring . "<b>Surname:" . field() ; //field being the function name
?>

I know this is very simple but I have never used functions before.. tried google, didn't help much and I'm pressed for time so decided to ask here. Thanks in advance

Hi, I could use a little guidance here. 1) is a function with
values to be sent to 2).

1) <!-- use ajax - OnCalc function to send data to your database. -->
function OnCalc(value1,op,value2,total)
  {

2) php file using above function values
<?php
  header( "refresh:5;url='http://localhost/hom...lcprint.php'");
  echo 'You\'ll be redirected in about 5 secs. If not, click <a

href="http://localhost/hom...hp">here</a>.';

echo '<script type="text/javascript">'
   , 'OnCalc();'
   , '</script>';
No error but code not working?

i am wondering what the '@' is used for when used in front of a function like


Function(@$VAR);


What is the benefit of the @?

I have a function to get some data from the database. However it always comes back with:

Code: [Select]
Notice: Undefined variable: db in C:\wamp\www\ASF A Simple Forum\functions\functions.php on line 233

Fatal error: Call to a member function query() on a non-object in C:\wamp\www\ASF A Simple Forum\functions\functions.php on line 233
here is the code:


require_once(ASF_ROOT."includes/init.php"); // this is where the db connection is

function get_db_info($type, $select, $table, $where="", $order="DESC", $limit="")
{
if (empty($type) || empty($select) || empty($table))
{
try
{
throw new emptyArgs();
}
catch (emptyArgs $invalid)
{
echo "<div style=\"border:1px solid #f00;
padding:5px;
width:350px;
line-height:10px;\">";

echo "<b>$invalid</b>";
echo "<p>get_info() needs atleast 3 arguments (Type, Select and Table) - none supplied</p>";
echo "</div>";
}
}
else
{
if ($type == "num")
{
$query = $db->query("
SELECT $select 
FROM ".TBL_PREFIX."$table
$where
$order
$limit
") or die($db->error());
$result = $db->num_rows(MYSQLI_NUM);
return $result;
}
else
{
$query = $db->query("
SELECT $select 
FROM ".TBL_PREFIX."$table
$where
$order
$limit
");
$result = $query->fetch_array(MYSQL_ASSOC);
return $result;
}

}
}

I have a function for mysqli_real_escape_string above this function and it works with no errors.

Have i done something wrong? as you can see i am including the file which holds the connection but it doesnt seem to use it. every other file that uses the connection works fine.

Hey guys.
Can anyone tell me what this means?
function foo 
{
}


It is basic php but I don't get it. Should it be called for execution, or does it work automatically, or both?
The php manual at w3schools and php.net are too tough for me. That's why I posted here.

Thanks!