PHP - Nesting Foreach In A Function

ok.

say i have a list with a foreach loop in it.
like this:

Code: [Select]
echo'
<ul>';

$link = Link::find_all();
foreach($link as $links){
$name = $links->name;

echo'
<li>'.$name.'</li>';

}
echo'
</ul>';




now.
say that i want to put this part :
Code: [Select]
$link = Link::find_all();
foreach($link as $links){
$name = $links->name;

into a function so i can reuse the code...

like this:

FUNCTION
Code: [Select]
function(find_li){
  $link = Link::find_all();
  foreach($link as $links){
  $name = $links->name;
}
Code: [Select]
echo'
<ul>';

find_li();

echo'
<li>'.$name.'</li>';
}
echo'
</ul>';


the problem is the foreach } its not inside the function so the function will not work. but it needs to be after the </li> so that i get all the results in the <li>

so is there a way to put the function before the <li> and the } after the </li>

I've made this code for a very simple registration form practice:

 

  //assign form variables
  $firstname = $_POST['firstname'];
  $lastname = $_POST['lastname'];
  $username = $_POST['username'];

  function clean_names($dirty_name) {
      strip_tags($dirty_name);
      str_replace(' ', '', $dirty_name);
      ucfirst(strtolower($dirty_name));

      //return $dirty_name;
    }

  $names = array($firstname, $lastname, $username);

  if(isset($_POST['register_button'])) {

    //  WHY IS THIS FUNC CALL NOT WORKING??
    foreach($names as $name) {
      clean_names($name);

    }

    echo "First Name: " . $firstname . "<br>";
    echo "Last Name: " . $lastname . "<br>";
    echo "Username: " . $username . "<br>";

  }

The values are returned but they haven't been put through the clean_names function.
I'm really new with PHP. Can someone tell me why this isn't working? Thank you

Hello,

I am new to PHP and have come to a grinding halt in my project. I am attempting to dynamically generate values for Wordpress shortcodes ( [example] ). I have successfully created the shortcodes and am having trouble setting their value. When I call the function that is supposed to return the value for the shortcode, it returns empty. I can however hard code a string and have it returned to the function, thereby manually creating a value for the shortcode. However, because the shortcodes are being generated and filled dynamically, I need this function to work without specific values. I know this may sound like a Wordpress specific question, but I have a feeling it's just my lack of understanding of PHP operations. So, here is the basic layout:

The name of the shortcode is generated from within a foreach loop that retrieves the name of custom fields on the post ($keyName).

Code: [Select]
$custom_field_keys = get_post_custom_keys();
foreach ( $custom_field_keys as $key => $keyName )
{
  $valuet = trim($keyName);
  if ( '_' == $valuet{0} )
continue;
if ( get_post_meta($thePostID, $keyName, true) ) :
$fieldName = get_post_meta($thePostID, $keyName, true);
endif;
$fieldValue = $_GET["$keyName"];
add_shortcode((string)$keyName, 'myFields');

}

The add_shortcode function has two parameters ('name_of_shortcode', 'function_name'):

Code: [Select]
add_shortcode((string)$keyName, 'myFields');
I need the myFields function to return the value of $fieldValue from within the foreach loop. That's where the problem lies.
This doesn't work:

Code: [Select]
function myFields()
{
$myString = preg_replace('/[^a-zA-Z\s]/', '', $fieldValue);
return $myString;
}

This does work:
Code: [Select]
function myFields()
{
return 'Content to replace the shortcode';
}


This code will replace [shortcode] with "Content to replace the shortcode" in the post.

The ultimate goal is: when [$keyName] appears anywhere within the post, it will display the content returned by the myFields function ($fieldValue). However, it's not working.  I can't seem to pass the value of $fieldValue to the myFields function and thereby return it to add_shortcode. Any help is appreciated and I am awaiting anxiously to answer any questions.

Here's all the code together:

Code: [Select]
function myFields()
{
$myString = preg_replace('/[^a-zA-Z\s]/', '', $fieldValue);
return $myString;
}

                $custom_field_keys = get_post_custom_keys();

foreach ( $custom_field_keys as $key => $keyName )
{
  $valuet = trim($keyName);
  if ( '_' == $valuet{0} )
continue;
if ( get_post_meta($thePostID, $keyName, true) ) :
$fieldName = get_post_meta($thePostID, $keyName, true);
endif;
$fieldValue = $_GET["$keyName"];
add_shortcode((string)$keyName, 'yourFunction');

}

Im trying to assign and update table rows with a random 9 character string but am receiving the error : Fatal error: Cannot redeclare make_seed() (previously declared in ...

How can I clear/reset the value before the next loop

Code: [Select]
else {
while ($data=mysql_fetch_array($users)){
$user=$data[user];

$usersarray = array($users);

foreach ($usersarray as $key => $u){
//clear pass
$token = "";
srand();

//generate new password
$password_length = 9;

function make_seed() {
  list($usec, $sec) = explode(' ', microtime());
  return (float) $sec + ((float) $usec * 100000);
}

srand(make_seed());

$alfa = "1234567890qwertyuiopasdfghjklzxcvbnmQWERTYUIOPASDFGHJKLZXCVBNM!@#$%^&*(){}[]";

for($i = 0; $i < $password_length; $i ++) {
  $token .= $alfa[rand(0, strlen($alfa))];
  }   

// insert password
// setup SQL statement 
    $SQL = " UPDATE data SET pass='$token' WHERE user='$m1' ";
       
        // execute SQL statement
        $makeit = mysql_db_query($userdb,"$SQL",$usercid);

        // check for error
        if (!$makeit) { echo("ERROR: " . mysql_error() . "\n$SQL\n");
}

Can  anyone help me complete this script I can get it working with using an implode function, but for the purpose of knowledge I want to not use it.

I just want it to echo back the corresponding checkboxes, but I can't get the echoing correct, it echoes back array not the value?

Code: [Select]
<html>
<title>What do you want on your Tombstone?</title>

<body>

<?php

$Output_form = true;
if (isset($_POST['submit'])) 
{
if (empty($_POST['toppings'])) 
{ 

echo '<b>You forgot the toppings for your Tombstone.</b>';
echo '<br>';
echo '<br>';

} else {

echo '<p><b>This is what you are getting on your Tombstone: ';
(array)$_POST['toppings'];
echo $toppings;
echo '!';
echo '</p></b>';
$Output_form = false;
}
}

if ($Output_form)
{ 
?>

<form action="ProcessToppings.php" method="post">
<p><i><h2>What do you want on your Tombstone?</h2></i></p>
<p>
<input type="checkbox" name="toppings[]" value="pepperoni" /> Pepperoni<br />
<input type="checkbox" name="toppings[]" value="sausage" /> Sausage<br />
<input type="checkbox" name="toppings[]" value="mushrooms" /> Mushrooms<br />
<input type="checkbox" name="toppings[]" value="cheese" /> Cheese<br />
<input type="checkbox" name="toppings[]" value="olives" /> Olives</p>
<p>
<input type="submit" value="Make that Peet-Za!" name="submit" /></p>

</form>

<?php 
} 

?>

</body>
</html>