PHP - Is This Upload Script Secure?

I'm allowing users to upload a file into a directory that is inside of my ftp's root directory(what is the proper term for this area anyway?)
Anyway, I am uploading to this folder:
Code: [Select]
+ www.mywebsite.com/
+ files/
+ images/
- welcome.jpg
+ system/
- text.txt
- index.php
+ upload/ <-- here, this one right here
- an_uploaded_file.zip

If I have a php script that downloads from this folder would I need to worry about someone doing something that is not intended? I don't want someone overwriting my index.php with their own.

Hello, i want to know if this code is ok or do i have sql-injection, session hijacking etc. thank you very much for your help. Rafal

<?php
INI_SET('SESSION.USE_ONLY_COOKIES', 1);
SESSION_START();
SESSION_CACHE_EXPIRE(10);
SESSION_REGENERATE_ID();
$uname = "mail@mail.com";
$upassword = "a4ca6e1f044a98a8a72e7b356a134319433f4d98adb3f463202246bddb883712459e66ea985f37cb2e7171165500c341be4effd1f6e4461246e3c61e5767741f";
if (isset($_POST["inp_name"]) && isset($_POST["inp_pwd"]))
{
if ($uname == $_POST["inp_name"] && $upassword == hash('sha512', $_POST["inp_pwd"]))
{
$_SESSION["e64X96ea"] = 1;
}
}
?>
<?php
if ($_SESSION["e64X96ea"] != 1)
{
header ( 'Location:login.php' );
exit;
}
?> 

Edited by rafal, 16 November 2014 - 08:39 AM.

Hi All,
I am using HTTP Session2 pear module in my project.
My logout code is

HTTP_Session2::set('user_id','');
HTTP_Session2::set('user_type','');
HTTP_Session2::regenerateId(true);
HTTP_Session2::destroy();
pageRedirect("index.php?q=registration/login");
exit;


My Check Login Script is


if(trim(HTTP_Session2::get('user_id'))=='' || trim(HTTP_Session2::get('user_type'))=='') {
        HTTP_Session2::set('user_id','');
HTTP_Session2::set('user_type','');
HTTP_Session2::regenerateId(true);
HTTP_Session2::destroy();
pageRedirect("index.php?q=registration/login");
        exit;
}



problem here is whenever I click on back button after logout then I can see the user homepage, on which I have written "Check Login Script ".

Is there a good solution available ?

Hi everyone,

I have a page that i use to upload images to my website, i got a bit fed up of uploading one at a time so i decided to add multiple file fields to the form to upload multiple images at the same time.

Im having a few problems, iv read up he http://www.php.net/manual/en/features.file-upload.multiple.php and it seems all i have to do is add [] to the form names to turn them into arrays. However when i come to upload the images, i keep getting the "$error[] = "Incorrect format!...." error from the code below. I cant seem to figure out what the problem is.

Could anybody please point me in the right direction?


<?php 
session_start();

$id = $_SESSION['id'];

$connect = mysql_connect("localhost","leemp5_admin","p7031521");
mysql_select_db("leemp5_database");

$query = mysql_query("SELECT * FROM users WHERE id='$id'");
$row = mysql_fetch_assoc($query);

$username = $row['username'];

$submit = $_POST['submit'];

$type = $_FILES['image']['type'];
$size = $_FILES['image']['size'];
$max_size = "1000"; 
$width = "100"; 
$height = "100";
 
$error = array();

function make_thumb($image_name,$filename,$new_width,$new_height) 
{

$ext=getExtension($image_name); 

if(!strcmp("jpg",$ext) || !strcmp("jpeg",$ext)) 

$source_image=imagecreatefromjpeg($image_name);   

if(!strcmp("png",$ext)) 

$source_image=imagecreatefrompng($image_name);

if(!strcmp("gif",$ext)) 

$source_image=imagecreatefromgif($image_name); 

$old_x=imageSX($source_image);

$old_y=imageSY($source_image);   

$ratio1=$old_x/$new_width; 

$ratio2=$old_y/$new_height; 

if($ratio1>$ratio2)

{ 

$thumb_width=$new_width; 

$thumb_height=$old_y/$ratio1; 

} 

else 

{ 

$thumb_height=$new_height;

$thumb_width=$old_x/$ratio2; 

} 
  

$destination_image=ImageCreateTrueColor($thumb_width,$thumb_height);   

imagecopyresampled($destination_image,$source_image,0,0,0,0,$thumb_width,$thumb_height,$old_x,$old_y);   

if(!strcmp("jpg",$ext) || !strcmp("jpeg",$ext))

{

imagejpeg($destination_image,$filename); 

}

if(!strcmp("png",$ext)) 

{

imagepng($destination_image,$filename); 

}

if(!strcmp("gif",$ext)) 

{

imagegif($destination_image,$filename); 

}

imagedestroy($destination_image); 

imagedestroy($source_image); 
}   


function getExtension($str)
{ 

$i = strrpos($str,"."); 

if (!$i) { return ""; } 

$l = strlen($str) - $i; 

$ext = substr($str,$i+1,$l); 

return $ext; 
}   

if($submit) 
{ 

$image=$_FILES['image']['name']; 

if ($image) 

{ 

$filename = stripslashes($_FILES['image']['name']);   

$extension = getExtension($filename); 

$extension = strtolower($extension); 

if (($extension != "jpg") && ($extension != "jpeg") && ($extension != "png") && ($extension != "gif"))

{ 

$error[] = "Incorrect format! Please make sure your image is a .jpg, .jpeg, .png or .gif file.";

} 

else

{ 

$size=getimagesize($_FILES['image']['tmp_name']); 

$sizekb=filesize($_FILES['image']['tmp_name']); 
  

if ($sizekb > $max_size*1024) 

{ 

$error[] = "Your image is too big! The maximum upload size is 1MB.";

}   

else

{

$image_name=time().'.'.$extension; 
 

$newname="uploads/" . $username . "/images/".$image_name; $copied = copy($_FILES['image']['tmp_name'], $newname); 

if (!$copied) 

{ 

$error[] = "There was an error uploading your image. Please try again!";

} 

else 

{ 

$thumb_name='uploads/' . $username . '/images/thumbs/thumb_'.$image_name; 
 

$thumb=make_thumb($newname,$thumb_name,$width,$height); 

}

}

}

}

else

{

$error[] = "Please select an image to upload!";

}

if(empty($error))

{

echo "Upload Successfully!<br />"; 

echo '<img src="'.$thumb_name.'">';

mysql_query("INSERT INTO images VALUES ('','$username','$image_name','','','','','uploads/$username/images/$image_name','uploads/$username/images/thumbs/thumb_$image_name','$type','$size')");

}

else

{
    

echo implode($error);

}
}
?>
<form method="post" enctype="multipart/form-data" action="upload_images.php">
<input type="file" name="image[]" /><br />
<input type="file" name="image[]" /><br />
<input type="file" name="image[]" /><br />
<input type="file" name="image[]" /><br />
<input type="file" name="image[]" /><br />
<input type="file" name="image[]" /><br />
<input type="submit" name="submit" value="Upload">
</form>


Thanks