PHP - Php Optimization: Mysql_fetch_assoc Vs Foreach

i have a random no. of directories and files being created using the mkdir and touch functions and the newly created files are copying a pre-made template.. the links of the pages which were being created had %20 signs between the spaces.. i wanted to change them with "-" soo i used the following code.. but it gives errors.. as invalid arguments in mkdir and touch and as well as copy function

can anyone help?
here is the code
while ($row = mysql_fetch_assoc($result1) )
 {

$hosting = explode(',', $row['host']);
$linking = explode(',', $row['links']);
$parts = explode(',', $row['link_no']);
$no_host = count($hosting); //miniusing the no of loops to make it accurate
$count_host = count($hosting);
$count_links = count($parts);
$current_k = 0;
$sum = 0;
$parts_href = '';
$new = null;
$updated_part = null;
for($i=0; $i<($count_host-1); $i++ )
{
$j = $i+1;
$hos = str_replace(":","",$hosting[$i]);
$path = "$base_folder/{$hos}";

          echo "<br />{$hos}";
echo "<br />{$path}";

mkdir($path);


for($k=$current_k; $k<($count_links); $k++)
{
for($f=0; $f<$parts[$current_k]; $f++ )
{
$for_touch = "$base_folder/{$hos}/".$linking[$sum].".php";
$for_touch = str_replace(" ","-",$for_touch);
touch("$for_touch");
$new_seo = "{$part_href}/{$hos}/".$linking[$sum].".php";
$new_seo = str_replace(" ","-",$new_seo);
    $new = "$new_seo";
  $updated_part = $updated_part.$new;
$updated_part = $updated_part.",";
//copy function
$old_file = "$for_touch";
$new_file = "{$part_page}/part".$sum.".php";
$new_file = str_replace(" ","-",$new_file);
$new_file = "$new_file";
copy($new_file,$old_file);
$sum++;

}
$query_href = 'update movies set href_parts = \''.$updated_part.'\'';
mysql_query($query_href) or die('COULD NOT EXECUTE THE QUERY FOR PARTS HREF');
echo "<br />{$updated_part}";
$sum = $sum;
$current_k = $current_k+1;
break;

}

}


PLEASE HELP ME!

Hi all.

I was looking for some tips on code optimization and came across a few resources.  However, I know nothing as of yet about code optimization so I'm not sure how legitimate these resources are.  Some confirmation would be very helpful along with any personal tips you may have.  Thanks in advance!
http://www.wmtips.com/php/tips-optimizing-php-code.htm
http://www.chazzuka.com/blog/?p=58(some redundancy from the first link is included here)


Some Questions I Thought Up (Warning: may be ridiculous questions):
1) Does excess white space (returns, space, tabs, etc.) in files affect performance for a large scale application (For an application that's ~500 files)?
2) Does directory structure affect performance (e.g. 3 directories deep versus 10 directories deep)?
Possibly more to come

I am trying to optimize my website for speed as much as possible. However it is heavily database driven. Are there any ways to speed up each page request?

Also I am closing each MySql connection after every page load. Here is my database class, is that a good idea?

<?php
//For changes, see: http://www.php.net/manual/en/mysqli.connect.php
class Database{
var $mysqli, $result, $q, $affectedRows;
function __construct($host, $user, $pass, $db){
$this->connect($host, $user, $pass, $db);
}
function connect($host, $user, $pass, $db){
$this->mysqli = new MySQLi($host, $user, $pass, $db);
if(mysqli_connect_error()){
//Add Line to error handling system here...
echo "Internal Site Error - Cannot Continue!";
exit;
}
}
function clean(){
$str = $this->q;
$str = @trim($str);
if(get_magic_quotes_gpc()){
$str = stripslashes($str);
}
$this->q = mysqli_real_escape_string($this->mysqli, $str);
}
function execute($query, $mode = MYSQLI_STORE_RESULT){
$this->q = $query;
$this->clean();
$result = $this->mysqli->query($query, $mode);
if(is_object($result) && $result instanceof MySQLi_Result){//if result is a object and is part of the mysqli class?
$this->result = $result;
$this->affectedRows = $this->result->num_rows;
}else
$this->affectedRows = $this->mysqli->affected_rows;
return $this;
}
function fetchRow(){
return $this->result->fetch_assoc();
}
function fetchAll(){
/*$row = $this->result->fetch_all($mode); 
 See manual for the mode under mysqli_result::fetch_all
//return !empty($row) ? $row : array();//if not empty return row, else return an array? */
$row = array();
while($f = $this->fetchRow()){
$row[] = $f;
}
return !empty($row) ? $row : array();
}
function numRows(){
return $this->affectedRows;
}
function delete($table, $where){
return $this->execute("DELETE FROM ".$table." WHERE ".$where);
}
function deleteAll($table){
return $this->execute("TRUNCATE ".$table);
}
function update($table, $set, $where){
return $this->execute("UPDATE ".$table." SET ".$set." WHERE ".$where);
}
function select($table, $select = "*", $where = NULL, $cap = ""){
if(is_null($where) || empty($where))
return $this->execute("SELECT ".$select." FROM ".$table." ".$cap);
else
return $this->execute("SELECT ".$select." FROM ".$table." WHERE ".$where." ".$cap);
}
function lastId(){
return $this->mysqli->insert_id;
}
function resetInc($table, $inc){
$this->execute("ALTER TABLE ".$table." AUTO_INCREMENT = ".$inc);
}
function error(){
return @mysqli_error($this->mysqli). " <strong><font color=\"red\">QUERY</font>: ".$this->q."</strong>";
}
function close(){
@mysqli_close($this->mysqli);
}
function __destruct(){
$this->close();
}
}
$db = new Database(DB_HOST, DB_USER, DB_PASS, DB_DB);
?>

Not sure what I am doing wrong:

Warning: mysql_fetch_assoc(): supplied argument is not a valid MySQL result resource in /public_html/lq/index.php on line 12


$schedule = "LQ";
include('/public_html/en/header_staff.php'); 
include("connect.php");

$page = $_SERVER["SERVER_NAME"];
$who = explode(".", $page);

$sql = "select * from rp_staff WHERE schedule = $schedule";
$rpstaff = mysql_query($sql);

while ($row = mysql_fetch_assoc($rpstaff)) {
$alt = $row['dj'];
$name = $row['name'];
$city = $row['city'];
$state = $row['state'];
$country = $row['country'];
$artists = $row['artists'];
$about = $row['about'];
$genre = $row['genrev'];
$position = $row['position'];
}

I am receiving this error:
Code: [Select]
Warning: mysql_fetch_assoc() expects parameter 1 to be resource, boolean given in /home/shannon/public_html/booter/inc/classes/class.db.php on line 17
For the function:
Code: [Select]
function fetch_array($query) {
    $array = mysql_fetch_assoc($query);
    return $array;
}

Why would I receive that error, if I am just passing a variable? Not a resource or boolean?

Thanks.