PHP - Filesize Function

I have this function completely written in my class file that I am working on.  The point to this function is to be able to check the login of a user or administrator for either of the control panels associated with my site.

It will check the session intime as well as the page / module referenced.  Once it passes all those checks, it will check and ensure the emailaddress/password stored in the current session still holds true and the account is still active...  if the account is still active it will update the lastActivity as well as update all of the session variables with what is currently in the database.

What I am looking for is basically a look at the function, see if it looks good..  If there is any part to it that could create security holes for the site just off the login function itself...

Usage: $q->validUser($_SESSION['user'], $_mod);

<?php
 function validUser($sess, $p) {

if ($sess['inTime'] == '' && $p != 'login' && $p != 'logout') {
session_destroy();
$login = '0';
$_int = '';
return $login;
} else if ($sess['inTime'] < time()-3600 && $p != 'login') {
$sess['inTime'] = '';
session_destroy();
$this->check_login($sess, $p);
} else {
$this->user = $sess['emailAddress'];
$this->pass = $sess['password'];

$login = $this->sql_query("SELECT * FROM users WHERE emailAddress = '".$this->user."' AND password = '".$this->pass."' 
   AND status = '1' LIMIT '1'");
if ($login = $this->sql_numrows($login) < 1) {
$sess['inTime'] == '';
session_destroy();
$login = '0';
} else {
// logged in, lets update the database for last_activity AND the session.

$this->sql_query("UDATE users SET lastActivity = '".now()."' WHERE
  emailAddress = '".$this->user."'");
$login = $this->sql_query("SELECT * FROM users WHERE emailAddress = '".$this->user."' AND password = '".$this->pass."' 
       AND status = '1' LIMIT '1'");
$login = mysql_fetch_assoc($login);
foreach ($login as $key => $value)
{ 
$sess[$key] = $value;
}
$sess['inTime'] = time();
$login = '1';
}
return $login;
}
}

?>

That is the main function, sql_query and sql_numrows is:

<?php
function sql_query($query = "", $transaction = FALSE) {
unset($this->query_result);

if ($query != "") {
$this->num_queries++;
if ($transation == BEGIN_TRANSACTION && !$this->in_transation) {
$result = mysql_query("BEGIN", $this->db_connect_id);
if (!$result) {
return false;
}
$this->in_transaction = TRUE;
}

$this->query_result = mysql_query($query, $this->db_connect_id);
} else {
if ($transaction == END_TRANSACTION && $this->in_transaction ) {
$result = mysql_query("COMMIT", $this->db_connect_id);
}
}
if ($this->query_result) {
unset($this->row[$this->query_result]);
unset($this->rowset[$this->query_result]);

if ($transaction == END_TRANSACTION && $this->in_transaction ) {
$this->in_transaction = FALSE;
if (!mysql_query("COMMIT", $this->db_connect_id)) {
mysql_query("ROLLBACK", $this->db_connect_id);
return false;
}
}
return $this->query_result;
} else {
if ($this->in_transaction ) {
mysql_query("ROLLBACK", $this->db_connect_id);
$this->in_transaction = FALSE;
}
return false;
}
}

function sql_numrows($query_id = 0) {
if(!$query_id) {
$query_id = $this->query_result;
}
return ($query_id) ? mysql_num_rows($query_id) : false;
} ?>

Any insight that can help to benefit these functions would be appreciated.

Question 1) Is the only and proper way to call a parent function "parent::function()"?  Are there other/better ways from within a child function?

Question 2) What are the deciding factors for when to make a function or attribute static?  How do you make that decision?  Assuming 5.3...

Thanks.

I need to call usort from a class function, and I'm puzzled about how to define the comparison function.

I've tried to define the comparison function in the same class, but I can't get usort to call it. I found one hint that it will work if I make the comparison function static, but I tried that, and it didn't work for me.

If I define the comparison function outside the class, it won't have access to object properties that it needs to operate.

The only solution I can think of is to define the comparison function outside the class and put the object properties it needs in globals. Is there a cleaner way to do this?

I want to define a function instead of repeating query in all my php pages. I call a function by passing an $id value and from that function i have to get all the info related to that id, like name, description and uom.    I am trying to do this, but i dont know how to get these values seperately.   here is my function  

function items($item_id)
{
$details = array(); 
$result = mysql_query("select item_id, name, uom, description from items where item_id=".$item_id."") or die (mysql_error());
while($row = mysql_fetch_array($result))
{
$details[] = array((stripslashes($row['name'])), (stripslashes($row['uom'])), (stripslashes($row['description'])));
}
return $details;
}

and i call my function like this

$info = items($id);

Can somebody guide me in this    

When I put this chunk of code into it's own function:


function fetch_all ($dbc, $query) {

include ('knuffix_list_func.php');

pagination_start ($dbc, $query);

$offset = $pag_array[0];

$rows_per_page = $pag_array[1];

$query = $query . " LIMIT $offset, $rows_per_page";

echo "test query: " . $query;

knuffix_list ($query, $dbc);

pagination_end ($pag_array);
}


And when I echo out the query as you can see in the example, then I notice that the variables $offset and $rows_per_page never get appended.
I set the variable $pag_array to a global inside the function pagination_start(). It usually works when I DON'T wrap a function around this chunk of code, but if I do wrap a function around everything then the global suddenly won't work anymore.

Btw, this also won't work if I wrap a function around the function DECLARATIONS.

Any ideas, how I could make it work?

I've followed the PHP Freaks pagination tutorial which you can find here.

And I also got it to work, the only problem is that the script won't work when I use the query outside of the function.

Here's the function:



<?php 
function knuffix_list ($query, $dbc) {

// find out how many rows are in the table:
$query_row = "SELECT COUNT(*) FROM con";
$query_run = mysqli_query ($dbc, $query_row);
$row = mysqli_fetch_row($query_run);
$num_rows = $row[0];

// number of rows to show per page
$rows_per_page = 5;

// find total pages -> ceil for rounding up
$total_pages = ceil($num_rows / $rows_per_page);

// get the current page or set a default
if (isset($_GET['current_page']) && is_numeric($_GET['current_page'])) {

// make it an INT if it isn't

$current_page = (int) $_GET['current_page'];

} else {

// default page number

$current_page = 1;

}


// if current page is greater than total pages then set current page to last page
if ($current_page > $total_pages) {

$current_page = $total_pages;

}

// if current page is less than first page then set current page to first page
if ($current_page < 1) {

$current_page = 1;

}

// the offset of the list, based on current page
$offset = (($current_page - 1) * $rows_per_page);

echo "test " . $query;

// SCRIPT ONLY WORKS IF I INSERT QUERY HERE

$query

= "SELECT * FROM con, user WHERE con.user_id = user.user_id ORDER BY contributed_date DESC LIMIT $offset, $rows_per_page";

$data = mysqli_query ($dbc, $query) or die (mysqli_error ($dbc));

// Loop through the array of data

while ($row = mysqli_fetch_array ($data)) {

global $array;

// Variables for the table

$con_id = $row['con_id'];

$likes_count = $row['likes'];

$dislikes_count = $row['dislikes'];

$dbuser_name = $row['nickname'];

$dbuser_avatar = $row['avatar'];

$user_id = $row['user_id'];

// The TABLE

echo "<table padding='0' margin='0' class='knuffixTable'>";

echo "<tr><td width='65px' height='64px' class='avatar_bg' rowspan='2' colpan='2'><img src='avatar/$dbuser_avatar' alt='avatar' /></td>";

echo "<td class='knuffix_username'><strong><a href='profile.php?user=$dbuser_name' title='Profile of $dbuser_name'>" . $dbuser_name . "</a> ___ " . $user_id . "____ <form action='' method='POST'><button type='submit' name='favorite' value='fav'>Favorite</button></form>";

echo "</strong><br />" . $row['category'] .  " | " . date('M d, Y', strtotime($row['contributed_date'])) . "</td></tr><tr><td>";

echo "<form action='' method='post'>

<button class='LikeButton' type='submit' name='likes' value='+1'>Likes</button>

<button class='DislikeButton' type='submit' name='dislikes' value='-1'>Dislikes</button>

<input type='hidden' name='hidden_con_id' value='" . $con_id . "' />

</form></td><td class='votes'>Y[" . $likes_count . "] | N[" . $dislikes_count . "]</td></tr>";

echo "<tr><td class='knuffix_name' colspan='3'><strong>" . htmlentities($row['name']) . "</strong><br /></td></tr>";

echo "<tr><td colspan='2' class='knuffix_contribution'><pre>" . $row['contribution'] . "</pre><br /></td></tr>";

echo "</table>";

// POST BUTTONS inside the table

$likes = $_POST['likes'];

$dislikes = $_POST['dislikes'];

$con_id = $_POST['hidden_con_id'];

$favorite = $_POST['favorite'];

$array = array ($likes, $dislikes, $con_id, $user_id, $favorite);

}

/********* build the pagination links *********/

// BACKWARD
// if not on page 1, show back links and show << link to go back to the very first page
if ($current_page > 1) {

echo " <a href='{$_SERVER['PHP_SELF']}?current_page=1'><<</a> ";

// get previous page number and show < link to go to previous

$prev_page = $current_page - 1;
 

echo " <a href='{$_SERVER['PHP_SELF']}?current_page=$prev_page'><</a> ";

}

// CURRENT
// range of number of links to show
$range = 3;

// loop to show links in the range of pages around current page
for ($x = ($current_page - $range); $x < (($current_page + $range) + 1); $x++) {

// if it's a valid page number...

if (($x > 0) && ($x <= $total_pages)) {

// if we're on current page

if ($x == $current_page) {

// highlight it but don't make a link out of it

echo "[<b>$x</b>]";

// if it's not the current page then make it a link

} else {

echo "<a href='{$_SERVER['PHP_SELF']}?current_page=$x'>$x</a>";

}

}
}


// FORWARD
// if not on the last page, show forward and last page links
if ($current_page != $total_pages) {

// get next page

$next_page = $current_page + 1;

// echo forward link for next page

echo " <a href='{$_SERVER['PHP_SELF']}?current_page=$next_page'>></a> ";

// echo forward link for last page

echo " <a href='{$_SERVER['PHP_SELF']}?current_page=$total_pages'>>></a> ";

}

/***** end building pagination links ****/

mysqli_close($dbc);

}

?>


As you can see above, the script will only work if I put the query right below the $offset variable and above the $data variable.

I put the test echo above the query to see how the query looks like when I induce the query from the outside through the function parenthesis into the function, and this is what I get printed out:


test SELECT * FROM con, user WHERE con.user_id = user.user_id ORDER BY contributed_date DESC LIMIT ,


Obviously the $offset and the $rows_per_page variables are not set, when I induce the query from the outside into the function.

So in that sense my question is:

How can I induce the query from the outside into the function SO THAT the $offset and the $rows_per_page variables are set as well and NOT empty?


p.s.

I need the query outside of the function because I'm using a sort by category functionality.

im using a function which connects to a db called 'comments' and then inside that function i again called another function that will connect to the db 'main' to get avatars.... but as i put Code: [Select]
mysql_select_db("main") or die(mysql_error()); on the new function, the original function stops to fetch rows.

i tried to remove "mysql_select_db("main") or die(mysql_error());" and used the new function to return some text only and it worked, so i guess the connection to the db was the problem... i tried doing Code: [Select]
mysql_query("SELECT * FROM  main.avatar
INNER JOIN main.list ON main.avatar.title=main.list.id
WHERE main.avatar.page_id='$id'"); but it also didnt work

Hi I have a table class and functions I want to call in another function but can't get it working. Some help will be very welcome.

It seesm that the new table class is not working in this function if I pass the values to it, I have tested the class, it does get the post values I post to it so $_POST['id'] are being received as well as all the other $_POST's but the table class and find function is not working, it works fine if I don't put it in a function..

function edit() {
   
   if (isset($error)){ $error.="Please fix the error(s) above";}
   else {

      if ($_POST['id'] <> "") { 
                   
         $update =& new table($db, 'publisher');

         $update->find($_POST['id']);
         $update->name       = $_POST['name'];
         $update->url        = $_POST['url'];
         $update->contact    = $_POST['contact'];
         $update->address    = $_POST['address'];
         $update->phone        = $_POST['phone'];
         $update->email        = $_POST['email'];
         $update->save();

         $error = "The Publisher has been edited";   
                }
   }
  }

Hi all, I want to call a javascript function from a php function like this:

        public function Buscar()
        {
            $HoraInicio = $_POST['edtHoraInicio'];
            $HoraFin = $_POST['edtHoraFin'];
            $FechaInicio = $_POST['edtFec1'];
            $FechaFin = $_POST['edtFec2'];

            $FechaMax = $FechaFin." ".$HoraFin.":00";
            $FechaMin = $FechaInicio." ".$HoraInicio.":00";

            $_GET["FechaMax"] = $FechaMax;
            $_GET["FechaMin"] = $FechaMin;

            echo $FechaMin;

            echo "<script language=javascript>alert('Hi.')</script>";
           
        }

but the function Buscar never show the alert but shows the $FechaMin

I hopu u guys can help me out with this probem

Thanks,

Siddhartha

window.setInterval(function(){

s="<?= $lastid ?>";

$.post('../action/updatestream.php',{statusid:s.val()},function(e){
 
alert(e)

 });


}, 10000);

Why isn't it working?

Thanks,  

can you do that with php?

Code: [Select]
Database2() {
function test($id) {

$newdb = new Database2();
$newdb->test($id);


}
}

Hello Everyone

I have written a simple mail function to be emailed to a certain person on submission.  On submission they would also like to have attachments sent to them.

I got the email being sent but I can;t get the attachments to work. I have read several different examples and tutorials and none of them work.

This is my code so far without any code for file attachment

<?php

$project_name = $_POST['project_name'];
$needed = $_POST['date_needed'];
$submitted = $_POST['date_submitted'];
$department = $_POST['department'];
$contact = $_POST['contact_person'];
$extension = $_POST['extension'];
$project_type = $_POST['project_type'];
$published = $_POST['date_last_published'];
$description = $_POST['description'];
$color = $_POST['color'];
$pdf = $_POST['pdf_needed'];
$web = $_POST['web_needed'];
$quanity = $_POST['quanity'];

$email = "mdmartiny@sc4.edu";  
$subject = "SC4 Graphics Design Service Request Form";  

$headers .= "MIME-Version: 1.0\r\n";  
$headers .= "Content-Type: text/html; charset=ISO-8859-1\r\n";

$message = "<html><body>
<table width=\"100%\" border=\"0\" cellspacing=\"5px\" >
<tr><td></td>
<td>Project name: $project_name</td>
<td></td>
<td>Date needed by: $needed</td>
</tr>
<tr>
<tr>
<td></td>
<td colspan=\"3\" align=\"left\" valign=\"top\"><strong><font size=\"+1\">Submitted to graphic designer</font></strong></td></tr>
<tr><td height=\"25\"></td><td>Date $submitted</td><td>Department $department</td><td></td></tr>
<tr><td height=\"25\"></td><td>Contact Person $contact</td><td>Extension $extension</td><td></tr>
<tr><td height=\"25\"></td><td>Type of project $project_type</td><td colspan=\"2\">Approximate date of last publication $published</td></tr>
<tr><td height=\"25\"></td><td colspan=\"3\">Project description/special instructions</td>
<tr><td></td>><td colspan=\"3\">$description</td></tr>
<tr><td height=\"25\"></td><td>Color $color</td><td>PDF needed $pdf</td><td>Website update needed $web</td></tr>
<tr><td ></td><td>Estimated print quanity $quanity</td><td></td><td></td></tr>
<tr>
    <td colspan=\"4\" align=\"left\" valign=\"top\"><hr height=\"5\"/>

<strong><font size=\"+1\">Graphics office use only</font></strong></td>
  </tr>
  <tr>
    <td height=\"25\" width=\"2%\">&nbsp;</td>
    <td width=\"34%\">Print Shop&nbsp;&nbsp;&nbsp;&nbsp;Color copier</td>
    <td colspan=\"2\">Print Vendor_______________________________________</td>
  </tr>
  <tr>
    <td height=\"25\">&nbsp;</td>
    <td><strong><font size=\"+1\">Project tracking</font></strong></td>
    <td>&nbsp;</td>
    <td>&nbsp;</td>
  </tr>
  <tr>
    <td height=\"25\">&nbsp;</td>
    <td colspan=\"3\">Received by graphic designer_______________________ &nbsp;&nbsp;Date _______</td>
  </tr>
  <tr>
    <td height=\"25\">&nbsp;</td>
    <td colspan=\"3\">

  <table width=\"100%\" height=\"35\">
  <tr>
  <td>Approved by executive director__________ &nbsp;&nbsp;Date_________</td><td><input type=\"checkbox\">
      Revisions needed<br /><input type=\"checkbox\"> 
      Revisions made ______ &nbsp;&nbsp;Date_______</td><tr>

  </table>

  </td>
  </tr>
  <tr>
    <td height=\"25\">&nbsp;</td>
    <td colspan=\"3\">Completed and spell checked by graphic designer___________________________&nbsp;&nbsp;Date__________</td>

  </tr>
  <tr>
    <td>&nbsp;</td>
    <td align=\"center\" colspan=\"3\">
    <table cellpadding=\"10px\" cellspacing=\"0\" border=\"1\" width=\"100%\">
    <tr bgcolor=\"#CCCCCC\">
    <td>

<table>

<tr>

<td>
    Proofread by marketing coordinator __________&nbsp;&nbsp; Date__________</td>

</tr>

<tr>

<td>
    Proofread by secretary __________&nbsp;&nbsp; Date__________ 

</td>

</tr>

</table>
    </td>
    <td>
    <input type=\"checkbox\">
Revisions needed&nbsp;&nbsp;
<br>
<input type=\"checkbox\">
Revisions made ____ &nbsp;&nbsp;Date_____
    </td>
    </tr>
    </table></td>
  </tr>
  <tr>
  <td></td>
  <td colspan=\"3\">
  <table width=\"100%\" height=\"75\">
  <tr>
  <td>Proofread by executive director______ Date______ </td><td><input type=\"checkbox\">
      Revisions needed<br />

  <input type=\"checkbox\"> Revisions made ______ &nbsp;&nbsp;Date_______</td>
  </tr>
  </table>

  </td>
  </tr>
  <tr>
  <td></td>
  <td colspan=\"3\">
  <table width=\"100%\" height=\"75\">
  <tr>
  <td>
  Approval by requesting department __________ Date_________ <br />
  &nbsp;&nbsp; <strong><font size=\"-1\">(Include all paperwork when returning)</font></strong></td><td><input type=\"checkbox\">
      Revisions needed<br /><input type=\"checkbox\"> 
      Revisions made ______ &nbsp;&nbsp;Date_______</td>
  </tr>
  </table>
  </td>
  </tr>
  <td></td height=\"25\">
  <td colspan=\"3\">Final approval by executive director _________________________________________ Date_________ </td>
  </tr>
  <tr>
  <td height=\"75\"></td>
  <td><input type=\"checkbox\"> Printed ____ Date _____</td>
  <td colspan=\"2\"><input type=\"checkbox\"> PDF created _____ Date _____<br />
<input type=\"checkbox\"> Website updated _____ Date _____</td>
  </tr>
</table>";

$message .= "</body></html>";

mail($email, $subject, $message, $headers, "From: $email");  

echo "The email has been sent.";  

?> 

How can I call a public function inside of another public function?  The get_primary_edge() says it's undefined, but it's just another public function in the class so shouldn't this work?

Code: [Select]
public function get_dynamic_edge($uid)
{
$uid = (int)$uid;

$sql = "(
SELECT
`users`.`id`
FROM partners
INNER JOIN `users`
ON `partners`.`user_id` = `users`.`id`
WHERE partners.friend_id = '${uid}'
AND `approved` = 1
)
UNION ALL
(
SELECT
`users`.`id`
FROM `partners`
INNER JOIN `users`
ON `partners`.`friend_id` = `users`.`id`
WHERE `partners`.`user_id` = '${uid}'
AND `approved` = 1
)";

$result = mysql_query($sql) or die(mysql_error());

$i = 0;

while (($row = mysql_fetch_assoc($result)) !== false)
{
$dynamic[$i] = array(
'uid' => $row['id'],
'score' => get_primary_edge($row['id']),
);

$i++;
}

print_array($dynamic);
}

I created a PHP function on my website to recognize if the user is a normal, banned, pro, top player or an admin. But whenever the function goes around a username it always moves the username to the front of the loop from where it originally was.


Notice where the username is...

Now see where it is now?

Well here is the function script..
<?php
function username($username){
$staff = "SELECT * FROM users WHERE usergroup = 'Staff' AND username = '".$username."'";
if( mysql_num_rows( mysql_query( $staff ) ) == 1 ){
echo "<span class='staff'>".$username."</span>";
}

$pro = "SELECT * FROM users WHERE usergroup = 'Pro' AND username = '".$username."'";
if( mysql_num_rows( mysql_query( $pro ) ) == 1 ){
echo "<span>".$username."</span>";
} 

    $topplayer = "SELECT * FROM users ORDER BY points DESC LIMIT 1";
$result3 = mysql_query($topplayer);
while($row = mysql_fetch_array($result3)){
if($username==$row['username']){
echo "<span>".$username."</span>";
} else {
$else = "SELECT * FROM users WHERE banned != 'yes' AND username = '".$username."' AND usergroup != 'Staff' AND usergroup != 'Pro'";
if( mysql_num_rows( mysql_query( $else ) ) == 1 ){
echo "<span>".$username."</span>";
} } }

$banned = "SELECT * FROM users WHERE banned = 'yes' AND username = '".$username."'";
if( mysql_num_rows( mysql_query( $banned ) ) == 1 ){
echo "<span>".$username."</span>";
}  

}
?>

Any help is appreciated!

Hi,

Here is a part of my code to generate a URL to output to some table headers.

Code: [Select]
$URL = "order_sheet.php?sortby=orders_id&fromdate=" . $fromdate . "&todate=" . $todate . "&sortorder=" . $newsortorder;
On each heading, I need to do something like this: $URL['orders_id'], $URL['customer_name'], etc to decide on which "sortby" to use.

I know I could make multiple varibles for each headding, but thats the lazy way and I need to learn!

Thanks