PHP - Header Location Using If-not Working

Hi Everyone,

I'm having a bit of a problem if someone could help me with?

I have a simple registration form with fields userid, username, password, clientaddress

So when the user logs in with their username and password it will redirect to their client address but I cant get the redirect working. Here is my code:

Code: [Select]
$clientaddress = trim($_POST['clientaddress']);

$_SESSION['start'] = time();
 header("Location:$clientaddress"); 
 exit;
}

also note if I add:

Code: [Select]
$clientaddress = 'http://www.google.com';

it redirects ok to google. It's getting the field from the database I think thats the problem

Can somone help it just wont redirect to the client address

Hello everyone.

I want to use php to obtain the 'location' value from a header of a url.
However, when I use get_headers() it automatically follows the redirect and gives me the header information of the new page.
I don't want this, I need the headers of the original page. (I need the value of the 'location' variable in the header).

Hope you can help me out.

Hi,
Im new to all this coding stuff but get by ok with help from the wealth of info on the internet however in this instance i cant solve a PHP redirect issue im having.
Ive got a very simple php script to redirect to a secure paypal item link using the header function.

header("Location:https://www.paypal.com/cgi-bin/webscr?cmd=_s-xclick&hosted_button_id=XYX96W3MSFQZ6");

The problem is when the script is called upon in IE it loops endlessly however works perfectly in Chrome, Firefox, Opera and the Andriod stock browser.
I originally tried the redirect directly within the meta tag although this failed on all browsers so now i have the meta tag point to this PHP file. (The meta tag is in a script that submits form data and displays a temporary 'redirecting...' page.

Has anyone expirenced this problem before or know of ways to fix it for IE? Could it be an issue with security in IE because the paypal link is secure?
Any help would be greatly appreciated.

I want the page to refresh on with the query string, but this isn't working for me...

Code: [Select]
header("Location: " . $_SERVER['php_self'] . "?" . $_SERVER['query_string'] );

I'm trying to rewrite the old jpmaster77 login script that I used back in the day quite extensively, but I'm having problems getting the $form->error messages to the correct page.   Login form, on the index.php:

          <div>
            <h3>Login</h3>
            <form method="post" action="process.php" id="sublogin">

                  /* error message should be displayed here when username is empty or == username */
                  <p>
                  <?php
                  echo $form->error("user");
                  ?>

                  <input class="loginside" type="text" name="user" value="username" /> ?> <br />
                  <input class="loginside" type="password" name="pass" value="password" /> <br />
                  <input type="hidden" name="sublogin" value="1">
                  <input type="checkbox" name="remember">Remember me <br />
                  <input class="sublogin" type="submit" value="login" style="border: 0; margin: 5px 0 0 1px;" />
              </p>
            </form>
            Not registered yet? Sign up here!
          </div>

process.php

class Process
{
   /* Class constructor */
   function Process(){
      global $session;
      /* User submitted login form */
      if(isset($_POST['sublogin'])){
      	      	
      	      	
				$this->procLogin();
        
      }

      /**
       * Should not get here, which means user is viewing this page
       * by mistake and therefore is redirected.
       */
       else{
          header("Location: index.php");
       }
   }
   
   function procLogin(){
   
      global $session, $form;
      /* Login attempt */
      $_POST = $session->cleanInput($_POST);
      $retval = $session->login($_POST['user'], $_POST['pass'], isset($_POST['remember']));
      
		if($retval){
			header("Location: correct.php");
		}
		else{
		$_SESSION['value_array'] = $_POST;
                $_SESSION['error_array'] = $form->getErrorArray();
                header("Location: index.php");
		}

                /* if instead the $_SESSION and header I enter echo $form->error("user")
                   then the error message is displayed in process.php, and not in index.php
                */
   }

   
 }
 
$process = new Process;

?>

But when instead the $_SESSION and the header location I enter here echo $form->error("user"); then all is fine. But the error message should not be displayed in the process.php, but rather above the login form on the index.php



session.php
 

<?php

include "database.php";
include "form.php";

class Session

{
		var $time;
		
		function Session(){
			
			$this->time = time();
			$this->startSession();
			
		}
		
		function startSession(){
			
			$session_name = 'sec_session_id';   // Set a custom session name
	    $secure = true;
	    
	    // This stops JavaScript being able to access the session id.
	    $httponly = true;
	    
	    // Forces sessions to only use cookies.
	    if (ini_set('session.use_only_cookies', 1) === FALSE) {
	        header("Location: ../error.php?err=Could not initiate a safe session (ini_set)");
	        exit();
	    }
	    
	    // Gets current cookies params.
	    $cookieParams = session_get_cookie_params();
	    session_set_cookie_params($cookieParams["lifetime"],
	    $cookieParams["path"], 
	    $cookieParams["domain"], 
	    $secure,
	    $httponly);
	        
	    // Sets the session name to the one set above.
	    session_name($session_name);
	    session_start();           		 	// Start the PHP session 
	    session_regenerate_id(true);    // regenerated the session, delete the old one. 
		}		
		

		function login($subuser, $subpass, $subremember)
		{
			global $database, $form;
				
			/* username check */
			$field = "user";
			if(!$subuser || $subuser == "username")
			{
            $form->setError($field, "* Username incorrect");
			}

			/* password check */
			
			/* if e-mail welcome, check if user activated account */
      	
     	/* Return if form errors exist */
      if($form->num_errors > 0){
         return false;
      }	
      
      return true;
      
		}

		
		function cleanInput($post = array()) {
       foreach($post as $k => $v){
            $post[$k] = trim(htmlspecialchars($v));
         }
         
         return $post;
   	}
			
};

$session = new Session;
$form = new Form;

?>

form.php
 

<?php 
/**
 * Form.php
 *
 * The Form class is meant to simplify the task of keeping
 * track of errors in user submitted forms and the form
 * field values that were entered correctly.
 *
 * Written by: Jpmaster77 a.k.a. The Grandmaster of C++ (GMC)
 * Last Updated: August 19, 2004
 */
 
class Form
{
   var $values = array();  //Holds submitted form field values
   var $errors = array();  //Holds submitted form error messages
   var $num_errors;   //The number of errors in submitted form

   /* Class constructor */
   function Form(){
      /**
       * Get form value and error arrays, used when there
       * is an error with a user-submitted form.
       */
      if(isset($_SESSION['value_array']) && isset($_SESSION['error_array'])){
         $this->values = $_SESSION['value_array'];
         $this->errors = $_SESSION['error_array'];
         $this->num_errors = count($this->errors);

         unset($_SESSION['value_array']);
         unset($_SESSION['error_array']);
      }
      else{
         $this->num_errors = 0;
      }
   }

   /**
    * setValue - Records the value typed into the given
    * form field by the user.
    */
   function setValue($field, $value){
      $this->values[$field] = $value;
   }

   /**
    * setError - Records new form error given the form
    * field name and the error message attached to it.
    */
   function setError($field, $errmsg){
      $this->errors[$field] = $errmsg;
      $this->num_errors = count($this->errors);
   }

   /**
    * value - Returns the value attached to the given
    * field, if none exists, the empty string is returned.
    */
   function value($field){
      if(array_key_exists($field,$this->values)){
         return htmlspecialchars(stripslashes($this->values[$field]));
      }else{
         return "";
      }
   }

   /**
    * error - Returns the error message attached to the
    * given field, if none exists, the empty string is returned.
    */
   function error($field){
      if(array_key_exists($field,$this->errors)){
         return "<font size=\"2\" color=\"#ff0000\">".$this->errors[$field]."</font>";
      }else{
         return "";
      }
   }

   /* getErrorArray - Returns the array of error messages */
   function getErrorArray(){
      return $this->errors;
   }
};
 
?>

Does anyone know why the $form->error("user") variable cannot be transfered to the index.php? Is something wrong with the session_start or something?

thanks in advance guys!
Edited by dde, 07 January 2015 - 03:49 PM.

Hi,

I have a div which reloads every 10 seconds but I want it so that if it equals something then redirect the whole page when at the moment it just loads the whole page in in the div but need the div as it stores all my variables, anyone know of anything else I can use?

Thanks

I'm using jQuery ajax for my login script. However my linked php file with ajax doesn't change the screen with header('location') whats a way to change the page on login using ajax?

Thanks

So I have a site in which a user logs in. When they click the submit button on the login page, it checks to see if a username and password combo exists in an array. If it doesn't exist, the user is supposed to be redirected back to the login page.   This code USED to work, and I think I added one thing completely away from the code that should do any of this, but now it doesn't work any more.   I've read that you can't have anything output before the header code, so I've double checked, and can't find any spaces, echo statements or anything of the like. I've thrown in a random echo statement to see if my if's else's were being entered correctly, and they are. I definitely get into the else statement with the header(location: blah) code when an incorrect username/password is used...   Here's the code I'm looking at. (And there is More HTML under this...)

<?php session_start();?>

<?php
include("passwords.php");

//this statement will be entered if coming from the login.php page.
if ($_POST["ac"]=="log"){

	//check if submitted username and password exist in $PASSWORD array
	if ($PASSWORD[$_POST["username"]]==$_POST["password"]){
	
		//set various session variables
		$_SESSION["username"]=$_POST["username"];
		$_SESSION["firstname"]=$FIRSTNAME[$_POST["username"]];
		$_SESSION["lastname"]=$LASTNAME[$_POST["username"]];
		$_SESSION["email"]=$EMAIL[$_POST["username"]];
	}
	else{

	//if username and password do not exist, set session variable for "incorrect username/password" message and redirect to login.php
		$_SESSION['incorrect'] = "incorrect";
		header('Location: login.php');
	};
};

// check if user is logged in already when they are coming from a random place. If not, redirect to login.php
check_logged();
?>

Any ideas out there why my header('Location: login.php'); line is not working?

I have a form, where I'm collecting registration info - like name, address, email, password. I'm calling another php file at server side code, where it will check whether the email exists or not. Pretty simple, just receiving those post variables and check with the database.

The issue, if I find a match, I want to go back to the registration.php page, using the following code:

if ($email_already_use == "y") {
      $_SESSION['ERROR'] = "Error";
      $_SESSION['MESSAGE'] = "This email address already used. Please try another";
      header("location: ".$settings['site_url']."registration.php");
      exit;
}

Now, I would like to place the user input at the registration.php file, but I do not want to use pass variable at URL like this:

header("location: ".$settings['site_url']."registration.php?".name=$name&address=$address&email=$email;

Is there anyway, I can retrieve those variables at registration.php, without specifying .name=$name&address=$address&email=$email ?

Thanks for your help. I see some sites has similar implementation, but did not find anything like how to do it.

Hi..

I have query for insert then I just want to add condition that after it save it will locate on the previous page:

here is my code:

Code: [Select]
$sql = "INSERT INTO receiving_materials
    (sr_date, sr_number, si_num, s_name, po_num, qty, mat_code, mat_desc, wh_code, bin_loc)
    VALUES
    ('$sr_date', '$sr_number', '$si_num', '$s_name', '$po_num', '$qty', '$mat_code', '$mat_desc', '$wh_code', '$bin_loc')
    ON DUPLICATE KEY UPDATE
    sr_date = '$sr_date', sr_number = '$sr_number', si_num = '$si_num', s_name = '$s_name', po_num = '$po_num',
    qty = '$qty', mat_code = '$mat_code', mat_desc = '$mat_desc', wh_code = 'wh_code', bin_loc = '$bin_loc'";
    $res_receiving = mysql_query($sql, $con) or die(mysql_error());

Thank you

For SEO purposes I am told that either 301/302 redirects are better.

I use header("Location: $url everywhere, is this 301 or 302 ?

Also, I see somewhere that this is the proper way to do it.
Code: [Select]
header ('HTTP/1.1 301 Moved Permanently');
header ('Location: '.$location);
.. what if I didn't use the first line (I have sites all over the place littered with header Location, but have only used the 2nd line)? Would it make a difference - it works that's for sure.

I have this working script below. I never managed to turn it into a function...  I think it's because there's classes in it. 

 

I stopped that investigation and instead I choose to:- keep it on another page, trigger it with the a <form> button, then return to the form page using header location.

This is probably much more elaborate than it needs to be... but it seems to be working fine. 

 

I'd like to print out "email sent" if successful. The collection of confusion at the end of this script, is me trying to get it to return the - "email sent" message

<index.php>

<?php

require 'includes/PHPMailer.php';
require 'includes/SMTP.php';
require 'includes/Exception.php';

use PHPMailer\PHPMailer\PHPMailer;
use PHPMailer\PHPMailer\SMTP;
use PHPMailer\PHPMailer\Exception;

$mail = new PHPMailer();

$mail->isSMTP();

$mail->Host = "smtp.gmail.com";

$mail->SMTPAuth = "true";

$mail->SMTPSecure = "tls";

$mail->Port = "587";

$mail->Username = "email@gmail.com";

$mail->Password = "pass";

$mail->Subject = "Test email using PhPmailer";

$mail->setFrom("email@gmail.com");

$mail->isHTML(true);

//$mail->addAttachment('img/movie.mp4');

$mail->Body = "<h1>This is a HTML heading</h1></br><p>This is a html title</p>";

$mail->addAddress("email@gmail.com");

if ($mail->Send() ) {
	echo "Email sent..!";	
}
else{
	echo "Error..!";
}

$mail->smtpClose();

ob_start();
$Message = urlencode("Email Sent");
header("Location:EmailBut.html?Message=".$Message);
die;
ob_flush();
?>

The stuff at the beginning of this next script is me trying to get it to print out email sent. 

I can get it to return the message in the URL but it won't print out. 

<EmailBut.html>

<?php
ob_start();
if(isset($_GET['Message'])){
    echo $_GET['Message'];
}

echo $_GET['Message'];
ob_flush();
?>

<html>
<body>
<form action="index.php" method="POST">
<button type="submit">Send</button>
</form>
</body>
</html>

Can you please give me a push in the right direct here? 

Edited January 30, 2020 by JonnyDriller

Hi:

Does this header redirection:
Code: [Select]
header("Location: http://www.WebSite.com/Page.php");

Happen on the server, and then get sent to the browser, or is it something that happens on the users computer?

I was hoping someone could help me figure out why my
  Code: [Select]
header('Location: .');works right on my localhost testing computer but not when I load it onto the actual server.

Here are the two files in question.  The first is a snippet from my index.php controller file.
Code: [Select]
if (isset($_POST['action']) and $_POST['action'] == 'Edit')
{
include '../../includes/db.inc.php';
  {
$id = mysqli_real_escape_string($link, $_POST['id']);
$sql = "Select * from s_times where id = '$id'";
$result = mysqli_query($link, $sql);
if (!$result)
{
$error = 'Error fetching service time details ' . mysqli_error($link);
include '../../includes/error.php';
exit();
}

$row = mysqli_fetch_array($result);
$pagetitle = 'Edit Category';
$action = 'editform';
$id =  $row['id'];
$day = $row['day'];
$time =  $row['time'];
$event =  $row['event'];
$avail =  $row['avail'];
$orderby = $row['orderby'];
$button = 'Update';

 }
include 'stimes_modify.php';
exit();
}

if (isset($_GET['editform']))
{
include '../../includes/db.inc.php';

$id = mysqli_real_escape_string($link, $_POST['id']);
$day = mysqli_real_escape_string($link, $_POST['day']);
$time = mysqli_real_escape_string($link, $_POST['time']);
$event = mysqli_real_escape_string($link, $_POST['event']);
$avail = mysqli_real_escape_string($link, $_POST['available']);
$orderby = mysqli_real_escape_string($link, $_POST['orderby']);
$sql = "Update s_times set
day = '$day',
time = '$time',
event = '$event',
avail = '$avail',
orderby = '$orderby'
where id = '$id'";
if (!mysqli_query($link, $sql))
{
$error = 'Error updating service times ' . mysqli_error($link);
include '../../includes/error.php';
exit();
}

header('Location: .');
exit();
}


here is the stimes_modify.php file code
Code: [Select]
if (isset($_POST['action']) and $_POST['action'] == 'Edit')
{
include '../../includes/db.inc.php';
  {
$id = mysqli_real_escape_string($link, $_POST['id']);
$sql = "Select * from s_times where id = '$id'";
$result = mysqli_query($link, $sql);
if (!$result)
{
$error = 'Error fetching service time details ' . mysqli_error($link);
include '../../includes/error.php';
exit();
}

$row = mysqli_fetch_array($result);
$pagetitle = 'Edit Category';
$action = 'editform';
$id =  $row['id'];
$day = $row['day'];
$time =  $row['time'];
$event =  $row['event'];
$avail =  $row['avail'];
$orderby = $row['orderby'];
$button = 'Update';

 }
include 'stimes_modify.php';
exit();
}

if (isset($_GET['editform']))
{
include '../../includes/db.inc.php';

$id = mysqli_real_escape_string($link, $_POST['id']);
$day = mysqli_real_escape_string($link, $_POST['day']);
$time = mysqli_real_escape_string($link, $_POST['time']);
$event = mysqli_real_escape_string($link, $_POST['event']);
$avail = mysqli_real_escape_string($link, $_POST['available']);
$orderby = mysqli_real_escape_string($link, $_POST['orderby']);
$sql = "Update s_times set
day = '$day',
time = '$time',
event = '$event',
avail = '$avail',
orderby = '$orderby'
where id = '$id'";
if (!mysqli_query($link, $sql))
{
$error = 'Error updating service times ' . mysqli_error($link);
include '../../includes/error.php';
exit();
}

header('Location: .');
exit();
}


The functionality of both pages seems to be working in relation to editing the database but the page will not redirect back to the main page when it gets back down to the header line.  Like I said it works on localhost just not on actual server.  I also tried putting in the full URL like this
Code: [Select]
header('Location: http://www.bbcpa.org/dbsite/admin/stimes/stimes/php');and still got a blank page.

The URL in the address bar shows this
http://www.bbcpa.org/dbsite/admin/stimes/?editform
it should show this
http://www.bbcpa.org/dbsite/admin/stimes/
so maybe something is wrong with this line in stimes_modify.php
Code: [Select]
<form action="?<?php htmlout($action); ?>" method="POST">
anyway any help would be greatly appreciated.
Thanks

My Error Output is this:
Warning: Cannot modify header information - headers already sent by (output started at city-search.php:1) in city-search.php on line 65

What I'm I missing in the code, I can't seem to get these. It works excellent in Localhost, but in production. Error above.
Code: [Select]
<?php
// MG CREATED THIS SIMPLE REGISTRATION PHP FOR THAT GOES TO ONE SPECIFIC USER.
// WILL TEST FORM REGSITRATION NG 07-2011
//If the form is submitted
if(isset($_POST['submit'])) {

//Check to make sure that the name field is not empty
if(trim($_POST['name']) == '') {
$hasError = true;
} else {
$name = trim($_POST['name']);
}

//Check to make sure that the subject field is not empty
if(trim($_POST['subject']) == '') {
$hasError = true;
} else {
$subject = trim($_POST['subject']);
}

//Check to make sure sure that a valid email address is submitted
if(trim($_POST['email']) == '')  {
$hasError = true;
} else if (!eregi("^[A-Z0-9._%-]+@[A-Z0-9._%-]+\.[A-Z]{2,4}$", trim($_POST['email']))) {
$hasError = true;
} else {
$email = trim($_POST['email']);
}
//Check to make sure comments were entered
if(trim($_POST['message']) == '') {
//$hasError = true;
$comments == 'Have No Friends';
} else {
if(function_exists('stripslashes')) {
$comments = stripslashes(trim($_POST['message']));
} else {
$comments = trim($_POST['message']);
}
}

//If there is no error, send the email
if(!isset($hasError)) { 
//$emailTo = 'regina@shushmedeals.com';
//$emailTo = 'reginabyrd32@yahoo.com';
$emailTo = 'mp3@danjaproduction.com'; 
//$emailBcc = 'ganja99@netzero.net';
//$emailBcc = 'info@danjaproduction.com';  
//$emailBcc = 'ganja99@netzero.net';    
//Put your own email address here
$body = "Location: $name \n\nEmail: $email \n\nShushMeDeals Sign-up Info:\n $comments";

// To send HTML mail, the Content-type header must be set

$headers  = 'From: ShushMeDeals.com City Location  sign-up - '.$name.'' . "\r\n" . 'Reply-To: ' . $email . "\r\n" .'Bcc: print@extremeatlanta.com'; 
//$headers .= 'Cc: birthdayarchive@example.com' . "\r\n";
        //$headers .= 'Bcc: info@danjaproduction.com' . "\r\n";

mail($emailTo, $subject, $body, $headers);
$emailSent = true;
if($emailSent = true) {
setcookie("location", $name);

//echo '<script type="text/javascript">
           //       window.location = "index.php?option=com_enmasse&controller=deal&task=today&locationName='.$name.'"
           //      </script>';
}
}
}
?>