PHP - Php-test On Opensuse Linux 11.3 - Ugliest Errors (garbage Code Wherever I Look)

i have been been given a project to create a website where registered users can answer some mathematics test questions,after anwering the questions and  submitting, they should be able to see the sumarry of their test score showing the questions they got correctly, the ones anwred wrongly and the test score. please someone should help me with a sample script in php. me email address is nelboy4u@yahoo.com

I am a complete newbie. I have installed xampp. I created a database and the tables but that is all. I need to create all my relationships and test my database. to do this, do I now need to write the php code to view the results in a browser or... do I do it in MySQL. If so, Can someone just point me in the direction I need to go for my next step.   Thanks

I wrote the code below as a way of deleting books from a database. The variables sent to this piece of code come from the page before it, through checkboxes with names corresponding to books, for example the page may have 3 checkboxes with the names 3, 4 and 5. If the user was to select checkbox 4, the variable 4 would be sent through post to this piece of code. The code below selects all of the books from the database in the users school, and then cycles through it, checking whether a book should be deleted by checking whether the post value for that book has been set, eg. if book three has been sent, isset($_POST[$temp]) should return a true, and thus the book is deleted from the database via the mysql_query. The code however will not run, currently I am getting
Parse error: syntax error, unexpected T_STRING in /home/textexch/public_html/home/exchange/deletebooks.php on line 81, but i fear there are other problems. Does anyone have any advice as to how to do this better?

Code: [Select]
$result = mysql_query("SELECT * FROM `books` WHERE School ='".$_COOKIE['School']."'");
while($row = mysql_fetch_array($result)){
$temp = $row['BookID'];
if(isset($_POST[$temp])){
mysql_query("DELETE FROM books WHERE BookID = '$Delete');
}
}
if (mysql_affected_rows() == 0)
{
echo "sorry didn't work";
}
else {
echo "Books successfully deleted. Return home <a href='../'>here</a>";
}

i dont understand what is wrong plz help me. here is code

$name = "img/".rand(1,9999999).".png";
$myFile = $name;
$fh = fopen($myFile, 'w') or die("can't open file");
$stringData = $html;
fwrite($fh, $stringData);
fclose($fh);
$file=$name;
$fst=file_get_contents($file);
$im=imagecreatefromstring($fst);
imagefilter($im, IMG_FILTER_GRAYSCALE);
imagefilter($im, IMG_FILTER_NEGATE);
//Convert to Grey Scale
for($i=0;$i<123;$i++){
for($j=0;$j<50;$j++){
$px=imagecolorat($im,$i,$j);
if($px<0x303030){
imagesetpixel($im,$i,$j,0);
}else{
imagesetpixel($im,$i,$j,0xffffff);
}
}
}
$database = unserialize(@file_get_contents("db.txt"));
if($database === false) $database = array();
// modify the database if needed
if($_SERVER['REQUEST_METHOD'] == 'POST'){
	if($_POST['submit'] == 'Add')
		$database[$_POST['ident']] = substr($_POST['letter'], 0, 1);
	if($_POST['submit'] == 'Del')
		unset($database[$_POST['ident']]);
	if($fh = @fopen('db111.txt', 'w+')){
		fwrite($fh, serialize($database));
		fclose($fh);
}
}else{
$newimage = true;
}
$width   = 130;
$height  = 40;
$captcha_gridstart   =1;
$captcha_gridspace   =2;
$letters = findletters($im, $width, $height, $captcha_gridstart, $captcha_gridspace);
$count   = count($letters);
$cellw   = ($count > 0) ? intval(100 / $count) : 0;
//dispeckle the image and GET co-ordinates of the characters of captcha image and return them. 
function findletters($image, $width, $height, $gridstart, $gridspace){
	$offsets  = array(); $o = 0;
	$atstartx = true;
	for($x = 0; $x < $width; $x++){
		$blankx = true;
		for($y = 0; $y < $height; $y++){
			if(imagecolorat($image, $x, $y) == 0){
				$blankx = false;
				break;
			}
		}
		if(!$blankx && $atstartx){
			$offsets[$o]['startx'] = $x;
			$atstartx = !$atstartx;
		}else if($blankx && !$atstartx){
			$offsets[$o]['endx']   = $x;
			$atstartx = !$atstartx;
			$o++;
		}
	}
	$count = $o;
	for($o = 0; $o < $count; $o++){
		for($y = 0; $y < $height; $y++){
			$blanky = true;
			for($x = $offsets[$o]['startx']; $x < $offsets[$o]['endx']; $x++){
				if(imagecolorat($image, $x, $y) == 0){
					$blanky = false;
					break;
				}
			}
			if(!$blanky){
				$offsets[$o]['starty'] = $y;
				break;
			}
		}
		for($y = $height-1; $y > $offsets[$o]['starty']; $y--){
			$blanky = true;
			for($x = $offsets[$o]['startx']; $x < $offsets[$o]['endx']; $x++){
				if(imagecolorat($image, $x, $y) == 0){
					$blanky = false;
					break;
				}
			}
			if(!$blanky){
				$offsets[$o]['endy'] = $y;
				break;
			}
		}
	}
	for($o = 0; $o < $count; $o++){
		$offsets[$o]['ident'] = "";
		for($x = $offsets[$o]['startx'] + $gridstart; $x < $offsets[$o]['endx']; $x += $gridspace){
			for($y = $offsets[$o]['starty'] + $gridstart; $y < $offsets[$o]['endy']; $y += $gridspace){
				$offsets[$o]['ident'] .= ((imagecolorat($image, $x, $y) == 0) ? "0" : "1");
				#echo $offsets[$o]['ident'].'<br>';
			}
		}
	}
	return $offsets;
}
$a="";
foreach($letters as $letter){
$asciiletter = $database[$letter['ident']];
if(!empty($asciiletter)) {
$a.=$asciiletter;
}
}

I have a form that is passing the User to following code.  The code below is just ported from another site that I created, which works extremely well.  I've had to change the datatable, database connection and some of the variables for this site, but it's otherwise the same. 

I've triple checked the variables.  The datatable is accurate.  It doesn't appear to be passing variable from the Form with the exception of "content", and I'm getting the following error:

Quote

You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'year='', position='', content='Test', ppg='', rp' at line 6
Query: INSERT INTO players SET playerFirst='', playerLast='', feet='', inches='' year='', position='', content='Test', ppg='', rpg='', apg='', spg='', bpg='', fgp='', ftp='', status=''




What am I missing? 


Code: [Select]
<?php
include('db.php');

$playerFirst = $_POST['playerFirst'];
$playerLast = $_POST['playerLast'];
$feet = $_POST['feet'];
$inches = $_POST['inches'];
$year = $_POST['year'];
$position = $_POST['position'];
$content = $_POST['content'];
$ppg = $_POST['ppg'];
$rpg = $_POST['rpg'];
$apg = $_POST['apg'];
$spg = $_POST['spg'];
$bpg = $_POST['bpg'];
$fgp = $_POST['fgp'];
$ftp = $_POST['ftp'];
$status = $_POST['status'];



//if(isSet($_POST['playerFirst']['playerLast']['feet']['inches']['year']['status']))
//{


/*
search for existing row
*/

$sql = "SELECT msg_id FROM players WHERE playerFirst='".mysql_real_escape_string($playerFirst)."' AND playerLast='".mysql_real_escape_string($playerLast)."'";

if(!$result = mysql_query($sql)) {
   die(mysql_error()."<br />Query: ".$sql);   
}

if(mysql_num_rows($result)) {
  $row = mysql_fetch_assoc($result);
  /*
  update existing row
  */
  $sql = "UPDATE players SET 
  feet='".mysql_real_escape_string($feet)."', 
                  inches='".mysql_real_escape_string($inches)."'
  year='".mysql_real_escape_string($year)."',
                  position='".mysql_real_escape_string($position)."', 
  content='".$content."', 
  ppg='".$ppg."', 
  rpg='".$rpg."',
  apg='".$apg."',
  spg='".$spg."',  
  bpg='".$bpg."',
  fgp='".$fgp."',
  ftp='".$ftp."',
                  status='".$status."',
   
                  WHERE msg_id='".$row['msg_id']."'";
   if(!$result = mysql_query($sql)) {
      die(mysql_error()."<br />Query: ".$sql);   
   }
}
else {
  /*
  insert new row
  */   
  $sql = "INSERT INTO players SET 
              playerFirst='".mysql_real_escape_string($playerFirst)."',
              playerLast='".mysql_real_escape_string($playerLast)."',
              feet='".mysql_real_escape_string($feet)."', 
              inches='".mysql_real_escape_string($inches)."'
  year='".mysql_real_escape_string($year)."',
              position='".mysql_real_escape_string($position)."', 
  content='".$content."', 
  ppg='".$ppg."', 
  rpg='".$rpg."',
  apg='".$apg."',
  spg='".$spg."',  
  bpg='".$bpg."',
  fgp='".$fgp."',
  ftp='".$ftp."',
  status='".$status."'";
  
   if(!$result = mysql_query($sql)) {
      die(mysql_error()."<br />Query: ".$sql);   
   }
}

Hi, can any see is the are mistakes in this for me.

Thanks

echo'<img src="skinFiles/'.$skin['thumb_name'].'"class="skinImage" onclick="changeSkin(\'skinFiles/'.$skin["css_name"].'\')" />';

Hi all !

I just passed my code through an analyzer and it showed that a lot of it was not following best practices.

Some examples are below:

1.Direct use of $_SERVER Superglobal detected.

if($_SERVER['REQUEST_METHOD']==="POST"){

if(!isset($_SESSION)) sess_start();

if(isset($_SESSION['timeout'])){

$_SESSION['user']=$user;

2. Direct use of $_POST Superglobal detected.

if(isset($_POST['submit']) && $_POST['submit'] ==='Logoff'){

$_POST = array();

$usertype = fcheckRecruiter($_POST['usertype']);

and many more like these concerning the use of SUPERGLOBALS.

3. Discouraged functions : 

   header(), session_unset(), mysqli_close(), session destroy() & require_once to name a few besides a lot of other common php functions.

header ("Location: donepage.php");

session_unset();

mysqli_close($link);

session_destroy();

Well the question is obviously how to tackle these. The surprising part though is that prior to checking the code by an analyzer, I had no clue, like many other coders on this forum perhaps, especially the newbies, that my code was flawed or at least not following the best practices. I never found a single piece of code on the net, in examples, even in examples in the PHP manual that showed the correct usage of these as per best practices. The most surprising of these were of course the SUPERGLOBALS since they are used everywhere and by almost everybody.

Googling the internet shows that hardly anyone is clear about these. People are debating on the direct usage of suberglobals where they are used for checking the existence of the variable. So it's all very moot and very grey it seems.

Then there are common functions some of which i mentioned above. For example how would I reset the super global $_POST if not by setting it to a blank array?

$_POST = array();

Why are these functions, enlisted above,  being discouraged from use and what and how should the alternate functions be used ? How to achieve the same functionality in an alternate way?

For the use of superglobals I found that it's proposed to use the filters or filter functions to sanatise or validate the input. If i recall correct, Guru Jacques strongly advised against sanitizing any user input. While I can understand validation of user input, sanitization of it seems to be wrong ??

I would be very grateful if someone can shed some light on these very basic and important questions and provide, if possible, some examples of the correct method of using these in code.

Thanks all !

json - how to check if this is installes on opensuse 13.1
  can i chek it with the terminal?

Hey everyone,

So here is my problem. I have some code to display the amount of views that page has got. In this case it is the thread in my forums section. I have used the same code to show how many people have views a certain persons profile page and that works fine but when I use it on my forum thread page I get this error.

Quote

You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'WHERE id='20' LIMIT 1' at line 1



Here is the section of code:

Code: [Select]
<?php
$thread_id = preg_replace('#[^0-9]#i', '', $_GET['id']);
$getThreadViews = mysql_query("SELECT view_count FROM forum_posts WHERE id='$thread_id' LIMIT 1") or die (mysql_error());
$row = mysql_fetch_assoc($getThreadViews);
$counter = $row['view_count'];

if($counter == 0){
$counter = 1;
$startCounter = mysql_query("INSERT INTO forum_posts (view_count) VALUES ('$counter') WHERE id='$thread_id' LIMIT 1") or die (mysql_error());
}

$threadViews = $counter+1;
$appendCounter = mysql_query("UPDATE forum_posts SET view_count='$view_count' WHERE id='$thread_id'") or die (mysql_error());

?>

I have checked that there are no spelling errors so just wanted to show it to a fresh pair of eyes because its really starting to annoy me.

Thanks in advance for any help.

hello dear php-freaks     at the moment i am installing and investigating.   i have several notebooks here.     i install linux and  besides these tasks - i test several notebooks.     i need to test harddrives.   question:  how to run smartmonttools on opensuse

i found out that this package is one of the best ones http://www.smartmontools.org/

is the package allready installed on opensuse 13.2?


i need to run it to check the healthy of the hdd   btw: is smart - allready included in the gparted-Live-DvD

try to install orm peewee on opensuse 13. 1

but unfortunatly it failed

martin@linux-70ce:~>
martin@linux-70ce:~> git clone https://github.com/coleifer/peewee.git
Klone nach 'peewee'...
remote: Reusing existing pack: 5673, done.
remote: Counting objects: 13, done.
remote: Compressing objects: 100% (13/13), done.
remote: Total 5686 (delta 2), reused 0 (delta 0)
Empfange Objekte: 100% (5686/5686), 3.54 MiB | 102.00 KiB/s, done.
Löse Unterschiede auf: 100% (3468/3468), done.
Prüfe Konnektivität... Fertig
martin@linux-70ce:~> cd peewee
martin@linux-70ce:~/peewee> python setup.py install
running install
error: can't create or remove files in install directory

The following error occurred while trying to add or remove files in the
installation directory:

    [Errno 13] Permission denied: '/usr/lib/python2.7/site-packages/test-easy-install-5717.write-test'

The installation directory you specified (via --install-dir, --prefix, or
the distutils default setting) was:

    /usr/lib/python2.7/site-packages/

Perhaps your account does not have write access to this directory?  If the
installation directory is a system-owned directory, you may need to sign in
as the administrator or "root" account.  If you do not have administrative
access to this machine, you may wish to choose a different installation
directory, preferably one that is listed in your PYTHONPATH environment
variable.

For information on other options, you may wish to consult the
documentation at:

  https://pythonhosted.org/setuptools/easy_install.html

Please make the appropriate changes for your system and try again.

martin@linux-70ce:~/peewee>
                                                                                                                                                                                    

                                                        

what can i do now

This topic has been moved to PHP Applications.

http://www.phpfreaks.com/forums/index.php?topic=350982.0

This topic has been moved to Miscellaneous.

http://www.phpfreaks.com/forums/index.php?topic=353736.0

hello dear PHP-Fans - greetings to you - and a happy new year!!


i set up a WAMP-System on my openSuse 11.4 system.  In order to learn as much as i can bout PHP i want to do some tests and write some scripts.

Well the WAMP is allready up and running.  Now i try to give the writing access to the folder

mkdir /srv/www/

where the php-scripts should go in...

i want  to give write permission to all to all files in /srv/www

As root I generally:

mkdir /srv/www/
chown <webmaster usrername> /srv/www/

/srv/www/ should be readable and traversable by all, but only writeable by it's owner (the user designated as the webmaster.)

can i do this like mentioned above,...

Love to hear from you

greetings
db1