PHP - Moved: Classes Vs Functions

This topic has been moved to Application Design.

http://www.phpfreaks.com/forums/index.php?topic=314334.0

Not sure how to describe what I'm trying to do here in the title, but here goes with what I am trying to accomplish.

I've got a few hundred lines of code in total so far, so I'll try to keep it as short as I can. I've got an application that I am programming using classes for each module and right now I am coding the base classes that I need in order for it to run (database, errors, logging, etc). What I'm doing for my database class is I have a query factory and it extends the MySQLi class so I can process, clean and code the rest of my app faster. I also have another, unrelated class "Error", which will be used for processing errors I might come across.

I'd rather do it this way instead of having to call trigger_error and error_log every time there is an error. I'd also not like to have to call a new instance of an object every time I need to use something from that class. Is there any way I can call a class within a class and return it as an object for all the methods within the class?

I've tried the methods below, but no luck I've tried others, but I'm trying to keep it brief and get what I'm trying to do across.

<?php

class QueryFactory extends MySQLi {

public  $err = new error(); //Doesn't work.
public  $err = error(); //Nope.

#This is the function that I need the $err object for.
function set($fields, $newvals) {

if ( is_array($fields) && is_array($newvals) ) {

if ( count($fields) != count($newvals) ) {
//Instead of below, I want to do something like $err->('Array lengths must match for method', 256, $islogged = 1);
                              trigger_error('Array lengths must match for method', 256);
}

}
}

}


The thing is, I have a "run.inc.php" which does include and create new objects for running just the basic app and if I try to redeclare the error class in query.class.php, it gives me an error saying I can't do that, but if i try to call $err from the page that has all the classes defined it throws an error saying that my method is undeclared. I'd like my error class be available to every other class I create so I can display and log errors as needed. Any suggestions or links to point me where I'd like to go?

I have a script I am putting together that simulate a cricket game. The only issue is, that there are a huge number of functions because there doesn't seem to be any other way to do this properly. As well as this, there a while() loop and all this seems to be leading to the page reaching a max 30 second timeout when generating the result.

My code is attached below, it is quite messy at the moment because i've just be working on it, but I was wondering if anyone has any solutions of how I can speed this up or change to prevent a timeout:

<?php
// Error reporting
error_reporting(E_ALL);

// Connect DB
mysql_connect("wickettowicket.adminfuel.com", "rockinaway", "preetha6488") or die(mysql_error());

// Select DB
mysql_select_db("wickettowicket") or die(mysql_error());

// MySQL queries to find batsmen and bowlers 
$array_batsmen = mysql_query('SELECT id, name, ability, strength FROM wtw_players WHERE team_id = 1 ORDER BY id ASC');
$array_bowlers = mysql_query('SELECT id, name, ability, strength FROM wtw_players WHERE team_id = 2');

// Start table for data 
$data = '<table width="600px">';

// Create blank scorecard
while ($array_bat = mysql_fetch_array($array_batsmen))
{
$data .= '<tr><td>'.$array_bat['name'].'</td><td></td><td></td><td>0</td></tr>';
}

// Set up arrays for players 
$current_batsman = $current_bowler = array();

// Reset query
mysql_data_seek($array_batsmen,0);

$in_one = $in_two = $it = '';

function currentBatsman($id, $name, $ability, $strength, $out, $in, $runs)
{
global $current_batsman;


$current_batsman = array (
'id' => $id,
'name' => $name,
'ability' => $ability,
'strength' => $strength,
'out' => $out,
'in' => $in,
'runs' => $runs
);

echo 'set current';
}

// Set up arrays of batsmen
while ($array = mysql_fetch_array($array_batsmen))
{

if ($it < 3 && $in_one == '') 
{
currentBatsman($array['id'], $array['name'], $array['ability'], $array['strength'], 0, 1, 0);

$batsmen[$array['id']] = array (
'id' => $array['id'],
'name' => $array['name'],
'ability' => $array['ability'],
'strength' => $array['strength'],
'out' => 0,
'in' => 1,
'runs' => 0
);

$in_one = $array['id'];
$current = $array['id'];
$it++;
}
else if ($it < 3 && $in_two == '') 
{
$batsmen[$array['id']] = array (
'id' => $array['id'],
'name' => $array['name'],
'ability' => $array['ability'],
'strength' => $array['strength'],
'out' => 0,
'in' => 1,
'runs' => 0
);

$in_two = $array['id'];
$it++;
}
else 
{
$batsmen[$array['id']] = array (
'id' => $array['id'],
'name' => $array['name'],
'ability' => $array['ability'],
'strength' => $array['strength'],
'out' => 0,
'in' => 0,
'runs' => 0
);
}

}

// Bowler Array
while ($array = mysql_fetch_array($array_bowlers))
{
$bowlers[] = array (
'name' => $array['name'],
'ability' => $array['ability'],
'strength' => $array['strength']
);

}

// Reset both queries
mysql_data_seek($array_bowlers,0);
mysql_data_seek($array_batsmen,0);



function changeBatsman($just_out)
{
global $array_batsmen, $batsmen; 

//Update array
$batsmen[$just_out] = array (
'in' => 1,
'out' =>  1
);

while ($array = mysql_fetch_array($array_batsmen))
{
if ($just_out != $array['id'] && $batsmen[$array['id']]['out'] != 0) currentBatsman($array['id'], $array['name'], $array['ability'], $array['strength'], 0, 1, 0);
}

// Reset query
mysql_data_seek($array_batsmen,0);

echo 'change batsman';
}

function swapBatsman($other_batsman)
{
global $array_batsmen, $batsman; 

while ($array = mysql_fetch_array($array_batsmen))
{
if ($other_batsman != $array['id'] && $batsman[$array['id']]['out'] != 0 && $batsman[$array['id']]['in'] == 1) currentBatsman($array['id'], $array['name'], $array['ability'], $array['strength'], 0, 1, 0);
}

// Reset query
mysql_data_seek($array_batsmen,0);

echo 'swap batsman';
}

$runs = $outs = $balls = $overs = 0;

$played = array();

function selectBowler()
{
global $bowlers, $current_bowler;

// Select random bowler
$choose_bowler = array_rand($bowlers, 1);

$current_bowler = array (
'name' => $bowlers[$choose_bowler]['name'],
'ability' => $bowlers[$choose_bowler]['ability'],
'strength' => $bowlers[$choose_bowler]['strength']
);

 

}

/*
function selectBatsman();
{
global $array_batsmen;

while ($array_batsmen[]['out'] != 1)
{


}*/

function bowl()
{
global $batsmen, $bowlers, $current_bowler, $current_batsman, $data, $balls, $outs, $runs;

if ($current_batsman['out'] == 0)
{
echo 'bowling';
// Set the initial number
$number = rand(0, 190);

// Ability of batsman
if ($current_batsman['ability'] > 90) $number += 30;
else if ($current_batsman['ability'] > 70) $number += 15;
else if ($current_batsman['ability'] > 50) $number += 2;
else $number = $number;

// Strength of batsman
if ($current_batsman['strength'] > 90) $number += 15;
else if ($current_batsman['strength'] > 70) $number += 10;
else if ($current_batsman['strength'] > 50) $number += 5;
else $number = $number;

// Depending on overs
if ($balls > 270) $number += 30;
else if ($balls > 120) $number -= 10;

// Ability
if ($current_bowler['ability'] > 90) $number -= 30;
else if ($current_bowler['ability'] > 70) $number -= 15;
else if ($current_bowler['ability'] > 50) $number -= 2;
else $number = $number;

// If batsman has made a huge total of runs, we need to knock some numbers off - more likely to get out
if ($current_batsman['runs'] > 200) $number -= 70;
else if ($current_batsman['runs'] > 100) $number -= 30;

// Finally sort out runs
if ($number > 190) $run = 6;
else if ($number > 170) $run = 4;
else if ($number > 160) $run = 3;
else if ($number > 100) $run = 2;
else if ($number > 50) $run = 1;
else if ($number > 10) $run = 0;
else if ($balls > 120 && $number > 0) $run = 0;
else $run = -1;

// Increase number of balls
$balls += 1;

// Are they out?
if ($run == -1)
{
$current_batsman['out'] = 1;

$played[] = $current_batsman['id'];
$find = '<tr><td>'.$current_batsman['name'].'</td><td></td><td></td><td>0</td></tr>';
$replace = '<tr><td>'.$current_batsman['name'].'</td><td></td><td>'.$current_bowler['name'].'</td><td>'.$current_batsman['runs'].'</td></tr>';

$data = str_replace($find, $replace, $data);


changeBatsman($current_batsman['id']); 



echo 'out';

}
else
{
$current_batsman['runs'] += $run;
$runs += $run;

if ($run == 1 || $run == 3)
{
swapBatsman($current_batsman['id']);
echo 'time to swap';
}

echo $run;


}

// Count outs
if ($current_batsman['out'] == 1)
$outs += 1;


}
}

function game()
{
global $main, $batsmen, $bowlers, $data, $batted, $balls, $outs, $current_batsman;

// Check if possible
while ($balls <= 295 && $outs < 10)
{

selectBowler();

// Actually bowl now

bowl();


}


}


game();



echo $data;

I teaching myself php, but I am coming from java and other compiled languages, so the process has been a little bumpy. I am trying to do something like this:

Code: [Select]
class my_class
{

  function one ()
  {
     $two = two ();

     $three = three ();

     $five = $two + $three;

     return $five;
  }

  function two ()
  {
     $two = 2;

    return $two;
  }
 
  function three ()
  {
     $three = 3;

     return $three;
  }
}


Unfortunately, I keep getting an error message saying that my call to two () is an undefined function. I am gathering from this that the scope of one () is not aware of the existence of two (). Is there a way to get around this so I can call two () and three () from one ()?

How can i get my class to be showed on the front page
here is the front page
<?php
require('ex2.php');
$start = new A();
$tart->Display();
?>
now here is ex2.php
<?php
ini_set('display_errors', 1);
error_reporting(E_ALL);

class A
{
    public $title = "test1";
    public $end = "test2";
}   
function __set($name, $value)
    {
        $this->$name = $value;
    }
function Display()
{
    echo $title;
    echo $end;
}

?>
shoudn't this print test1 and test2 ?

ini_set('display_errors', 1);
error_reporting(E_ALL);

class A
{
    private function operation1() //only be used inside this class
    {
        echo 'operation1 called';
    }
    protected function operation2() //only inside this class
    {
        echo 'operation2 called';
    }
    public function operation3() //public can be used in any class
    {    
        echo 'operation3 called';
    }
}
class B extends A
{
    function _construct()
    {
        //$this->operation1();
        //$this ->operation2();
        $this->operation3();
        
    }
}

$b = new B;


can someone please tell me why this code doesn't work ?

Hi there,    This might a newbie question but I need help understanding PHP classes which am currently learning.    I have an index page.    With this three included files.    database.php config.php account.php    on database.php, the class is declared using $connection new Database(...), on this page is also all the coding for this class.   In config.php is a declared class of $account new Account($user_id);   and on account.php is all the details for the account class.    on the index.php is echo $account->sayHello;    However, My page is throwing out an error because I'm trying to use $connection->query(..) in my account.php / Account class.    I have tried to extend the Account class with Database but still have no luck.    How can I make sure the I can use a class function from another page in my Account class?        Thanks for reading

Hi.

I want to know how I access calsses in PHP. I mean how I search for class that I want and need. do I need to search in php.net? and what editors that provide access the the whole php classes and who they keep updated?

Cheers.

Hello,

maybe back to basics, but

  [PHP] pobierz, plaintext

Hello All,

I am fairly new to PHP class development, and I was wondering if it is normal behaviour to see classes not being able to access global variables related to PHP-based requests ($_GET, $_SESSION, etc.)? I seem to either have to use "global <var>" inside of the class to access the data, or I am forced to change the methods so then such required data is passed in as parameters. Perhaps I am just doing something wrong?

Here is an example of what I mean:

class Something
{
       function aFunc()
       {
               if (isset($_SESSION['somedata'])) { return false; } // this always returns false whether I had set the value or not
       }
       function bFunc()
       {
              global $_SESSION; // figured this would already be in a global accessible scope
              if (isset($_SESSION['somedata'])) { return false; } // now this will return false only when the value is set
       }
}


Now the above example is commented to demonstrate what I was meaning above, and I was wondering if this was the 'norm' when developing classes for PHP (and thus such values should be passed as parameters)?

Thanks!

Take the following example:


<?php
class a {
var $things;
public function __construct($stuff) {
$this->things = $stuff;
}
}
class b {
var $morethings;
$this->morethings = "something";
}

$c = new a(new b);

echo $c->things->__PARENT__;
?>


The line "echo $c->things->__PARENT__;" (as you can probably imagine) does not work. How would I output what the 'b' object is stored in ('a')?

Hi, I want to build a simple calculator class and one of the function is to calculate the factorial, but for some reason I cannot get this to work.

Here is class:
=========
Code: [Select]
<?php
class Calculator {

 function factorial($n) {
  if($n==1)
return 1;
  else 
return factorial($n-1)*$n;
 }
}//END CLASS Calculator

$calculator=new Calculator();
print $calculator->factorial(3);
?> 

But it doesn't work, I know this is simple but I am a little rusty with object oriented programming.

I'd appreciated any help!

I have just start using PHP classes and was wondering how you continue an instance of a class in another file.  For example I have a folder called "includes" where I includes files that I send data to when I perform ajax request.  However how do I continue an instance of class in these files?  Hope that makes sense. 

Thanks for any help. 

If I have defined an instance of a class in one script how do I then use this same instance and the same variable in other scripts?  For example say I have this code in a file called "index.php"


include("myclass.class.php");

$myclass = new myClass;

$myclass->$variable = "hello world";


However if I then have this code in a file called "page1.php" when I try to access the same variable it is empty. 


include("myclass.class.php");

echo($myclass->$variable)


How can I use the same instance of this class across all files keep the variable values the same?

Thanks for any help.