PHP - User Class Help...

What do you think of my user class so far?
Room to improve, things to change etc.
I'm still getting the hang of this oop thing.
Code: [Select]
http://pastebin.com/fPFk21k4

Hi,

I've always used PHP code in my websites in a procedural manner as I come from a html/css background. Now that I want to do projects with more complexity I'm thinking I need to approach development in a more Object Oriented fashion.

My question is more a theoretical one. I'm creating a User class and I'm not sure on what is the best practise for putting my functions etc. and where to call them.

My project will have 2 different users (Admin & End User) so is it correct to say that the User class should encapsulate all the functions of both of these users ? By that I mean create/delete/modify user, login & change password/forgotten password functionality rather than having a seperate Login class

Should I only call the database functions within these methods of the user class as opposed to calling them on the php page where the form data is posted ?

For example, if a user logins in and when the form data is posted I currently open a connection, validate data, run the query.
In an OO approach would I have just one User class method thats relevant to a particular page functionality ?
Say, in pseudo code, for handling a login request

loginRequest.php
Code: [Select]
include User class

try {
create new user User();
User::login();
}
catch Exception()



and should my User class look something like this

class.User.php
Code: [Select]
include DBase class

class User {
 var name,
 var email,
 var password,

function validateInput (email, password) {
     if (!valid input)
         throw Exception
    else
       return true
}

function login (email, password){
    try {
       database connection
       validateInput();
       sql to see if user exists and login
       
   }
   catch Exception
}

}

Apologies for this being a bit long winded!

thanks

tmfl

All my code is returning is the username... Please help.   index.php

<?php

include('user.class');
$user = new user("Jbonnett", "0", "Admin", "Jamie", "Bonnett", "jbonnett@site.co.uk", "01/09/1992");

echo "username: " . $user->getUsername() . "<br/>";
echo "id: " . $user->getId() . "<br/>";
echo "level: " . $user->getLevel() . "<br/>";
echo "Forename: " . $user->getForename() . "<br/>";
echo "Surname: " . $user->getSurname() . "<br/>";
echo "Email: " . $user->getEmail() . "<br/>";
echo "Dob: " . $user->getDob() . "<br/>";


?> 

user.class 

<?php

class user {
	
	private $username;
	private $id;
	private $level;
	private $forename;
	private $surname;
	private $email;
	private $dob;
	
	public function user($username, $id, $level, $forname, $surname, $email, $dob) {
		$this->setUsername($username);
		$this->setId($id);
		$this->setLevel($level);
		$this->setForename($forename);
		$this->setSurname($surname);
		$this->setEmail($email);
		$this->setDob($dob);
	}
	
	public function destroy() {
		unset($this->username);
		unset($this->id);	
		unset($this->level);	
		unset($this->forename);	
		unset($this->surname);	
		unset($this->uemail);
		unset($this->dob);		
	}
	
	public function setUsername($username) {
		$this->username = $username;
	}
	
	public function getUsername() {
		return $this->username;
	}
	
	public function setId($id) {
		$this->id = $id;
	}
	
	public function getId() {
		return $this->$id;
	}
	
	public function setLevel($level) {
		$this->level = $level;
	}
	
	public function getLevel() {
		return $this->level;
	}
	
	public function setForename($forename) {
		$this->foreName = $forename;
	}
	
	public function getForename() {
		return $this->forename;
	}
	
	public function setSurname($surname) {
		$this->surName = $surname;
	}
	
	public function getSurname() {
		return $this->surname;
	}
	
	public function setEmail($email) {
		$this->email = $email;
	}
	
	public function getEmail() {
		return $this->email;
	}
	
	public function setDob($dob) {
		$this->dob = $dob;
	}
	
	public function getDob() {
		return $this->dob;
	}
	
};

?>

OK, Here is the code

$sql = "SELECT
TrialListing.listingID AS Trial, TrialClass.classID AS Class, place.place_name AS Place,
CONCAT_WS(
' ',
pedigree.pretitle,
pedigree.`Name`) AS Hound,
CONCAT_WS(
' ',
ped2.pretitle,
ped2. NAME
)AS Sire,
CONCAT_WS(
' ',
ped3.pretitle,
ped3. NAME
)AS Dam,
pedigree.Breeder,
pedigree.`Owner`,
CASE
WHEN placement.place_id < 5 THEN
TRUNCATE(TrialClass.number_of_entrants / placement.place_id,2)
WHEN placement.place_id  = 5 THEN
''
ELSE
0
END

AS Score
FROM
TrialListing
Left Join TrialClass ON TrialListing.listingID = TrialClass.listingID

JOIN placement ON placement.event_id = TrialClass.trialClassID
JOIN pedigree ON pedigree.PedigreeId = placement.hound_id
LEFT OUTER JOIN pedigree AS ped2 ON pedigree.SireId = ped2.PedigreeId
LEFT OUTER JOIN pedigree AS ped3 ON pedigree.DamId = ped3.PedigreeId
LEFT JOIN place ON place.place_id = placement.place_id

WHERE
TrialListing.listingID = 11
ORDER BY Class, FIELD(place.place_id, '1', '2', '3', '4', '0')


";      // Database Query  

$result = mysql_query("$sql");  // Database Query result

$num_rows = mysql_num_rows($result);





// Starts the table
echo "<table class=\"clubList\">\n
<tr>
<th>trialID</th>
<th>ClassID</th>
<th>Place</th>
<th>Hound</th>
<th>Sire</th>
<th>Dam</th>
<th>Score</th>

</tr>";

// Create the contents of the table.
for( $i = 0; $i < $row = mysql_fetch_array($result); $i++){




echo "<tr>\n"
        ."<td>".$row["Trial"]."</td>\n" 
        ."<td>".$row["Class"]."</td>\n" 
        ."<td>".$row["Place"]."</td>\n"  
        ."<td>".$row["Hound"]."</td>\n"  
        ."<td>".$row["Sire"]."</td>\n"                
        ."<td>".$row["Dam"]."</td>\n"
        ."<td>".$row["Score"]."</td>\n"  
        ."</tr>";}



echo "</TABLE>";


Here is the output, I added the TrialID & ClassID for informational purposes, they do not need to be displayed in the live table.

trialID ClassID Place Hound Sire Dam Score 11 1 1st Eaton Brook Tug Hill Tatonka Eaton Brook Hickety Hawk Eaton Brook Gunner's Beulah 43.00 11 1 2nd FC North Bend Igloo FC DFJ Murphy White IFC Brad-Ju's Bella Donna 21.50 11 1 3rd FC North Bend Igloo FC DFJ Murphy White IFC Brad-Ju's Bella Donna 14.33 11 1 4th Rail Road Spike VI Elwell's Mike Elwell's Hannah 10.75 11 1 NBQ FC Fish Creek Spike Fish Creek Bull II Fish Creek Susie [H849395] 11 2 1st Enman Hill Sweet Poppy FTCH Straight Arrow Lucky of Coos 32.00 11 2 2nd Fishflakes Penny At Harehaven FTCH Jill's Fair-Isle Spud FTCH Millbridge Brownie 16.00 11 2 3rd Line Elm Flakers IFC Flakers Rex IFC Line Elm Ginger 10.66 11 2 4th FTCH Fareast Mookie FTCH Mellowrun Sly FTCH Cape Breton Maude 8.00 11 2 NBQ FTCH Mellowrun Sly Mellowrun Skylighter FTCH Mellowrun Becka 11 3 1st Bojangle V Lee Otworth Half Acre's Cocoa Candy 23.00 11 3 2nd Gay Doll Gay Roll II Gay Idol 11.50 11 3 3rd Bruce's Blue Lady FC Kilsock's Blue Creek Bart Bishopville's Zippy 7.66 11 3 4th FC Pearson Creek Barbin FC Pearson Creek Barbarian FC B-Line Stubby 5.75 11 3 NBQ Sims Creek Cricket Ronnie Joe Sims Creek Tiny 11 4 1st FTCH Fareast Mookie FTCH Mellowrun Sly FTCH Cape Breton Maude 26.00 11 4 2nd FTCH Mellowrun Sly Mellowrun Skylighter FTCH Mellowrun Becka 13.00 11 4 3rd Fishflakes Penny At Harehaven FTCH Jill's Fair-Isle Spud FTCH Millbridge Brownie 8.66 11 4 4th Enman Hill Sweet Poppy FTCH Straight Arrow Lucky of Coos 6.50 11 4 NBQ Line Elm Flakers IFC Flakers Rex IFC Line Elm Ginger
Below is what I would like to generate. How do I word or nest the proper PHP code/loops to accomplish this?

ClassID

Place Hound Sire Dam Score 1st Eaton Brook Tug Hill Tatonka Eaton Brook Hickety Hawk Eaton Brook Gunner's Beulah 43.00 2nd FC North Bend Igloo FC DFJ Murphy White IFC Brad-Ju's Bella Donna 21.50 3rd FC North Bend Igloo FC DFJ Murphy White IFC Brad-Ju's Bella Donna 14.33 4th Rail Road Spike VI Elwell's Mike Elwell's Hannah 10.75 NBQ FC Fish Creek Spike Fish Creek Bull II Fish Creek Susie [H849395]

ClassID

Place Hound Sire Dam Score 1st Enman Hill Sweet Poppy FTCH Straight Arrow Lucky of Coos 32.00 2nd Fishflakes Penny At Harehaven FTCH Jill's Fair-Isle Spud FTCH Millbridge Brownie 16.00 3rd Line Elm Flakers IFC Flakers Rex IFC Line Elm Ginger 10.66 4th FTCH Fareast Mookie FTCH Mellowrun Sly FTCH Cape Breton Maude 8.00 NBQ FTCH Mellowrun Sly Mellowrun Skylighter FTCH Mellowrun Becka

ClassID

Place Hound Sire Dam Score 1st Bojangle V Lee Otworth Half Acre's Cocoa Candy 23.00 2nd Gay Doll Gay Roll II Gay Idol 11.50 3rd Bruce's Blue Lady FC Kilsock's Blue Creek Bart Bishopville's Zippy 7.66 4th FC Pearson Creek Barbin FC Pearson Creek Barbarian FC B-Line Stubby 5.75 NBQ Sims Creek Cricket Ronnie Joe Sims Creek Tiny

ClassID

Place Hound Sire Dam Score 1st FTCH Fareast Mookie FTCH Mellowrun Sly FTCH Cape Breton Maude 26.00 2nd FTCH Mellowrun Sly Mellowrun Skylighter FTCH Mellowrun Becka 13.00 3rd Fishflakes Penny At Harehaven FTCH Jill's Fair-Isle Spud FTCH Millbridge Brownie 8.66 4th Enman Hill Sweet Poppy FTCH Straight Arrow Lucky of Coos 6.50 NBQ Line Elm Flakers IFC Flakers Rex IFC Line Elm Ginger

I have mysqli object in Database class base:

[color=]database class:[/color]

class Database {
  private $dbLink = null;
  
  public function __construct() {
    if (is_null($this->dbLink)) {
      // load db information  to connect
      $init_array = parse_ini_file("../init.ini.inc", true);
      $this->dbLink = new mysqli($init_array['database']['host'],
                           $init_array['database']['usr'],
                           $init_array['database']['pwd'],
                           $init_array['database']['db']);
  
      if (mysqli_connect_errno()) {
        $this->dbLink = null;
      }
    }
  }

  public function __destruct() {
    $this->dbLink->close();
  }
}


Class derived is Articles where I use object dBLink in base (or parent) class and I can't access to mysqli methods (dbLink member of base class):

Articles class:

require_once ('./includes/db.inc');

class Articles extends Database{
  private $id,
              ....
              ....
             $visible = null;
  
  public function __construct() {
    // Set date as 2009-07-08 07:35:00
    $this->lastUpdDate = date('Y-m-d H:i:s');
    $this->creationDate = date('Y-m-d H:i:s');
  }
  
  // Setter
  ....
  ....

  // Getter
  ....
  ....

  public function getArticlesByPosition($numArticles) {
    if ($result = $this->dbLink->query('SELECT * FROM articles ORDER BY position LIMIT '.$numArticles)) {
      $i = 0;
      while ($ret = $result->fetch_array(MYSQLI_ASSOC)) {
        $arts[$i] = $ret;
      }
      $result->close();
      return $arts;
    }
  }
}


In my front page php I use article class:


include_once('./includes/articles.inc');
$articlesObj = new articles();
$articles = $articlesObj->getArticlesByPosition(1);
var_dump($articles);


[color=]Error that go out is follow[/color]

Notice: Undefined property: Articles::$dbLink in articles.inc  on line 89

Fatal error: Call to a member function query() on a non-object in articles.inc on line 89

If I remove constructor on derived class Articles result don't change 
Please help me