PHP - Probably A Stupid Question About Uploading Files With Php

Hello everyone,

I'm writing a script that allows a user to upload multiple attachments to an email from PHP. So far, everything seems to be working except the multiple attachments part. If I upload one file, it works. If I upload 2, it's messing up the file names so the files don't exist.

So if I upload a.jpg, it works. If I upload a.jpg and b.jpg, b.jpg gets named a b.jpg. Can someone help me understand why this is happening and how to fix it?

I'm almost certain its happening on my while loop around lune 72, but the more I look at the syntax the more it looks okay to me.

I had it appending the path to the file names (so a.jpg become uploads/a.jpg) so I commented that out in hopes that was causing the error but it didn't fix it.

Below is the full script.

<?php
/*******************************************
/* contact_us_process.php
/* Author: Brandon Pence (brandonpence@gmail.com)
/*  
/* Desc: This page process and checks the submitted form.
/*
/* variable meaning
/* -------- -------
/* $FieldCheck Instance of the FieldCheck class.
/*
/******************************************/

//start session
session_start();

//include files
require ("./inc/include.inc.php");

//include Field Check Class
include("classes/FieldCheck.php");

//instantiate fieldcheck class
$FieldCheck = new FieldCheck;

extract($_POST);

/*****DEBUG*********/
echo '<h1>POST ARRAY:</h1>';
print_r($_POST);
echo '<hr/>';

echo '<h1>DATAFILE:</h1>';
print_r($datafile);

echo 'foreach: <hr/>';

echo '<h1>FILES ARRAY:</h1>';
print_r($_FILES);
echo '<hr/>';

echo 'File name test: '.$_FILES['uploadedfile']['name']['0'].'<br/>';
echo 'File name test: '.$_FILES['uploadedfile']['name']['1'].'<br/>';
echo 'File name test: '.$_FILES['uploadedfile']['name']['2'].'<br/>';
/********************/

//foreach($datafile as $key=>$value){
//echo 'Datafile: '.$datafile.' || Key: '.$key.' || Value: '.$value.'<br/>';
//$value = $id.'/'.$value;
//echo 'Datafile: '.$datafile.' || Key: '.$key.' || Value: '.$value.'<br/>';
//}


if(file_exists("uploads/$id")){
echo 'Folder Exists!';
}else{
echo 'Folder does not exist. Create folder.';

//create directory
mkdir("uploads/$id",0777,true);
}

//path we want the files stored in
$target_path = "uploads/$id/";

//begin counter
$i = 0;

$files = array();
    
//begin loop
while($i < 3){

//make sure each array key has valid data
if(!is_null($_FILES['uploadedfile']['name'][$i])){

//append path to filenames in array
//$target_path = $target_path . basename($_FILES['uploadedfile']['name'][$i]); 

//upload files
if(move_uploaded_file($_FILES['uploadedfile']['name'][$i], $target_path)) {
     echo "The file ".  basename($_FILES['uploadedfile']['name'][$i]). " has been uploaded";
    
     $files[$i] = 'uploads/'.$id.'/'.$_FILES['uploadedfile']['name'][$i];
     }
    
    //if file upload failed
    }else{
     echo "There was an error uploading the file, please try again!";
}

$i++;

}

//validate input
if (!$FieldCheck->checkName($your_name)){ $errors['your_name'] = "Your name is not valid.";}
if (!$FieldCheck->isEmpty($your_date)){ $errors['your_date'] = "Your date is not valid.";}
if (!$FieldCheck->isEmpty($your_message)){ $errors['your_message'] = "Your message is not valid.";}

foreach($_POST as $key=>$value){

$fields[$key] = $value;

}

//print_r($_POST);

//check for error messages
if (isset($errors)) {
$_SESSION['errors'] = $errors;
$_SESSION['fields'] = $fields;
$_SESSION['error_msg'] = "Errors found!  Please review your entries.";
$url = "./testimonials.php?action=errors";
header ("Location: $url");
exit;
}else{


echo '$files ARRAY:';
print_r($files);
 
// email fields: to, from, subject, and so on
$to = "a@c.om";
$from = "a@b.com"; 
$subject ="Testing Script"; 
$message = "My message";
$headers = "From: $from";
 
// boundary 
$semi_rand = md5(time()); 
$mime_boundary = "==Multipart_Boundary_x{$semi_rand}x"; 
 
// headers for attachment 
$headers .= "\nMIME-Version: 1.0\n" . "Content-Type: multipart/mixed;\n" . " boundary=\"{$mime_boundary}\""; 
 
// multipart boundary 
$message = "This is a multi-part message in MIME format.\n\n" . "--{$mime_boundary}\n" . "Content-Type: text/plain; charset=\"iso-8859-1\"\n" . "Content-Transfer-Encoding: 7bit\n\n" . $message . "\n\n"; 
$message .= "--{$mime_boundary}\n";
 
// preparing attachments
for($x=0;$x<count($files);$x++){
$file = fopen($files[$x],"rb");
$data = fread($file,filesize($files[$x]));
fclose($file);
$data = chunk_split(base64_encode($data));
$message .= "Content-Type: {\"application/octet-stream\"};\n" . " name=\"$files[$x]\"\n" . 
"Content-Disposition: attachment;\n" . " filename=\"$files[$x]\"\n" . 
"Content-Transfer-Encoding: base64\n\n" . $data . "\n\n";
$message .= "--{$mime_boundary}\n";
}
 
// send
 
$ok = @mail($to, $subject, $message, $headers); 
if ($ok) { 
echo "<p>mail sent to $to!</p>"; 
} else { 
echo "<p>mail could not be sent!</p>"; 
} 

echo 'EMAIL SENT!';

}

?>

hello all,

i moved my inhouse website to a hosting company.

now i have a few files that i used to upload data to the website, but every time i try uploading it gives me this error.


Warning: move_uploaded_file(..\pdfs\htdocs\pdfs\citysect/03152011CCRM.pdf) [function.move-uploaded-file]: failed to open stream: No such file or directory in /data/26/2/13/16/2502179/user/2740540/htdocs/loginscripts/uploadpdf.php on line 34

Warning: move_uploaded_file() [function.move-uploaded-file]: Unable to move '/data/20/tmp_new/php2GMXs3' to '..\pdfs\htdocs\pdfs\citysect/03152011CCRM.pdf' in /data/26/2/13/16/2502179/user/2740540/htdocs/loginscripts/uploadpdf.php on line 34
could not moved


can anyone help me?

I am using xammp with FileZilla running on it. I've changed my php.ini  settings
to "C:/xxx/tmp" directory but am unable to upload a file. Th cod is  running but
it dos not seem to upload the temporary fil. Plase somebody help  me. ALso my form in upload.html  has <form action="upload_file.php" method="post" enctype="multipart/form-data">

Hi,
I have a script where employees of a company can upload invoices to their clients. This is done via a simple upload form.
My question is,
What would be most secure way to do this? How should i upload files, should i make different directories for each customer, or should i have one huge, where file names will be random or, what would you do?

Hi All,

I am having trouble with this script that was from a example script online, basically I am getting the last error message everytime I try an up a zip file?
Unknown Error: No file uploaded


<?php
include('dbconnect.php');
session_start();
$user_id = $_SESSION['user_id'];

$query = " SELECT * FROM roms WHERE user_id = '$user_id' ORDER BY rom_date DESC LIMIT 1";
  $result = mysql_query($query);
if (!mysql_query($query))
  {
  die('Error: ' . mysql_error());
  }
  
while($row = mysql_fetch_array($result))
  {
$_SESSION['rom_version'] = $row['rom_version'];
}

if
((!empty($_FILES["rom"])) && ($_FILES['rom']['error'] == 0)) 

{
   $filename = $user_id . $_SESSION['rom_version'] . '.zip';
   $ext = substr($filename, strrpos($filename, '.') + 1);
   if (($ext == "zip") && ($_FILES["rom"]["type"] == "application/zip") && 
     ($_FILES["rom"]["size"] < 2500000)) 

{
    $newname = dirname(__FILE__).'roms/'.$filename;
       if (!file_exists($newname)) 
{
        if ((move_uploaded_file($_FILES['uploaded_file'][ 'tmp_name'],$newname))) 
{
            echo "It's done! The file has been saved as: ".$newname;
         } 
else 
{
            echo "Error: A problem occurred during file upload!";
         }
       } 
  
else 
{
          echo "Error: File ".$_FILES["rom"]["name"]." already exists";
       }
} 
else 
{
      echo "Error: Only .zip images under 250mb are accepted for upload";
   }
} 
else 
{
  echo "Unknown Error: No file uploaded";
}
?>