PHP - Correct Ternary Syntax?

<?php
error_reporting(E_ALL);
session_start();

include ("dbcon.php");
echo "include working";
$username1= ($_POST['username']);
echo ($_POST['username']);

if ($_POST) {
	
		if (!empty($_POST['username']) && !empty($_POST['pass'])) {
			$sql = "SELECT * FROM `user` WHERE `username`='($_POST['username'])' LIMIT 1";
			$result = mysqli_query($sql);
			if (mysqli_num_rows($result) > 0) {
				//user is valid, check pass
				$query = mysqli_fetch_assoc($result);
							 $password = ($_POST['pass']);
				if ($password !== $query['pass']) {
					//invaid pass, input error code
					echo "Wrong Password";
					exit;
				}	
				 else {
					//valid user and pass, login
					$_SESSION['login'] = TRUE;
					$_SESSION['username'] = $_POST['username'];
					//echo "logged in";
					header('location: home.php');
					exit(); 
				}
			} 
			else {
				//user is not in database, input error code
				echo " User Not Found";
			}
		}
		else {
			//form submitted but no username/password, input error code
			echo "Fields are Blank";
		}
} 
else {
	//page loaded, but no form submitted, input error code
	echo "Submition Error";
}


?>

I can't figure out the problem........ Any help is appreciated!

What would be the correct way to use returned sql results as variables.  I have tried the way in my script, but Im unsure of how I can echo just one of the $nt variables further on in my script.   


$code = $_GET['postcode'];
$shortcode = substr($code,0,2);
$query =mysql_query ("SELECT email FROM treesurgeons WHERE postcode like '%" . $shortcode . "%' ORDER BY companyName LIMIT 3");
echo mysql_error();
echo "<p>The email addresses you have requested are;</p>";
while($nt=mysql_fetch_row($query)){echo "$nt[0],$nt[1],$nt[2]<br>";}
echo "<p>please use $nt[2] if you ever want to contact me</p>"; //this line doesnt work for me
?></body></html>

is there is a way to assign variables such as;

$nt[0] = $firstemail
$nt[1] = $secondemail
$nt[2] = $thirdemail

this way I could use each of my sql values, just as I would any other variable?

In this statement...

$firstName = (isset($_SESSION['memberFirstName']) ? $_SESSION['memberFirstName'] : '');


Can isset() be replaced with most other functions, e.g. empty(), is_numeric(), is_null(), etc??

Thanks,


Debbie

if($AClass->select_error || $BClass->ErrorFile){
include("/path/to/files/".($AClass->select_error ? 'no_selector' : 'error_file_missing').".php");
exit;
}

if($CClass->WriteError){
include("/path/to/files/FileWriteError.php");
exit;
}



Probably a simple one for you folks, but I can't for the life of me work out how to make the above into 1 line of ternarys.

Cheers,
Rw

hello

i keep seeing Ternary Operators like this
Code: [Select]
$action = (empty($_POST['action'])) ? 'default' : $_POST['action'];

but how would i turn this if statement in to a Ternary Operator ?

Code: [Select]
if($a == $b){
echo 'hello';
}else{
//do nothing
}

thanks

Hey all,
when job_title property is equal to null, I want this to happen:

Welcome to the blog of John Merlino.

If it is not null then:

Welcome to the blog of John Merlino, a web designer. //where web designer refers to the value stored in job_title

So I come up with this:

Code: [Select]
echo "Welcome to the blog of " . $blogger->first_name . ' ' . $blogger->last_name  . (!is_null($blogger->job_title)) ? ', ' . $blogger->job_title . '.' : '.';

But when job_title is null, all the page renders is this:
Code: [Select]
, .

That's right. Just a comma, then a space, and then a period.

What am I missing here?

Thanks for response.

Please bear with me in the following exercise.  I'm fairly new to php (but not coding) and am trying to push my skills for the future, so I'm going beyond a problem for which I already have a solution to see if I understand the coding principles correctly.

I am trying to understand just how far I can push the ternary operator shorthand.  I know how to do simple tasks, but I'm wondering if I can perform more than one command in the same statement? I'm a little confused because I'd like to both set a session variable and do a page redirect and I have a feeling that the order of these operations matters, so all I've done here may be incorrect.

I have a form on the front page of my site that includes a checkbox that is required in order to enter the site.  The form action goes to a page where this is checked, a $_SESSION variable is set, and the page is redirected.  I am also not sure if I need the  session_write_close(); command, or if it is in the right place.  In the full length version, it could be moved into the set of commands following the IF.

Here is the full length code that I would like to translate into shorthand:

Code: [Select]
<?php session_start();
if (isset($_POST['ConsentCheckbox'])
{
$_SESSION['Consented'] = 'true';
header('Location: http://www.mySite/welcome');
} else {
header('Location: http://www.mySite/errors/NotConsented');
}
session_write_close(); ?>
The if/else conditions translate easily into these two lines of code, which could be one line if I didn't also need to set the session variable:

Code: [Select]
<?php session_start();
        $_SESSION['Consented'] =  isset($_POST['ConsentCheckbox']) ? 'true' : 'false';
        header('Location: http://mySite.com/'.($_SESSION['Consented'] ? 'welcome' : 'error/NotConsented'));
session_write_close(); ?>
But, I really only need to set the $_SESSION variable if the $_POST['ConsentCheckbox'] is set.  This makes the test on the following pages of my site much simpler (where I test to see if the $_SESSION variable is set and then either redirect to the consent form or load the desired page). 

SO, I'm wondering if it can be further condensed.  I've come up with these possibilities, but am not totally sure.  This has now become a theoretical exercise in coding for me.  Here is what I think is possible, but I have a couple of outstanding questions, so I'd like some input, please.

I first translated it into the following.  I think this is correct, although I'm not sure if I need brackets around the multiple commands in the TRUE section.

Code: [Select]
<?php session_start();
        isset($_POST['ConsentCheckbox']) ? $_SESSION['Consented']='true'; header('Location: http://www.mySite.com/welcome') :  header('Location: http://www.mySite/errors/NotConsented');
session_write_close(); ?>

Then, I wondered if I can even further condense it in the following way?  Here is where the order of the commands is likely to break the code - and I'm not entirely sure that my use of double quotes will suffice instead of escaping out the end bracket of the header() command:

Code: [Select]
<?php session_start();
        header('Location: http://www.mySite.com/'.(isset($_Post['ConsentCheckbox']) ? "welcome')"; $_SESSION['Consented'] = 'true' : "errors/NotConsented')");
session_write_close(); ?>
Have I gone too far?

Thanks

It's pretty simple to see what I am trying to do here. For some reason all results in the table are the same exact cityName replacing all existing records. The echoed results are correct. I've include a small dump of my table as well.

$query = "SELECT cityName FROM sys_city_dev_2";
      $resource = mysqli_query($cxn, $query) or die("MySQL error: " . mysqli_error($cxn) . "<hr>\nQuery: $query");
      
  while($result = mysqli_fetch_assoc($resource)) {

          $nox = $result['cityName'];

          $toUpper = ucfirst($nox);
  echo "$toUpper" . "<br />";

          $setString = "UPDATE sys_city_dev_2 SET cityName = '" . $toUpper ."' WHERE cityName != ''";
          mysqli_query($cxn,$setString);


      } 

100 Records of table dump (pre running my script above):

--
-- Table structure for table `sys_city_dev_2_backup`
--

CREATE TABLE IF NOT EXISTS `sys_city_dev_2_backup` (
  `ID` int(11) NOT NULL AUTO_INCREMENT,
  `Mid` int(11) NOT NULL DEFAULT '0',
  `cityName` varchar(30) NOT NULL DEFAULT '',
  `forder` int(4) NOT NULL DEFAULT '0',
  `disdplay` int(4) NOT NULL DEFAULT '0',
  `cid` int(11) NOT NULL DEFAULT '0',
  PRIMARY KEY (`ID`)
) ENGINE=MyISAM  DEFAULT CHARSET=latin1 AUTO_INCREMENT=113970 ;

--
-- Dumping data for table `sys_city_dev_2_backup`
--

INSERT INTO `sys_city_dev_2_backup` (`ID`, `Mid`, `cityName`, `forder`, `disdplay`, `cid`) VALUES
(84010, 1, 'dothan', 0, 0, 0),
(84011, 1, 'alabaster', 0, 0, 0),
(84012, 1, 'birmingham', 0, 0, 0),
(84013, 2, 'flagstaff', 0, 0, 0),
(84014, 1, 'auburn', 0, 0, 0),
(84015, 1, 'florence', 0, 0, 0),
(84016, 1, 'gadsden', 0, 0, 0),
(84017, 1, 'huntsville', 0, 0, 0),
(84018, 1, 'mobile', 0, 0, 0),
(84019, 1, 'montgomery', 0, 0, 0),
(84020, 1, 'tuscaloosa', 0, 0, 0),
(84021, 2, 'mohave valley', 0, 0, 0),
(84022, 2, 'phoenix', 0, 0, 0),
(84023, 2, 'prescott', 0, 0, 0),
(84024, 2, 'sierra vista', 0, 0, 0),
(84025, 2, 'tucson', 0, 0, 0),
(84026, 2, 'yuma', 0, 0, 0),
(84027, 3, 'bakersfield', 0, 0, 0),
(84028, 3, 'chico', 0, 0, 0),
(84029, 3, 'fresno / madera', 0, 0, 0),
(84030, 3, 'gold country', 0, 0, 0),
(84031, 3, 'humboldt county', 0, 0, 0),
(84032, 3, 'imperial', 0, 0, 0),
(84033, 3, 'inland empire', 0, 0, 0),
(84034, 3, 'los angeles', 0, 0, 0),
(84035, 3, 'alhambra', 0, 0, 0),
(84036, 3, 'merced', 0, 0, 0),
(84037, 49, 'fayetteville', 0, 0, 0),
(84038, 49, 'fort smith', 0, 0, 0),
(84039, 49, 'jonesboro', 0, 0, 0),
(84040, 49, 'little rock', 0, 0, 0),
(84041, 49, 'arkadelphia', 0, 0, 0),
(84042, 49, 'texarkana', 0, 0, 0),
(84043, 3, 'modesto', 0, 0, 0),
(84044, 3, 'alta sierra', 0, 0, 0),
(84045, 3, 'alpine', 0, 0, 0),
(84046, 3, 'pedley', 0, 0, 0),
(84047, 3, 'redding', 0, 0, 0),
(84048, 3, 'alondra park', 0, 0, 0),
(84049, 3, 'sacramento', 0, 0, 0),
(84050, 4, 'canon city', 0, 0, 0),
(84051, 3, 'san luis obispo', 0, 0, 0),
(84052, 3, 'santa barbara', 0, 0, 0),
(84053, 3, 'stockton', 0, 0, 0),
(84054, 3, 'aliso viejo', 0, 0, 0),
(84055, 3, 'visalia', 0, 0, 0),
(84056, 3, 'yuba city', 0, 0, 0),
(84057, 4, 'boulder', 0, 0, 0),
(84058, 4, 'colorado springs', 0, 0, 0),
(84059, 4, 'denver', 0, 0, 0),
(84060, 4, 'applewood', 0, 0, 0),
(84061, 4, 'pueblo', 0, 0, 0),
(84062, 4, 'air force academy', 0, 0, 0),
(84063, 5, 'avon', 0, 0, 0),
(84064, 5, 'hartford', 0, 0, 0),
(84065, 5, 'new haven', 0, 0, 0),
(84066, 5, 'ansonia', 0, 0, 0),
(84067, 5, 'fairfield', 0, 0, 0),
(84068, 7, 'daytona beach', 0, 0, 0),
(84069, 7, 'sebastian', 0, 0, 0),
(84070, 5, 'wallingford center', 0, 0, 0),
(84071, 8, 'belvedere park', 0, 0, 0),
(84072, 7, 'sarasota springs', 0, 0, 0),
(84073, 7, 'sandalfoot cove', 0, 0, 0),
(84074, 7, 'san carlos park', 0, 0, 0),
(84075, 7, 'st. augustine', 0, 0, 0),
(84076, 7, 'tallahassee', 0, 0, 0),
(84077, 7, 'safety harbor', 0, 0, 0),
(84078, 7, 'ruskin', 0, 0, 0),
(84079, 8, 'athens-clarke county', 0, 0, 0),
(84080, 8, 'atlanta', 0, 0, 0),
(84081, 8, 'augusta-richmond county', 0, 0, 0),
(84082, 8, 'brunswick', 0, 0, 0),
(84083, 8, 'columbus', 0, 0, 0),
(84084, 8, 'americus', 0, 0, 0),
(84085, 8, 'acworth', 0, 0, 0),
(84086, 8, 'valdosta', 0, 0, 0),
(84087, 10, 'boise', 0, 0, 0),
(84088, 10, 'ammon', 0, 0, 0),
(84089, 10, 'moscow', 0, 0, 0),
(84090, 10, 'blackfoot', 0, 0, 0),
(84091, 10, 'twin falls', 0, 0, 0),
(84092, 10, 'meridian', 0, 0, 0),
(84093, 10, 'jerome', 0, 0, 0),
(84094, 10, 'idaho falls', 0, 0, 0),
(84095, 11, 'addison', 0, 0, 0),
(84096, 10, 'garden city', 0, 0, 0),
(84097, 10, 'eagle', 0, 0, 0),
(84098, 10, 'chubbuck', 0, 0, 0),
(84099, 10, 'caldwell', 0, 0, 0),
(84100, 12, 'bloomington', 0, 0, 0),
(84101, 12, 'evansville', 0, 0, 0),
(84102, 12, 'fort wayne', 0, 0, 0),
(84103, 12, 'indianapolis', 0, 0, 0),
(84104, 12, 'muncie / anderson', 0, 0, 0),
(84105, 12, 'lafayette / west lafayette', 0, 0, 0),
(84106, 12, 'south bend / michiana', 0, 0, 0),
(84107, 12, 'terre haute', 0, 0, 0),
(84108, 12, 'northwest indiana', 0, 0, 0),
(84109, 13, 'ames', 0, 0, 0);

I have been looking at this code most of the morning and do not have a clue what is wrong with the code. I am hoping its not a stupid mistake, can someone please help me out? thank you   

 
<title>Inputing Travel Detials</title>
 
<header>
  <h1 align="center"> Adding Travel Detials </h1>
  
 
  <body>
    <p>  <center><img  src="cyberwarfareimage1.png" alt="Squadron logo" style="width:200px;height:200px" style="middle"></center>
        <table border="1">
          <tr>
            <td><a href="index.php"> Home Page </a></td>
            <td><a href="administratorhomepage.html">Administrator Home Page </a></td>
            <td><a href="viewhomepage.html">View Home Page </a></td>
            <td><a href="Inputhomepage.html">Input Home Page </a></td>
            <td><a href="traveldetials.html">Enter More Travel Detials </a></td>
        </table>
    </p>
 
 
<?php
 
include "connection.php";
 
$Applicant_ID = $_POST["Applicant_ID"];
$Method_Of_Travel = $_POST["Method_Of_Travel"];
$Cost = $_POST["Cost"];
$ETA = $_POST["ETA"];
$Main_Gate_Advised = $_POST["Main_Gate_Advised"];
 
$query = ("UPDATE `int_board_applicant` SET `Method_Of_Travel`=`$Method_Of_Travel', `Cost`=`$Cost', `ETA`='$ETA', `Main_Gate_Advised`='$Main_Gate_Advised' WHERE `Applicant_ID`='$Applicant_ID'");
   
 
$result = mysqli_query($dbhandle, $query) 
    or die(mysqli_error($dbhandle));
 
if($result){ echo "Success!"; }
 
  else{ echo "Error."; }
 
 
// successfully insert data into database, displays message "Successful".
 if($query){
  echo "Successful";
}
 
  else {
  echo "Data not Submitted";
}
 
 
//closing the connection
   mysqli_close($dbhandle)
   
 
 
 
 
?>

Ok this is puzzleing. I am geting "Could not delete data: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '1' at line 1". but its is deleting the entry that needs to be removed. The "1" is the entry. Just not sure what is causing the error. I do have another delete php but I have put that on the back burning for the time being.     <?php

         $con = mysqli_connect("localhost","user","password","part_inventory");
    // Check connection
if (mysqli_connect_errno()) {
  printf("Connect failed: %s\n", mysqli_connect_error());
    exit();
} else {
    
    $result = mysqli_query($con, "SELECT * FROM amp20 ");
    
    $amp20ptid = $_POST['amp20ptid'];                // escape variables for security
    $amp20ptid = mysqli_real_escape_string($con, $_POST['amp20ptid']);
    
    mysqli_query($con, "DELETE FROM amp20 WHERE amp20ptid = '$amp20ptid'");
      
    
if (!mysqli_query($con, $amp20ptid));

{
 die('Could not delete data: ' . mysqli_error($con));    
}
 echo "Part has been deleted to the database!!!\n";
    mysqli_close($con);
}
?>

Hi guys   I have this code below and all works fine when submitting this online application apart from when someone types either ' # & into one of the comment fields in which it throws up the error. Have tried various fixes from across the internet but no joy. Can anyone offer suggestions?   <?php $con = mysql_connect("localhost:3306","root","password"); if (!$con)   {   die('Could not connect: ' . mysql_error());   } mysql_select_db('sfapp', $con); $sql="INSERT INTO 'sfapp' ('surname_add','forename_add','dob_add','hometele_add','mobiletele_add','homeadd_add','siblings_add','schoolname_add','headname_add','schooladd_add','schooltele_add','schoolem_add','alevel_add','personstate_add','nameprovided_add','pe_add','se_add','PredGrade_Art','PredGrade_AScience','PredGrade_BusStudies','PredGrade_Electronics','PredGrade_EnglishLang','PredGrade_EnglishLit','PredGrade_French','PredGrade_German','PredGrade_Geog','PredGrade_Graphics','PredGrade_History','PredGrade_Maths','PredGrade_SepScience','PredGrade_ProductDesign','PredGrade_Spanish','PredGrade_Other','Gender_Male','Gender_Female','Sub_EnglishLit','Sub_Maths','Sub_FurtherMaths','Sub_Biology','Sub_Chemistry','Sub_Physics','Sub_French','Sub_German','Sub_Spanish','Sub_Geography','Sub_History','Sub_RE','Sub_FineArt','Sub_Business','Sub_Computing','Sub_GlobPersp','Sub_DramaAndTheatre','Sub_PE','Sub_Dance','Sub_Politics','Sub_Psychology','Sub_Sociology','readprospect_chk','Sib_Yes','Sib_No','Current_Student_Yes','Current_Student_No','I_Understand_chk','Current_Education_chk','Local_Care_chk','Staff_Cwhls_chk','Sub_Film')   VALUES ('$_POST[surname_add]','$_POST[forename_add]','$_POST[dob_add]','$_POST[hometele_add]','$_POST[mobiletele_add]','$_POST[homeadd_add]','$_POST[siblings_add]','$_POST[schoolname_add]','$_POST[headname_add]','$_POST[schooladd_add]','$_POST[schooltele_add]','$_POST[schoolem_add]','$_POST[alevel_add]','$_POST[personstate_add]','$_POST[nameprovided_add]','$_POST[pe_add]','$_POST[se_add]','$_POST[PredGrade_Art]','$_POST[PredGrade_AScience]','$_POST[PredGrade_BusStudies]','$_POST[PredGrade_Electronics]','$_POST[PredGrade_EnglishLang]','$_POST[PredGrade_EnglishLit]','$_POST[PredGrade_French]','$_POST[PredGrade_German]','$_POST[PredGrade_Geog]','$_POST[PredGrade_Graphics]','$_POST[PredGrade_History]','$_POST[PredGrade_Maths]','$_POST[PredGrade_SepScience]','$_POST[PredGrade_ProductDesign]','$_POST[PredGrade_Spanish]','$_POST[PredGrade_Other]','$_POST[Gender_Male]','$_POST[Gender_Female]','$_POST[Sub_EnglishLit]','$_POST[Sub_Maths]','$_POST[Sub_FurtherMaths]','$_POST[Sub_Biology]','$_POST[Sub_Chemistry]','$_POST[Sub_Physics]','$_POST[Sub_French]','$_POST[Sub_German]','$_POST[Sub_Spanish]','$_POST[Sub_Geography]','$_POST[Sub_History]','$_POST[Sub_RE]','$_POST[Sub_FineArt]','$_POST[Sub_Business]','$_POST[Sub_Computing]','$_POST[Sub_GlobPersp]','$_POST[Sub_DramaAndTheatre]','$_POST[Sub_PE]','$_POST[Sub_Dance]','$_POST[Sub_Politics]','$_POST[Sub_Psychology]','$_POST[Sub_Sociology]','$_POST[readprospect_chk]','$_POST[Sib_Yes]','$_POST[Sib_No]','$_POST[Current_Student_Yes]','$_POST[Current_Student_No]','$_POST[I_Understand_chk]','$_POST[Current_Education_chk]','$_POST[Local_Care_chk]','$_POST[Staff_Cwhls_chk]','$_POST[Sub_Film]')"; if (!mysql_query($sql,$con))   {   die('Error: ' . mysql_error());   }   ?> <?php //if "email" variable is filled out, send email   if (isset($_REQUEST['pe_add']))  {     //Email information     $admin_email = $_REQUEST['pe_add'];   $forename = $_REQUEST['forename_add'];   $email = "autoreply@testing.com";   $subject = "Application";   $desc =   "Dear $forename   Thank you for submitting your online application, we will be in touch shortly. " ;       //send email   mail($admin_email, "$subject", "$desc", "From:" . $email);     //Email response   echo "Thank you for contacting us!";   }     //if "email" variable is not filled out, display the form   else  { ?> If you are seeing this, you need to go back and fill out the Personal Email section! <?php   }   header("location:complete.php"); mysql_close($con) ?>     Thanks in advance.

Hi..

I create mysql syntax for query testing before i input to my php code

here is my mysql code:

Code: [Select]
set @t = 0;
set @rqty=31968;
SELECT LOT_CODE as code,  DATE_ENTRY,   
CASE WHEN @t+OUTPUT_QTY > @rqty
THEN @rqty  -@t 
ELSE OUTPUT_QTY
END as qty,
@t := @t + d.OUTPUT_QTY as cumulative   
FROM dipping d  WHERE SUBSTR(LOT_CODE, 9,4) = 'P28' AND (@t < @rqty);

and i attach the sample output of the above query.

Now that query test is work i  will input that code to my php codes.


     $sql = "SELECT SKUCode, Materials, Comp, Qty 
     FROM bom  WHERE SKUCode = '$SKUCode'";
     $res = mysql_query($sql, $con);

    ($row = mysql_fetch_assoc($res));
     $Materials = $row['Materials'];
     $Qty = $row['Qty'];
     $Comp = $row['Comp']; //P28
//-----Compute Req Qty and Save to table---//     

     $ReqQty = $Qty * $POReq; // 31968


     
$sql = "UPDATE bom SET ReqQty = '$ReqQty' WHERE SKUCode = '$SKUCode' AND Materials = '$Materials'";
$resReqQty = mysql_query($sql, $con);

$t = 0;

$sql = "SELECT LOT_CODE as code,  DATE_ENTRY,   
CASE WHEN $t+OUTPUT_QTY > $ReqQty 
THEN $ReqQty  -$t  
ELSE OUTPUT_QTY 
END as qty,
$t := $t + d.OUTPUT_QTY as cumulative   
FROM dipping d  WHERE SUBSTR(LOT_CODE, 9,4) = '$Comp' AND ($t < $ReqQty)";



when I echo the query:

I got this:

 SELECT LOT_CODE as code, DATE_ENTRY, CASE WHEN 0+OUTPUT_QTY > 31968 THEN 31968 -0 ELSE OUTPUT_QTY END as qty, 0 := 0 + d.OUTPUT_QTY as cumulative FROM dipping d WHERE SUBSTR(LOT_CODE, 9,4) = 'P28' AND (0 < 31968)

then I run it to the sql

and I got an error:

Error Code : 1064
You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near ':= 0 + d.OUTPUT_QTY as cumulative FROM dipping d WHERE SUBSTR(LOT_CODE, 9,4) = '' at line 1
(0 ms taken)


Any help is highly appreciated

Thank you so much

Which of the below syntax is the better to be using?

$bal = 100;
if($bal  > 100)
{
echo "you have over 100 pounds;
}
else
{
echo "you have less than 100 pounds";
}

if ($bal > 100);
echo "you have over than 100";
else ;
echo "you have less than 100";
endif;

Hi,

Is this the correct way to go by setting cookies for my login 'remember' functionality?, I've posted the relevant login and logout code.

Login:

<?php
session_start();

//some code...

if (isset($_POST['remember'])) {

$expire = time() + 1728000; // Expire in 20 days

$site_domain = 'phpfreaks.com'; //example

$_SESSION['username'] = $_POST['username']; //don't worry this has been validated :D

$username = $_SESSION['username'];

//some sql query to fetch code..

$code = $row['code'];

setcookie('username', $username, $expire, NULL,  ".$site_domain", NULL, TRUE);

setcookie('code', $code, $expire, NULL, ".$site_domain", NULL, TRUE);

}
?>


Logout:

<?php
session_start();

if (isset($_COOKIE['username'])) {

$expire = time() - 1728000; // Expire in 20 days

$site_domain = 'phpfreaks.com'; //example

$username = $_SESSION['username'];

//some sql query to fetch code..

$code = $row['code'];

setcookie('username', $username, $expire, NULL, ".$site_domain", NULL, TRUE);

setcookie('code', $code, $expire, NULL, ".$site_domain", NULL, TRUE);

}

unset($_SESSION['username']);

$_SESSION = array();

session_destroy();
?>


Please tell me if it looks good to go and/or any improvements.

PS:

I want it accessible on all areas of the domain (including subdomains and paths etc.), and HTTP ONLY (so js can't access it) - I believe I've set the right parems?