PHP - Problem When Turning Register Globals = Off

Hello,

I changed my register table and it seems to have made it stop working, All's i changed is the layout of the 'Username, Email' etc so it looks better, nothing else, but the register button aint working!!

Old Code:
Code: [Select]
<table width="700" height="900" background="registerpic.jpg">
<tr valign="middle">
<td align="center">
<br>
<div align="center" class="style4">
  <? echo REGIS ?></div>
<table width="28%" border="0" align="center" cellpadding="0" cellspacing="0">
<form action="" method="post">

  <tr>
    <td><div align="right" class="style6 style1"><strong><? echo USEE ?></strong></div></td>
    <td width="9">:</td>
    <td width="192"><div align="left">
      <input name="reg_username" type="text" class="input" id="reg_username" value="" size="32" maxlength="64">
    </div></td>
  </tr>
  <tr>
    <td><div align="right" class="style6 style1"><strong><? echo PASSS ?></strong></div></td>
    <td><span class="style6 style1"><strong>:</strong></span></td>
    <td><div align="left">
      <input name="reg_password" type="password" class="input" id="reg_password" value="" size="32" maxlength="40">
    </div></td>
  </tr>
  <tr>
    <td><div align="right" class="style6 style1"><strong><? echo CONPASS ?></strong></div></td>
    <td><span class="style6 style1"><strong>:</strong></span></td>
    <td><div align="left">
      <input name="reg_password2" type="password" class="input" id="reg_password2" value="" size="32" maxlength="40">
    </div></td>
  </tr>
  <tr>
    <td><div align="right" class="style6 style1"><strong><? echo EM ?></strong></div></td>
    <td><span class="style6 style1"><strong>:</strong></span></td>
    <td><div align="left">
      <input name="email" type="text" class="input" id="username3" value="" size="32" maxlength="150" >
    </div></td>
  </tr>
  <tr>
    <td><div align="right" class="style6 style1"><strong><? echo GENDER ?></strong></div></td>
    <td><span class="style6 style1"><strong>:</strong></span></td>
    <td><div align="left">
      <select name="gender" class="input" id="starting" >
        <option value="Male"><? echo MALE ?></option>
        <option value="Female"><? echo FEMALE ?></option>
      </select>
    </div></td>
  </tr>
   <tr>
    <td><div align="right" class="style6 style1"><strong><? echo LANGU ?></strong></div></td>
    <td><span class="style6 style1"><strong>:</strong></span></td>
    <td><div align="left">
      <select name="lang" class="input" id="starting" >
        <option value="English"><? echo ENG ?></option>
        <option value="Turkish"><? echo TR ?></option>
      </select>
    </div></td>
  </tr>
  <tr>
    <td><div align="right" class="style5"><? echo START ?></div></td>
    <td><span class="style6 style1"><strong>:</strong></span></td>
    <td><div align="left">
      <select name="location" class="input" id="starting" >
        <option value="England" selected>England</option>
        <option value="Japan">Japan</option>
        <option value="Colombia">Colombia</option>
        <option value="Usa">Usa </option>
        <option value="Russia">Russia </option>
        <option value="Italy">Italy</option>
        <option value="Turkey">Turkey</option>
      </select>
      <input type="hidden" name="ref" value="<?php echo "$_GET[ref]"; ?>">
    </div></td>
  </tr>
   <tr>
    <td colspan="3"><div align="center">
      <p style="display: inline">&nbsp;</p>
      <p style="display: inline"><em><strong>
        <? echo SEC ?>      </strong></em></p>
    </div></td>
  </tr><tr>
      <td colspan="2" class="TableArea"><img src="eng/CaptchaSecurityImages.php" width="171" height="50" /></td>
      <td class="TableArea" valign="top"><fieldset>
        <legend><font color="#6F6F6F"><b><? echo SECC ?></b>:</font></legend>
        <span class="tablearea">
        <input id="security_code" class="button" name="security_code" size="20" type="text"/>
        </span>
        <span style="display: inline">
        <input name=Submit type=submit  value=  <? echo REGGG ?>  >
        </span>
      </fieldset></td>
    </tr>

  <tr>
    <td colspan="3"><div align="center"></div></td>
  </tr>
</table>
<center><p><b><font color= "ffffff"><? echo "$message"; ?></font></p>
<p>
</p></td>
<a href='register.php'><font size="1" color="#CCCCCC"><b><a href='index.php'>Home</a> - <a href='lost2.php'>Lost Password</a> - <a href='screens.php'>Screenshots</a></b></i></font>
<td align="center" width="238"></form>
</table>

New Code:
Code: [Select]
<div id="main">
      <img src="images/register(1).jpg">

<form action="" method="post">
      <div id="register_table">
        <div class="row">
          <div class="title_column">Username</div>
          <div class="space_column">~</div>
          <div class="input_column"><input type="text" name="reg_username" id="reg_username" value="" class="text" /></div>
        </div>
        <div class="row">

          <div class="title_column">Email</div>
          <div class="space_column">~</div>
          <div class="input_column"><input type="text" name="username3" id="username3" value="" class="text" /></div>
        </div>
        <div class="row">
          <div class="title_column">Password</div>
          <div class="space_column">~</div>

          <div class="input_column"><input type="text" name="reg_password" id="reg_password"  value="" class="text" /></div>
        </div>
        <div class="row">
          <div class="title_column">Retype Pass</div>
          <div class="space_column">~</div>

          <div class="input_column"><input type="text" name="reg_password2" id="reg_password2"  value="" class="text" /></div>
        </div>
        <div class="row">
          <div class="title_column">Gender</div>
          <div class="space_column">~</div>
          <div class="input_column"><select name="gender" style="font-size:9px;font-family:Tahoma;width:130px;"><option value="Male">Male</option><option value="Female">Female</option></select></div>
        </div>

        <div class="row">
          <div class="title_column">Location</div>
          <div class="space_column">~</div>
          <div class="input_column"><select name="starting" style="font-size:9px;font-family:Tahoma;width:130px;"><option value="England">England</option><option value="Japan">Japan</option><option value="Colombia">Colombia</option><option value="USA">USA</option><option value="Russia">Russia</option><option value="Italy">Italy</option><option value="Turkey">Turkey</option></select></div>
        </div>

        <div class="row">
          <div class="title_column" style="padding-top: 2px; margin-top: 2px;"><img src="eng/CaptchaSecurityImages.php" alt="Verify" /></div>
          <div class="space_column">~</div>
          <div class="input_column"><input type="text" name="security_code" id="security_code" value="" class="text" /></div>
        </div>

        <br />
      <div style="text-align:center;"><input type="submit" name="submit" value="<? echo Register ?>" class="submit" />
      </div>
<? echo "$message"; ?>
</form></div>
Thanks Guys!

Ok so im working on this register script and trying to implement a select value field along with a email field and password field. At the moment i have given it my best shot and typed in most of the code, although im still not satisfied with the outcome.

For example: When i type in a correct email with a legit password, and i DONT select one of the drop down options, i want it to say the error: "Please type in all fields.". This would be vise versa for each other field also!

If the user again types in a legit email and password, and selects a value from the dropdown menu, but is already registered in the database, i would want another error message saying: "This club has already been registered to the database".

I given it my best shot but simply not getting the above result.

<?php include"database.php";?>     <html><head><title>Register</title></head><body><h1>Register</h1><form name="register" action="register.php" method="post">Email: <input type="text" name="email"><br>Password: <input type="password" name="password"><br>Club: <select name="club">    <option value="">Select...</option>    <option value="npob">Old Boys</option>    <option value="tukupa">Tukupa</option>    <option value="coastal">Coastal</option>    <option value="inglewood">Inglewood</option>    <option value="clifton">Clifton</option>    <option value="stratford">Stratford</option>    <option value="hawera">Hawera</option>  </select><br><input type='submit' name='submit' value='Submit'></form>     <?php     if (isset($_POST['submit'])) {              if (empty($_POST['email']) && empty($_POST['password']) && empty($_POST['club']))  {         $errors[] = "Please fill out all fields.";         }              $email = addslashes(strip_tags($_POST['email']));     $password = addslashes(strip_tags($_POST['password']));     $club = addslashes(strip_tags($_POST['club']));          if (!empty($email)) {         if (!filter_var($email, FILTER_VALIDATE_EMAIL)) {         $errors[] =  "This email address is not valid.";         }         }          if (!empty($password)){         if (strlen($password)>25 || strlen($password)<6) {         $errors[] =  "Password must be betwen 6 and 25 characters.<br>";         }         }         if (!empty($club)){          $errors[] =  "Please select a Club.<br>";          }       $check = mysql_query("SELECT * FROM users WHERE email='".$email."'");         if (mysql_num_rows($check)>=1) {         $errors[] =  "Email is already taken!";         }      $check = mysql_query("SELECT * FROM users WHERE club='".$club."'");      if (mysql_num_rows($check)>=1) {      $errors[] =  "Sorry this club has already been registered with the NZRU.";      }                  if (empty($errors)) {         $register = mysql_query("INSERT INTO users (email, password, club, level) VALUES ('".$email."', '".md5($password)."', '".$club."', '')");         echo "You have succesfully registered!";                              } else {                                  foreach($errors as $nErrors){         echo $nErrors . "<br>";                         }                     }                 } ?>()

Thankyou.

Hi everyone, im working on a e comm site as a project.
I have a register.php page, and its supposed to check for the presence of posted data, and if data is not posted show a form block,and if posted data is present insert it into a database.
However its not working,i get an unexpected } on line 114, where there is a }else{ .
I've only been working with php a few days, but from what i've read the braces seem where they should be,can someone please tell me where the problem is?
<script language="JavaScript" type="text/javascript" src="library/checkout.js"></script>
<?php
//set up a couple of functions
function doDB() {
global $mysqli;

//connect to server and select database; you may need it
$mysqli = mysqli_connect("localhost", "root", "", "onlinestore");
}
//determine if they need to see the form or not
if (!$_POST) {
//they need to see the form, so create form block
$display_block = "

<form name=\"register\" method=\"post\"action=\"index.php?r=1\"\ id=\"register\">
<table width=\"550\" border=\"0\" align=\"center\" cellpadding=\"5\" cellspacing=\"1\" class=\"entryTable\">
        <tr class=\"entryTableHeader\"> 
            <td colspan=\"2\">Login Details</td>
        </tr>
        <tr> 
            <td width=\"150\" class=\"label\">Email</td>
            <td class=\"content\"><input name\=\"txtEmail\" type=\"text\" class=\"box\" id=\"txtEmail\" size=\"30\" maxlength=\"50\"></td>
        </tr>
        <tr> 
            <td width=\"150\" class=\"label\">Password</td>
            <td class=\"content\"><input name=\"txtPassword\" type=\"password\" class=\"box\" id=\"txtPassword\" size=\"30\" maxlength=\"50\"></td>
        </tr>
    </table>
    <p>&nbsp;</p>    
      <table width=\"550\" border=\"0\" align=\"center\" cellpadding=\"5\" cellspacing=\"1\" class=\"entryTable\">
        <tr class=\"entryTableHeader\"> 
            <td colspan=\"2\">Shipping Information</td>
        </tr>
        <tr> 
            <td width=\"150\" class=\"label\">First Name</td>
            <td class=\"content\"><input name=\"txtShippingFirstName\" type=\"text\" class=\"box\" id=\"txtShippingFirstName\" size=\"30\" maxlength=\"50\"></td>
        </tr>
        <tr> 
            <td width=\"150\" class=\"label\">Last Name</td>
            <td class=\"content\"><input name=\"txtShippingLastName\" type=\"text\" class=\"box\" id=\"txtShippingLastName\" size=\"30\" maxlength=\"50\"></td>
        </tr>
        <tr> 
            <td width=\"150\" class=\"label\">Address1</td>
            <td class=\"content\"><input name=\"txtShippingAddress1\" type=\"text\" class=\"box\" id=\"txtShippingAddress1\" size=\"50\" maxlength=\"100\"></td>
        </tr>
        <tr> 
            <td width=\"150\" class=\"label\">Address2</td>
            <td class=\"content\"><input name=\"txtShippingAddress2\" type=\"text\" class=\"box\" id=\"txtShippingAddress2\" size=\"50\" maxlength=\"100\"></td>
        </tr>
        <tr> 
            <td width=\"150\" class=\"label\">Phone Number</td>
            <td class=\"content\"><input name=\"txtShippingPhone\" type=\"text\" class=\"box\" id=\"txtShippingPhone\" size=\"30\" maxlength=\"32\"></td>
        </tr>
        <tr> 
            <td width=\"150\" class=\"label\">Area</td>
            <td class=\"content\"><input name=\"txtShippingState\" type=\"text\" class=\"box\" id=\"txtShippingState\" size=\"30\" maxlength=\"32\"></td>
        </tr>
        <tr> 
            <td width=\"150\" class=\"label\">City</td>
            <td class=\"content\"><input name=\"txtShippingCity\" type=\"text\" class=\"box\" id=\"txtShippingCity\" size=\"30\" maxlength=\"32\"></td>
        </tr>
        <tr> 
            <td width=\"150\" class=\"label\">Post Code</td>
            <td class=\"content\"><input name=\"txtShippingPostalCode\" type=\"text\" class=\"box\" id=\"txtShippingPostalCode\" size=\"10\" maxlength=\"10\"></td>
        </tr>
    </table>
    <p>&nbsp;</p>
    <table width=\"550\" border=\"0\" align=\"center\" cellpadding=\"5\" cellspacing=\"1\" class=\"entryTable\">
        <tr class=\"entryTableHeader\"> 
            <td width=\"150\">Payment Information</td>
            <td><input type=\"checkbox\" name=\"chkSame\" id=\"chkSame\" value=\"checkbox\" onClick=\"setPaymentInfo(this.checked);\"> 
                <label for=\"chkSame\" style=\"cursor:pointer\">Same as shipping information</label></td>
        </tr>
        <tr> 
            <td width=\"150\" class=\"label\">First Name</td>
            <td class=\"content\"><input name=\"txtPaymentFirstName\" type=\"text\" class=\"box\" id=\"txtPaymentFirstName\" size=\"30\" maxlength=\"50\"></td>
        </tr>
        <tr> 
            <td width=\"150\" class=\"label\">Last Name</td>
            <td class=\"content\"><input name=\"txtPaymentLastName\" type=\"text\" class=\"box\" id=\"txtPaymentLastName\" size=\"30\" maxlength=\"50\"></td>
        </tr>
        <tr> 
            <td width=\"150\" class=\"label\">Address1</td>
            <td class=\"content\"><input name=\"txtPaymentAddress1\" type=\"text\" class=\"box\" id=\"txtPaymentAddress1\" size=\"50\" maxlength=\"100\"></td>
        </tr>
        <tr> 
            <td width=\"150\" class=\"label\">Address2</td>
            <td class=\"content\"><input name=\"txtPaymentAddress2\" type=\"text\" class=\"box\" id=\"txtPaymentAddress2\" size=\"50\" maxlength=\"100\"></td>
        </tr>
        <tr> 
            <td width=\"150\" class=\"label\">Phone Number</td>
            <td class=\"content\"><input name=\"txtPaymentPhone\" type=\"text\" class=\"box\" id=\"txtPaymentPhone\" size=\"30\" maxlength=\"32\"></td>
        </tr>
        <tr> 
            <td width=\"150\" class=\"label\">Area</td>
            <td class=\"content\"><input name=\"txtPaymentState\" type=\"text\" class=\"box\" id=\"txtPaymentState\" size=\"30\" maxlength=\"32\"></td>
        </tr>
        <tr> 
            <td width=\"150\" class=\"label\">City</td>
            <td class=\"content\"><input name=\"txtPaymentCity\" type=\"text\" class=\"box\" id=\"txtPaymentCity\" size=\"30\" maxlength=\"32\"></td>
        </tr>
        <tr> 
            <td width=\"150\" class=\"label\">Post Code</td>
            <td class=\"content\"><input name=\"txtPaymentPostalCode\" type=\"text\" class=\"box\" id=\"txtPaymentPostalCode\" size=\"10\" maxlength=\"10\"></td>
        </tr>
    </table>
    <p>&nbsp;</p>

    <p>&nbsp;</p>
    <p align=\"center\"> 
        <input class=\"box\" name=\"btnStep1\" type=\"submit\" id=\"btnStep1\" value=\"Proceed &gt;&gt;\">
    </p>
</form>" 
} else {
//connect to database
doDB();
//add records
$add_sql = "INSERT INTO tbl_customer (email) VALUES('".$_POST["txtEmail"]."')";
$add_sql = "INSERT INTO tbl_customer (password) VALUES('".$_POST["txtPassword"]."')";

$add_sql = "INSERT INTO tbl_customer (od_shipping_first_name) VALUES('".$_POST["txtShippingFirstName"]."')";
$add_sql = "INSERT INTO tbl_customer (od_shipping_last_name) VALUES('".$_POST["txtShippingLastName"]."')";
$add_sql = "INSERT INTO tbl_customer (od_shipping_address1) VALUES('".$_POST["txtShippingAddress1"]."')";
$add_sql = "INSERT INTO tbl_customer (od_shipping_address2) VALUES('".$_POST["txtShippingPhone"]."')";
$add_sql = "INSERT INTO tbl_customer (od_shipping_phone) VALUES('".$_POST["txtShippingState"]."')";
$add_sql = "INSERT INTO tbl_customer (od_shipping_city) VALUES('".$_POST["txtShippingCity"]."')";
$add_sql = "INSERT INTO tbl_customer (od_shipping_state) VALUES('".$_POST["txtShippingState"]."')";
$add_sql = "INSERT INTO tbl_customer (od_shipping_postal_code) VALUES('".$_POST["txtShippingPostalCode"]."')";

$add_sql = "INSERT INTO tbl_customer (od_payment_first_name) VALUES('".$_POST["txtPaymentFirstName"]."')";
$add_sql = "INSERT INTO tbl_customer (od_payment_last_name) VALUES('".$_POST["txtPaymentLastName"]."')";
$add_sql = "INSERT INTO tbl_customer (od_payment_address1) VALUES('".$_POST["txtPaymentAddress1"]."')";
$add_sql = "INSERT INTO tbl_customer (od_payment_address2) VALUES('".$_POST["txtPaymentPhone"]."')";
$add_sql = "INSERT INTO tbl_customer (od_payment_phone) VALUES('".$_POST["txtPaymentState"]."')";
$add_sql = "INSERT INTO tbl_customer (od_payment_city) VALUES('".$_POST["txtPaymentCity"]."')";
$add_sql = "INSERT INTO tbl_customer (od_payment_state) VALUES('".$_POST["txtPaymentState"]."')";
$add_sql = "INSERT INTO tbl_customer (od_payment_postal_code) VALUES('".$_POST["txtPaymentPostalCode"]."')";


$add_res = mysqli_query($mysqli, $add_sql) or die(mysqli_error($mysqli));
$display_block = "<p>Thanks for signing up!</p>";
}
?>

Hey, so this is my register script 

<?php

error_reporting(E_ALL | E_NOTICE);
ini_set('display_errors', 1);
require 'connect.php';

echo "<title>  Register  </title>";

if(isset($_POST['register'])) {

	$username = trim($_POST['username']);
	$username = mysqli_real_escape_string($con, $_POST['username']);
	$password = mysqli_real_escape_string($con, $_POST['password']);
	$password = hash('sha512', $_POST['password']);

	if(!$_POST['username'] OR !$_POST['password']) {

		die("You must enter a username and password!");

	}


	

	$stmt = $con->prepare("INSERT INTO usrs_usr (username, password) VALUES (?, ?)");
	$stmt->bind_param("ss", $username, $password);
	$stmt->get_result();
	var_dump($stmt);
	$stmt->execute();
	
	

	echo "New user has been created successfully";

	$stmt->close();
	$conn->close();

}

?>

Now the problem is i have done a variable dump which outputs nothing, and the only error i am getting is

Fatal error: Call to a member function bind_param() on a non-object

Almost every time when I read about globals, programmers discourage their use. I have a function where I need to send back some variables (which I will use in a query) so I need to use globals. Below is the function and query. I'm trying to figure out if it's ok to use globals in it.

function paginate($connection, $tableName) {
//the forsaken globals
global $limit; 
global $start;

//Pagination
$targetpage = "http://localhost/website/untitled2.php"; 
$limit = 4; 

//count rows
$sql = "SELECT COUNT(*) as num FROM $tableName";
$total_pages = $connection->query($sql) or die(mysqli_error($connection)); 
$row = $total_pages->fetch_assoc();
$total_pages = $row['num'];

//if there's no page number, set it to the first page
$stages = 3;
$page = isset($_GET['page']) ? $_GET['page'] : 0;
$start = empty($page) ? 0 : ($page - 1) * $limit;

// Initial page num setup
if ($page == 0){$page = 1;}
$prev = $page - 1;
$next = $page + 1;
$lastpage = ceil($total_pages/$limit);
$LastPagem1 = $lastpage - 1;


$paginate = '';
if($lastpage > 1)
{

$paginate .= "<div class='paginate'>";
// Previous
if ($page > 1){
$paginate.= "<a href='$targetpage?page=$prev'>previous</a>";
}else{
$paginate.= "<span class='disabled'>previous</span>"; }



// Pages
if ($lastpage < 7 + ($stages * 2)) // Not enough pages to breaking it up
{
for ($counter = 1; $counter <= $lastpage; $counter++)
{
if ($counter == $page){
$paginate.= "<span class='current'>$counter</span>";
}else{
$paginate.= "<a href='$targetpage?page=$counter'>$counter</a>";}
}
}
elseif($lastpage > 5 + ($stages * 2)) // Enough pages to hide a few?
{
// Beginning only hide later pages
if($page < 1 + ($stages * 2))
{
for ($counter = 1; $counter < 4 + ($stages * 2); $counter++)
{
if ($counter == $page){
$paginate.= "<span class='current'>$counter</span>";
}else{
$paginate.= "<a href='$targetpage?page=$counter'>$counter</a>";}
}
$paginate.= "...";
$paginate.= "<a href='$targetpage?page=$LastPagem1'>$LastPagem1</a>";
$paginate.= "<a href='$targetpage?page=$lastpage'>$lastpage</a>";
}
// Middle hide some front and some back
elseif($lastpage - ($stages * 2) > $page && $page > ($stages * 2))
{
$paginate.= "<a href='$targetpage?page=1'>1</a>";
$paginate.= "<a href='$targetpage?page=2'>2</a>";
$paginate.= "...";
for ($counter = $page - $stages; $counter <= $page + $stages; $counter++)
{
if ($counter == $page){
$paginate.= "<span class='current'>$counter</span>";
}else{
$paginate.= "<a href='$targetpage?page=$counter'>$counter</a>";}
}
$paginate.= "...";
$paginate.= "<a href='$targetpage?page=$LastPagem1'>$LastPagem1</a>";
$paginate.= "<a href='$targetpage?page=$lastpage'>$lastpage</a>";
}
// End only hide early pages
else
{
$paginate.= "<a href='$targetpage?page=1'>1</a>";
$paginate.= "<a href='$targetpage?page=2'>2</a>";
$paginate.= "...";
for ($counter = $lastpage - (2 + ($stages * 2)); $counter <= $lastpage; $counter++)
{
if ($counter == $page){
$paginate.= "<span class='current'>$counter</span>";
}else{
$paginate.= "<a href='$targetpage?page=$counter'>$counter</a>";}
}
}
}

// Next
if ($page < $counter - 1){ 
$paginate.= "<a href='$targetpage?page=$next'>next</a>";
}else{
$paginate.= "<span class='disabled'>next</span>";
}

$paginate.= "</div>";


}
 echo $total_pages.' Results';
 // pagination
 echo $paginate;
 
}//end function


and this is how I'm using the function. Without the globals I would get undefined vars $start and $limit used in the query below.


paginate($connection, "categories"); 

$sql = "SELECT * FROM categories ORDER BY cat_name LIMIT $start, $limit";
$cats_result = $connection->query($sql) or die(mysqli_error($connection)); 
while ($row = $cats_result->fetch_assoc()) { 
$cat_id = $row['cat_id'];
$cat_name = $row['cat_name'];
$cat_desc = $row['cat_desc'];

...etc


Am I using the globals properly?