PHP - 1 Added To Included String

Hi,

I'm trying to write myself a tiny MVC framework and having some trouble:
Code: [Select]
<?php
class One {
    public function main (  ) {
        $var = 'Hello';
        include ( 'file.php' );
        }
}
?>file.php:
Code: [Select]
<?php echo $var; ?>This doesn't work.  Is there any way without setting that variable to global, to reach it like that?

Hi All,

I'm trying to secure my web app which is currently in development, and came across this issue.

I have a header.php and footer.php page which are included to every page, with the content in the middle. The problem is, if you visit header.php then it displays the header, with some blank text.

What is the best way to protect this - i.e., if visited directly, it re-directs to index.php etc.

My initial thought is to set a $happylink on each page and in the header and footer, checking basically doing the following


if (isset($happylink) && !empty($happylink))
{
     blah blah;
}
else
{
     Header("Location: index.php");
}

Would that be the best way? Is there something easier?

I understand that this is a header error but i still do not know how to fix it.
I am trying to create a login box that is in the top right corner of my site. Once the user uses it to log in they need to be redirected to the account page. i include the login_box.php file in the appropriate div. however the file uses header("Location: account.php"); to redirect the user. because this file is included after the header i receive Warning: Cannot modify header information - headers already sent by (output started at C:\xampp\htdocs\index.php:17) in C:\xampp\htdocs\layout_inc\login_box.php on line 76
What would be the correct way to do this. My code is bellow. Thank you in advance
<?php 
//Forms posted

if(!empty($_POST))
{
$errors = array();
$username = trim($_POST["username"]);
$password = trim($_POST["password"]);
$remember_choice = trim($_POST["remember_me"]);

//Perform some validation
//Feel free to edit / change as required
if($username == "")
{
$errors[] = lang("ACCOUNT_SPECIFY_USERNAME");
}
if($password == "")
{
$errors[] = lang("ACCOUNT_SPECIFY_PASSWORD");
}

//End data validation
if(count($errors) == 0)
{
//A security note here, never tell the user which credential was incorrect
if(!usernameExists($username))
{
$errors[] = lang("ACCOUNT_USER_OR_PASS_INVALID");
}
else
{
$userdetails = fetchUserDetails($username);

//See if the user's account is activation
if($userdetails["Active"]==0)
{
$errors[] = lang("ACCOUNT_INACTIVE");
}
else
{
//Hash the password and use the salt from the database to compare the password.
$entered_pass = generateHash($password,$userdetails["Password"]);

if($entered_pass != $userdetails["Password"])
{
//Again, we know the password is at fault here, but lets not give away the combination incase of someone bruteforcing
$errors[] = lang("ACCOUNT_USER_OR_PASS_INVALID");

}
else
{
//Passwords match! we're good to go'

//Construct a new logged in user object
//Transfer some db data to the session object
$loggedInUser = new loggedInUser();
$loggedInUser->email = $userdetails["Email"];
$loggedInUser->user_id = $userdetails["User_ID"];
$loggedInUser->hash_pw = $userdetails["Password"];
$loggedInUser->display_username = $userdetails["Username"];
$loggedInUser->clean_username = $userdetails["Username_Clean"];
$loggedInUser->remember_me = $remember_choice;
$loggedInUser->remember_me_sessid = generateHash(uniqid(rand(), true));
//Update last sign in
$loggedInUser->updateLastSignIn();

if($loggedInUser->remember_me == 0)
$_SESSION["userCakeUser"] = $loggedInUser;
else if($loggedInUser->remember_me == 1) {
$db->sql_query("INSERT INTO ".$db_table_prefix."Sessions VALUES('".time()."', '".serialize($loggedInUser)."', '".$loggedInUser->remember_me_sessid."')");
setcookie("userCakeUser", $loggedInUser->remember_me_sessid, time()+parseLength($remember_me_length));
}

//Redirect to user account page

header("Location: account.php");
die();
}
}
}
}
}

if(!isUserLoggedIn()) {?><form name="newUser" action="<?php echo $_SERVER['PHP_SELF'] ?>" method="post">
                <table>
<tr>
<td>
<label>Username:</label>
</td>
<td>
<input type="text" name="username" />
</td>
</tr>
<tr>
<td>
<label>Password:</label>
</td>
<td>
<input type="password" name="password" />
</td>
</tr>
<tr>
<td>
<label>&nbsp;</label>
<input type="submit" value="Login" class="submit"/>
</td>
<td>
<input type="checkbox" name="remember_me" value="1" /> <label style="font-size:12px">Remember Me?</label>
</td>
</tr>
</table>
<div style="text-align:center;">
<a href="register.php" class="info">Register</a> | <a href="forgot-password.php" class="info">Forgot Password?</a>
</div>
</form><?php }
else{?><h1>Welcome <?php echo $loggedInUser->display_username; ?> </h1>
 <br/>

<a href="account.php" class="info">Dashboard</a> | <a href="logout.php" class="info">Logout</a><?php }

?>

Hello:

I have this code in an included file:
myNav.php
Code: [Select]
function spLeftMenu() {
$spLeftMenu =
"
<p>
<div id=\"myLeftNavPaper\">
<img src=\"images/sidePaperTop.png\" alt=\"\" />

<div id=\"myLeftNavPaper2\">

echo \". $mySideBarPageData .\"

</div>

<img src=\"images/sidePaperBottom.png\" alt=\"\" />
</div>

</p>

";
return $spLeftMenu;
}

I can not get:
Code: [Select]
echo \". $mySideBarPageData .\"

To display the results on this page:
Page.php
Code: [Select]
<html>
...

<?php echo spLeftMenu(); ?>

...
</html>


What am I missing ??

Hi,

Im in trouble with a script. Mainly the problem is that the declared value is not reachable.

lets sai i have main.php file where i declare that

$user_id = '22';
and then i include a file that needs to get that value to work
include('somescript.php');

now when i go over to the somescript.php i write at the top that print $user_id; and i get nothing.

What am i doing wrong?