PHP - Php Upload Script

Hey guys!! i'm after a bit of help with a script i am using for simple image upload to server.

At the moment the script works fine and will allow upload of JPG files, i want to extend on this to allow GIF and PNG files to be uploaded aswell.

This is the script i am using...

<?php
//?heck that we have a file
if((!empty($_FILES["uploaded_file"])) && ($_FILES['uploaded_file']['error'] == 0)) {
  //Check if the file is JPEG image and it's size is less than 600Kb
  $filename = basename($_FILES['uploaded_file']['name']);
  $ext = substr($filename, strrpos($filename, '.') + 1);
  if (($ext == "jpg") && ($_FILES["uploaded_file"]["type"] == "image/jpeg") && 
    ($_FILES["uploaded_file"]["size"] < 600000)) {
    //Determine the path to which we want to save this file
      $newname = dirname(__FILE__).'/uploads/'.$filename;
      //Check if the file with the same name is already exists on the server
      if (!file_exists($newname)) {
        //Attempt to move the uploaded file to it's new place
        if ((move_uploaded_file($_FILES['uploaded_file']['tmp_name'],$newname))) {
           echo "Upload Complete! You can use the following link in the IMS:" .$newname;
        } else {
           echo "Error: A problem occurred during file upload!";
        }
      } else {
         echo "Error: File ".$_FILES["uploaded_file"]["name"]." already exists";
      }
  } else {
     echo "Error: Only .jpg images under 600Kb are accepted for upload";
  }
} else {
 echo "Error: No file uploaded";
}

 // $sessionid=session_id()
  //$newname=$_SESSION['session_name']
  header( 'Location: success.php?newname1='.$filename ) ;


?>


Any help would be appriciated!!

ta!! jonny

It says error unexpecting T_ELSE on line 50...Any help is appreciated

<?php



if (is_uploaded_file($file_tmp)){

///SUPPORTED IMAGE TYPES

$tgif = "IMAGETYPE_GIF";
$tjpeg = "IMAGETYPE_JPEG";
$tpng = "IMAGETYPE_PNG";
$twsf = "IMAGETYPE_SWF";
$tbmp = "IMAGETYPE_BMP";
 
 $file_size = $_FILES["file"]["size"];
 $file_tmp = $_FILES['file']['tmp_name'];
 $file_name = $_FILES["file"]["name"] ;
 $file_type = $_FILES["file"]["type"];
 $file = $file_name . $file_type;


$path = "images/" . $title_id . "/";
$path - $path . basename($file_name);

 

   if (exif_imagetype('$file') != $tgif || $tjpeg || $tjpng || $twsf || $tbmp){ 


        if ($file_size < 20000000){     /////20mb/////
           

if (file_exists($path . $file_name)){


if (move_uploaded_file($file_tmp,$path)){

$msg = "File upload successful";
}

else{
$msg = "There was an error";
}

}else{
$msg = "This file already exists on the server";
{


}else{
 $msg = "File size is too large";
  }  
 
}else{
$msg = "File type not supported";
}


}else{
$file = "";
}







?>

Alright guys, i have been looking for a simple script for this online to try get my head around it. I need a script thats is going to take an image and save the orginal file along with two modified files (small and medium thumbnail). I really cant get my head around the ones i have already seen so i was wondering if anyone had any advice or a link they can post me to that can help me.

Hello,

I'm planning on making a website where people are able to upload files and directly link to them. Ideally, I want to keep the same file names that the people use when they upload the file. I was planning on keeping the directory that stored all of the files outside of the www directory and disable execute permissions. However, how would I avoid file overwriting with the same file name?

I need to set my script here to change the CHMOD settings to 644.  The images that are uploaded into the Yahoo server are not able to be accessed.  I believe this is the CHMOD, however I have never worked with CHMOD.  Please help, or if you notice an error in my coding please let me know.

Code: [Select]
<?php


$Name = $_POST['Name'];
$Pic = $_FILES["file"] ["name"];

if ((($_FILES["file"] ["type"] == "image/gif")
    || ($_FILES["file"] ["type"] == "image/jpeg")
    || ($_FILES["file"] ["type"] == "image/pjpeg"))
    && ($_FILES["file"] ["size"] < 100000))
      {
      if ($_FILES["file"] ["error"] > 0)
        {
     echo "Return Code: " . $_FILES["file"] ["error"] . "<br />";
     }
      else
        {
    
     if (file_exists("../Graphics/" . $_FILES["file"] ["name"]))
       {
  
  include("../Admin/photos.php");
  
       echo $_FILES["file"] ["name"] . " already exists. ";
       }
     else
       {          

       move_uploaded_file($_FILES["file"] ["tmp_name"],
       "../Graphics/" . $_FILES["file"] ["name"]);

          chmod("$pic",0644);
  
      }
      }
    }
  else
      {
  
       echo "<font size='5' face='Arial'><b>Invalid file</b></font>";
      }

  $Category = $_POST['Category'];

              include('database.php');

                  mysql_select_db("bluemoonmastiff", $con);
                
                  $good_data = $_POST;
                  
                  foreach($good_data as $field => $value)
                  {
                    if($field != "submitted")
                 {
                    $field_array[] = $field;
                    $clean = strip_tags(trim($value));
                    $escaped = mysqli_real_escape_string($cxn,$clean);
                    $value_array[] = $escaped;
                 }
                  }
                  
                  $fields = implode(",",$field_array);
                  $values = implode('","',$value_array);

                  $sql = "INSERT INTO gallery SET Name='$Name',PicAddress='Graphics/$Pic',Category='$Category'";
                  
                   if (!mysql_query($sql,$con))
  {
  die('Error: ' . mysql_error());
  }

 

echo "<font size='5' face='Arial'><b>Picture Upload Complete</b></font>";

?>

Hi All
Not so much help as here is a handy class for uploading images
Please feel free to find security bugs and let me know.
Also feel free to use it if you want.

http://onlyican.com/test_samples/bl_upload_img.phps

To use the class, simply use the following

require_once('bl_upload_img.php');
$objUploadImg = new UploadImg();
//Set values here if you wish such as 
$objUploadImg->setFormField('myFormField'); // The Name from <input type="file" name="myFormField" />
$objUploadImg->setSaveDirMain($_SERVER['DOCUMENT_ROOT'].'/MyImageFolder'; //Make sure to set the permissions

//You can change most settings, just look at the function setDetaultValues() to get the function name
//Now upload the image
if($objUploadImg->uploadImage()){
  $strFileName = $objUploadImg->getFileNameMain();

  }else{
  echo 'Error uploading Image<br />'.$objUploadImg->getErrorMessage();

  }

hey guys im trying to make a file upload script so that when the user uploads a pic it gets shown in a div...when you add another it is the added by the side of the 1st pic...but some reason when selecting a image nothing shows...   what am i doing wrong?   here is my code below if anyone can tell me what it is wrong im doing...thank you

<script src="//ajax.googleapis.com/ajax/libs/jqueryui/1.11.2/jquery-ui.min.js"></script>
<meta http-equiv="Content-Type" content="text/html; charset=ISO-8859-1">
<title>Insert title here</title>
<script>
$( document ).ready(function() {
	
	var files       = $('.input-file').prop("files");
	var file_count  = files.length;
	
	var names = $.map(files, function(val) { 
		return val.name; 
	});
	
	$('#input-file-button').click(function() {
		$('.input-file').click(); 
	});
	
	$('.input-file').change(function (){
		var file_name = $(this).val();
		var file_path = URL.createObjectURL(event.target.files[0]);

		$('#uploaded-images').append('<div><img src="'+ file_path +'" /></div>' + file_name);	
	 });
		
	if (file_count < 1)
	{
		$('#uploaded-images').text("No images are selected.");
	}
});


</script>
<style>
.input-file
{
	display: none;
}
</style>
</head>
<body>
<div id="uploaded-images"></div>
<br />
<input type="file" name="files[]" class="input-file"/><span id='input-file-button'>Upload Photo</span>
</body>
</html>

im getting a warning saying 'Warning: mkdir() [function.mkdir]: File exists in /home/multisea/public_html/BSGN/secure_upload.php on line 5' if i execute the script below

Code: [Select]
<?php
$secure_folder = "upimg/$rand/$time";
$rand=rand(0000000000,9999999999);
$time=time();
mkdir("$secure_folder", 0777);
echo "secure folder made successfully... not done yet so dont close this window...";
$target = "$secure_folder";
$target = $target . basename( $_FILES['uploaded']['name']) ;
$ok=1;
 if ($uploaded_size > 1500000) 
 { 
 echo "Your file is too large.<br>"; 
 $ok=0; 
 } 
 if ($ok==0)
 {
 echo "sorry your file was not uploaded...";
 }
 else
 {if(move_uploaded_file($_FILES['uploaded']['tmp_name'], $target))
 {echo "the file ". basename( $_FILES['uploadedfile']['name']). "hasbeen uploaded the link to your file is http://multi-search.org/BSGN/$secure_folder/". basename( $_FILES['uploaded']['name'])."<br />";
 }
 else
 {echo "sorry, there was a problem uploading your file.";
 }
 }
 ?>

Code: [Select]
<?php
    // Maximum file size for upload
    $maxFileSize = 5242880;
    
    // If file is too large
    if(!empty($_SERVER['CONTENT_LENGTH']) && $_SERVER['CONTENT_LENGTH'] > $maxFileSize)
        echo "File too large";
    else
    {
        if(isset($_POST['submit']))
        {
            // List of acceptable file types
            $whitelist = array(
                "application/vnd.openxmlformats-officedocument.wordprocessingml.document",    // .docx
                "application/msword",                                                        // .doc, .rtf
                "text/plain",
                "image/jpeg",
                "image/gif",
                "image/png",
                "application/pdf",
                "application/octet-stream",                                                    // .rar
                "application/x-zip"                                                            // .zip
            );
            
            // Is uploaded file type in whitelist array
            if(!in_array($_FILES['file_upload']['type'], $whitelist))
                exit("Bad Filetype");
            
            // Don't allow php files
            if(preg_match("/\.php.*$/i", $_FILES['file_upload']['name']))
                exit("We do not allow uploading PHP files\n");
            
            // Move the file
            $uploaddir = '../uploads/';
            $uploadfile = $uploaddir . "[" . time(). "]." . basename($_FILES['file_upload']['name']);
            
            if (move_uploaded_file($_FILES['file_upload']['tmp_name'], $uploadfile))
                exit("File is valid, and was successfully uploaded.\n");
            else
                exit("File uploading failed.\n");
        }
    }
?>
<html>
    <head>
        <title>Upload Test</title>
    </head>
    <body>
        <form action="<?php echo $_SERVER['PHP_SELF']; ?>" enctype="multipart/form-data" method="POST">
            <input type="hidden" name="MAX_FILE_SIZE" value="<?php echo $maxFileSize; ?>" />
            <input type="file" name="file_upload" />
            <input type="submit" name="submit" value="upload" />
            <br />
            <?php echo "(Max: " . number_format($maxFileSize/1048576,0) . " MB)" ?>
        </form>
    </body>
</html>

hello i am adding an image upload script, so users can upload a image with the recipe they are adding, but my script seems to not work, these are the files.

add_recipe.php

<?php
// Start_session, check if user is logged in or not, and connect to the database all in one included file
include_once("scripts/checkuserlog.php");
// Include the class files for auto making links out of full URLs and for Time Ago date formatting
include_once("wi_class_files/autoMakeLinks.php");
include_once ("wi_class_files/agoTimeFormat.php");
// Create the two objects before we can use them below in this script
$activeLinkObject = new autoActiveLink;
$myObject = new convertToAgo;
?>
<?php
// Include this script for random member display on home page
include_once "scripts/homePage_randomMembers.php"; 
?>
<?php
$sql_blabs = mysql_query("SELECT id, mem_id, the_blab, blab_date FROM blabbing ORDER BY blab_date DESC LIMIT 30");

$blabberDisplayList = ""; // Initialize the variable here

while($row = mysql_fetch_array($sql_blabs)){

$blabid = $row["id"];

$uid = $row["mem_id"];

$the_blab = $row["the_blab"];

$notokinarray = array("fag", "gay", "shit", "fuck", "stupid", "idiot", "asshole", "cunt", "douche");
    $okinarray   = array("sorcerer", "grey", "shug", "farg", "smart", "awesome guy", "asshole", "cake", "dude");

$the_blab = str_replace($notokinarray, $okinarray, $the_blab);

$the_blab = ($activeLinkObject -> makeActiveLink($the_blab));

$blab_date = $row["blab_date"];

$convertedTime = ($myObject -> convert_datetime($blab_date));
    $whenBlab = ($myObject -> makeAgo($convertedTime));

//$blab_date = strftime("%b %d, %Y %I:%M:%S %p", strtotime($blab_date));

// Inner sql query

$sql_mem_data = mysql_query("SELECT id, username, firstname, lastname FROM myMembers WHERE id='$uid' LIMIT 1");

while($row = mysql_fetch_array($sql_mem_data)){

$uid = $row["id"];

$username = $row["username"];

$firstname = $row["firstname"];

if ($firstname != "") {$username = $firstname; } // (I added usernames late in  my system, this line is not needed for you)

///////  Mechanism to Display Pic. See if they have uploaded a pic or not  //////////////////////////

$ucheck_pic = "members/$uid/image01.jpg";

$udefault_pic = "members/0/image01.jpg";

if (file_exists($ucheck_pic)) {

$blabber_pic = '<div style="overflow:hidden; width:40px; height:40px;"><img src="' . $ucheck_pic . '" width="40px" border="0" /></div>'; // forces picture to be 100px wide and no more

} else {

$blabber_pic = "<img src=\"$udefault_pic\" width=\"40px\" height=\"40px\" border=\"0\" />"; // forces default picture to be 100px wide and no more

}

$blabberDisplayList .= '
      

<table width="100%" align="center" cellpadding="4" bgcolor="#CCCCCC">
        <tr>
          <td width="7%" bgcolor="#FFFFFF" valign="top"><a href="profile.php?id=' . $uid . '">' . $blabber_pic . '</a>
          </td>
          <td width="93%" bgcolor="#EFEFEF" style="line-height:1.5em;" valign="top"><span class="greenColor textsize10">' . $whenBlab . ' <a href="profile.php?id=' . $uid . '">' . $username . '</a> said: </span><br />
          ' . $the_blab . '</td>
        </tr>
      </table>';

}

}
?>
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
  <head>
    <meta http-equiv="Content-Type" content="text/html; charset=ISO-8859-1" />
    <meta name="Description" content="Web Intersect is a deft combination of powerful free open source software for social networking, mixed with insider guidance and tutorials as to how it is made at its core for maximum adaptability. The goal is to give you a free website system that has a network or community integrated into it to allow people to join and interact with your website when you have the need." />
    <meta name="Keywords" content="web intersect, how to build community, build social network, how to build website, learn free online, php and mysql, internet crossroads, directory, friend, business, update, profile, connect, all, website, blog, social network, connecting people, youtube, myspace, facebook, twitter, dynamic, portal, community, technical, expert, professional, personal, find, school, build, join, combine, marketing, optimization, spider, search, engine, seo, script" />
    <title>CookBookers</title>
    <link href="style/main.css" rel="stylesheet" type="text/css" />
    <link rel="icon" href="favicon.ico" type="image/x-icon" />
    <link rel="shortcut icon" href="favicon.ico" type="image/x-icon" />
    <script src="js/jquery-1.4.2.js" type="text/javascript"></script>
<style type="text/css">
#Layer1 {

height:210px;

}
body {

background-color: #3c60a4;
}
.style4 {font-size: 36px}
</style>
</head>
<body>
<p>
  <?php include_once "header_template.php"; ?>
  </head>
  <body 
style="margin:0px;">
  <center>
</p>
<p>&nbsp;</p>
<table border="0" align="center" cellpadding="0" cellspacing="0" class="mainBodyTable">
  <tr>
    <td width="124" valign="top">
    <td width="776" colspan="2" align="left" valign="top" style="background-color:#EFEFEF; border:#999 0px; padding:10px;">
<table border="0" cellpadding="6">

  </table>
  <table width="574" border="0">
  <form enctype="multipart/form-data" action="include/recipe.php" method="post">
    <span class="style4">Add Recipie</span>
  
    <tr>
      <th width="232" scope="col"></th>
      <th width="332" scope="col">&nbsp;</th>
    </tr>
    <tr>
      <td><span style="margin-bottom:5px; color:brown;">Public:</span></td>
      <td><span style="margin-bottom:5px; color:brown;">
        <input name="Pub" value="1" type="checkbox" id="Pub"/>
      </span></td>
    </tr>
    <tr>
      <td><span style="margin-bottom:5px; color:brown;">Title:</span></td>
      <td><span style="margin-bottom:5px; color:brown;">
        <input type="text" name="title" />
      </span></td>
    </tr>
    <tr>
      <td><span style="margin-bottom:5px; color:brown;">Prep time:</span></td>
      <td><span style="margin-bottom:5px; color:brown;">
        <input type="text" name="prep" />
    </tr>
    <tr>
      <td><span style="margin-bottom:5px; color:brown;">Cooking time:</span></td>
      <td><span style="margin-bottom:5px; color:brown;">
        <input type="text" name="cook" />
    </tr>
    <tr>
      <td><span style="margin-bottom:5px; color:brown;">Makes:</span></td>
      <td><span style="margin-bottom:5px; color:brown;">
         <input type="text" name="make" />
      </span></td>
    </tr>
    <tr>
      <td><span style="margin-bottom:5px; color:brown;">Ingrediants:</span></td>
      <td><span style="margin-bottom:5px; color:brown;">
        <textarea rows="5" name="ingr" cols="40"></textarea>
      </span></td>
    </tr>
    <tr>
      <td><span style="margin-bottom:5px; color:brown;">Method: </span></td>
      <td><span style="margin-bottom:5px; color:brown;">
        <textarea rows="5" name="desc" cols="40"></textarea>
      </span></td>
    </tr>
    <tr>
      <td><span style="margin-bottom:5px; color:brown;">Notes:</span></td>
      <td><span style="margin-bottom:5px; color:brown;">
        <textarea rows="5" name="note" cols="40"></textarea>
      </span></td>
    </tr>

<tr>
       <td><input type="hidden" name="MAX_FILE_SIZE" value="1000000" />
    Choose a picture to upload: 
      <input name="uploaded_file" type="file" /></td>

</tr>

<tr>

  <td><input name="submit" type="submit" style="padding:5px 10px;" value="Submit" /></td>

  </tr>

<tr>

  <td>&nbsp;</td>

  </tr>
  </table>
    </tr>
</table>
            </td>
</tr>
        </table>

<?php include_once "footer_template.php"; ?>
</body>


recipe.php (upload form script)

<?php
//include("session.php");          
include("database.php");
@session_start();

$user = $_SESSION['username'];

mysql_real_escape_string($user);
    

//die($user);

$Pub=$_POST['Pub'];
    $title=$_POST['title'];

$prep=$_POST['prep'];
    $cook=$_POST['cook'];
    $make=$_POST['make'];
    $ingr=$_POST['ingr'];
    $desc=$_POST['desc'];
    $note=$_POST['note'];
    //if($user=="Guest"||$user==""){
    //header("Location: ../index.php");
    //}
    //else{
    $database->AddRecipe($user,$Pub,$title,$prep,$cook,$make,$ingr,$desc,$note);
    $uploaded_file=$_POST['files']['uploaded_file']
//&#1057;heck that we have a file
if ((!empty($_FILES["uploaded_file"])) && ($_FILES['uploaded_file']['error'] == 0)) {
  //Check if the file is JPEG image and it's size is less than 350Kb
  $filename = basename($_FILES['uploaded_file']['name']);
  $ext = substr($filename, strrpos($filename, '.') + 1);
  if (($ext == "jpg") && ($_FILES["uploaded_file"]["type"] == "image/jpeg") && 
    ($_FILES["uploaded_file"]["size"] < 350000)) {
    //Determine the path to which we want to save this file
      $newname = dirname(__FILE__).'/upload/'.$filename;
      //Check if the file with the same name is already exists on the server
      if (!file_exists($newname)) {
        //Attempt to move the uploaded file to it's new place
        if ((move_uploaded_file($_FILES['uploaded_file']['tmp_name'],$newname))) {
           echo "It's done! The file has been saved as: ".$newname;
        } else {
           echo "Error: A problem occurred during file upload!";
        }
      } else {
         echo "Error: File ".$_FILES["uploaded_file"]["name"]." already exists";
      }
  } else {
     echo "Error: Only .jpg images under 350Kb are accepted for upload";
  }
} else {
 echo "Error: No file uploaded";
}

header("Location: ../recipe_added.php");
    //}
?>





 

Hello everyone.  I'm posting because I'm having difficulty using a file upload script I wrote in PHP.  (Based on a tutorial naturally.)  May someone more skilled than I could take a look at it?

Form: (simple, no ajax or jquery involved. I'll add that later.)
Code: [Select]
<form enctype="multipart/form-data" action="upload.php" method="POST">
<table><tr><td>File</td><td><input name="uploaded" type="file" /></td></tr>
<tr><td colspan="2"><input type="submit" value="Upload" style="float:right;" /></td></tr></table>
</form>

Upload Script:
Code: [Select]
<?
session_start();
include('include/session.php');

/*IMAGE*/
 $target = "upload/";
 $target = $target . basename($_FILES['uploaded']['name']);
$name =  basename( $_FILES['uploaded']['name']);
 $ok=1;
 
 global $database;

 
 //This is our size condition
 if ($uploaded_size > 350000000)
 {
 echo "Your file is too large.<br>";
 $ok=0;
 }
 
 //This is our limit file type condition
 if ($uploaded_type =="text/php")
 {
 echo "No PHP files<br>";
 $ok=0;
 }
 
 //Here we check that $ok was not set to 0 by an error
 if ($ok==0)
 {
 Echo "Sorry your file was not uploaded";
 }
 
 //If everything is ok we try to upload it
 else
 {
 if(move_uploaded_file($_FILES['uploaded']['tmp_name'], $target))
 {
 $channel_number = $_SESSION['channel_number'];
 $n = "INSERT INTO `documents` (`name`,`channel_number`) VALUES ('$name','$channel_number')";
 mysql_query($n);
 header("Location:index.php");
 }
 else
 {
 echo "Sorry, there was a problem uploading your file.";
 }
 }
 ?>

The mysql query works fine, and it's just so that I can keep track of the uploads.  I'm well aware this is not a secure script, btw. I'm just doing it to learn.

<!doctype html>
<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="content-type">
<title>Untitled Document</title>
</head>

<body>
<form action="upload_image.php" method="post" enctype="multipart/form-data">
<label>select page<input type="file" name="image">
<input type="submit" name="upload">
</label>
</form>
<?php 
if(isset($_POST['upload']))
{
	$image_name=$_FILES['image']['name']; //return the name ot image
	$image_type=$_FILES['image']['type']; //return the value of image
	$image_size=$_FILES['image']['size']; //return the size of image
	$image_tmp_name=$_FILES['image']['tmp_name'];//return the value
	if($image_name=='')
	{
		echo '<script type="text/javascript">alert("please select image")</script>';
		exit();
	}
	else
	{
		$ex=move_uploaded_file($image_tmp_name,"image/".$image_name);
		if($ex)
		{
		    echo 'image upload done "<br>"';
			echo $image_name.'<br>';
			echo $image_size.'<br>';
			echo $image_type.'<br>';
			echo $image_tmp_name.'<br>';
		}
		else
		{
			echo 'error';
		}
	}
}
?>
</body>
</html>

I make this simple script for upload files like photo , It's work correctly ,but not upload the large files ex 8MB images 12MB images
Edited by Ch0cu3r, 04 October 2014 - 09:50 AM.
Modified topic title - changed download to upload

Hey guys! I'm not that good with PHP, and I really need to finish this script. I'm having a hard time finding the problem..it keeps saying Error, query failed and I've also checked the database info, connectivity info and even tried a connection and database selection verification to see if that was working. Is there any other error you guys can find in the script that may be causing the message?

Edit: The files I want to be able to upload should be pdf's, txts, docs, etc. Would that be possible with this script?

Thanks!!

Code: [Select]
<form method="post" enctype="multipart/form-data">
<table width="350" border="0" cellpadding="1" cellspacing="1" class="box">
<tr>
<td width="246">
<input type="hidden" name="MAX_FILE_SIZE" value="104857600"></td>
<td width="80">&nbsp;</td>
</tr>
</table>
<p>Archivo:
  <input name="userfile" type="file" id="userfile" />
</p>
<p>Nomb
  <label for="name"></label>
 <input type="text" name="nombrelista" id="nombrelista" />
</p>
<p>Password (para luego borrar si necesario):
  <input type="text" name="pass" id="pass" />
</p>
<p>
  <input name="upload" type="submit" class="box" id="upload" value=" Upload " />
</p>

<?php
if(isset($_POST['upload']) && $_FILES['userfile']['size'] > 0)
{
$fileName = $_FILES['userfile']['name'];
$tmpName  = $_FILES['userfile']['tmp_name'];
$fileSize = $_FILES['userfile']['size'];
$fileType = $_FILES['userfile']['type'];
$filePass = $_POST['pass'];
$nombreLista = $_POST['nombrelista'];



$fp      = fopen($tmpName, 'r');
$content = fread($fp, filesize($tmpName));
$content = addslashes($content);
fclose($fp);

$host_db = "localhost";
$user_db = "melkien_rudesa";
$pass_db = "jorlan2407";
$base_db = "melkien_rudesa";



$link = mysql_connect($host_db, $user_db, $pass_db);
if (!$link) {
    die('Could not connect: ' . mysql_error());
mysql_close($link); 
}

mysql_select_db($base_db, $link) or die(mysql_error());



if(!get_magic_quotes_gpc())
{
   $fileName = addslashes($fileName);
}


$query = "INSERT INTO 'upload'('nombrelista', 'name', 'pass', 'size', 'type', 'content' ) VALUES ('$nombreLista', $fileName', '$filePass', $fileSize', '$fileType', '$content')";


mysql_query($query) or die('Error, query failed'); 


echo "<br>File $fileName uploaded<br>";

mysql_close($link); 

}



?>


</form>

Hello,

My upload script is working for the most part and while I know that I need a couple of little fixes and will need help with those I also wouldn't mind some tips on how I could have written it better in the first place.

The 2 problems I am having.
1. If the copy image fails the script doesn't and still creates a database entry. I would like to stop it from doing that but can't seem to work it out.
2. My mate is getting file type errors even though he is trying to upload small .jpg files. I can't seem to recreate the problem. Maybe someone can see something that might be problematic??
Code: [Select]
<?
        $idir = "../rosysartworks/gallery/";   // Path To Images Directory
        $tdir = "../rosysartworks/gallery/thumbs/";   // Path To Thumbnails Directory
        $iwidth = "600";   // Maximum Width For Thumbnail Images
        $iheight = "600";   // Maximum Height For Thumbnail Images
        $twidth = "233";   // Maximum Width For Thumbnail Images
        $theight = "178";   // Maximum Height For Thumbnail Images
        ?>

          <?
        // Catching the inputs
$title = Trim(stripslashes($_POST['title']));
$paypal = Trim(stripslashes($_POST['paypal']));
        // Check if the form has been submitted.
if (isset ($_POST['submit'])) {
$problems = FALSE; // No problems so far.

// Check for each value.
if (empty ($title)) {
$problem = TRUE;
$problems = 'You forgot to enter a title!<br />';
}
if (empty ($paypal)) {
$problem = TRUE;
$problems = 'You forgot to enter a paypal link!<br />';
}
if (!$problem) { // If there are no problems...
       
        // Uploading/Resizing Script
        $url = $_FILES['imagefile']['name'];   // Set $url To Equal The Filename For Later Use
        if ($_FILES['imagefile']['type'] == "image/jpg" || $_FILES['imagefile']['type'] == "image/jpeg" || $_FILES['imagefile']['type'] == "image/pjpeg" || $_FILES['imagefile']['type'] == "image/JPG") {
          $file_ext = strrchr($_FILES['imagefile']['name'], '.');   // Get The File Extention In The Format Of , For Instance, .jpg, .gif or .php
          $copy = copy($_FILES['imagefile']['tmp_name'], "$idir" . $_FILES['imagefile']['name']);   // Move Image From Temporary Location To Permanent Location
         
         
          if ($copy) {   // If The Script Was Able To Copy The Image To It's Permanent Location
         
            // Resize for preview image.
            $simg = imagecreatefromjpeg("$idir" . $url);   // Make A New Temporary Image To Create The Thumbanil From
            $currwidth = imagesx($simg);   // Current Image Width
            $currheight = imagesy($simg);   // Current Image Height
           
            if ($currwidth > $iwidth && $currheight > $iheight) {
              $newwidth = $iwidth;
              $newheight = $newwidth * $currheight / $currwidth;
              if ($newheight > $iheight) {
                $newheight = $iheight;
                $newwidth = $newheight * $currwidth / $currheight; }

              $dimg = imagecreatetruecolor($newwidth, $newheight);   // Make New Image For Preview
              imagetruecolortopalette($simg, false, 256);   // Create New Color Pallete
              $palsize = ImageColorsTotal($simg);
              for ($i = 0; $i < $palsize; $i++) {   // Counting Colors In The Image
              $colors = ImageColorsForIndex($simg, $i);   // Number Of Colors Used
              ImageColorAllocate($dimg, $colors['red'], $colors['green'], $colors['blue']);   // Tell The Server What Colors This Image Will Use
              }
              imagecopyresampled($dimg, $simg, 0, 0, 0, 0, $newwidth, $newheight, $currwidth, $currheight);   // Copy Resized Image To The New Image (So We Can Save It)
              $success = imagejpeg($dimg, "$idir" . $url, 100);   // Saving The Image
              imagedestroy($simg);   // Destroying The Temporary Image
              imagedestroy($dimg);   // Destroying The Other Temporary Image

              if ($success) {
                print 'Preview image '.$url.' width: '.$newwidth.' height: '.$newheight.' created successfully.<br />';   // Resize successful for preview image
                unset($success);
              }
            } else {
              unset($simg, $currwidth, $currheight);
          }
           
           
              // Resize for thumbnail
              $simg = imagecreatefromjpeg("$idir" . $url);   // Make A New Temporary Image To Create The Thumbanil From
              $currwidth = imagesx($simg);   // Current Image Width
              $currheight = imagesy($simg);   // Current Image Height
           
              $newwidth = $twidth;
              $newheight = $newwidth * $currheight / $currwidth;
              if ($newheight > $theight) {
                $newheight = $theight;
                $newwidth = $newheight * $currwidth / $currheight; }
           
              // maxWidth: mw, maxHeight: mh, oldHeight: oh, oldWidth: ow, newHeight: nh, newWidth: nw.   
              // nw = mw; nh = nw * oh / ow;
              // if (nh > mh) { nh = mh; nw = nh * ow / oh }
         
              $dimg = imagecreatetruecolor($newwidth, $newheight);   // Make New Image For Thumbnail
              imagetruecolortopalette($simg, false, 256);   // Create New Color Pallete
              $palsize = ImageColorsTotal($simg);
              for ($i = 0; $i < $palsize; $i++) {   // Counting Colors In The Image
              $colors = ImageColorsForIndex($simg, $i);   // Number Of Colors Used
              ImageColorAllocate($dimg, $colors['red'], $colors['green'], $colors['blue']);   // Tell The Server What Colors This Image Will Use
              }
              imagecopyresampled($dimg, $simg, 0, 0, 0, 0, $newwidth, $newheight, $currwidth, $currheight);   // Copy Resized Image To The New Image (So We Can Save It)
              $success = imagejpeg($dimg, "$tdir" . $url, 100);   // Saving The Image
              imagedestroy($simg);   // Destroying The Temporary Image
              imagedestroy($dimg);   // Destroying The Other Temporary Image
             
              if ($success) {
              print 'Image thumbnail '.$url.' width: '.$newwidth.' height: '.$newheight.' created successfully.';   // Thumbnail created successfully
              }
            } else {
            print '<font color="#FF0000">ERROR: Unable to upload image.</font>';   // Error Message If Upload Failed
            } // End upload at copy failure
                 }  else {
                     print 'Failed to copy image to temp location.';
                   }
        } else {
          print '<font color="#FF0000">ERROR: Wrong filetype (has to be a .jpg or .jpeg. Yours is ';   // Error Message If Filetype Is Wrong
          print $file_ext;   // Show The Invalid File's Extention
          print '.</font>';
        } // End upload script

       
// Define the query.
  $add_new_session = $sql = "INSERT INTO  `gallery` (
  `id` ,
  `title` ,
  `image` ,
  `thumb` ,
  `width` ,
  `height` ,
  `paypal` ,
  `date_entered`
  )
  VALUES (
  0,
  '".mysql_real_escape_string(($title))."',
  '".mysql_real_escape_string(($url))."',
  '".mysql_real_escape_string(($url))."',
  '".mysql_real_escape_string(($newwidth))."',
  '".mysql_real_escape_string(($newheight))."',
  '".mysql_real_escape_string(($paypal))."',
  NOW()
  )";

  // execute the query.
  if (@mysql_query ($add_new_session)) {
  print "<p>The new gallery image $url has been added.</p>";
  unset($sessionName, $maxAttendees, $newwidth, $newheight);
  $hidden = 'hidden';
}
else{
  print '<a name="formTop"></a>'.'<p class="error">Your session has failed to upload. Please contact website support.</p>';
  echo $add_new_session;
}
} else { // Forgot a field.

// print '<p>Please try again!</p>';
$problems .= '<a name="formTop"></a>'.'Please try again!<br />';
if ($problem) {
print '<p class="error">' . $problems . '</p>';
}
}

// End of handle form IF
// Display the form

print '<h2>Upload New Image</h2>'
. '<p>Please only try uploading .jpg images</p>'
  . '<form method="post" action="index.php" enctype="multipart/form-data">'
  . '<label>Title:</label>'
      . '<input type="text" name="title" class="form">'
      . '<br />'
      . '<label>Image:</label>'
      . '<input type="file" name="imagefile" class="form">'
      . '<br />'
      . '<label>Paypal Link:</label>'
      . '<input type="text" name="paypal" class="form" size="50">'
      . '<br /><br />'
     
      . '<input name="submit" type="submit" value="Sumbit" class="form">'
      . '<input type="reset" value="Clear" class="form">'
  . '</form>';
?>