PHP - Creating A New Record And Then Updating It. What's Wrong Here?

Hey Guys,

Im slowly updating our website to php/mysql, im getting there slowly but stuck at the minute. Im try to create a form where we can edit one of the pages text and then update the text in the database if that makes sense 

Basically at the moment i have a form where you can see the pages text like so:

<table width="400" border="0" align="center" cellpadding="3" cellspacing="1">
<tr>
<td><strong>Edit About Us English </strong></td>
</tr>
</table>

<table width="400" border="0" align="center" cellpadding="0" cellspacing="1">
<tr>
<td><form name="form1" method="post" action="send_update_english.php">
<table width="100%" border="0" cellspacing="1" cellpadding="3">

<tr>
<td>Detail</td>
<td>:</td>
<td><textarea name="detail" cols="50" rows="4" id="detail">

[b]<?php

mysql_connect("localhost", "web148", "123") or die(mysql_error());
mysql_select_db("web148") or die(mysql_error());

mysql_query("SET names 'utf8'");

$result = mysql_query("SELECT body FROM aboutenglish WHERE ID = '1'");


$row = mysql_fetch_array( $result );

echo nl2br($row['body']);


?>[/b]

</textarea></td>
</tr>
<tr>
<td>&nbsp;</td>
<td>&nbsp;</td>
<td><input type="submit" name="Submit" value="Submit"> <input type="reset" name="Submit2" value="Reset"></td>
</tr>
</table>
</form>
</td>
</tr>
</table>

Ive got that php bit in the middle to pull out the text thats on that page but not sure if thats correct or not. But anyways on the 'send form' page i have:

<?php

// Details
[b]$message="$detail";[/b]

mysql_connect("localhost", "web148", "123") or die(mysql_error());
mysql_select_db("web148") or die(mysql_error());

mysql_query("SET names 'utf8'");
$result = mysql_query("UPDATE aboutenglish SET body = '$message' where ID = '1'");


?>


the update query works if i put text in there, but when i use '$message' the database is left blank.


This is only my second week doing all this stuff, so bare with me 

I appreciate your answers.

I am getting this error when updating a record (through a form)

Parse error: syntax error, unexpected T_ENCAPSED_AND_WHITESPACE, expecting T_STRING or T_VARIABLE or T_NUM_STRING in /home/wormste1/public_html/tilburywebdesign/shop/FTPServers/barryottley/updates.php on line 62

This is updates.php

<?php

mysql_connect("localhost", "wormste1_barry", "barry") or die(mysql_error());
mysql_select_db("wormste1_barry") or die(mysql_error());

$carname = mysql_real_escape_string(trim($_POST['CarName']));
$cartitle = mysql_real_escape_string(trim($_POST['CarTitle']));
$carprice = mysql_real_escape_string(trim($_POST['CarPrice']));
$carmiles = mysql_real_escape_string(trim($_POST['CarMiles']));
$cardesc = mysql_real_escape_string(trim($_POST['CarDescription']));




mysql_query("UPDATE cars WHERE id='.intval ($_GET['id']).' LIMIT 1 
(CarName, CarTitle, CarPrice, CarMiles, CarDescription, photo) VALUES('$carname', '$cartitle', '$carprice', '$carmiles', '$cardesc' ) ") 
or die(mysql_error());  


echo "The vehicle data has been updated!";

?>

the updates.php actually processes the update.

the form page is edit.php:

<CENTER><B>Update a Vehicle</B></CENTER>
<BR>

<?php
$what_id=$_GET['id'];
$query="SELECT * FROM cars WHERE id = '$what_id'";
$result=mysql_query($query);
while($row=mysql_fetch_array($result)) {

$carname = $row['CarName'];

$cartitle = $row['CarTitle'];

$carprice = $row['CarPrice'];

$carmiles = $row['CarMiles'];

$cardesc = $row['CarDescription'];
}
?>
<form action="updates.php" method="post">
<CENTER>Vehicle Name:</CENTER> <br><CENTER><input type="text" name="CarName" value="<?php echo $carname; ?>"></CENTER><br>
<CENTER>Vehicle Type:</CENTER><br><CENTER><input type="text" name="CarTitle" value="<?php echo $cartitle; ?>"></CENTER><br>
<CENTER>Vehicle Price:</CENTER><br><CENTER><input type="text" name="CarPrice" value="<?php echo $carprice; ?>"></CENTER><br>
<CENTER>Vehicle Mileage:</CENTER><br><CENTER><input type="text" name="CarMiles" value="<?php echo $carmiles; ?>"></CENTER><br>
<CENTER>Vehicle Description:</CENTER><br><CENTER><input type="text" name="CarDescription" value="<?php echo $cardesc; ?>"></CENTER><br>
<CENTER>Vehicle Description:</CENTER><br>
<CENTER><textarea name="CarDescription" rows="10" cols="30" value="<?php echo nl2br($cardesc); ?>"></textarea></CENTER><br>
<CENTER><input type="Submit"></CENTER>
</form>


Any idea for the error.  I think it could be because the UPDATE tag syntax is wrong.

Help would be great!!!

I have three pages;

edit_records.php (list of records, user picks one ready to edit, works fine)

update.php (by in large works fine, heres the code for it anyway)

Code: [Select]
<?php

require_once ('./includes/config.inc.php');

require_once (MYSQL);

if($id = isset($_GET['prodID']))
{
$query = "SELECT * FROM product WHERE prodID='{$_GET['prodID']}'";
$r = mysqli_query($dbc, $query);

while ($row = mysqli_fetch_array($r))
{
$id = $row['prodID'];
$product = $row ['product'];

?>

<form action="update_save.php" method="post">
    ID: <input type="text" value="<?php echo $id;?>" name="id" disabled="disabled" />
Product: <input type="text" value="<?php echo $product;?>" name="product" />
<br />
<input type="submit" value="submit changes" />
</form>
   
    <?php

}

}
and finally

update_save.php (this is where the actual updating takes place)

Code: [Select]
<?php

require_once ('./includes/config.inc.php');

require_once (MYSQL);

$product = $_POST['product'];

$query = "UPDATE product SET product = $product WHERE prodID = '$id'";
$r = mysqli_query($dbc, $query);

echo 'Database Updated!!';
?>
however, on line 19 of update save, i get this error;

Quote

An error occurred in script 'C:\Users\David Morgan\Desktop\WEBSITES\hairz_&_graces\site\admin\update_save.php' on line 9:
Undefined variable: id


now I am aware i should really create a variable but since i already stored it in update.php, i had hoped it would work but it hasnt.

what should i do? help would be much appreciated please

I don't know if I'm wording this right.
I have a textarea that is entered into a database. When this is edited, I want to store and display a list of all the changes that have been made to it.
Like a conversation in a forum. The reason for this is that I want past changes to be locked from editing.

Would a new database table storing only this text fields data need to be created? Maybe have column for the work request number and a second column for the text entered? But then wouldn't I need an third identifier column so the changes can be displayed in the right order?

Looking for sage like wisdom

Thanks

Brad_Strickland

I making an web app for teachers to assess their students online. The problems I am currently having are on select only one record is displayed and after update no records are displayed in the form even though it was successfully updated.. The program has two files, index.php and process.php. The problems started when got the class name into the query to search and display the class. 

$result = $mysqli->query("SELECT * FROM data WHERE classroom = '".$classroom."' ORDER BY '.name';") or die($mysqli->error);

The query works but doesn't order by name I would like. I would be grateful if anyone could cast an eye over it and give me some tips.

Thanks guys. The beers are on me if anyone can sort it, but you'll have to come to Phnom Penh, Cambodia as that is where I live.

Anyway here's the code. process.php

<html>
<?php
session_start();

$mysqli = new mysqli("localhost","ray","password","reports") or die(mysqli_error($mysqli));

$id = 0;
$update = false;
$name = '';
$classroom = '';


if (isset($_GET['edit'])){
    $id = $_GET['edit'];
    $update = true;
    $result = $mysqli->query("SELECT * FROM data WHERE id=$id") or die($mysqli->error());
    if(isset($result->num_rows) && $result->num_rows > 0) {
        $row = $result->fetch_array();
        $name = $row['name'];
        $classroom = $row['classroom'];
        $pacomment = $row['pacomment'];           
    }
}

if (isset($_POST['update'])){
    $id = $_POST['id'];
    $pacomment = $_POST['pacomment'];   
    $mysqli->query("UPDATE data SET pacomment= '$pacomment' WHERE id=$id") or die($mysqli->error);
    
    $_SESSION['message'] = "Record has been updated!";
    $_SESSION['msg_type'] = "warning";

    header('location: index.php');

}

index,php

<?php require_once 'process.php'; ?>
 <!--************************************** Setup Messages **************************************** -->
<?php if (isset($_SESSION['message'])): ?>
            <div class="alert alert-<?=$_SESSION['msg_type']?>">
                <?php 
                    echo $_SESSION['message']; 
                    unset($_SESSION['message']);
                ?>
            </div>
        <?php endif ?>
  <!--**************************************End  Setup Messages ***********************************************  -->
<?php

?>
<!DOCTYPE html>
<html>
    <head>
    <title>Home of English Reports</title>
  <meta charset="utf-8">
  <meta name="viewport" content="width=device-width, initial-scale=1">
  <link rel="stylesheet" href="https://maxcdn.bootstrapcdn.com/bootstrap/3.4.1/css/bootstrap.min.css">
  <script src="https://ajax.googleapis.com/ajax/libs/jquery/3.5.1/jquery.min.js"></script>
  <script src="https://maxcdn.bootstrapcdn.com/bootstrap/3.4.1/js/bootstrap.min.js"></script>

  <style>= 
body {
  margin: 0;
  font-family: Arial, Helvetica, sans-serif;
}

.topnav {
  overflow: hidden;
  background-color: #008080;
}

.topnav a {
  float: left;
  color: #f2f2f2;
  text-align: center;
  padding: 14px 16px;
  text-decoration: none;
  font-size: 17px;
}

.topnav a:hover {
  background-color: #ddd;
  color: black;
}

.topnav a.active {
  background-color: #4CAF50;
  color: white;
}
</style>

</head>
<body style="background-color:linen;">


 <!--************************************** End Setup Page Styles ************************************* -->
<div class="container">
<form action="index.php" method = get>
    <label for="classroom">Class name:</label><br>
    <input type="text" id="classroom" name="classroom" value="107i am"><br>

    <input type="submit" value="Submit">
</form>
</div>

 <?php $resultcomment = $mysqli->query("SELECT EnglishComment FROM comments"); ?>

    <!-- ************************************** Begin Connect DB  ************************************************ -->
    
        <div class="container" align-content-center>
        <?php
        $classroom = (isset($_GET['classroom']) ? $_GET['classroom'] : null);
        $result = $mysqli->query("SELECT * FROM data WHERE classroom = '".$classroom."' ORDER BY '.name';") or die($mysqli->error);

        ?>
    <!-- ************************************** End Connect DB ****************************************************  -->

    <div class="row justify-content-center">
        <form action="process.php" method="POST">
            <input type="hidden" name="id" value="<?php echo $id; ?>">

            <div class="form-group">
                <h1><label><?php echo $name?></label></h1>
            </div>



            <form action="process.php" method="POST">
            <input type="hidden" name="id" value="<?php echo $id; ?>">

            <div class="form-group">
                <h3><label>PA Teacher's Comment</label></h3> <select name = "pacomment">
               <?php
                    while($rows = $resultcomment-> fetch_assoc())
                    {
                        $EnglishComment = $rows['EnglishComment'];
                        echo "<option value='$EnglishComment'>$name.$EnglishComment</option>";
                    }
                    ?></h2> 
                </select><br>
                <p>

            <div class="form-group">
            <?php 
            if ($update == true): 
            ?>
                <button type="submit" class="btn btn-info" name="update">Update</button>
            <?php else: ?>
                <!-- <button type="submit" class="btn btn-primary" name="save">Save</button> -->
            <?php endif; ?>
            </div>
        </form>

    <!-- ************************************** Begin Setup Table Headers ******************************************   -->        
            <div class="row justify-content-center">
                <table class="table" width = "20%" border = "5" cellpadding = "1";>
                    <thead>
                        <tr>
                            <th><center>Action</center></th>
                            <th><center>ID</center></th>
                            <th>Name and Comment</th>
                        </tr>
                    </thead>
                    
    <!-- ************************************** End Setup Classlist Table Headers ******************************************   -->
    
    <!-- ****** Loop thru Every Record From $result Query Variable and get variables and echo each variable into the table rows  **********   -->
            <?php
                while ($row = $result->fetch_assoc()): ?>

            <tr>
                        <td>
                        <center><a href="index.php?edit=<?php echo $row['id']; ?>"
                            class="btn btn-info">Assess</a></center>                         
                        </td>
    <!-- ************************************** Put data into Classlist table rows ******************************************   -->
                    
                        <td><center><?php echo $row['studentid']; ?></center></td>
                        <td><?php echo $row['name']." ".$row['pacomment'] ?></td>
                        
            </tr>
                  
            <?php endwhile; ?>  <!-- ****************** End While() Loop ****************************   --> 
    
                </table> <!-- *************** End of Classlist Table  ******************************************   -->

            </div> 
   
        </div>
        </div>
    </body>

</html>

 

 

 

 

Edited July 25, 2020 by raymon