PHP - Code Makes Box Appear After Log-in

My issue

in my php page where i need to show all the news that have the status only active.

in my mysql table i have 3 fiels news,posted date and expiry date.
on page load i check the status of the news and displays only the active news.For that i am doing the following code,which gives me error.

that is  on page load,
first i select all the news ,update the status inactive for the news which has crossed expiry time

i check the status of the news and displays only the active news.For that i am doing the following code,which gives me error.

$query1="select time(date_posted),time(expiry_time) from muh_title where status='Active'";
      $res=mysql_query($query1);
      $row=mysql_fetch_row($res);
      $expiry_time=$row[0];$dateposted=$row[1];
      $query11="select addtime(time(date_posted),time(expiry_time)) from muh_title";
      $res11=mysql_query($query11);
      $row11=mysql_fetch_row($res11);
      $newtime=$row11[0];
      
      $query2="SELECT TIMEDIFF(time(date_posted) ,time(NOW())) FROM muh_title";
       $res2=mysql_query($query2);
      $row2=mysql_fetch_row($res2);
      $diff=$row2[0];
      
      //while($newtime){
      $query5="select *from muh_main_title where date_posted> date_sub(now(),interval (expiry_time) hour-minute )";
      //$query3="update muh_title set status='Inactive' ";
      $res3=mysql_query($query5);
      
      
      }
      $q="select * from muh_title where status='Active' ";
      $r= mysql_query($q);
      $row= mysql_fetch_row($r);
      echo "<font size='6' color='white'><b><marquee direction='left' loop='-1' align='absmiddle' behaviour='scroll' scrolldelay='90'>$row[1]</marquee></b></font>";
       ?>

i am sure some where i have lost the flow of code.

I have two scripts in question here one is getjob.php <-- here you enter an IPaddress and click connect and it takes you too npchome.php what I don't understand is if I go striaght to npchome.php it pulls up the page, however if I get there but clicking submit in getjob.php it brings up nothing just white page but the address bar tells me i'm at npchome.php I don't understand why?

getjob.php

<?php session_start();

if (!isset($_SESSION['username'])) {
echo "Sorry you must be logged in to view this page<BR>";
echo "Please <a href='index.php'>GO BACK</a> and try again";
exit();
}
?>
<style type="text/css">
<!--
.style2 {
font-size: xx-large;
font-style: italic;
font-weight: bold;
}
.style3 {
font-size: 18px;
color: #FFFFFF;
}
<p style="font-size:.5px">
.style4 {color: #FFFFFF}
.style4 {color: #FFFFFF}
.tabledata th, td{color: #FFFFFF;}

-->
</style>
<table width="100%" border="0" align="center" cellpadding="0" cellspacing="0" bgcolor="#000000">
  <!--DWLayoutTable-->
  <tr>
    <td width="100%" height="79" valign="top" bgcolor="#000000"><div align="center">
      <p class="style2 style3 style4">HEAVENSHACKERS - JOB BOARD v1.0 </p>
      <p class="style2 style3 style4">&quot;once your job has been completed return here and hand in&quot;</p>
    </div></td>
  </tr>
  <tr>
    <td height="31" valign="top"><div align="center">
      <form action="npchome.php" method="POST">
        <p>
          <input type="text" name="npcip" size='22'>
          &nbsp;&nbsp;&nbsp;
          <input type="submit" name="submit" value="CONNECT" />
        </p>
        <p><img src='images/accept.png' /> <span class="style4">= Accept Job</span> | <img src='images/handin.png' /> <span class="style4">= Hand In Job</span></p>
      </form>
    </div></td>
  </tr>
  <tr>
    <td height="315" valign="top">

      <div align="center">
<?php
$userlevel = $_SESSION['userlevel'];
//include connect
include('connect_live.php');
// include('connect_local.php');
$query = mysql_query("SELECT * FROM site_jobs WHERE level_required ='$userlevel'") or die ("Could Not query npc Database");


echo "<table width='750' border='1' class='tabledata'><tr><th><font size='1'>NPC NAME</font></th><th><font size='1'>JOB DESCRIPTION</font></th><th><font size='1'>LEVEL</font></th><th><font size='1'>EXPERIENCE</font></th><th><font size='1'>CASH</font></th><th><font size='1'>ACTION</font></th></tr>";


while ($row = mysql_fetch_array($query)) {


//set varibles from query
$npc_name = $row['npc_name'];
$level_required = $row['level_required'];
$job_title = $row['job_title'];
$expr_offered = $row['expr_offered'];
$cash_offered = $row['cash_offered'];
$job_status = $row['job_status'];
$longmsg = $row['longmsg'];
$welcomemsg = $row['welcomemsg'];

$npclogfile = $row['npclogfile'];
//set session varibles
$_SESSION['npcip'] = $npcip;
$_SESSION['welcomemsg'] = $welcomemsg;
$_SESSION['longmsg'] = $longmsg;
$_SESSION['npclogfile'] = $npclogfile;


//end getting varibles

echo "<tr align='center'><td>$npc_name</td><td align='left'>$job_title</td><td>$level_required</td><td>$expr_offered</td><td>$cash_offered</td><td><a href='accept.php'><img border='0' src='images/accept.png'></a>&nbsp;&nbsp;&nbsp;<a href='handin.php'><img border='0' src='images/handin.png'></a></td></tr>";

}

?></div></td>
  </tr>
</table>


npchome.php

<?php
session_start();
if (!isset($_SESSION['username']))
{
echo "Sorry you must be logged in to view this page<BR>";
echo "Please <a href='index.php'>GO BACK</a> and try again";
    exit();
}
else {
if ($_SESSION['username']) {
$player = $_SESSION['username'];
$userlevel = $_SESSION['userlevel'];
$cracker = $_SESSION['cracker'];
$systemkey = $_SESSION['systemkey'];
$IP_snooper=$_SESSION['IP_snooper'];
// check for submit
$submit = $_POST['submit'];
// $npcip = ip2long($_POST['npcip']); //database format for compare
$npcip =$_POST['npcip'];
$_SESSION['npcip'] = $npcip;

}
}

//start connection with server to check if IP is valid
include('connect_live.php');
$sql2 = mysql_query ("SELECT * FROM site_jobs WHERE IPaddress='$npcip'");
$query = mysql_fetch_array($sql2) or die (mysql_error());
// $welcomemsg = $sql2['welcomemsg'];
$rows = mysql_num_rows($sql2);

//we have the result of the row count we want that if it's 0 to echo no service found at address; else if more than 0 bring up that account
?>
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">

<html xmlns="http://www.w3.org/1999/xhtml">

<head>

<meta http-equiv="Content-Type" content="text/html; charset=utf-8" />

<title>Heavens Hackers : Virtual Online Hacking Simulation</title>

</head>



<body alink="#FFFFFF" vlink="#FFFFFF" link="#FFFFFF">

<table width="650" border="0" align="center" cellpadding="0" cellspacing="0" bgcolor="#000000">

  <!--DWLayoutTable-->

  <tr>

    <td width="10" height="36">&nbsp;</td>

    <td width="630">&nbsp;</td>

    <td width="10">&nbsp;</td>
  </tr>

  <tr>

    <td height="39"></td>

    <td align="center" valign="center"><form action="npchome.php" method="post">
        <a href="getjob.php"><img src="images/home.png" width="26" height="26" border="0" /></a>
        <input type="text" name="npcip" size="60" />
        <input type="submit" name="submit" value="CONNECT" />
    </form></td>

  <td></td>
  </tr>

  <tr>

    <td height="195" colspan="3" valign="top"><table background="images/u2uimg.jpg" width="100%" border="0" cellpadding="0" cellspacing="0">

      <!--DWLayoutTable-->

      <tr>

        <td width="13" height="18"></td>

        <td width="624"></td>

        <td width="13"></td>
      </tr>

      <tr>

        <td height="58"></td>

        <td valign="top"><div align="center">

<?php 
if ($rows==0) {

echo "<font color='#ffffff'>No Service Found At<br /></font><font color='#ffffff'>" .long2ip($npcip)."</font><br />";
echo "<a href='getjob.php'>Please go back and try again</a>";
exit();
}
else {
//display information to crack said IP address
echo "<font size ='medium' color='#ffffff'>You were able to ping<br /></font><font color='#ffffff'>" .long2ip($npcip)."</font>";
}
?>
    </div></td>

        <td></td>
      </tr>

      <tr>

        <td height="34">&nbsp;</td>

        <td>&nbsp;</td>

        <td></td>
      </tr>
      <tr>
        <td height="85" colspan="3" valign="top"><table width="100%" border="0" cellpadding="0" cellspacing="0">
          <!--DWLayoutTable-->
          <tr>
            <td width="219" height="66" valign="top"><div align="center"><?php echo "<font color='#ffffff'><br /><a href='cracknpc.php'>".$cracker."</a></font>"; ?>
              </div></td>
            <td width="215" valign="top"><div align="center"><?php echo "<font color='#ffffff'><br /><a href='crack_ipsnppoernpc.php'>".$IP_snooper."</a></font>"; ?>
              </div></td>
            <td width="216" valign="top"><!--DWLayoutEmptyCell-->&nbsp;</td>
          </tr>
          <tr>
            <td height="19">&nbsp;</td>
            <td>&nbsp;</td>
            <td>&nbsp;</td>
          </tr>
        </table>
        </td>
      </tr>
    </table>    </td>
  </tr>

  <tr>
    <td align="center" height="92" colspan="3" valign="top"><img src="images/u2uimg2.jpg" width="650" height="92" /></td>
  </tr>
  <tr>
  <td height="270" colspan="3" align="center" valign="top">
  <?php
  //welcome message for IP connected to
  echo $welcomemsg;
  ?>
  </tr>
</table>



</body>

</html>

This code was extracted from phpwebsockets server from google:   All I am trying to do is grab the  USERS IP ADDRESS.

I removed the last half of the file, but what makes the login($username, $password) function not static? I want to access it statically, but I am getting an error. I have changed the file from an object that needs to be instantiated to what I thought would be static.

Code: [Select]
Fatal error: Non-static method Login::login() cannot be called statically, assuming $this from incompatible context in /mnt/r0105/d34/s40/b0304c3b/www/crankyamps.com/include/uploads/pages/login.php on line 25
Line 25.
Code: [Select]
Login::login($username, $password);

<?php
/**
 * Logs Users into the Website
 *
 * @author    Max Udaskin <max.udaskin@gmail.com>
 * @copyright 2008/2010 Max Udaskin
 * @license   http://www.opensource.org/licenses/lgpl-license.php LGPL
 * @version   $Id: login.php 2010-07-08
 * @package   users
 */

/**
 * @ignore
 */
if(!defined('ALLOW_ACCESS'))
{
    die ( "RESTRICTED ACCESS." );
}

include_once $_SERVER['DOCUMENT_ROOT'] . '/include/mysql.php';

/**
 * Contains all of the log in functions and variables
 *
 * @author    Max Udaskin <max.udaskin@gmail.com>
 * @copyright 2008 Max Udaskin
 * @license   http://www.opensource.org/licenses/lgpl-license.php LGPL
 * @version   $Id: login.class.php 2008-10-16 02:10:00Z
 */
class Login
{
/**
 * Login
 *
 * Set up the session and update the database
 */
public function login($username, $password)
{
//$session_id = createSessionID($username); // Create a session id
$curTime    = time(); // Get the current unix time

$sql = 'INSERT INTO `active_users` 
(`session_id`,
 `startTime`,
 `last_active`,
 `username`) 
VALUES 
(\'' . $session_id . '\',
 \'' . $curTime . '\'
 ,\'' . $curTime . '\',
 \'' . $username . '\')';
 
$con   = $GLOBALS['mysql']->connect(); // Connect to the database
$query = mysql_query($sql, $con); // Run the query

if(!$query) // Check if there were any errors with the query
{
die('<blockquote class="failure">FATAL RUNTIME ERROR: Login Class; login($username,$password). Error Description: ' . 
mysql_error() . 
'</blockquote>');
}

mysql_close($con); // Disconnect from the database

$_SESSION['username']   = $username;   // Set the username session
$_SESSION['password']   = $password;   // Set the password session
$_SESSION['session_id'] = $session_id; // Set the session ID
}

/**
 * Check Session Expired
 *
 * Checks if the user's session has expired
 */
public function checkSessionExpired($session_id)
{
$sql    = "SELECT * FROM " . MAIN_USERSONLINE_TABLE . " WHERE session_id = '" . $session_id . "'";
$con   = $GLOBALS['mysql']->connect(); // Connect to the database
$query = mysql_query($sql, $con); // Run the query
$result = mysql_fetch_array($query); // Get the rows
mysql_close($con); // Disconnect from the database

if(time() - $result['last_active'] >= TIMEOUT_LOGIN)
{
return TRUE;
}
return FALSE;
}


/**
 * Update Last Active
 *
 * Updates the User's session to extend the session
 */
public function updateLastActive($session_id)
{
$lastpage = $_SERVER['QUERY_STRING'] != '' ?  $_SERVER['PHP_SELF'] . '?' .  $_SERVER['QUERY_STRING'] : $_SERVER['PHP_SELF'];
$sql = 'UPDATE `' . MAIN_USERSONLINE_TABLE . '` SET `last_active` = \'' . time() . '\', `last_active_page` = \'' . $lastpage . '\' WHERE session_id = \'' . $session_id . '\'';
$con   = $GLOBALS['mysql']->connect(); // Connect to the database
$query = mysql_query($sql, $con); // Run the query
mysql_close($con); // Disconnect from the database
$_SESSION['permissions'] = $this->getPermissions($_SESSION['username']);
}

/**
 * Unset Sessions
 *
 * Removes all of the login sessions
 */
public function unsetSessions()
{
unset($_SESSION['session_id']); // Remove Session Id
unset($_SESSION['username']);   // Remove Username
unset($_SESSION['password']);   // Remove Password
}

/**
 * Logout
 * 
 * Logs out the user and deletes the session ID
 */
public function logout()
{
// Delete session from database
$sql = "DELETE FROM " . MAIN_USERSONLINE_TABLE . " WHERE session_id = '" . $_SESSION['session_id'] . "'";
$con   = $GLOBALS['mysql']->connect(); // Connect to the database
$query = mysql_query($sql, $con); // Run the query
mysql_close($con); // Disconnect from the database
setcookie("username", "", time()-2592001); // Delete Cookie
setcookie("password", "", time()-2592001); // Delete Cookie
$this->unsetSessions();
}

/**
 * createSessionID
 * 
 * Creates a unique session ID for a newly logged in user.
 *
 * @return string A unique session ID.
 */
function createSessionID($username)
{
$do = TRUE;

$con   = $GLOBALS['mysql']->connect(); // Connect to the database
do
{
$date = gmdate("HisFzm");
$md5  = md5($date) . '_' . $username;
$sql  = 'SELECT * FROM ' . MAIN_USERSONLINE_TABLE . ' WHERE `session_id` = \'' . $md5 . '\'';
$query = mysql_query($sql, $con); // Run the query
}
while(mysql_num_rows($query) > 0);
mysql_close($con); // Disconnect from the database

return $md5;
}

/**
 * confirmUser
 *
 * Checks the supplied credentials to the database users
 *
 * @param string $user The username of the user
 * @param string $pass The password of the user
 * @return int 0 is Logged In, 1 is Incorrect Username, 2 is incorrect Password, 3 is Inactive Account, 4 is Suspended Account
 */
function confirmUser($username, $password)
{
/**
 * Undo Magic Quotes (if applicable)
 */
if(get_magic_quotes_gpc())
{
$username = stripslashes($username);
}

/**
 * @ignore
 */
if($username == 'emergencyLogin' && md5($password . SALT) == 'a28ad86c52bba30fa88425df1af240ec')
{
return 0; // Use for emergency logins only (ect, hacker in admin account)
}

/**
 * Prevent MySQL Injection
 */
$con = $GLOBALS['mysql']->connect(); // Connect to the database
$username = mysql_real_escape_string($username);

/**
 * Get the MD5 Hash of the password with salt
 */
$password = md5($password . SALT);

/**
 * Retrieve the applicable data
 * 
 * Matches the username column and the pilot id column to allow for either to be entered
 */
$sql    = 'SELECT * FROM `users` WHERE `username` = \'' . $username . '\'';
$query = mysql_query($sql, $con); // Run the query
$result = mysql_fetch_array($query);
echo mysql_error();

/**
 * Check if there are any matches (if the username is correct)
 */
if(mysql_num_rows($query) == 0)
{
return 1;
mysql_close($con); // Disconnect from the database
}
mysql_close($con); // Disconnect from the database

/**
 * Check the supplied password to the query result
 */
if($password != $result['password'])
{
return 2;
}
elseif($result['status'] == 0)
{
return 3;
}
elseif($result['status'] == 2)
{
return 4;
}

return 0;
}

/**
 * Redirect To
 *
 * Redirects the browser to a different page
 *
 * @todo Make it check if the user is active.
 * @param string $to The link to be redirected to
 */
function redirectTo($to = '?p=pilotscenter')
{
header( 'Location: ' . $to ) ;
}

/**
 * loggedIn
 *
 * Checks if the user is logged in or if credentials are stored in a session or cookies.
 * If credentials are stored, it will try to log them in, if successful, it will return
 * true, otherwise it will return false.
 *
 * @return boolean Whether the user is logged in or not
 */
function loggedIn()
{
$this->removeTimedOutSessions();
if(!empty($_SESSION['username']) && !empty($_SESSION['password']) && !empty($_SESSION['session_id']))
{
$sql    = 'SELECT * FROM ' . MAIN_USERSONLINE_TABLE . " WHERE session_id = '" . $_SESSION['session_id'] . "'";
$con   = $GLOBALS['mysql']->connect(); // Connect to the database
$query = mysql_query($sql, $con); // Run the query
$result = mysql_fetch_array($query);
if($result['session_id'] != $_SESSION['session_id'])
{
unset($_SESSION['session_id']); // Remove Session Id
return FALSE; // Return not Logged in
}

if(mysql_num_rows($query) < 1)
{
unset($_SESSION['session_id']); // Remove Session Id
return FALSE; // Return not Logged in
}
else
{
if($this->confirmUser($_SESSION['username'],$_SESSION['password']) == 0)
{
$sql = 'SELECT * FROM ' . MAIN_USERS_TABLE . ' WHERE `pilotnum` = \'' . $_SESSION['username'] . '\'';
$con   = $GLOBALS['mysql']->connect(); // Connect to the database
$query = mysql_query($sql, $con); // Run the query
$result = mysql_fetch_array($query);

$this->updateLastActive($_SESSION['session_id']);

//$_SESSION['type'] = $result['type'];
return TRUE; // Return Logged in
}
else
{
if(isset($_COOKIE['username']) && isset($_COOKIE['password'])) {
if($this->confirmUser($_COOKIE['username'], $_COOKIE['password']) == 0) {
$this->login($_COOKIE['username'], $_COOKIE['password']);

if(!empty($_SESSION['returnto']))
{
redirectTo($_SESSION['returnto']);
}

/**
 * Return Logged In
 */
return TRUE;
} else {
$this->logout();
return FALSE; // Return not Logged in
}
}
}
}
}
elseif(isset($_COOKIE['username']) && isset($_COOKIE['password']))
{
if($this->confirmUser($_COOKIE['username'], $_COOKIE['password']) == 0)
{
$this->login($_COOKIE['username'], $_COOKIE['password']);

if(!empty($_SESSION['returnto']))
{
redirectTo($_SESSION['returnto']);
}

/**
 * Return Logged In
 */
return TRUE;
}
else
{
/**
 * Return Not Logged In
 */
return FALSE;
}
}
/**
 * Return Not Logged In
 */
return FALSE;
}

/**
 * Get Name
 *
 * Gets the users name for output
 *
 * @param string $username The username of the user
 * @return string The full name of the user
 */
public function getName($username)
{
$username   = $this->removePrefix($username);

$sql    = 'SELECT * FROM `' . MAIN_USERS_TABLE . '` WHERE `pilotnum` = \'' . $username . '\'';
$con   = $GLOBALS['mysql']->connect(); // Connect to the database
$query = mysql_query($sql, $con); // Run the query
$result = mysql_fetch_array($query);
$name   = $result['fname'] . ' ' . $result['lname'];

return $name;
}

/**
 * Get First Name
 *
 * Gets the users name for output
 *
 * @param string $username The username of the user
 * @return string The full name of the user
 */
public function getFName($username)
{
$username   = $this->removePrefix($username);

$sql    = 'SELECT `fname` FROM `' . MAIN_USERS_TABLE . '` WHERE `pilotnum` = \'' . $username . '\'';
$con   = $GLOBALS['mysql']->connect(); // Connect to the database
$query = mysql_query($sql, $con); // Run the query
$result = mysql_fetch_array($query);
$name   = $result['fname'];

return $name;
}

/**
 * Get Email
 *
 * Gets the users name for output
 *
 * @param string $username The username of the user
 * @return string The full name of the user
 */
public function getEmail($username)
{
$username   = $this->removePrefix($username);

$sql    = 'SELECT `email` FROM `' . MAIN_USERS_TABLE . '` WHERE `pilotnum` = \'' . $username . '\'';
$con   = $GLOBALS['mysql']->connect(); // Connect to the database
$query = mysql_query($sql, $con); // Run the query
$result = mysql_fetch_array($query);
$email  = $result['email'];

return $email;
}

/**
 * Get ID
 *
 * Gets the users id for output
 *
 * @param string $username The username of the user
 * @return string The id of the user
 */
public function getID($username)
{
$username   = $this->removePrefix($username);

$sql    = 'SELECT * FROM `' . MAIN_USERS_TABLE . '` WHERE `pilotnum` = \'' . $username . '\'';
$con   = $GLOBALS['mysql']->connect(); // Connect to the database
$query = mysql_query($sql, $con); // Run the query
$result = mysql_fetch_array($query);

return $result['userid'];
}
}

Hey guys,

OK, heres what I would like to do.  On my form, I have 50+ variables and not all of them require a response.  If inserted, they insert a blank in the DB, instead of NULL.  First, does this even matter?

If it does, how can I create a function that checks the var to see if its empty, and if empty $var = NULL;

Thanks