PHP - Deleting Files

Hii everyone.
I'm using the following code to save a file into a folder, and allow files to be deleted from the folder. the upload works fine. The delete does work, but sometimes you have to click on the delete link a few times before the file is deleted. i'm wondering if someone can see where the problem is in the code. Also, when the file is deleted, the history entry is not added. i'm a bit confused why it doesn't. i'd appreciate any assistance which you can provide. thank you.

Code: [Select]
<?php
include('db.php');
        $CommID = $_GET['CommID'];
        // prevent server timeout if uploads take longer than 30 seconds.
set_time_limit(0);

if (isset($_GET['action'])) {
  $action = $_GET['action'];
} else {
  $action = '';
}

if (($action == 'view' or $action == 'dnld') and isset($_GET['id'])) {
$id = $_GET['id'];

// User is retrieving a file
$sql = "SELECT * FROM communicationsattachments WHERE id = '$id'";
$result = @mysql_query($sql);
if (!$result) {
exit('Database error: ' . mysql_error());
}
  
$file = mysql_fetch_array($result);
if (!$file) {
exit('No files found in database!');
}
    
$uploadDir = "upload/";
$filename = $file['name'];
$mimetype = $file['type'];
$disposition = 'inline';
$filePath = $uploadDir . $filename;
  
if ($action == 'dnld') {
$disposition = 'attachment';
if (strpos($_SERVER['HTTP_USER_AGENT'], 'MSIE 5') or
strpos($_SERVER['HTTP_USER_AGENT'], 'Opera 7')) {
$mimetype = 'application/x-download';
}
}
  
header("content-disposition: $disposition; name=$filename");
header("content-type: $type");
readfile($filename);
   exit();
  
} elseif ($action == 'del' and isset($_GET['id'])) {
   $id = $_GET['id'];
     $sql = "SELECT * FROM communicationsattachments WHERE id='$id'";
$result = @mysql_query($sql);
if (!$result) {
exit('Database error: ' . mysql_error());
}
  
$file = mysql_fetch_array($result);
   if (!$file) {
exit('File with given ID not found in database!');
}
 
chdir('upload/'); 
$uploadDir = "upload/";
$filename = $file['name'];
$mimetype = $file['type'];
$disposition = 'inline';
$path="upload/" . $filename;
if(unlink($path)) 
echo "File has been deleted file ";

// User is deleting a file
mysql_query ("DELETE FROM communicationsattachments WHERE id='$id'") or die(mysql_error());
    
// fetch name of case owner based on CommID Number
$sql = "SELECT communications.CommID, communications.ActionOwner
FROM communications WHERE communications.CommID='$CommID'";
$result = mysql_query($sql);

if (!$result) {
echo "Could not successfully run query ($sql) from DB: " . mysql_error();
exit;
}

if (mysql_num_rows($result) == 0) {
echo "No case owner found";
exit;
}

while ($row = mysql_fetch_assoc($result)) {
$CaseOwner = $row["ActionOwner"];
}


// Inserts history into the communications history table
mysql_query("INSERT INTO communicationshistory (CommID, DateRecorded, TimeRecorded, StatusNotes) 
VALUES ('$CommID', CURDATE(), NOW(), 'Attachment Saved by $CaseOwner')") or die(mysql_error());


// header('location: ' . $_SERVER['PHP_SELF']);
exit();

} elseif (isset($_FILES['upload'])) {

// Bail out if the file isn't really an upload.
if (!is_uploaded_file($_FILES['upload']['tmp_name'])) {
echo "There was no file uploaded!";
//header('location: ' . $_SERVER['PHP_SELF']);
exit; 
}

$uploadDir = "upload/";
$fileName = $_FILES['upload']['name']; 
$tmpName = $_FILES['upload']['tmp_name']; 
$fileSize = $_FILES['upload']['size']; 
$fileType = $_FILES['upload']['type']; 
$uploaddesc = $_POST['desc'];
$filePath = $uploadDir . $fileName; 
$result = move_uploaded_file($tmpName, $filePath); 
if (!$result) { 
echo "Error uploading file"; 
 } 

if(!get_magic_quotes_gpc()) 
{ 
$fileName = addslashes($fileName); 
$filePath = addslashes($filePath); 
}  

$query = "INSERT INTO communicationsattachments (name, type, description, CommID,  size, path ) ". 
"VALUES ('$fileName', '$fileType', '$uploaddesc', '$CommID', '$fileSize', '$filePath')"; 
mysql_query($query) or die('Error, query failed : ' . mysql_error());  
echo "<br>Files uploaded<br>"; 

// fetch name of case owner based on Mega Case Number
$sql = "SELECT communications.CommID, communications.ActionOwner
FROM communications WHERE communications.CommID='$CommID'";
$result = mysql_query($sql);

if (!$result) {
echo "Could not successfully run query ($sql) from DB: " . mysql_error();
exit;
}

if (mysql_num_rows($result) == 0) {
echo "No case owner found";
exit;
}

while ($row = mysql_fetch_assoc($result)) {
$CaseOwner = $row["ActionOwner"];
}


// Inserts history into the communications history table
mysql_query("INSERT INTO communicationshistory (CommID, DateRecorded, TimeRecorded, StatusNotes) 
VALUES ('$CommID', CURDATE(), NOW(), 'Attachment Saved by $CaseOwner')") or die(mysql_error());

}

// Default page view: lists stored files
$sql = "SELECT * FROM communicationsattachments WHERE CommID=$CommID";
$filelist = @mysql_query($sql);
if (!$filelist) {
  exit('Database error: ' . mysql_error());
}
?>

<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN"
    "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<title></title>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1" />
   
<link href="styles.css" rel="stylesheet" type="text/css" />
<style type="text/css">
body {
background-color: #cad7f6;
}
</style>
<script type="text/javascript">
function refresh_parent(){
    window.parent.location = window.parent.location.href;
}
</script>

</head>
<body>
        <div style="margin:20PX; background-color:#cad7f6; ">
            <form action="" method="post" enctype="multipart/form-data" >
                Upload File:
                <input type="file" name="upload" />
                File Description: (not required)
                <input type="text" name="desc" maxlength="255" />
                <input type="submit" value="Upload" onclick="refresh_parent()"/>
            <input name="MAX_FILE_SIZE" type="hidden" value="10737418240" />
        </form>
        Files stored in the datebase for CommID <?php echo $CommID; ?> are listed below. You may attach as many files as necessary.<br /><br />
        <table>
            <tr>
                <th>Filename: </th>
                <th>Description: </th>
                <th>Size: </th>
            </tr>
<?php
if (mysql_num_rows($filelist) > 0) {
   while ($f = mysql_fetch_array($filelist)) {
?>

            <tr valign="top">
                <td width="200px"><?php echo $f['name']; ?> </td>
                <td width="200px"><?php echo $f['description']; ?> </td>
                <td><?php echo $f['size']; ?> </td>
                <td>
                    [<a href="<?php echo $_SERVER['PHP_SELF']; ?>?action=dnld&amp;id=<?php echo $f['id']; ?>">Download</a> |
                    <a href="<?php echo $_SERVER['PHP_SELF']; ?>?action=del&amp;id=<?php echo $f['id']; ?>" onclick="refresh_parent()">Delete</a>]
                </td>
            </tr>
<?php
}
} else {
?>
<tr><td colspan="3">No Files!</td></tr>
<?php
}
?>
</table>
</div>
</body>
</html>

i am trying to delete files for a user, and then update the database with the new bandwhitch/free space.  here is my code:

http://pastebin.com/J2XE9Fip

i just can't figure out where i'm going wrong... 

thanks in advance

I have a bad way with words, so if the title doesnt make much sense nor my post, I apolagize!

But I am using a while loop and mysql_fetch_array to echo all information in a table in mysql.

With each entry, I have included a button that executes a delete query for that entry.

Code: [Select]
$delquery="DELETE FROM requests WHERE user = '".$row['user']."'";
mysql_query($delquery,$link2);
echo "<font size='19px' color='#009933'>User deleted from request database.When I click the button, the message is echod in every entry listed on the page, and nothing happens. I figured Id use delete from the username, so that way mysql will know which one to delete... but Idk when I think about it thats dumb and makes no sense. Im stuck.

This side of the application im trying to make is the admin side where I can process requests. After I process the request I delete it from the database so I know I processed it. I have no idea what query to use for this.

Anybody know how I could do this?

Thanks

Could anyone tell me why this is not deleting the userip and post id from the database at all.

Thanks


Code: [Select]
<?php
include('dbcon.php');

if($_REQUEST['postId'])
{
$userip = $_SERVER['REMOTE_ADDR'];

mysql_query("update collapsed_likes set likes=likes-1 where post_id= ".$_REQUEST['postId']);

mysql_query("delete from collapsed_ip where userip=".$userip." AND post_id = ".$_REQUEST['postId']);

$total_likes = mysql_query("SELECT * FROM collapsed_likes where post_id = ".$_REQUEST['postId']." ");
$likes = mysql_fetch_array($total_likes);
$likes = $likes['likes'];
}
echo $likes;
?>

So far I have managed to create an upload process which uploads a picture, updates the database on file location and then tries to upload the db a 2nd time to update the Thumbnails file location (i tried updating the thumbnails location in one go and for some reason this causes failure)

But the main problem is that it doesn't upload some files

Here is my upload.php

<?php
include 'dbconnect.php';

$statusMsg = '';

$Title = $conn -> real_escape_string($_POST['Title']) ; 
$BodyText = $conn -> real_escape_string($_POST['ThreadBody']) ; 
	 

// File upload path
$targetDir = "upload/";
$fileName = basename($_FILES["file"]["name"]);
$targetFilePath = $targetDir . $fileName;
$fileType = pathinfo($targetFilePath,PATHINFO_EXTENSION);
$Thumbnail = "upload/Thumbnails/'$fileName'";

if(isset($_POST["submit"]) && !empty($_FILES["file"]["name"])){
    // Allow certain file formats
    $allowTypes = array('jpg','png','jpeg','gif','pdf', "webm", "mp4");
    if(in_array($fileType, $allowTypes)){

        // Upload file to server
        if(move_uploaded_file($_FILES["file"]["tmp_name"], $targetFilePath)){

            // Insert image file name into database
            $insert = $conn->query("INSERT into Threads (Title, ThreadBody, filename) VALUES ('$Title', '$BodyText', '$fileName')");
            if($insert){
               $statusMsg = "The file ".$fileName. " has been uploaded successfully."; 

		$targetFilePathArg = escapeshellarg($targetFilePath);
		$output=null;
		$retval=null;
		 //exec("convert $targetFilePathArg -resize 300x200 ./upload/Thumbnails/'$fileName'", $output, $retval);
		 exec("convert $targetFilePathArg -resize 200x200 $Thumbnail", $output, $retval);
		echo "REturned with status $retval and output:\n" ; 
		if ($retval == null) { 
		echo "Retval is null\n" ;
		echo "Thumbnail equals $Thumbnail\n" ; 
		}

            }else{
                $statusMsg = "File upload failed, please try again.";
            } 
        }else{
            $statusMsg = "Sorry, there was an error uploading your file.";
        }
    }else{
        $statusMsg = 'Sorry, only JPG, JPEG, PNG, GIF, mp4, webm & PDF files are allowed to upload.';
    }
}else{
    $statusMsg = 'Please select a file to upload.';
}

//Update SQL db by setting the thumbnail column to equal $Thumbnail
$update = $conn->query("update Threads set thumbnail = '$Thumbnail' where filename = '$fileName'");
            if($update){
               $statusMsg = "Updated the thumbnail to sql correctly.";
		echo $statusMsg ;  } 
else 
{ echo "\n Failed to update Thumbnail. Thumbnail equals $Thumbnail" ; } 


// Display status message
echo $statusMsg;
?>

And this does work on most files however it is not working on a 9.9mb png file  which is named "test.png" I tested on another 3.3 mb gif file and that failed too?

For some reason it returns the following

Updated the thumbnail to sql correctly.Updated the thumbnail to sql correctly.

Whereas on the files it works on it returns

REturned with status 0 and output: Retval is null Thumbnail equals upload/Thumbnails/'rainbow-trh-stache.gif' Failed to update Thumbnail. Thumbnail equals upload/Thumbnails/'rainbow-trh-stache.gif'The file rainbow-trh-stache.gif has been uploaded successfully.

Any idea on why this is?