PHP - Register Form - Confirm Password - Help

I am trying to use the new way of validating the entered email in a register form.

Code: [Select]
/* REGISTER FORM */
// check if submit button has been clicked
if (isset($_POST['submit_signup'])) {

// process and assign variables after post submit button has been clicked
$user_email = strip_tags(trim($_POST['email']));
$user_email             = filter_var($user_email, FILTER_VALIDATE_EMAIL);

$nickname = strip_tags(trim($_POST['nickname']));
$password = $_POST['password'];
$repassword = $_POST['repassword'];
$month = $_REQUEST['month'];
$day = $_REQUEST['day'];
$year = $_REQUEST['year'];
$dob = $year . "-" . $month . "-" . $day;
$find_us_question = strip_tags(trim($_POST['find_us_question']));

// connect to database
$dbc = mysqli_connect(DB_HOST, DB_USER, DB_PASSWORD, DB_NAME);

$check_query = "SELECT * FROM user WHERE nickname = '$nickname'";

$check_connect  = mysqli_query($dbc, $check_query) or die(mysqli_error($dbc));

$check_count =  mysqli_num_rows($check_connect);

       
       
       
        // Check if the email exists twice
       
        $query_get = "SELECT email FROM user WHERE email = '$user_email'";

        $query_run = mysqli_query($dbc, $query_get);

        $num_rows = mysqli_num_rows($query_run);
       
       
       
       
       
       
       
// check if username is already taken
if ($check_count != 0) {
echo "Username already exists!";
           
               
        } elseif ($num_rows != 0) {
           
            echo "This email address is already registered in the database, you can not register it twice.";
           
           
// check if fields are empty
} elseif (empty($user_email) || empty($nickname) || empty($password) || empty($day) || empty($month) || empty($year)) {
echo "Please fill out all the fields!";

// check char length of input data
} elseif (strlen($nickname) > 30 || strlen($user_email) > 50) {
echo "Maximum allowed character length for nickname/firstname/lastname are 30 characters!";

// check password char length
} elseif (strlen($password) > 25 || strlen($password) < 6) {
echo "Your password must be between 6 and 25 characters!";

// check if passwords match with each other
} elseif ($password != $repassword) {
echo "Please make sure your passwords are matching!";

} else {
// encrypt password
$password = sha1($password);
I would like to implement now an error message stating something along the lines that the entered email address is not valid, how would I have to do the if statement to check the condition?

This is my registering script:

<?php
include('connectvars.php');

$user_email = strip_tags(trim($_POST['email']));
$firstname = strip_tags(trim($_POST['firstname']));
$lastname = strip_tags(trim($_POST['lastname']));
$nickname = strip_tags(trim($_POST['nickname']));
$password = strip_tags($_POST['password']);
$repassword = strip_tags($_POST['repassword']);
$dob = $_POST['dob'];
$find_us_question = strip_tags(trim($_POST['find_us_question']));


if (isset($_POST['submit_signup'])) {

if ((empty($user_email)) || (empty($firstname)) || (empty($lastname)) || (empty($nickname)) || (empty($password)) || (empty($dob))) {

echo "Please fill out all the fields!";

} else {
// check char length of input data
if (($nickname > 30) || ($firstname > 30)  || ($lastname > 30) || ($user_email > 50)) {

echo "Your nickname, first- and/or lastname seem to be too long, please make sure you have them below the maximum allowed length of 30 characters!";

} else {

// check password char length
if (($password > 25) || ($password < 6)) {
echo "Your password must be between 6 and 25 characters!";

} else {
// encrypt password
$password = sha1($password);
$repassword = sha1($repassword);


 if ($password != $repassword) {
echo "Please make sure your passwords are matching!";

} else {

$dbc = mysqli_connect(DB_HOST, DB_USER, DB_PASSWORD, DB_NAME);

$query = sprintf("INSERT INTO user (firstname, lastname, nickname, password, email, dob, doj) VALUES ('%s', '%s', '%s', '%s', '%s', '%s', now())",
mysqli_real_escape_string($dbc, $firstname),
mysqli_real_escape_string($dbc, $lastname),
mysqli_real_escape_string($dbc, $nickname),
mysqli_real_escape_string($dbc, $password),
mysqli_real_escape_string($dbc, $user_email),
$dob);



mysqli_query($dbc, $query);

mysqli_close($dbc);

echo "You have been successfully registered!";

}

}
}
}
}

?>


A bunch of nested if statements, the read-ability gets worse after a while, I'm new to programming so I don't know if there's a better more read-able solution.

Anyway, every time I try to sign up it's printing out the echo message:
"Your password must be between 6 and 25 characters!"

Which derives from:


// check password char length
if (($password > 25) || ($password < 6)) {
echo "Your password must be between 6 and 25 characters!";

} else {


EVEN if I stay between 6 and 25 characters it's still printing out this error message, let's say I have a password of 8 characters, and I've entered everything else correctly, it's still giving me all the time this error message, and I can not figure out why.

Sorry for many posts, trying to make my website   When I press the register button on my website it will just act as if the page is refreshing and not send any information to mysql I believe I have connected everything up correctly, can anyone tell my what I have done wrong please?   If you want to check out the website to see what is going on check out www.jokestary.comli.com

<?php


//This function will display the registration form

function register_form(){


$date = date('D, M, Y');

echo "<form action='?act=register' method='post'>"

."Username: <input type='text' name='username' size='30'><br>"

."Password: <input type='password' name='password' size='30'><br>"

."Confirm your password: <input type='password' name='password_conf' size='30'><br>"

."Email: <input type='text' name='email' size='30'><br>"

."<input type='hidden' name='date' value='$date'>"

."<input type='submit' value='Register'>"

."</form>";


}


//This function will register users data

function register(){


//Connecting to database

include('connect.php');

if(!$connect){

die(mysql_error());

}


//Selecting database

$select_db = mysql_select_db("database", $connect);

if(!$select_db){

die(mysql_error());

}


//Collecting info

$username = $_REQUEST['username'];

$password = $_REQUEST['password'];

$pass_conf = $_REQUEST['password_conf'];

$email = $_REQUEST['email'];

$date = $_REQUEST['date'];


//Here we will check do we have all inputs filled


if(empty($username)){

die("Please enter your username!<br>");

}


if(empty($password)){

die("Please enter your password!<br>");

}


if(empty($pass_conf)){

die("Please confirm your password!<br>");

}


if(empty($email)){

die("Please enter your email!");

}


//Let's check if this username is already in use


$user_check = mysql_query("SELECT username FROM users WHERE username='$username'");

$do_user_check = mysql_num_rows($user_check);


//Now if email is already in use


$email_check = mysql_query("SELECT email FROM users WHERE email='$email'");

$do_email_check = mysql_num_rows($email_check);


//Now display errors


if($do_user_check > 0){

die("Username is already in use!<br>");

}


if($do_email_check > 0){

die("Email is already in use!");

}


//Now let's check does passwords match


if($password != $pass_conf){

die("Passwords don't match!");

}



//If everything is okay let's register this user


$insert = mysql_query("INSERT INTO users (username, password, email) VALUES ('$username', '$password', '$email')");

if(!$insert){

die("There's little problem: ".mysql_error());

}


echo $username.", you are now registered. Thank you!<br><a href=login.php>Login</a> | <a href=index.php>Index</a>";


}


switch($act){


default;

register_form();

break;


case "register";

register();

break;


}


?> 

Here is the connect.php code

<?php
$hostname="mysql6.000webhost.com"; //local server name default localhost
$username="a5347792_users";  //mysql username default is root.
$password="";       //blank if no password is set for mysql.
$database="a5347792_users";  //database name which you created
$con=mysql_connect($hostname,$username,$password);
if(! $con)
{
die('Connection Failed'.mysql_error());
}
 
mysql_select_db($database,$con);
?>

Hello,   i got a problem with a part of my code :   <?php

Hi everyone, im working on a e comm site as a project.
I have a register.php page, and its supposed to check for the presence of posted data, and if data is not posted show a form block,and if posted data is present insert it into a database.
However its not working,i get an unexpected } on line 114, where there is a }else{ .
I've only been working with php a few days, but from what i've read the braces seem where they should be,can someone please tell me where the problem is?
<script language="JavaScript" type="text/javascript" src="library/checkout.js"></script>
<?php
//set up a couple of functions
function doDB() {
global $mysqli;

//connect to server and select database; you may need it
$mysqli = mysqli_connect("localhost", "root", "", "onlinestore");
}
//determine if they need to see the form or not
if (!$_POST) {
//they need to see the form, so create form block
$display_block = "

<form name=\"register\" method=\"post\"action=\"index.php?r=1\"\ id=\"register\">
<table width=\"550\" border=\"0\" align=\"center\" cellpadding=\"5\" cellspacing=\"1\" class=\"entryTable\">
        <tr class=\"entryTableHeader\"> 
            <td colspan=\"2\">Login Details</td>
        </tr>
        <tr> 
            <td width=\"150\" class=\"label\">Email</td>
            <td class=\"content\"><input name\=\"txtEmail\" type=\"text\" class=\"box\" id=\"txtEmail\" size=\"30\" maxlength=\"50\"></td>
        </tr>
        <tr> 
            <td width=\"150\" class=\"label\">Password</td>
            <td class=\"content\"><input name=\"txtPassword\" type=\"password\" class=\"box\" id=\"txtPassword\" size=\"30\" maxlength=\"50\"></td>
        </tr>
    </table>
    <p>&nbsp;</p>    
      <table width=\"550\" border=\"0\" align=\"center\" cellpadding=\"5\" cellspacing=\"1\" class=\"entryTable\">
        <tr class=\"entryTableHeader\"> 
            <td colspan=\"2\">Shipping Information</td>
        </tr>
        <tr> 
            <td width=\"150\" class=\"label\">First Name</td>
            <td class=\"content\"><input name=\"txtShippingFirstName\" type=\"text\" class=\"box\" id=\"txtShippingFirstName\" size=\"30\" maxlength=\"50\"></td>
        </tr>
        <tr> 
            <td width=\"150\" class=\"label\">Last Name</td>
            <td class=\"content\"><input name=\"txtShippingLastName\" type=\"text\" class=\"box\" id=\"txtShippingLastName\" size=\"30\" maxlength=\"50\"></td>
        </tr>
        <tr> 
            <td width=\"150\" class=\"label\">Address1</td>
            <td class=\"content\"><input name=\"txtShippingAddress1\" type=\"text\" class=\"box\" id=\"txtShippingAddress1\" size=\"50\" maxlength=\"100\"></td>
        </tr>
        <tr> 
            <td width=\"150\" class=\"label\">Address2</td>
            <td class=\"content\"><input name=\"txtShippingAddress2\" type=\"text\" class=\"box\" id=\"txtShippingAddress2\" size=\"50\" maxlength=\"100\"></td>
        </tr>
        <tr> 
            <td width=\"150\" class=\"label\">Phone Number</td>
            <td class=\"content\"><input name=\"txtShippingPhone\" type=\"text\" class=\"box\" id=\"txtShippingPhone\" size=\"30\" maxlength=\"32\"></td>
        </tr>
        <tr> 
            <td width=\"150\" class=\"label\">Area</td>
            <td class=\"content\"><input name=\"txtShippingState\" type=\"text\" class=\"box\" id=\"txtShippingState\" size=\"30\" maxlength=\"32\"></td>
        </tr>
        <tr> 
            <td width=\"150\" class=\"label\">City</td>
            <td class=\"content\"><input name=\"txtShippingCity\" type=\"text\" class=\"box\" id=\"txtShippingCity\" size=\"30\" maxlength=\"32\"></td>
        </tr>
        <tr> 
            <td width=\"150\" class=\"label\">Post Code</td>
            <td class=\"content\"><input name=\"txtShippingPostalCode\" type=\"text\" class=\"box\" id=\"txtShippingPostalCode\" size=\"10\" maxlength=\"10\"></td>
        </tr>
    </table>
    <p>&nbsp;</p>
    <table width=\"550\" border=\"0\" align=\"center\" cellpadding=\"5\" cellspacing=\"1\" class=\"entryTable\">
        <tr class=\"entryTableHeader\"> 
            <td width=\"150\">Payment Information</td>
            <td><input type=\"checkbox\" name=\"chkSame\" id=\"chkSame\" value=\"checkbox\" onClick=\"setPaymentInfo(this.checked);\"> 
                <label for=\"chkSame\" style=\"cursor:pointer\">Same as shipping information</label></td>
        </tr>
        <tr> 
            <td width=\"150\" class=\"label\">First Name</td>
            <td class=\"content\"><input name=\"txtPaymentFirstName\" type=\"text\" class=\"box\" id=\"txtPaymentFirstName\" size=\"30\" maxlength=\"50\"></td>
        </tr>
        <tr> 
            <td width=\"150\" class=\"label\">Last Name</td>
            <td class=\"content\"><input name=\"txtPaymentLastName\" type=\"text\" class=\"box\" id=\"txtPaymentLastName\" size=\"30\" maxlength=\"50\"></td>
        </tr>
        <tr> 
            <td width=\"150\" class=\"label\">Address1</td>
            <td class=\"content\"><input name=\"txtPaymentAddress1\" type=\"text\" class=\"box\" id=\"txtPaymentAddress1\" size=\"50\" maxlength=\"100\"></td>
        </tr>
        <tr> 
            <td width=\"150\" class=\"label\">Address2</td>
            <td class=\"content\"><input name=\"txtPaymentAddress2\" type=\"text\" class=\"box\" id=\"txtPaymentAddress2\" size=\"50\" maxlength=\"100\"></td>
        </tr>
        <tr> 
            <td width=\"150\" class=\"label\">Phone Number</td>
            <td class=\"content\"><input name=\"txtPaymentPhone\" type=\"text\" class=\"box\" id=\"txtPaymentPhone\" size=\"30\" maxlength=\"32\"></td>
        </tr>
        <tr> 
            <td width=\"150\" class=\"label\">Area</td>
            <td class=\"content\"><input name=\"txtPaymentState\" type=\"text\" class=\"box\" id=\"txtPaymentState\" size=\"30\" maxlength=\"32\"></td>
        </tr>
        <tr> 
            <td width=\"150\" class=\"label\">City</td>
            <td class=\"content\"><input name=\"txtPaymentCity\" type=\"text\" class=\"box\" id=\"txtPaymentCity\" size=\"30\" maxlength=\"32\"></td>
        </tr>
        <tr> 
            <td width=\"150\" class=\"label\">Post Code</td>
            <td class=\"content\"><input name=\"txtPaymentPostalCode\" type=\"text\" class=\"box\" id=\"txtPaymentPostalCode\" size=\"10\" maxlength=\"10\"></td>
        </tr>
    </table>
    <p>&nbsp;</p>

    <p>&nbsp;</p>
    <p align=\"center\"> 
        <input class=\"box\" name=\"btnStep1\" type=\"submit\" id=\"btnStep1\" value=\"Proceed &gt;&gt;\">
    </p>
</form>" 
} else {
//connect to database
doDB();
//add records
$add_sql = "INSERT INTO tbl_customer (email) VALUES('".$_POST["txtEmail"]."')";
$add_sql = "INSERT INTO tbl_customer (password) VALUES('".$_POST["txtPassword"]."')";

$add_sql = "INSERT INTO tbl_customer (od_shipping_first_name) VALUES('".$_POST["txtShippingFirstName"]."')";
$add_sql = "INSERT INTO tbl_customer (od_shipping_last_name) VALUES('".$_POST["txtShippingLastName"]."')";
$add_sql = "INSERT INTO tbl_customer (od_shipping_address1) VALUES('".$_POST["txtShippingAddress1"]."')";
$add_sql = "INSERT INTO tbl_customer (od_shipping_address2) VALUES('".$_POST["txtShippingPhone"]."')";
$add_sql = "INSERT INTO tbl_customer (od_shipping_phone) VALUES('".$_POST["txtShippingState"]."')";
$add_sql = "INSERT INTO tbl_customer (od_shipping_city) VALUES('".$_POST["txtShippingCity"]."')";
$add_sql = "INSERT INTO tbl_customer (od_shipping_state) VALUES('".$_POST["txtShippingState"]."')";
$add_sql = "INSERT INTO tbl_customer (od_shipping_postal_code) VALUES('".$_POST["txtShippingPostalCode"]."')";

$add_sql = "INSERT INTO tbl_customer (od_payment_first_name) VALUES('".$_POST["txtPaymentFirstName"]."')";
$add_sql = "INSERT INTO tbl_customer (od_payment_last_name) VALUES('".$_POST["txtPaymentLastName"]."')";
$add_sql = "INSERT INTO tbl_customer (od_payment_address1) VALUES('".$_POST["txtPaymentAddress1"]."')";
$add_sql = "INSERT INTO tbl_customer (od_payment_address2) VALUES('".$_POST["txtPaymentPhone"]."')";
$add_sql = "INSERT INTO tbl_customer (od_payment_phone) VALUES('".$_POST["txtPaymentState"]."')";
$add_sql = "INSERT INTO tbl_customer (od_payment_city) VALUES('".$_POST["txtPaymentCity"]."')";
$add_sql = "INSERT INTO tbl_customer (od_payment_state) VALUES('".$_POST["txtPaymentState"]."')";
$add_sql = "INSERT INTO tbl_customer (od_payment_postal_code) VALUES('".$_POST["txtPaymentPostalCode"]."')";


$add_res = mysqli_query($mysqli, $add_sql) or die(mysqli_error($mysqli));
$display_block = "<p>Thanks for signing up!</p>";
}
?>