PHP - Include Functions In A Class!

I been wondering how to protect all the files that contain classes, functions and forms in php to prevent direct access to something that the user shouldnt be able to without the proper check's (typing http://server/inc/login.php insteand of http://server/), and i came to this small idea of checking if an object is set or not but i m wondering if this is really the best idea here's what i have (the case bellow will protect an login form to be accessed directly):

Code: [Select]
<?php
    if(!isset($mysqlobj)) die();
    if( isset( $_POST['username'] ) && isset( $_POST['password'] ) ){
        $login = authentication::login( $_POST['username'], $_POST['password'] );
        if( $login == true ){
            header( 'location:?go=home' );
        }else{
            $_SESSION['message'] = 'loginfailed';
            header( 'location:?go=login' );
        }
    }else{
      if( !empty($_SESSION['logged'] ) && $_SESSION['logged'] == true ){
          header( 'location:?go=home' );
      }else{
          ?>
            <div id="loginform">
                <form action="?go=login" method="post">
                    <table align="center">
                        <tr>
                            <td><font size="2">Username</font></td>
                            <td><input type="text" name="username" /></td>
                        </tr>
                        <tr>
                            <td><font size="2">Password</font></td>
                            <td><input type="password" name="password" /></td>
                        </tr>
                        <tr>
                            <td colspan="2" align="center"><input type="submit" value="Login" /></td>
                        </tr>
                    </table>
                </form>
                </div>               
          <?php
      }   
    }
?>

Just looking for an "best practice" i tried google for it but i couldnt get to an straight awnser any enlightment is appreciated.

Using PHP Version 5.2.13
My question: How do I access a class and it's methods from an included file?

I have an Index.php page that calls two methods:
<?php get_header(); ?>
<?php get_footer(); ?>

and it creates a class in an include file
<?php include_once($_SERVER['DOCUMENT_ROOT'].'/includes/common.html');?>
   $site = new WebSite($site_name); // Creates a bunch of properties, defines some methods, etc...
              $site->initialize();

<?php get_header(); ?> ends up including a another file (header.php)
<?php get_header(); ?> ends up including a another file (footer.php)

All calls in Index.php to methods in my class work. ie <?php $site->display_section('column'); ?>
But calls in either the header.php or footer.php to methods in my class fail with "Call to a member function is not an object".
I understand what the error means but I don't understand why. I thought all functions and classes defined in an include file have global scope. As per PHP.NET's documentation:

"When a file is included, the code it contains inherits the variable scope of the line on which the include occurs. Any variables available at that line in the calling file will be available within the called file, from that point forward. However, all functions and classes defined in the included file have the global scope."

The include that creates the class is something that I have inherited from another developer and I actually can't change the scope. I've tried with global $site = new WebSite($site_name);. It actually breaks the entire site.

How can I access classes, properties, methods in an include file?

Any help would be appreciated. I've been racking my head for several days now on it and it's probably some newbie thing that I am completely overlooking. I hope I've provided enough background and info.

Thanks,

Brian

I have 2 php files. I am unable to get B's global variable from A's static method:

A.php
Code: [Select]
class c_A
  { public static function f_A()
      { include_once( "B.php" ) ;
        print f_B() ;
      }
  }
c_A::f_A( ); // only prints "B : "

B.php
Code: [Select]
$gvs = "global variable from B" ;

function f_B()
  { return "B : " . $GLOBALS[ "gvs" ] ;
  }


any thoughts?


thanks,
Shannon

Hi, I'm having a bit of a problem understanding why I'm not able to use the class I'm extending off of functions.

I have a category class that extends off my core class, inside that category class, I'm able to use the core functions and variables inside all custom functions, but not the __construct function.

So, to be clear, inside class class, I'm able to call $this->core->function() inside custom functions, such as function add_parent(), but not the __construct function.

Why is this happening, what is the logic behind this?

This is how I'm extending the class off of the core class:
Code: [Select]
<?php
$core  = new core;
$parent = new parents;
$parent->core =& $core;
?>

With this, like I said, I'm able to use all of my core functions inside all other classes called this way, so inside all of the other classes I can do:
Code: [Select]
<?php $this->core->function(); ?>everywhere besides __construct().

Do I not have the class called properly? Do I need to pass my core class through differently? How can I fix this?

Thanks.

I am currently building my own MVC Framework and I have run into an issue that I can't solve when attempting to use 2 methods from a single model. I know that this isn't an issue with the queries or information being return. I am unsure of the proper way that I can call 2 methods when checking to see if a user is logged in... The issue that I face is both methods are calling the DB and it throws a PDO error which I don't know how to get around the issue.. Any guidance would be nice as I have been banging my head over this issue. Thank you!

 

Fatal error: Uncaught Error: Call to undefined method PDO::Select() in C:\xampp\htdocs\PicWrist\app\models\user.class.php:318 Stack trace: #0 C:\xampp\htdocs\PicWrist\app\controllers\home.php(21): User->getUser('4') #1 C:\xampp\htdocs\PicWrist\app\core\app.php(36): Home->index() #2 C:\xampp\htdocs\PicWrist\app\init.php(47): App->__construct() #3 C:\xampp\htdocs\PicWrist\public\index.php(5): require('C:\\xampp\\htdocs...') #4 {main} thrown in C:\xampp\htdocs\PicWrist\app\models\user.class.php on line 318

 

//Controller

<?php 
	/**
	 * Load the View
	 */
	class Controller{

		public function view($view, $data = []) {
			if (file_exists('../app/views/' . $view . '.php')) {
				require_once '../app/views/' . $view . '.php';
			} 
		}

		public function model($model, $data = []) {

			if (file_exists('../app/models/' . $model . '.class.php')) {
				require_once '../app/models/' . $model . '.class.php';

				return new $model();

			} else 

				return false;
		}
	}

?>

//Home Controller
<?php 
Class Home extends Controller {

	public static $user;
	public $errors;

	public function __construct() {

		self::$user = $this->model('user');

	}

	public function index() {
		$userdata 			= [];
		$data				= [];

		show(self::$user);
		$isLoggedin	= self::$user->isLoggedin;
		show($isLoggedin);

		$userdata = self::$user->getUser($_SESSION['user_id']);
		show($userdata);

		$this->view('home', $data);
	}

}

?>
<?php 
/**
 * Users
 */
class User
{
	private $db;
	private $errors = '';
	public $isLoggedin = False;
	public $isAdmin = False;

	public function __construct() {
		$this->isLoggedIn();
	}

	public function isLoggedIn() {

		if(isset($_SESSION['user_id'])){

			$data['user_id'] = $_SESSION['user_id'];
			$db = Database::getInstance();
			$query = "SELECT * FROM users WHERE user_id = :user_id LIMIT 1";
			$results = $db->Select($query, $data);

			if (is_array($results)) {
				 $this->isLoggedIn = True;
			}
		}

	}


	public function getUser($id) {

		if(isset($id)) {

			$data['user_id']	= intval($id);
			$db 				= Database::getInstance();
			$query 				= 'SELECT * FROM users WHERE user_id = :user_id';

			$results = $db->Select($query, $data);

			if (is_array($results)) {
				return $results;
			} else {
				return False;
			}
		} else {
			return False;
		}
	}

//DB
<?php 
	/**
	 * Database Connection
	 */
	class Database	{
		private $dbHost = DB_HOST;
		private $dbUser = DB_USER;
		private $dbPass = DB_PASS;
		private $dbName = DB_NAME;

		private $statment;
		private static $dbHandler;
		private $error;

		public function __construct()
		{
			$conn = 'mysql:host=' . $this->dbHost . ';dbname=' . $this->dbName;

			$options = array(
				PDO::ATTR_PERSISTENT 	=> true,
				PDO::ATTR_ERRMODE 		=> PDO::ERRMODE_EXCEPTION
			);

			try {
				self::$dbHandler = new PDO($conn, $this->dbUser, $this->dbPass, $options);
			} catch (PDOException $e) {
				self::$error = $e->getMessage();
				echo self::$error;
			}
		}

		public static function getInstance() {

			if(self::$dbHandler) {
				return self::$dbHandler;
			}

			return $instance = new Self();
		}

		public function Select($query, $data = array()) {
			$statement = self::$dbHandler->prepare($query);
			$result	= $statement->execute($data);

			If($result) {
				$data = $statement->fetchAll(PDO::FETCH_OBJ);
					if(is_array($data)) {
						// show($data);
						return $data;
				}
			}

			return False;
		}

		public function Update($query, $data = array()) {
			$statement = self::$dbHandler->prepare($query);
			$result	= $statement->execute($data);

			If($result) {
				return True;
			} 
			
			return False;

		}

	}

?>

 

Edited July 14 by avargas94
Wrong Code

This is a bit of a more advanced question so I am hoping there are some advanced programmers online at this time . Anyways basically I want to be able to "queue" functions from a class in a single call and am wondering if I am doing it correctly or if there is a better way to do it. Here is my code:


<?php
class test {
     private static $one;
     private static $two;
     private static $three;

     public function callOne($val){
          $one .= $val;
          return $this;
     }
     
     public function callTwo($val){
          $two .= $val;
          return $this;
     }

     public function callThree($val){
           $three .= $val;
           return $this;
     }

     public function print(){
          echo $this->one.' '.$this->two.' '.$this->three;
     }
}
?>


now when I want to call this I can do:

$test = new test();
$test->callOne('one')->callTwo('two')->callThree('three');
$test->callOne('another one');
$test->print();


Is there a better way to do this or is there a different method of doing this? Just wanna make sure I am doing it right lol.

Was just wondering why some people choose NOT to make use of static functions when initializing objects via Factory Classes/Containers.

What are the benefits of initializing the Factory class when for all intensive purposes, it's only used to initialize new classes, etc? 
Does this have any impact on Dependency Injection?  I'm assuming that it doesn't since that would defeat the purpose.

---------

Also, I've noticed that there seems to be an intense stigma within the development community in regard to singletons. 
Are singletons necessarily a bad thing? 

What about database objects? 

One argument I've heard is that this can often impact the flexibility of your application in the event that a new instance of said class needs to be initialized(a second completely separate connection).

However, I was thinking that you could simply store these objects within a static member variable in the factory class; leaving the Database Class' __construct public in the event that you need to create that second/third/fourth connection.

Wouldn't this resolve the issue? 

I have a script I am putting together that simulate a cricket game. The only issue is, that there are a huge number of functions because there doesn't seem to be any other way to do this properly. As well as this, there a while() loop and all this seems to be leading to the page reaching a max 30 second timeout when generating the result.

My code is attached below, it is quite messy at the moment because i've just be working on it, but I was wondering if anyone has any solutions of how I can speed this up or change to prevent a timeout:

<?php
// Error reporting
error_reporting(E_ALL);

// Connect DB
mysql_connect("wickettowicket.adminfuel.com", "rockinaway", "preetha6488") or die(mysql_error());

// Select DB
mysql_select_db("wickettowicket") or die(mysql_error());

// MySQL queries to find batsmen and bowlers 
$array_batsmen = mysql_query('SELECT id, name, ability, strength FROM wtw_players WHERE team_id = 1 ORDER BY id ASC');
$array_bowlers = mysql_query('SELECT id, name, ability, strength FROM wtw_players WHERE team_id = 2');

// Start table for data 
$data = '<table width="600px">';

// Create blank scorecard
while ($array_bat = mysql_fetch_array($array_batsmen))
{
$data .= '<tr><td>'.$array_bat['name'].'</td><td></td><td></td><td>0</td></tr>';
}

// Set up arrays for players 
$current_batsman = $current_bowler = array();

// Reset query
mysql_data_seek($array_batsmen,0);

$in_one = $in_two = $it = '';

function currentBatsman($id, $name, $ability, $strength, $out, $in, $runs)
{
global $current_batsman;


$current_batsman = array (
'id' => $id,
'name' => $name,
'ability' => $ability,
'strength' => $strength,
'out' => $out,
'in' => $in,
'runs' => $runs
);

echo 'set current';
}

// Set up arrays of batsmen
while ($array = mysql_fetch_array($array_batsmen))
{

if ($it < 3 && $in_one == '') 
{
currentBatsman($array['id'], $array['name'], $array['ability'], $array['strength'], 0, 1, 0);

$batsmen[$array['id']] = array (
'id' => $array['id'],
'name' => $array['name'],
'ability' => $array['ability'],
'strength' => $array['strength'],
'out' => 0,
'in' => 1,
'runs' => 0
);

$in_one = $array['id'];
$current = $array['id'];
$it++;
}
else if ($it < 3 && $in_two == '') 
{
$batsmen[$array['id']] = array (
'id' => $array['id'],
'name' => $array['name'],
'ability' => $array['ability'],
'strength' => $array['strength'],
'out' => 0,
'in' => 1,
'runs' => 0
);

$in_two = $array['id'];
$it++;
}
else 
{
$batsmen[$array['id']] = array (
'id' => $array['id'],
'name' => $array['name'],
'ability' => $array['ability'],
'strength' => $array['strength'],
'out' => 0,
'in' => 0,
'runs' => 0
);
}

}

// Bowler Array
while ($array = mysql_fetch_array($array_bowlers))
{
$bowlers[] = array (
'name' => $array['name'],
'ability' => $array['ability'],
'strength' => $array['strength']
);

}

// Reset both queries
mysql_data_seek($array_bowlers,0);
mysql_data_seek($array_batsmen,0);



function changeBatsman($just_out)
{
global $array_batsmen, $batsmen; 

//Update array
$batsmen[$just_out] = array (
'in' => 1,
'out' =>  1
);

while ($array = mysql_fetch_array($array_batsmen))
{
if ($just_out != $array['id'] && $batsmen[$array['id']]['out'] != 0) currentBatsman($array['id'], $array['name'], $array['ability'], $array['strength'], 0, 1, 0);
}

// Reset query
mysql_data_seek($array_batsmen,0);

echo 'change batsman';
}

function swapBatsman($other_batsman)
{
global $array_batsmen, $batsman; 

while ($array = mysql_fetch_array($array_batsmen))
{
if ($other_batsman != $array['id'] && $batsman[$array['id']]['out'] != 0 && $batsman[$array['id']]['in'] == 1) currentBatsman($array['id'], $array['name'], $array['ability'], $array['strength'], 0, 1, 0);
}

// Reset query
mysql_data_seek($array_batsmen,0);

echo 'swap batsman';
}

$runs = $outs = $balls = $overs = 0;

$played = array();

function selectBowler()
{
global $bowlers, $current_bowler;

// Select random bowler
$choose_bowler = array_rand($bowlers, 1);

$current_bowler = array (
'name' => $bowlers[$choose_bowler]['name'],
'ability' => $bowlers[$choose_bowler]['ability'],
'strength' => $bowlers[$choose_bowler]['strength']
);

 

}

/*
function selectBatsman();
{
global $array_batsmen;

while ($array_batsmen[]['out'] != 1)
{


}*/

function bowl()
{
global $batsmen, $bowlers, $current_bowler, $current_batsman, $data, $balls, $outs, $runs;

if ($current_batsman['out'] == 0)
{
echo 'bowling';
// Set the initial number
$number = rand(0, 190);

// Ability of batsman
if ($current_batsman['ability'] > 90) $number += 30;
else if ($current_batsman['ability'] > 70) $number += 15;
else if ($current_batsman['ability'] > 50) $number += 2;
else $number = $number;

// Strength of batsman
if ($current_batsman['strength'] > 90) $number += 15;
else if ($current_batsman['strength'] > 70) $number += 10;
else if ($current_batsman['strength'] > 50) $number += 5;
else $number = $number;

// Depending on overs
if ($balls > 270) $number += 30;
else if ($balls > 120) $number -= 10;

// Ability
if ($current_bowler['ability'] > 90) $number -= 30;
else if ($current_bowler['ability'] > 70) $number -= 15;
else if ($current_bowler['ability'] > 50) $number -= 2;
else $number = $number;

// If batsman has made a huge total of runs, we need to knock some numbers off - more likely to get out
if ($current_batsman['runs'] > 200) $number -= 70;
else if ($current_batsman['runs'] > 100) $number -= 30;

// Finally sort out runs
if ($number > 190) $run = 6;
else if ($number > 170) $run = 4;
else if ($number > 160) $run = 3;
else if ($number > 100) $run = 2;
else if ($number > 50) $run = 1;
else if ($number > 10) $run = 0;
else if ($balls > 120 && $number > 0) $run = 0;
else $run = -1;

// Increase number of balls
$balls += 1;

// Are they out?
if ($run == -1)
{
$current_batsman['out'] = 1;

$played[] = $current_batsman['id'];
$find = '<tr><td>'.$current_batsman['name'].'</td><td></td><td></td><td>0</td></tr>';
$replace = '<tr><td>'.$current_batsman['name'].'</td><td></td><td>'.$current_bowler['name'].'</td><td>'.$current_batsman['runs'].'</td></tr>';

$data = str_replace($find, $replace, $data);


changeBatsman($current_batsman['id']); 



echo 'out';

}
else
{
$current_batsman['runs'] += $run;
$runs += $run;

if ($run == 1 || $run == 3)
{
swapBatsman($current_batsman['id']);
echo 'time to swap';
}

echo $run;


}

// Count outs
if ($current_batsman['out'] == 1)
$outs += 1;


}
}

function game()
{
global $main, $batsmen, $bowlers, $data, $batted, $balls, $outs, $current_batsman;

// Check if possible
while ($balls <= 295 && $outs < 10)
{

selectBowler();

// Actually bowl now

bowl();


}


}


game();



echo $data;

I have mysqli object in Database class base:

[color=]database class:[/color]

class Database {
  private $dbLink = null;
  
  public function __construct() {
    if (is_null($this->dbLink)) {
      // load db information  to connect
      $init_array = parse_ini_file("../init.ini.inc", true);
      $this->dbLink = new mysqli($init_array['database']['host'],
                           $init_array['database']['usr'],
                           $init_array['database']['pwd'],
                           $init_array['database']['db']);
  
      if (mysqli_connect_errno()) {
        $this->dbLink = null;
      }
    }
  }

  public function __destruct() {
    $this->dbLink->close();
  }
}


Class derived is Articles where I use object dBLink in base (or parent) class and I can't access to mysqli methods (dbLink member of base class):

Articles class:

require_once ('./includes/db.inc');

class Articles extends Database{
  private $id,
              ....
              ....
             $visible = null;
  
  public function __construct() {
    // Set date as 2009-07-08 07:35:00
    $this->lastUpdDate = date('Y-m-d H:i:s');
    $this->creationDate = date('Y-m-d H:i:s');
  }
  
  // Setter
  ....
  ....

  // Getter
  ....
  ....

  public function getArticlesByPosition($numArticles) {
    if ($result = $this->dbLink->query('SELECT * FROM articles ORDER BY position LIMIT '.$numArticles)) {
      $i = 0;
      while ($ret = $result->fetch_array(MYSQLI_ASSOC)) {
        $arts[$i] = $ret;
      }
      $result->close();
      return $arts;
    }
  }
}


In my front page php I use article class:


include_once('./includes/articles.inc');
$articlesObj = new articles();
$articles = $articlesObj->getArticlesByPosition(1);
var_dump($articles);


[color=]Error that go out is follow[/color]

Notice: Undefined property: Articles::$dbLink in articles.inc  on line 89

Fatal error: Call to a member function query() on a non-object in articles.inc on line 89

If I remove constructor on derived class Articles result don't change 
Please help me

If a class has a constructor but also has a static method, if I call the static method does the constructor run so that I can use an output from the constructor in my static method?

--Kenoli

Ok. I know you can pass the object of a class as an argument. Example:


class A {
    function test() {
        echo "This is TEST from class A";
    }
}


class B {
    function __construct( $obj ) {
        $this->a = $obj;
    }

    function test() {
       $this->a->test();
    }

}


Then you could do:

$a = new A();
$b = new B($a);


Ok so that's one way i know of.

I also thought that you could make a method static, and do this: (assuming class A's test is 'static')

class B {
    function test() {
       A::test(); 
   }
}


But that is not working.


I'd like to know all possible ways of accomplishing this. Any hints are appreciated. thanks

Hi

Can you call Class A's methods or properties from Class B's methods?

Thanks.

I have an existing instance of my class Database, now I want to call that instance in my Session class, how would I go about doing this?

Hi Guys.. Merry Christmas

Im kinda new to this fantastic world of PHP and i have a little problem i hope you can help me with.

Im trying to build a website where I use include() to genereate my content. On my index.php i have a menu which includes
content in a content div from external .php pages, my structure kinda goes like this.. (simplified)

site/
   index.php
   content/
       fronpage.php
       products.php
       contact.php

The HTML looks like this.

<div id="menu">
    <ul>
          <li><a href="index.php?page=frontpage">frontpage</a></li>
          <li><a href="index.php?page=products">frontpage</a></li>
          <li><a href="index.php?page=contact">frontpage</a></li>
    </ul>         
</div               

<div id="main">

<?php
     include('/content/'.$_GET['page'].'.php');
?>

</div>

This all works very fine, but my problem is, can I have a include inside an already included page?
I would like to have a menu on my products.php site, but that page is already included from above,
and i would like the menu on the products.php site to stay as the content from the nested include
changes with input from the /products folder.

my idea was something like this.

site/
   index.php
   content/
      frontpage.php
      products.php
      contact.php
      products/
         product1.php
         product2.php


the HTML on the index.php is the same as above and then i would add the include() on the
products.php page, so its kinda the same thing, but one inside the other.

HTML inside the products.php folder

<div id="sub_menu">
    <ul>
          <li><a href="#">frontpage</a></li>
          <li><a href="#">frontpage</a></li>
          <li><a href="#">frontpage</a></li>
    </ul>         
</div               

<div id="sub_main">

<?php
     include('/content/products'.$_GET['#'].'.php');
?>

</div>

I dont know how to link to the new files so they will be included while the first include still stays on the page.

Any of you know how and if this can be done? Or maybe at better way to do it?

Hope this made sense, my first PHP question

Thanks

Hi

Still a new comer when it comes to PHP.

I have a situation where I want to use an include within an include and I am having trouble with my file paths.

My main header include, includes everything for each page of my site, beyond the opening of the body to incorporate my navigation etc conditionally loading in css, and loading in titles and meta data etc depending on the page in question.

This header needs to reference another include called the-pod.php which is required for every page, the only trouble is I want to use / to reference the root of the server and this is breaking my code. I can't use ../../ etc as its a different path depending on where the master file is located.

So my question is how do I get around this?

Can the root of the server or path to the root be stored in a variable? and if so how would I write this.

Any tips / advice will be greatly appreciated.