PHP - Review Script

So I was working on this site past month. I know it is too much time for such simple website, but I am a perfectionist and I need to have everything perfect. It is using JQuery, Twitter Bootstrap (I am deep fan of TWBS and I am using it on almost every website I make) and Yeti(?probably, I forgot ) theme from Bootswatch. Of course also FontAwesome for YT, FB, Twitter an GitHub icons. On smaller resolutions it is looking epic (1024x768 etc etc), on mobile devices too, but I am not sure how it looks on HD, HD-ready resolutions (yes, I can use zoom-out in my browser, but it is misleading...). What do you think?   P.S.: Projects in "My Recent Work" are clickable and that will toggle description with some fancy fade effect (using jQuery.toggle()).   P.S.2: I am not sure if I should vertically-center contact text or let it be with big top and bottom padding. What do you think?   P.S.3: Oh, I almost forgot. Website link is here http://deathbeam.github.io/. Yes, I am using GitHub pages, I love git. And nope, I do not bought my own domain yet.   P.S.4: I accept "brutal" criticizm, feel free to be rude   P.S.5: (this is starting to be annoying lol): If you guys have time, can you please tell me what feeling do you have from my subsite http://deathbeam.git...fwphp/index.htm. I tried to keep everything as simple as possible, but I am not sure if it is not too much :/   P.S.6: I am really sorry for my English...
Edited by deathbeam, 08 September 2014 - 01:08 PM.

hello dear community


i try to find a way to use  file_get_contents: a download of set of pages:  Can any body review my approach

.. and as i thought i can find all 790 resultpages within a certain range between Id= 0 and Id= 100000 i thought, that i can go the way with a loop:

http://www.foundationfinder.ch/ShowDetails.php?Id=11233&InterfaceLanguage=&Type=Html
http://www.foundationfinder.ch/ShowDetails.php?Id=927&InterfaceLanguage=1&Type=Html
http://www.foundationfinder.ch/ShowDetails.php?Id=949&InterfaceLanguage=1&Type=Html
http://www.foundationfinder.ch/ShowDetails.php?Id=20011&InterfaceLanguage=1&Type=Html
http://www.foundationfinder.ch/ShowDetails.php?Id=10579&InterfaceLanguage=1&Type=Html

How to mechanize with a loop from 0 to 10000 and throw out 404 responses
once you reach the page we then could use beautifulsoup to get the content (in our case the image file address)
but we also  could just loop trough the images directely with simple webrequests.

Well  - how to proceed:

like this:


<?php
// creating a stream!
$opts = array(
  'http'=>array(
    'method'=>"GET",
    'header'=>"Accept-language: en\r\n" .
              "Cookie: foo=bar\r\n"
  )
);

// opens a file

$file = file_get_contents('http://www.example.com/', false, $context);
?>


a typical page is http://www.foundationfinder.ch/ShowDetails.php?Id=134&InterfaceLanguage=&Type=Html
and the related image is at http://www.foundationfinder.ch/ShowDetails.php?Id=134&InterfaceLanguage=&Type=Image

after downloading the images we will need to OCR them to extract any useful info,
so at some stage we need to look at OCR libs.


I think google opensourced one, and since its google it has a good chance it has a python API


can anybody review the approach - look forward to hear from you

Hello guys,   I am an intermediate level PHP programmer and digging my way through this giant universe of programming,   During this term, I have been able to build logics for problems (simple ones though) using my own thinking etc etc..   Anyway, I fully understand that I still have a lot to learn and I dont have any teachers to guide me through. So I wanted to request that If i submit an application for a quick review, like what I missed, how should I do it next time and guidance like this will seriously help me through.   I know it will be a pain reviewing someone else's apps but i dont have elsewhere to go..

Hello all. I'm a newbie to this site and PHP and trying to build a basic contact/info form for an insurance company. I've been testing what I've done in FF, IE, and Google Chrome, and it seems to be generating consistent results ... but I thought I'd run it past the EXPERTS here, so you can tell me all that I've done wrong. : )

Attached is the PHP page that is triggered by a basic HTML page with check boxes, etc. And below is what a resulting email looks like, which is fine by me (of course this is empty).

Thanks for any advice!
-RP

-------------------------------------------------

Name:
Tel:
Company:
State:
Website:
Employees:

===== Type of Business =====
Manufacturer:
Retailer:
Jobber/Restyler:
Distributor:
Motorsports:
Professional Services:

===== Insurance Needs =====
General Liability:
Garage/Keepers:
Property Building:
Property Equipment:
Loss of Income:
Worker's Comp.:
Internet Liability:
Life & Disability:
Product Liability:
Legal Liability:
Property Contents:
Cargo/Mobile Property:
Employee Dishonesty:
401K & Retirement:
Health:
Other:

Personal Comments:

=========================

Dear Friends.

Just now I tried to create PHP to make Rest API for my mobile application and I would like to know that it's good coding and need any improve? it is my first time for Rest API. normally I just connect to PHP file directly

on .htaccess

RewriteEngine On
RewriteCond %{REQUEST_FILENAME} !-f
RewriteCond %{REQUEST_FILENAME} !-d
RewriteRule ^([0-9A-Za-z_]+)$ function.php?func=$1 [L,QSA]
RewriteRule ^([0-9A-Za-z_]+)/$ function.php?func=$1 [L,QSA]

on function.php

$func = $_GET['func'];
switch( $func) 
{
	case 'lab_info':		//ໜ້າຫຼັກ
		define( '_FUNC', 'lab_info.php');
		break;

	case 'customer_info':		//ຂໍ້ມູນຜູ້ໃຊ້
		define( '_FUNC', 'customer_info.php');
		break;
	default:			// No function
		define( '_FUNC', 'functionnotfound.php');
		break;
}

if( defined( '_FUNC') && constant( '_FUNC') !='')
	require( "func/" . _FUNC);

on customer_info.php

$error = array();
if(isset($_POST['user']) != 'lung'){
    $error['status'] = "422";
    $error['title'] = "Authentication Fail";
    $error['detail'] = "Invalid user authentication";

    echo json_encode($error);die();
}
if(!isset($_POST['user'])){
    $error['status'] = "401";
    $error['title'] = "Invalid Attribute";
    $error['detail'] = "Invalid Attribute For Information";

    echo json_encode($error);die();

}

$result = $conn->query("select Lab_Name,Lab_Username,Lab_Password from tb_labmanagers");
$customer = array();
while($row =mysqli_fetch_assoc($result))
{
    $customer[] = $row;
}

echo json_encode($customer);

this image attached file is result from postman, client need to send user = 'lung' to get information

 

i want the code for review approval platform (costumer reviews for a product  )and in backend editing the code and updating it

	if(get_images_for_delete($username, $newid, $mysqli) !== FALSE){
	// WE are dealing with images
	$images = get_images_for_delete($username, $newid, $mysqli);
	$sourceBucket = "***********";
	$targetBucket = "***********";
	foreach($images as $image){
	// copy our object
	$aws = new s3;
	$aws = $aws->copyObject($targetBucket, $image, $sourceBucket, $image);
	// delete our object
	$aws_delete = new s3;
	$aws_delete = $aws_delete->deleteObject($image);
	// copy our (thumbnail) object
	$aws2 = new s3;
	$aws2 = $aws2->copyObject($targetBucket, "thumb_".$image, $sourceBucket, "thumb_".$image);
	// delete our (thumbnail) object
	$aws_delete2 = new s3;
	$aws_delete2 = $aws_delete2->deleteObject("thumb_".$image);
	}

Is my code. Do I need to declare so many new s3 classes? All the methods are within the same class. Not sure if this is the correct way to go about it.

 In a project that I'm working on I can specify routing rules, which is somewhat similar to mod_rewrite but in PHP. It's currently set up to use full regular expressions, but it's kind of overkill. I'm trying to convert it to use routing rules similar to some of the php frameworks I've seen. The code I've written up below is working, and while it's unlikely that I would need anything more complex, I'm wondering if anyone would like to comment, offer suggestions, or offer criticisms. This little piece of code is just a part of a bigger routing class, but this is the code that I'm concerned with. Thanks.

<?php

$cfg['routes'] = [
    'cars/(:any)/(:any)/(:num).php' => 'cars/$3/$1/$2',
    'default_route'                 => 'cars/index',
    'trucks/parts?year=(:num)'      => 'parts/trucks/$1',
    'vans/articles(:any)'           => 'articles$1' 
];

$uris = [
    'cars/toyota/tercel/2014.php', # /cars/2014/toyota/tercel
    'default_route',               # /cars/index
    'trucks/parts?year=2014',      # /parts/trucks/2014
    'vans/articles?p=42342'        # /articles?p=42342
];

$i = 0;
foreach( $cfg['routes'] as $k => $v )
{
    $k = '|^' . preg_quote( $k ) . '$|uiD';

    $k = str_replace(
        [
            '\(\:any\)',
            '\(\:alnum\)',
            '\(\:num\)',
            '\(\:alpha\)',
            '\(\:segment\)'
        ], [
            '(.+)',
            '([[:alnum:]]+)',
            '([[:digit:]]+)',
            '([[:alpha:]]+)',
            '([^/]*)'
        ], 
        $k
    );

    echo '<br />' . $uris[$i] . '<br />' . $k . '<br />';
    
    if( @preg_match( $k, $uris[$i] ) )
    {
        echo preg_replace( $k, $v, $uris[$i] ) . '<br /><br />';
    }

    $i++;
}

Hello,   I'm the sole developer of Aptugo (http://www.aptugo.com), a web RAD development environment with focus on making every developer's life easier. I've spent countless hours over the last two years developing it, and while the main focus is to be a CRUD boilerplate, it can actually build complete websites with great features (Aptugo's website was completely built with Aptugo, and google page insights gave me a score of 92 right out of the oven and without any effort).   Anyway, it would be really nice if you could spend a few minutes taking a look at Aptugo, It is free, and I really want to keep it free forever, in order to be able to achieve that, I really mouth-to-mouth promotion, so I'm not trying to sell you anything here, I'm just asking for help and your empathy! . If you could tell me: "I would use aptugo if it..." I would really appreciate it.    Have a great day, Gaston

I have a problem with the below code:
Code: [Select]
<?php
$sql_ranks = ("SELECT vtp_members.id, vtp_members.name, vtp_members.teamleader, teams.team_name, count(vtp_tracking.id) surfs
FROM vtp_members, vtp_tracking, teams
WHERE vtp_members.team_id=".$_GET['t']." AND vtp_tracking.credit_members_id=vtp_members.id AND vtp_tracking.action_date > '$last_sunday' AND vtp_tracking.action_date < '$next_sunday'
GROUP BY teams.team_name
ORDER BY surfs DESC");
$rsranks = mysql_query($sql_ranks);
echo "<br><table align='center' valign='top' border='0' width='300px'>
<tr><td colspan='2' align='center'><font size='2px'><b>Team Rankings (Current Week)</b></font></td></tr>
<tr><td><font size='2px'><b>Team</font></td><td align='right'><font size='2px'>Total Surfs</font></td></tr>";
while ($row = mysql_fetch_array($rsranks)) {
echo "<tr><td><font size='2px'><b>".$row[team_name]."</font></td><td align='right'><font size='2px'>".$row[surfs]."</font></td></tr>";}
echo "</table>";
?>
Problem is that the last output (".$row[surfs].") is the same for all teams. It seems it is not making a total of all id's and not per team_name.

anyone can see what I am doing wrong. I need to sort by team_name and the surfs should display the total of the members with team_id is ".$_GET['t']."

$username = $loggedInUser->username; // This is the logged in username
$time = time();
$makedir = $username.'_'.$time;

$var = getcwd();
$var = str_replace('\users', '\imageuploads', $var);
$dirlocation = $var."\\".test_directory($username, $mysqli);   function test_directory ($username, $mysqli) {
     $stmt = $mysqli->prepare("SELECT Temp_Directory FROM uc_users WHERE user_name LIKE ?");
    $stmt->bind_param("s", $username);
    $stmt->execute();
    $stmt->bind_result($Tempdir);
    while ($stmt->fetch()){
    return $Tempdir;
        }
    } if((!empty(test_directory($username, $mysqli))) && is_dir($dirlocation)){
//echo "this is it";
$thedirectory = $dirlocation;
}

if(empty(test_directory($username, $mysqli))){
//echo "it's not a directory";
$newdir = $var."\\".$makedir;
$query = mysqli_query($mysqli, "UPDATE uc_users SET Temp_Directory='$makedir' WHERE user_name='$username'");
if(!$query){
//echo mysqli_error($mysqli);
}
mkdir($newdir);
//security
chmod($newdir, 0644);
$thedirectory = $newdir;
}

if(!is_dir($dirlocation) && (!empty(test_directory($username, $mysqli)))){
//echo "third one";
mkdir($dirlocation);
chmod($dirlocation, 0644);
$thedirectory = $dirlocation;
}         Ok, so what I'm doing here is testing to see whether a a record exists of the user having a folder in the MySQL database. Then, if it does, make sure that a folder exists at that location. If there is no folder, we create one for the user. If there is already a folder, we leave it alone.   This is for image uploads, and $thedirectory, is where we upload images later on in the script.   Hope that makes sense.   The code seems to work. But how can I improve it and make it more robust? Or should I just leave it alone? Should I return FALSE from the function for better reliability over empty()?  

Hi everyone!

I've been working on a php script to replace links that contain a query with direct links to the files they would redirect to.

Hi i have this upload script which works fine it uploads image to a specified folder and sends the the details to the database.
but now i am trying to instead make a modify script which is Update set so i tried to change insert to update but didnt work can someone help me out please
this my insert image script which works fine but want to change to modify instead
Code: [Select]
<?php
mysql_connect("localhost", "root", "") or die(mysql_error()) ;
mysql_select_db("upload") or die(mysql_error()) ;

// my file the name of the input area on the form type is the extension of the file
//echo $_FILES["myfile"]["type"];

//myfile is the name of the input area on the form 
$name = $_FILES["image"] ["name"]; // name of the file
$type = $_FILES["image"]["type"]; //type of the file
$size = $_FILES["image"]["size"]; //the size of the file
$temp = $_FILES["image"]["tmp_name"];//temporary file location when click upload it temporary stores on the computer and gives it a temporary name
$error =array(); // this an empty array where you can then call on all of the error messages
$allowed_exts = array('jpg', 'jpeg', 'png', 'gif'); // array with the following extension name values
$image_type = array('image/jpg', 'image/jpeg', 'image/png', 'image/gif'); // array with the following image type values
$location = 'images/'; //location of the file or directory where the file will be stored
$appendic_name = "news".$name;//this append the word [news] before the name so the image would be news[nameofimage].gif

// substr counts the number of carachters and then you the specify how how many you letters you want to cut off from the beginning of the word example drivers.jpg it would cut off dri, and would display vers.jpg
//echo $extension = substr($name, 3);

//using both substr and strpos, strpos it will delete anything before the dot in this case it finds the dot on the $name file deletes and + 1 says read after the last letter you delete because you want to display the letters after the dot. if remove the +1 it will display .gif which what we want is just gif
$extension = strtolower(substr($name, strpos ($name, '.') +1));//strlower turn the extension non capital in case extension is capital example JPG will strtolower will make jpg
// another way of doing is with explode
// $image_ext strtolower(end(explode('.',$name))); will explode from where you want in this case from the dot adn end will display from the end after the explode

$myfile = $_POST["myfile"];

     if (isset($image)) // if you choose a file name do the if bellow
       {
       
       // if extension is not equal to any of the variables in the array $allowed_exts error appears
        if(in_array($extension, $allowed_exts) === false )
       {
         $error[] = 'Extension not allowed! gif, jpg, jpeg, png only<br />'; // if no errror read next if line
       }
        // if file type is not equal to any of the variables in array $image_type error appears
        if(in_array($type, $image_type) === false)
       {
          $error[] = 'Type of file not allowed! only images allowed<br />';     
       }
       
        // if file bigger than the number bellow error message
        if($size > 2097152)
       {
          $error[] = 'File size must be under 2MB!';     
       }
       
       // check if  folder exist in the server
        if(!file_exists ($location))
       {
          $error[] = 'No directory ' . $location. ' on the server Please create a folder ' .$location;     
       }
            
     }
     // if no error found do the move upload function
       if (empty($error)){
           if (move_uploaded_file($temp, $location .$appendic_name))
           {
             // insert data into database first are the field name teh values are the variables you want to insert into those fields appendic is the new name of the image
mysql_query("INSERT INTO image (myfile ,image)
 VALUES ('$myfile', '$appendic_name')") ;
           exit();
           }
         }
       else
          {
        foreach ($error as $error)
           {
               echo $error;
           }
        }
      
     
  
//echo $type;
?>

I'm having trouble echoing $year in my script. Listed below is the script, just below ,$result = mysql_query("SELECT * FROM $dbname WHERE class LIKE '%$search%'") or die(mysql_error());, in the script I try to echo $year. It doesn't show up in the table on the webpage. Everything else works fine. Any help wold be appreciated greatly. Thanks in advance.



<?php
include 'config2.php';

$search=$_GET["search"];

// Connect to server and select database.
mysql_connect($dbhost, $dbuser, $dbpass)or die("cannot connect");
mysql_select_db("vetman")or die("cannot select DB");


$result = mysql_query("SELECT * FROM $dbname WHERE class LIKE '%$search%'") or die(mysql_error());
// store the record of the "" table into $row
//$current = '';
echo "<table align=center border=1>";
echo "<br>";
echo "<tr>";
echo "<td align=center>";
?>
<div style="float: center;"><a><h1><?php echo $year; ?></h1></a></div>


<?php
echo "</td>";
echo "</tr>";
echo "</table>";


// keeps getting the next row until there are no more to get
if($result && mysql_num_rows($result) > 0)

{
    $i = 0;
    $max_columns = 2;
    echo "<table align=center>";
echo "<br>";
    while($row = mysql_fetch_array($result))
   {
       // make the variables easy to deal with
       extract($row);

       // open row if counter is zero
       if($i == 0)

          echo "<tr>";

          echo "<td align=center>";
          ?>
          <div style="float: left;">
          <div><img src="<?php echo $image1; ?>"></div>

  </div>


          <?php
          echo "</td>";

       // increment counter - if counter = max columns, reset counter and close row
       if(++$i == $max_columns)
       {
           echo "</tr>";
           $i=0;
       }  // end if
   } // end while
} // end if results

// clean up table - makes your code valid!
if($i > 0)
{
    for($j=$i; $j<$max_columns;$j++)
        echo "<td>&nbsp;</td>";
   echo '</tr>';
}
mysql_close();
 ?>
</table>