PHP - Calling Functions Within Functions

I have a user form with a dete button on a dropdown.

When you click said button this runs

function deleteUser(){
		var e = event.target
		var uid = e.getAttribute("data-id");
		console.log(e)
		console.log(uid)
		$.ajax({
			type: 'post',
			data: {"ajax" : 'delUser', "id" : uid}
		})
	}

which goes into this

if(isset($_POST['ajax'])){
	switch($_POST['ajax']) {
		case 'newUserMod':
		exit(popNewUserModal());
		break;
		case 'userMod':
		exit(popUserModal($_POST['id']));
		break;
		case 'deleteUser':
		exit(deleteUser($_POST['id']));
		break;
	}
};

which calls this function in another file

function deleteUser($id){
	include 'includes/dbconn.php';
	$stmt = $conn -> prepare("DELETE FROM user WHERE id = ?");
	$stmt -> bind_param('i', $id);
	$stmt -> execute();
	header('Location: manage-users');
}

I know that i am getting the correct id in the ajax and i can see that the post happens correctly.

Any ideas why the users are not being deleted?

Hi I call a function with values of 51 and 100 but the function receives values 1 and 50

 

<?php
// EmilyMoor Version 1.0.0   05-07-2019   Desmond O'Toole.
ini_set('display_errors', 1);
error_reporting(E_ALL);
require("../secure/SecureFunctions.php");
require("secure/SecureFunctionsEmilyMoor.php");
$page = "Emily Moor";
session_start();

$Browser = $_SERVER['HTTP_USER_AGENT'];

if (!isset($_SESSION["PageValue"]))
    $_SESSION["PageValue"] = '1';

$_SESSION["PageValue"] = 2; // Keeps going back to 1

if($_SESSION["PageValue"] == 1)
{
	$_SESSION["StartValue"] = 1;
	$_SESSION["EndValue"] = 50;
}

if($_SESSION["PageValue"] == 2)
{
	$_SESSION["StartValue"] = 51;
	$_SESSION["EndValue"] = 100;
}

if($_SESSION["PageValue"] == 3)
{
	$_SESSION["StartValue"] = 101;
	$_SESSION["EndValue"] = 150;
}

if($_SESSION["PageValue"] == 4)
{
	$_SESSION["StartValue"] = 151;
	$_SESSION["EndValue"] = 200;
}

if($_SESSION["PageValue"] == 5)
{
	$_SESSION["StartValue"] = 201;
	$_SESSION["EndValue"] = 250;
}

if($_SESSION["PageValue"] == 6)
{
	$_SESSION["StartValue"] = 251;
	$_SESSION["EndValue"] = 300;
}

echo $_SESSION["PageValue"] . " - " . $_SESSION["StartValue"] . " - " . $_SESSION["EndValue"] . "<br>";

$qStationDetails = GetChanelInfo($_SESSION["StartValue"],$_SESSION["EndValue"]);
$rs = mysql_fetch_array($qStationDetails) or die ("E3001-101A");
$Name = $rs['Description'];


?>

function GetChanelInfo($StartCH, $EndCH) // E2004
{
	echo "Channels = " . $StartCH . " " . $EndCH . "<br>"; // values are 1 and 50
	$sqlChanelInfo = "SELECT * FROM  TV_EmilyMoor WHERE ID >= $StartCH and ID <= $EndCH";
	echo $sqlChanelInfo . "<br />";
	$qChanelInfo = mysql_query($sqlChanelInfo) or die ("E3004-01A");
	return $qChanelInfo;
}

 

This is a bit of a more advanced question so I am hoping there are some advanced programmers online at this time . Anyways basically I want to be able to "queue" functions from a class in a single call and am wondering if I am doing it correctly or if there is a better way to do it. Here is my code:


<?php
class test {
     private static $one;
     private static $two;
     private static $three;

     public function callOne($val){
          $one .= $val;
          return $this;
     }
     
     public function callTwo($val){
          $two .= $val;
          return $this;
     }

     public function callThree($val){
           $three .= $val;
           return $this;
     }

     public function print(){
          echo $this->one.' '.$this->two.' '.$this->three;
     }
}
?>


now when I want to call this I can do:

$test = new test();
$test->callOne('one')->callTwo('two')->callThree('three');
$test->callOne('another one');
$test->print();


Is there a better way to do this or is there a different method of doing this? Just wanna make sure I am doing it right lol.

I have a script I am putting together that simulate a cricket game. The only issue is, that there are a huge number of functions because there doesn't seem to be any other way to do this properly. As well as this, there a while() loop and all this seems to be leading to the page reaching a max 30 second timeout when generating the result.

My code is attached below, it is quite messy at the moment because i've just be working on it, but I was wondering if anyone has any solutions of how I can speed this up or change to prevent a timeout:

<?php
// Error reporting
error_reporting(E_ALL);

// Connect DB
mysql_connect("wickettowicket.adminfuel.com", "rockinaway", "preetha6488") or die(mysql_error());

// Select DB
mysql_select_db("wickettowicket") or die(mysql_error());

// MySQL queries to find batsmen and bowlers 
$array_batsmen = mysql_query('SELECT id, name, ability, strength FROM wtw_players WHERE team_id = 1 ORDER BY id ASC');
$array_bowlers = mysql_query('SELECT id, name, ability, strength FROM wtw_players WHERE team_id = 2');

// Start table for data 
$data = '<table width="600px">';

// Create blank scorecard
while ($array_bat = mysql_fetch_array($array_batsmen))
{
$data .= '<tr><td>'.$array_bat['name'].'</td><td></td><td></td><td>0</td></tr>';
}

// Set up arrays for players 
$current_batsman = $current_bowler = array();

// Reset query
mysql_data_seek($array_batsmen,0);

$in_one = $in_two = $it = '';

function currentBatsman($id, $name, $ability, $strength, $out, $in, $runs)
{
global $current_batsman;


$current_batsman = array (
'id' => $id,
'name' => $name,
'ability' => $ability,
'strength' => $strength,
'out' => $out,
'in' => $in,
'runs' => $runs
);

echo 'set current';
}

// Set up arrays of batsmen
while ($array = mysql_fetch_array($array_batsmen))
{

if ($it < 3 && $in_one == '') 
{
currentBatsman($array['id'], $array['name'], $array['ability'], $array['strength'], 0, 1, 0);

$batsmen[$array['id']] = array (
'id' => $array['id'],
'name' => $array['name'],
'ability' => $array['ability'],
'strength' => $array['strength'],
'out' => 0,
'in' => 1,
'runs' => 0
);

$in_one = $array['id'];
$current = $array['id'];
$it++;
}
else if ($it < 3 && $in_two == '') 
{
$batsmen[$array['id']] = array (
'id' => $array['id'],
'name' => $array['name'],
'ability' => $array['ability'],
'strength' => $array['strength'],
'out' => 0,
'in' => 1,
'runs' => 0
);

$in_two = $array['id'];
$it++;
}
else 
{
$batsmen[$array['id']] = array (
'id' => $array['id'],
'name' => $array['name'],
'ability' => $array['ability'],
'strength' => $array['strength'],
'out' => 0,
'in' => 0,
'runs' => 0
);
}

}

// Bowler Array
while ($array = mysql_fetch_array($array_bowlers))
{
$bowlers[] = array (
'name' => $array['name'],
'ability' => $array['ability'],
'strength' => $array['strength']
);

}

// Reset both queries
mysql_data_seek($array_bowlers,0);
mysql_data_seek($array_batsmen,0);



function changeBatsman($just_out)
{
global $array_batsmen, $batsmen; 

//Update array
$batsmen[$just_out] = array (
'in' => 1,
'out' =>  1
);

while ($array = mysql_fetch_array($array_batsmen))
{
if ($just_out != $array['id'] && $batsmen[$array['id']]['out'] != 0) currentBatsman($array['id'], $array['name'], $array['ability'], $array['strength'], 0, 1, 0);
}

// Reset query
mysql_data_seek($array_batsmen,0);

echo 'change batsman';
}

function swapBatsman($other_batsman)
{
global $array_batsmen, $batsman; 

while ($array = mysql_fetch_array($array_batsmen))
{
if ($other_batsman != $array['id'] && $batsman[$array['id']]['out'] != 0 && $batsman[$array['id']]['in'] == 1) currentBatsman($array['id'], $array['name'], $array['ability'], $array['strength'], 0, 1, 0);
}

// Reset query
mysql_data_seek($array_batsmen,0);

echo 'swap batsman';
}

$runs = $outs = $balls = $overs = 0;

$played = array();

function selectBowler()
{
global $bowlers, $current_bowler;

// Select random bowler
$choose_bowler = array_rand($bowlers, 1);

$current_bowler = array (
'name' => $bowlers[$choose_bowler]['name'],
'ability' => $bowlers[$choose_bowler]['ability'],
'strength' => $bowlers[$choose_bowler]['strength']
);

 

}

/*
function selectBatsman();
{
global $array_batsmen;

while ($array_batsmen[]['out'] != 1)
{


}*/

function bowl()
{
global $batsmen, $bowlers, $current_bowler, $current_batsman, $data, $balls, $outs, $runs;

if ($current_batsman['out'] == 0)
{
echo 'bowling';
// Set the initial number
$number = rand(0, 190);

// Ability of batsman
if ($current_batsman['ability'] > 90) $number += 30;
else if ($current_batsman['ability'] > 70) $number += 15;
else if ($current_batsman['ability'] > 50) $number += 2;
else $number = $number;

// Strength of batsman
if ($current_batsman['strength'] > 90) $number += 15;
else if ($current_batsman['strength'] > 70) $number += 10;
else if ($current_batsman['strength'] > 50) $number += 5;
else $number = $number;

// Depending on overs
if ($balls > 270) $number += 30;
else if ($balls > 120) $number -= 10;

// Ability
if ($current_bowler['ability'] > 90) $number -= 30;
else if ($current_bowler['ability'] > 70) $number -= 15;
else if ($current_bowler['ability'] > 50) $number -= 2;
else $number = $number;

// If batsman has made a huge total of runs, we need to knock some numbers off - more likely to get out
if ($current_batsman['runs'] > 200) $number -= 70;
else if ($current_batsman['runs'] > 100) $number -= 30;

// Finally sort out runs
if ($number > 190) $run = 6;
else if ($number > 170) $run = 4;
else if ($number > 160) $run = 3;
else if ($number > 100) $run = 2;
else if ($number > 50) $run = 1;
else if ($number > 10) $run = 0;
else if ($balls > 120 && $number > 0) $run = 0;
else $run = -1;

// Increase number of balls
$balls += 1;

// Are they out?
if ($run == -1)
{
$current_batsman['out'] = 1;

$played[] = $current_batsman['id'];
$find = '<tr><td>'.$current_batsman['name'].'</td><td></td><td></td><td>0</td></tr>';
$replace = '<tr><td>'.$current_batsman['name'].'</td><td></td><td>'.$current_bowler['name'].'</td><td>'.$current_batsman['runs'].'</td></tr>';

$data = str_replace($find, $replace, $data);


changeBatsman($current_batsman['id']); 



echo 'out';

}
else
{
$current_batsman['runs'] += $run;
$runs += $run;

if ($run == 1 || $run == 3)
{
swapBatsman($current_batsman['id']);
echo 'time to swap';
}

echo $run;


}

// Count outs
if ($current_batsman['out'] == 1)
$outs += 1;


}
}

function game()
{
global $main, $batsmen, $bowlers, $data, $batted, $balls, $outs, $current_batsman;

// Check if possible
while ($balls <= 295 && $outs < 10)
{

selectBowler();

// Actually bowl now

bowl();


}


}


game();



echo $data;

Hi,

I've got 3 different upload forms in one form.  I'm making a function so it just one piece of code.

I'm having a bit of a problem changing some of the code so it works for all 3.

Here is the function




function loadImages ($action, $position)
{
 $link = mysql_connect("","","");
if (!$link)
{
die('Error: could not connect: ' . mysql_error());
}

$db_select = mysql_select_db("",$link);
if (!$db_select)
{
die ("Error: database selection failed: " . mysql_error());
}
$page = ($_POST["pageName"]);
if ((($_FILES["bfile"]["type"] == "image/gif")
|| ($_FILES["bfile"]["type"] == "image/jpeg")
|| ($_FILES["bfile"]["type"] == "image/pjpeg"))
&& ($_FILES["bfile"]["size"] < 9000000))
{
if ($_FILES["bfile"]["error"] > 0)
{
echo "Return Code: " . $_FILES["bfile"]["error"] . "<br />";
}
else
{
 $success = '<p style="font-weight: bold; color: #C00">Upload successful<br />';
// move uploaded temporary file to final destination
move_uploaded_file($_FILES["bfile"]["tmp_name"],
"uploads/" . $_FILES["bfile"]["name"]);

// update database with new filename
 $filename = $_FILES["bfile"]["name"];
 $sql = "UPDATE images 
 SET filename= '$filename'
 where page = '$page'
 and position = '$position'";

if (!mysql_query($sql,$link))
{
die('Error: ' . mysql_error());
}

}
}
else
{
 $fail = '<p style="font-weight: bold; color: #C00">Invalid file';
}
mysql_close($link);
}


Now the $action is the bit that will determine whether it's updateTop updateMiddle or updateBottom.  $position finds out if it's top middle or bottom


if (isset($_POST['updateTop'])) 
    {
loadImages ($_POST['updateTop'], "top");
}


Here is a sample of the html, it's in a switch

case "Products":
                              echo "<p>Image Top</p>
                                    <input type=\"file\" name=\"file\" id=\"file\" />  <input type=\"submit\" name=\"updateTop\" value=\"Update $page Top\" />
                                    <p>Image Middle</p>
                                    <input type=\"file\" name=\"mfile\" id=\"mfile\" />  <input type=\"submit\" name=\"updateMiddle\" value=\"Update $page Middle\" />
                                    <p>Image Bottom</p>
                                    <input type=\"file\" name=\"bfile\" id=\"bfile\" />  <input type=\"submit\" name=\"updateBottom\" value=\"Update $page Bottom\" />
                                    ";
                              break;


What I need to do is get $_FILES["bfile" into a variable to see whether it's "bfile" "mfile" or "file" but not sure how to write it.

Thanks for the help.