PHP - Need Help On My Register Page

Hi there,
There's something wrong with this register form, it's submitting without validation.

Code: [Select]
<?php
  require_once('./includes/connectvars.php');

  // Connect to the database
  $dbc = mysqli_connect(DB_HOST, DB_USER, DB_PASSWORD, DB_NAME);

  if (isset($_POST['submit'])) {
    // Grab the profile data from the POST
    $username = mysqli_real_escape_string($dbc, trim($_POST['username']));
    $password1 = mysqli_real_escape_string($dbc, trim($_POST['password1']));
    $password2 = mysqli_real_escape_string($dbc, trim($_POST['password2']));
$firstname = mysqli_real_escape_string($dbc, trim($_POST['first_name']));
$lastname = mysqli_real_escape_string($dbc, trim($_POST['last_name']));

    if (!empty($username) && !empty($password1) && !empty($password2) && ($password1 == $password2) && !empty($firstname) && !empty($lastname)) {
      // Make sure someone isn't already registered using this username
      $query = "SELECT * FROM users WHERE username = '$username'";
      $data = mysqli_query($dbc, $query);
      if (mysqli_num_rows($data) == 0) {
        // The username is unique, so insert the data into the database
$query = "INSERT INTO users (username, password, join_date, first_name, last_name) VALUES ('$username', SHA('$password1'), NOW(), '$firstname', '$lastname')";

        mysqli_query($dbc, $query);

        // Confirm success with the user
        echo '<p>Your new account has been successfully created. You\'re now ready to <a href="login.php">log in</a>.</p>';

        mysqli_close($dbc);
        exit();
      }
      else {
        // An account already exists for this username, so display an error message
        echo '<p class="error">An account already exists for this username. Please use a different address.</p>';
        $username = "";
      }
    }
    else {
      echo '<p class="error">You must enter all of the sign-up data, including the desired password twice.</p>';
    }
  }

  mysqli_close($dbc);
?>

  <p>Please enter your username and desired password to sign up to Mismatch.</p>
  <form method="post" action="<?php echo $_SERVER['PHP_SELF']; ?>">
      <legend>Registration Info</legend>
      <label for="username">Username:</label>
      <input type="text" id="username" name="username" value="<?php if (!empty($username)) echo $username; ?>" /><br />
      <label for="password1">Password:</label>
      <input type="password" id="password1" name="password1" /><br />
      <label for="password2">Password (retype):</label>
      <input type="password" id="password2" name="password2" /><br />
  <label for="first_name">first name:</label>
      <input type="text" id="first_name" name="first_name" /><br />
  <label for="last_name">last name:</label>
      <input type="text" id="last_name" name="last_name" /><br />
    <input type="submit" value="Sign Up" name="submit" />
  </form>
</body>
</html>


I've had this problem for a while now and can't figure it out, any suggestions are appreciated.
Thank you.

Hi,
I created a previous thread but the problems were too confusing so I've started this thread again.

I have a register form and it's supposed to validate if fields are empty.
If fields are not empty, it should enter data on submit, into the table.

The problem: The form is able to submit without validation and the data does not enter the table.

The code:
Code: [Select]
<?php

  require_once('./includes/connectvars.php');

  // Connect to the database
      $dbc = mysqli_connect(DB_HOST, DB_USER, DB_PASSWORD, DB_NAME);

  if (isset($_POST['submit'])) {
    // Grab the profile data from the POST
    $username = mysqli_real_escape_string($dbc, trim($_POST['username']));
    $password1 = mysqli_real_escape_string($dbc, trim($_POST['password1']));
    $password2 = mysqli_real_escape_string($dbc, trim($_POST['password2']));
$firstname = mysqli_real_escape_string($dbc, trim($_POST['first_name']));
$lastname = mysqli_real_escape_string($dbc, trim($_POST['last_name']));

    if (!empty($username) && !empty($password1) && !empty($password2) && ($password1 == $password2) && !empty($firstname) && !empty($lastname)) {
      // Make sure someone isn't already registered using this username
      $query = "SELECT * FROM cuser WHERE username = '$username'";
      $data = mysqli_query($dbc, $query);
      if (mysqli_num_rows($data) == 0) {
        // The username is unique, so insert the data into the database
$query = "INSERT INTO cuser (username, password, join_date, first_name, last_name) VALUES ('$username', SHA('$password1'), NOW(), '$firstname', '$lastname')";

        mysqli_query($dbc, $query);

        // Confirm success with the user
        echo '<p>Your new account has been successfully created. You\'re now ready to <a href="login.php">log in</a>.</p>';

        mysqli_close($dbc);
        exit();
      }
      else {
        // An account already exists for this username, so display an error message
        echo '<p class="error">An account already exists for this username. Please use a different address.</p>';
        $username = "";
      }
    }
    else {
      echo '<p class="error">You must enter all of the sign-up data, including the desired password twice.</p>';
    }
  }

  mysqli_close($dbc);
?>

  <p>Please enter your username and desired password to sign up to Mismatch.</p>
  <form method="post" action="<?php echo $_SERVER['PHP_SELF']; ?>">
      <legend>Registration Info</legend>
      <label for="username">Username:</label>
      <input type="text" id="username" name="username" value="<?php if (!empty($username)) echo $username; ?>" /><br />
      <label for="password1">Password:</label>
      <input type="password" id="password1" name="password1" /><br />
      <label for="password2">Password (retype):</label>
      <input type="password" id="password2" name="password2" /><br />
  <label for="first_name">first name:</label>
      <input type="text" id="first_name" name="first_name" /><br />
  <label for="last_name">last name:</label>
      <input type="text" id="last_name" name="last_name" /><br />
    <input type="submit" value="Sign Up" name="submit" />
  </form>
</body>
</html>

Any ideas on what the problem is?

I've sent my sessions in another file.

Hi, I'm looking to change my 'Dead' page on my Mafia game to enable users to register a new account as soon as they log in to their dead one. I would like them to be able to just enter a new Username and then the email, password etc stay the same. Is this possible? Just ask for any parts of the register code you guys need.

Thanks in advance,.

Okay, I downloaded a PHP Script called RadiPanel which is a User System type thing and uploaded and installed it to my website. Now The problem with RadiPanel is, I have to add users/members to it as there is no registration process. So within the Admin page on RadiPanel I have taken the script out, now when I try view it as a "non logged in" user it just shows a white blank page, I was wondering if anyone here could determine just from the code below what I have to take out/delete in order for the public to view the page fully? Thanks guys

Code: [Select]
<?php

if( !preg_match( "/index.php/i", $_SERVER['PHP_SELF'] ) ) { die(); }

if( $_GET['id'] ) {

$id = $core->clean( $_GET['id'] );

$query = $db->query( "SELECT * FROM users WHERE id = '{$id}'" );
$data  = $db->assoc( $query );

$data['ugroups'] = explode( ",", $data['usergroups'] );

$editid = $data['id'];

}

?>
<form action="" method="post" id="addUser">
</div>

<?php

if( $_POST['submit'] ) {

try {

$username = $core->clean( $_POST['username'] );
$password = $core->clean( $_POST['password'] );
$email    = $core->clean( $_POST['email'] );
$habbo    = $core->clean( $_POST['habbo'] );
$dgroup   = $core->clean( $_POST['dgroup'] );

$query    = $db->query( "SELECT * FROM usergroups" );

while( $array = $db->assoc( $query ) ) {

if( $_POST['ugroup-' . $array['id']] ) {

$ugroups .= $array['id'] . ",";

}

}

$password_enc = $core->encrypt( $password );

if( !$username or ( !$password and !$editid ) or !$dgroup or !$ugroups ) {

throw new Exception( "All fields are required." );

}
else {

if( $editid ) {

if( $password ) {

$password = ", password = '{$password_enc}'";

}
else {

unset( $password );

}

$db->query( "UPDATE users SET username = '{$username}'{$password}, email = '{$email}', habbo = '{$habbo}', displaygroup = '{$dgroup}', usergroups = '{$ugroups}' WHERE id = '{$editid}'" );

}
else {

$db->query( "INSERT INTO users VALUES (NULL, '{$username}', '{$password_enc}', '{$email}', '{$habbo}', '{$dgroup}', '{$ugroups}');" );

}

echo "<div class=\"square good\">";
echo "<strong>Success</strong>";
echo "<br />";
echo "User added!";
echo "</div>";

}

}
catch( Exception $e ) {

echo "<div class=\"square bad\">";
echo "<strong>Error</strong>";
echo "<br />";
echo $e->getMessage();
echo "</div>";

}

}

?>

<table width="100%" cellpadding="3" cellspacing="0">
<?php

$query = $db->query( "SELECT * FROM usergroups" );

while( $array = $db->assoc( $query ) ) {

if( in_array( $array['id'], $data['ugroups'] ) ) {

$groups[$array['id'] . '_active'] = $array['name'];

}
else {

$groups[$array['id']] = $array['name'];

}

if( $array['id'] == $data['displaygroup'] ) {

$dgroups[$array['id'] . '_active']  = $array['name'];

}
else {

$dgroups[$array['id']]  = $array['name'];

}

}

echo $core->buildField( "text",
"required",
"username",
"Username",
"The new username.",
$data['username'] );

echo $core->buildField( "password",
"<?php if( !$editid ) { ?>required<?php } ?>",
"password",
"Password",
"The new password." );

echo $core->buildField( "text",
"",
"email",
"Email",
"The new email (optional).",
$data['email'] );

echo $core->buildField( "text",
"",
"habbo",
"Habbo name",
"The new Habbo name (optional).",
$data['habbo'] );

echo $core->buildField( "select",
"required",
"dgroup",
"Display group",
"The user's display group.",
$dgroups );

echo $core->buildField( "checkbox",
"required",
"ugroup",
"Active usergroups",
"The user's active groups.",
$groups );

?>
</table>

</div>

<div class="box" align="right">

<input class="button" type="submit" name="submit" value="Submit" />

</div>

</form>

<?php
echo $core->buildFormJS('addUser');

?>

I have a simple register script and some weird things are happening. If i leave blank password or repeat_password then code is still executed. Why? I can't seem to find any mistakes in the code. (only when username is empty then i get "You need to fill everything").
Code: [Select]
<?php
$submit = $_POST['submit'];
$username = strip_tags($_POST['username']);
$password = md5(strip_tags($_POST['password']));
$repeat_password = md5(strip_tags($_POST['repeat_password']));

require("connect.php");

if ($submit)
{
if (!empty($username) && !empty($password) && !empty($repeat_password))
{
mysql_query("INSERT INTO users2 VALUES ('', '$username', '$password', '1000', '0', '0','', '', '')");
echo "You are registered <br />Your username is "."<b>$username</b>"."<br /> You may now <a href='index.php'> login </a>";
}
else
{
echo "You have not filled everything.";
}
}
?>

Hello everyone,

I want to make a re-register script that enables a user to re-register once killed.... BUT keep the same email, same profile pic, same profile quote, same friends and a few other things.... BUT register new username etc. Any help would be great.

Hello everyone,i was trying to make a register/login pages on my own and well i got stuck..and my good friend google couldn't help me :S

So well i came to ask proffesionals

Okay here is it:
First thing i don't get is about email activation that i wanted to use on my register page...
I got do_reg.php file that looks like this:
Code: [Select]
<?php

include 'connection.php';

//grab data from form
$name = $_POST['username'];
$pass = $_POST['password'];
$pass_conf = $_POST['pass_conf'];
$email = $_POST['email'];
$ip = $_POST['ip'];

//if else
if($name == false || $pass == false || $pass_conf == false || $email == false){
echo "Please fill in all the required fields.";
};
if($pass != $pass_conf){ 
   echo "Blah..Passwords do not match."; 
}else{
//generate random code
$code = rand(11111111,99999999);
//send email
$subject = "Activate your account";
$headers = "From: admin@mysite.com";
$body = "Hello $name,\n\nYou registered and need to activate your account. Click the link below or paste it into the URL bar of your browser\n\n http://localhot/login/activate.php?code=$code\n\nThanks!";
if (!mail($email,$subject,$body,$headers))
echo "Error,what a shame!";
else {
$sql = mysql_query("INSERT INTO users (username,password,email,code,active,ip)
VALUES('$name','$pass','$email','$code',0,'$ip')") or die(mysql_error());
$result = mysql_query($sql);
echo "Thank you for registering! But your account is not still active :'( Please check your email ($email) for activation code! :)";
}
};
?>I went through thousands of erros and still couldn't make it work,i am using xampp localhost server for now and maybe that is the reason it wont work even if i tried to activate SMTP and that stuff in php.ini conf file (as my friend google told me)..
So this is one of the errors:
Quote

Warning: mail() [function.mail]: SMTP server response: 550 relaying denied in C:\xampp\htdocs\login\do_reg.php on line 25
Error,what a shame!


Now the next thing i couldn't understand is where is the error inside this script... (do_login.php)
Code: [Select]
<?php

include 'connection.php';

$session_username = $_SESSION['username'];

if($_POST['login']) 
{
//get form data
$username = $_POST['username'];
$password = $_POST['password'];
}
if(!$username||!$password)
echo "Username and password missing!";
else {
//login
$login = mysql_query("SELECT * FROM users WHERE username='$username'");
}
if (mysql_query($login)==0)
echo "No souch user!";
else 
{
while ($login_row = mysql_fetch_assoc($login)) 
{
$password_db = $login_row['password'];
$password = md5($password);

if ($password!=$password_db)
echo "Incorect password!";
else 
{
//check if active
$active = $login_row['active'];
$email = $login_row['email'];

if ($active==0)
echo "You haven't activated your account, please check your email ($email) for activation!";
else 
{
$_SESSION['username']=$username; //assign session
header("Location: index.php");//refresh
}
}
}
   }
?>
Thank you for your spent time and help..

My issue is that I cannot get my user information to (1) upload to the database, and (2) if I manually put information in the data base I cannot retrive it when trying to log in..

I assume its a connection issue, but I cannot seem to find it.

Thanks in advance for the help!



This is my "init.inc.php" script...

Code: [Select]
<?php

session_start();

$exceptions = array('register','login');

$page =  substr(end(explode('/',$_SERVER['SCRIPT_NAME'])),0,-4);

if(in_array($page, $exceptions) === false){
if(isset($SESSION['username']) === false){
header('Location: login.php');
die();
}
}

mysql_connect('localhost','root','');
mysql_select_db('newlogin');

$path = dirname(__FILE__);

include("{$path}/inc/user.inc.php");


?>

This is my "user.inc.php" script...

Code: [Select]
<?php

// check is the given username exisits in the table
function user_exists($user){
$user = mysql_real_escape_string($user);
$total = mysql_query("SELECT COUNT('user_id') FROM 'user_tbl' WHERE 'user_name' = '{$user}'");
return (mysql_result($total, 0) == '1') ? true : false;
}

// checks is the username and password are valid
function valid_credentials($user, $pass){
$user = mysql_real_escape_string($user);
$pass = sha1($pass);

$total = mysql_query("SELECT COUNT('user_id') FROM 'user_tbl' WHERE 'user_name' = '{$user}' AND 'user_password' = '{$pass}'");
return (mysql_result($total, 0) == '1') ? true : false;
}

//adds user to the database
function add_user($user, $pass){
$user = mysql_real_escape_string(htmlentities($user));
$pass = sha1($pass);

mysql_query("INSERT INTO 'user_tbl' ('user_name', 'user_password') VALUES ('{$user}', '{$pass}')");
}

?>


Finally this is my "register.php" Page...

Code: [Select]
<?php 
error_reporting(0);
include('core/init.inc.php');

$errors = array();

if(isset($_POST['username'], $_POST['password'], $_POST['repeat_password'])){
if(empty($_POST['username'])){
$errors[] = "The username field cannot be empty!";
}

if(empty($_POST['password']) || empty($_POST['repeat_password'])){
$errors[] = "The password fields cannot be empty!";
}

if($_POST['password'] !== $_POST['repeat_password']){
$errors[] = "Password verification failed !";
}

if(user_exists($_POST['username'])){
$errors[] = "That username has already been taken!";
}

if(empty($errors)){
add_user($_POST['username'], $_POST['password']);

$_SESSION['username'] = htmlentities($_POST['username']);

header('Location: protected.php');
die();

}

}
?>

<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
<title>Untitled Document</title>
</head>

<body>
<div>
    <?php

if( empty($errors) === false){
?>
        <ul>
        <?php

foreach($errors as $error){
echo "<li>{$error}</li>";
}

?>       
        </ul>
        <?php
}

?>
    </div>
<form action="" method="post">
    <p>
        <label for="username"> Username:</label>
            <input type="text" name="username" id="username" value="<?php if(isset($_POST['username'])) echo htmlentities($_POST['username']); ?>" />
        </p>
        <p>
        <label for="password"> Password:</label>
            <input type="password" name="password" id="password" />
        </p>
        <p>
        <label for="repeat_password"> Repeat Password:</label>
            <input type="password" name="repeat_password" id="repeat_password" />
        </p>
        <p>
        <input type="submit" value="Register" />
        </p>
       
   
    </form>
</body>
</html>

I'm trying to make my register script check the database's IP column and compare it with the user's IP. If the User's IP equals that in the DB column, it should say "Sorry, there is already an account registered with your IP Address. Please log in.", and if there's no IP match, it should allow them to continue with registering.
I've been tinkering around with this for a while and I can't seem to figure it out. Any help would be appreciated

 
if ($_SERVER['REMOTE_ADDR'] == mysql_query("SELECT ip FROM users")) {
 die('Sorry, there is already an account registered with your IP Address. Please <a href="/login.php>log in.</a>');
  }else{
  echo '';
  }


I think the problem is with the mySQL query...

Hello,

I changed my register table and it seems to have made it stop working, All's i changed is the layout of the 'Username, Email' etc so it looks better, nothing else, but the register button aint working!!

Old Code:
Code: [Select]
<table width="700" height="900" background="registerpic.jpg">
<tr valign="middle">
<td align="center">
<br>
<div align="center" class="style4">
  <? echo REGIS ?></div>
<table width="28%" border="0" align="center" cellpadding="0" cellspacing="0">
<form action="" method="post">

  <tr>
    <td><div align="right" class="style6 style1"><strong><? echo USEE ?></strong></div></td>
    <td width="9">:</td>
    <td width="192"><div align="left">
      <input name="reg_username" type="text" class="input" id="reg_username" value="" size="32" maxlength="64">
    </div></td>
  </tr>
  <tr>
    <td><div align="right" class="style6 style1"><strong><? echo PASSS ?></strong></div></td>
    <td><span class="style6 style1"><strong>:</strong></span></td>
    <td><div align="left">
      <input name="reg_password" type="password" class="input" id="reg_password" value="" size="32" maxlength="40">
    </div></td>
  </tr>
  <tr>
    <td><div align="right" class="style6 style1"><strong><? echo CONPASS ?></strong></div></td>
    <td><span class="style6 style1"><strong>:</strong></span></td>
    <td><div align="left">
      <input name="reg_password2" type="password" class="input" id="reg_password2" value="" size="32" maxlength="40">
    </div></td>
  </tr>
  <tr>
    <td><div align="right" class="style6 style1"><strong><? echo EM ?></strong></div></td>
    <td><span class="style6 style1"><strong>:</strong></span></td>
    <td><div align="left">
      <input name="email" type="text" class="input" id="username3" value="" size="32" maxlength="150" >
    </div></td>
  </tr>
  <tr>
    <td><div align="right" class="style6 style1"><strong><? echo GENDER ?></strong></div></td>
    <td><span class="style6 style1"><strong>:</strong></span></td>
    <td><div align="left">
      <select name="gender" class="input" id="starting" >
        <option value="Male"><? echo MALE ?></option>
        <option value="Female"><? echo FEMALE ?></option>
      </select>
    </div></td>
  </tr>
   <tr>
    <td><div align="right" class="style6 style1"><strong><? echo LANGU ?></strong></div></td>
    <td><span class="style6 style1"><strong>:</strong></span></td>
    <td><div align="left">
      <select name="lang" class="input" id="starting" >
        <option value="English"><? echo ENG ?></option>
        <option value="Turkish"><? echo TR ?></option>
      </select>
    </div></td>
  </tr>
  <tr>
    <td><div align="right" class="style5"><? echo START ?></div></td>
    <td><span class="style6 style1"><strong>:</strong></span></td>
    <td><div align="left">
      <select name="location" class="input" id="starting" >
        <option value="England" selected>England</option>
        <option value="Japan">Japan</option>
        <option value="Colombia">Colombia</option>
        <option value="Usa">Usa </option>
        <option value="Russia">Russia </option>
        <option value="Italy">Italy</option>
        <option value="Turkey">Turkey</option>
      </select>
      <input type="hidden" name="ref" value="<?php echo "$_GET[ref]"; ?>">
    </div></td>
  </tr>
   <tr>
    <td colspan="3"><div align="center">
      <p style="display: inline">&nbsp;</p>
      <p style="display: inline"><em><strong>
        <? echo SEC ?>      </strong></em></p>
    </div></td>
  </tr><tr>
      <td colspan="2" class="TableArea"><img src="eng/CaptchaSecurityImages.php" width="171" height="50" /></td>
      <td class="TableArea" valign="top"><fieldset>
        <legend><font color="#6F6F6F"><b><? echo SECC ?></b>:</font></legend>
        <span class="tablearea">
        <input id="security_code" class="button" name="security_code" size="20" type="text"/>
        </span>
        <span style="display: inline">
        <input name=Submit type=submit  value=  <? echo REGGG ?>  >
        </span>
      </fieldset></td>
    </tr>

  <tr>
    <td colspan="3"><div align="center"></div></td>
  </tr>
</table>
<center><p><b><font color= "ffffff"><? echo "$message"; ?></font></p>
<p>
</p></td>
<a href='register.php'><font size="1" color="#CCCCCC"><b><a href='index.php'>Home</a> - <a href='lost2.php'>Lost Password</a> - <a href='screens.php'>Screenshots</a></b></i></font>
<td align="center" width="238"></form>
</table>

New Code:
Code: [Select]
<div id="main">
      <img src="images/register(1).jpg">

<form action="" method="post">
      <div id="register_table">
        <div class="row">
          <div class="title_column">Username</div>
          <div class="space_column">~</div>
          <div class="input_column"><input type="text" name="reg_username" id="reg_username" value="" class="text" /></div>
        </div>
        <div class="row">

          <div class="title_column">Email</div>
          <div class="space_column">~</div>
          <div class="input_column"><input type="text" name="username3" id="username3" value="" class="text" /></div>
        </div>
        <div class="row">
          <div class="title_column">Password</div>
          <div class="space_column">~</div>

          <div class="input_column"><input type="text" name="reg_password" id="reg_password"  value="" class="text" /></div>
        </div>
        <div class="row">
          <div class="title_column">Retype Pass</div>
          <div class="space_column">~</div>

          <div class="input_column"><input type="text" name="reg_password2" id="reg_password2"  value="" class="text" /></div>
        </div>
        <div class="row">
          <div class="title_column">Gender</div>
          <div class="space_column">~</div>
          <div class="input_column"><select name="gender" style="font-size:9px;font-family:Tahoma;width:130px;"><option value="Male">Male</option><option value="Female">Female</option></select></div>
        </div>

        <div class="row">
          <div class="title_column">Location</div>
          <div class="space_column">~</div>
          <div class="input_column"><select name="starting" style="font-size:9px;font-family:Tahoma;width:130px;"><option value="England">England</option><option value="Japan">Japan</option><option value="Colombia">Colombia</option><option value="USA">USA</option><option value="Russia">Russia</option><option value="Italy">Italy</option><option value="Turkey">Turkey</option></select></div>
        </div>

        <div class="row">
          <div class="title_column" style="padding-top: 2px; margin-top: 2px;"><img src="eng/CaptchaSecurityImages.php" alt="Verify" /></div>
          <div class="space_column">~</div>
          <div class="input_column"><input type="text" name="security_code" id="security_code" value="" class="text" /></div>
        </div>

        <br />
      <div style="text-align:center;"><input type="submit" name="submit" value="<? echo Register ?>" class="submit" />
      </div>
<? echo "$message"; ?>
</form></div>
Thanks Guys!

hi guys i need help i started a code of a page Register.php and i need to now what to do now and if this function is 100% ok with the php rules
<?php
// ----
session_start();
error_reporting(E_ALL);
include_once("...\\config.php")
//----------------------------------------------------
function getRegisteredBy($Reg);
{
    switch($Reg){
        case 0:
            return "AccountName";
        case 1:
            return "AccountPassword";
        case 2:
            return "AccountEmail";       
    }
}
$Reg = mssql_query("INSERT INTO MEMB_INFO (memb___id,memb__pwd,memb_mail,) VALUES ($AccountName,$AccountPassword,$AccountEmail)");
?> thanks for the help and have a good day

Hi guys I'm trying to fix my user registration page, I've gotten myself into a real mess here so any help would be appreciated 
I am getting "Notice: Undefined index" message for my variables (firstname,lastname,password,repeatpasswords) and it is not loading the page only the "die" message which is happening because the script is failing.

Code: [Select]
<?php
session_start();

$con = mysql_connect('localhost','root','abc'); 
if (!$con)
   {
   die ("Could not connect to database" . mysql_error()); 
   }

//get data from the form
if (isset($_POST['firstname'])) { $firstname = $_POST['firstname']; }
if (isset($_POST['lastname'])) { $lastname = $_POST['lastname']; }
if (isset($_POST['username'])) { $username = $_POST['username']; }
if (isset($_POST['password'])) { $password = $_POST['password']; }
if (isset($_POST['repeatpassword'])) { $repeatpassword = $_POST['repeatpassword']; }
if (isset($_POST['submit']))
{
//check for existance
if ($firstname&&$lastname&&$username&&$password&&$repeatpassword)
           {
   //check passwords match
           if ($password==$repeatpassword) 
       {
       //check char length of username and names
       if (strlen($username)>25||strlen($firstname)>25)
       {
       echo "The first name, last name or username fields are too long!";
       }
       else
       {
       //check password length
       if (strlen($password)>25||strlen($password)<6)
       {
       echo "Password must be between 6 and 25characters";
       }
       else 
       {
   //encrypt password
       $password = md5 ($password); 
           $repeatpassword = md5 ($repeatpassword);
       }
       }
       }
          else
           echo "Your passwords do not match!";
       }
           else 
               echo "Please fill in all fields!";
   }
   
   //select database table
   mysql_select_db('theimageworks');
   //add data to database
   $sql="INSERT INTO user (firstname, lastname, username, password) 
   VALUES ('$_POST[firstname]', '$_POST[lastname]', '$_POST[username]', '$_POST[password]')";
  
   if (!mysql_query($sql,$con))
   {
   die ('Error: ' . mysql_error());
   }
die ("You have been registered! Return to <a href='loginpage.php'>login page</a>");
mysql_close($con);
?>

Ok so im working on this register script and trying to implement a select value field along with a email field and password field. At the moment i have given it my best shot and typed in most of the code, although im still not satisfied with the outcome.

For example: When i type in a correct email with a legit password, and i DONT select one of the drop down options, i want it to say the error: "Please type in all fields.". This would be vise versa for each other field also!

If the user again types in a legit email and password, and selects a value from the dropdown menu, but is already registered in the database, i would want another error message saying: "This club has already been registered to the database".

I given it my best shot but simply not getting the above result.

<?php include"database.php";?>     <html><head><title>Register</title></head><body><h1>Register</h1><form name="register" action="register.php" method="post">Email: <input type="text" name="email"><br>Password: <input type="password" name="password"><br>Club: <select name="club">    <option value="">Select...</option>    <option value="npob">Old Boys</option>    <option value="tukupa">Tukupa</option>    <option value="coastal">Coastal</option>    <option value="inglewood">Inglewood</option>    <option value="clifton">Clifton</option>    <option value="stratford">Stratford</option>    <option value="hawera">Hawera</option>  </select><br><input type='submit' name='submit' value='Submit'></form>     <?php     if (isset($_POST['submit'])) {              if (empty($_POST['email']) && empty($_POST['password']) && empty($_POST['club']))  {         $errors[] = "Please fill out all fields.";         }              $email = addslashes(strip_tags($_POST['email']));     $password = addslashes(strip_tags($_POST['password']));     $club = addslashes(strip_tags($_POST['club']));          if (!empty($email)) {         if (!filter_var($email, FILTER_VALIDATE_EMAIL)) {         $errors[] =  "This email address is not valid.";         }         }          if (!empty($password)){         if (strlen($password)>25 || strlen($password)<6) {         $errors[] =  "Password must be betwen 6 and 25 characters.<br>";         }         }         if (!empty($club)){          $errors[] =  "Please select a Club.<br>";          }       $check = mysql_query("SELECT * FROM users WHERE email='".$email."'");         if (mysql_num_rows($check)>=1) {         $errors[] =  "Email is already taken!";         }      $check = mysql_query("SELECT * FROM users WHERE club='".$club."'");      if (mysql_num_rows($check)>=1) {      $errors[] =  "Sorry this club has already been registered with the NZRU.";      }                  if (empty($errors)) {         $register = mysql_query("INSERT INTO users (email, password, club, level) VALUES ('".$email."', '".md5($password)."', '".$club."', '')");         echo "You have succesfully registered!";                              } else {                                  foreach($errors as $nErrors){         echo $nErrors . "<br>";                         }                     }                 } ?>()

Thankyou.

Sorry for many posts, trying to make my website   When I press the register button on my website it will just act as if the page is refreshing and not send any information to mysql I believe I have connected everything up correctly, can anyone tell my what I have done wrong please?   If you want to check out the website to see what is going on check out www.jokestary.comli.com

<?php


//This function will display the registration form

function register_form(){


$date = date('D, M, Y');

echo "<form action='?act=register' method='post'>"

."Username: <input type='text' name='username' size='30'><br>"

."Password: <input type='password' name='password' size='30'><br>"

."Confirm your password: <input type='password' name='password_conf' size='30'><br>"

."Email: <input type='text' name='email' size='30'><br>"

."<input type='hidden' name='date' value='$date'>"

."<input type='submit' value='Register'>"

."</form>";


}


//This function will register users data

function register(){


//Connecting to database

include('connect.php');

if(!$connect){

die(mysql_error());

}


//Selecting database

$select_db = mysql_select_db("database", $connect);

if(!$select_db){

die(mysql_error());

}


//Collecting info

$username = $_REQUEST['username'];

$password = $_REQUEST['password'];

$pass_conf = $_REQUEST['password_conf'];

$email = $_REQUEST['email'];

$date = $_REQUEST['date'];


//Here we will check do we have all inputs filled


if(empty($username)){

die("Please enter your username!<br>");

}


if(empty($password)){

die("Please enter your password!<br>");

}


if(empty($pass_conf)){

die("Please confirm your password!<br>");

}


if(empty($email)){

die("Please enter your email!");

}


//Let's check if this username is already in use


$user_check = mysql_query("SELECT username FROM users WHERE username='$username'");

$do_user_check = mysql_num_rows($user_check);


//Now if email is already in use


$email_check = mysql_query("SELECT email FROM users WHERE email='$email'");

$do_email_check = mysql_num_rows($email_check);


//Now display errors


if($do_user_check > 0){

die("Username is already in use!<br>");

}


if($do_email_check > 0){

die("Email is already in use!");

}


//Now let's check does passwords match


if($password != $pass_conf){

die("Passwords don't match!");

}



//If everything is okay let's register this user


$insert = mysql_query("INSERT INTO users (username, password, email) VALUES ('$username', '$password', '$email')");

if(!$insert){

die("There's little problem: ".mysql_error());

}


echo $username.", you are now registered. Thank you!<br><a href=login.php>Login</a> | <a href=index.php>Index</a>";


}


switch($act){


default;

register_form();

break;


case "register";

register();

break;


}


?> 

Here is the connect.php code

<?php
$hostname="mysql6.000webhost.com"; //local server name default localhost
$username="a5347792_users";  //mysql username default is root.
$password="";       //blank if no password is set for mysql.
$database="a5347792_users";  //database name which you created
$con=mysql_connect($hostname,$username,$password);
if(! $con)
{
die('Connection Failed'.mysql_error());
}
 
mysql_select_db($database,$con);
?>

ok so I have this code.  I need to know how to modify it so that if the user has already registered for the event, they cannot do so again.........how can I do this?  does this make sense? members that have already registered are held in a table called events..........userid, eventid, name, subevent.......
Code: [Select]
<?php

$sql = mysql_query("SELECT * FROM Registration WHERE eventid=".$_GET['eventid']." LIMIT 1");
while($row = mysql_fetch_array($sql)){
$eventid = $row["eventid"];
$event = $row["event"];
$startdate = $row["startdate"];
$enddate = $row["enddate"];
$description = $row["description"];
$location = $row["location"];
$title1 = $row['title1'];
$title2 = $row['title2'];
$title3 = $row['title3'];
$title4 = $row['title4'];
$title5 = $row['title5'];
$title6 = $row['title6'];
$title7 = $row['title7'];
$title8 = $row['title8'];
$price1 = $row['price1'];
$price2 = $row['price2'];
$price3 = $row['price3'];
$price4 = $row['price4'];
$price5 = $row['price5'];
$price6 = $row['price6'];
$price7 = $row['price7'];
$price8 = $row['price8'];
$date1 = $row['date1'];
$date2 = $row['date2'];
$date3 = $row['date3'];
$date4 = $row['date4'];
$date5 = $row['date5'];
$date6 = $row['date6'];
$date7 = $row['date7'];
$date8 = $row['date8'];

//this will echo the contents of each db row as they are iterated in the loop

#############################
echo "<form action ='eventreg.php' method='post'>";
echo "<center><table border='1' width='600'>";


if (!empty($title1)) { echo "<tr><td width='100'> <input type='checkbox' name='subevent1' value='$title1'/></td><td width='500'><strong>$title1 </strong><br /> $date1 <br />$ $price1 </tr></td> "; }
if (!empty($title2)) { echo "<br/><tr><td> <input type='checkbox' name='subevent2' value='$title2' /></td><td><strong>$title2 </strong><br /> $date2 <br />$ $price2 </tr></td>" ; }

if (!empty($title3)) { echo "<br/><tr><td><input type='checkbox' name='subevent3' value='$title3' /></td><td><strong>$title3</strong> <br /> $date3 <br />$ $price3</tr></td>"; }

if (!empty($title4)) { echo "<br/><tr><td><input type='checkbox' name='subevent4' value='$title4' /></td><td><strong>$title4</strong> <br /> $date4 <br />$ $price4</tr></td>"; }

if (!empty($title5)) { echo "<br/><tr><td><input type='checkbox' name='subevent5' value='$title5' /></td><td><strong>$title5</strong> <br /> $date5 <br />$ $price5</tr>"; }

if (!empty($title6)) { echo "<br/><tr><td> <input type='checkbox' name='subevent6' value='$title6' /></td><td><strong>$title6 </strong><br /> $date6 <br />$ $price6</tr></td>"; }

if (!empty($title7)) { echo "<br/><tr><td> <input type='checkbox' name='subevent7' value='$title7' /></td><td><strong>$title7</strong> <br /> $date7 <br />$ $price7</tr></td>"; }

if (!empty($title8)) { echo "<br/><tr><td> <input type='checkbox' name='subevent8' value='$title8' /></td><td><strong>$title8</strong> <br /> $date8 <br />$ $price8</tr></td>"; }
echo "</table>";
echo "<input name='userid' type=\"hidden\" value=\"$userid\" />";
echo "<input name='eventid' type=\"hidden\" value=\"$eventid\" />";
echo "<input name='event' type=\"hidden\" value=\"$event\" />";
echo "<input name='name' type=\"hidden\" value=\"$name\" />";
echo "<input name=\"save\" type=\"submit\" value=\"Register Now!\" />";

echo "</center></form>";
}
//etc etc

 ?>