PHP - Improving My Search

hi everyone, first time in the forum, english is not my first language so i apologize for the spelling...   i manage a website i did some years ago for a car sell place..   in the website i have to upload the new cars and download the ones that have been sold every month...   now that takes a lot of time, i have to send them a list and they tell me wich ones add to the list and wich ones remove, for every car i have a litle box with  picture and some data, whenyou clik it it sends you to a small page with some more pictures of that car and some more text.. so every time i have to create a new page for every car and put the pictures on it...   i would like to have some sort of database with the list of all the active cars that i can get with one clik... then... i would like to have some sort of form where i can drag the pictures and it takes one of them with some of the information and creates the small post of the car and the other biger one with the other pictures and the rest of the info...     i dont know if im expressing my self welll     any ideas?   this is the site: www.laradialautomoviles.com   its the first site i ever did about 5 years ago, i never studied webdesign dont have the money to do it... so please dont criticize XD

I'm trying to figure out how I can reduce as much functionality as possible and still keep it doing what it needs to do. What I mean by functionality is the number of queries being performed or any of the other code for that matter. I do show at the bottom of my post what I have so far, however that doesn't cover all the queries.




Code: [Select]
<?php
            if ($access_level_id == 2 || $access_level_id == 3) {
       $query = "SELECT
         characters.id
        FROM
         characters"; 
       $result = mysqli_query ($dbc,$query); 
       $total_num_characters = mysqli_num_rows($result);
     
       $query = "SELECT
         user_characters.id
        FROM
         user_characters
        INNER JOIN user_accounts
            ON user_accounts.id = user_characters.user_id"; 
      } else { 
       $query = "SELECT
         user_characters.id
        FROM
         user_characters
        INNER JOIN user_accounts
            ON user_accounts.id = user_characters.user_id
        WHERE
         user_accounts.id = '".$user_id."'"; 
      }
      $result = mysqli_query($dbc,$query);
            echo 

      $num_available_characters = mysqli_num_rows($result);
            if (($num_available_characters > "1") || (($access_level_id == 2 || $access_level_id == 3) && (isset($total_num_characters)) && ($total_num_characters > "0"))) {
            ?>
       <form method="POST" id="change_default_character">
                <select class="dropdown" name="new_default_character_id" id="new_default_character_id" title="Select Character">               
            <?php
    
       if ($default_character_id > "0") {
        print "<option value=".$default_character_id.">".$default_character_name;
       } else {
        print "<option value=0>- Select -";
       }
                if ($access_level_id == 2 || $access_level_id == 3) {
        $query = "SELECT
          characters.id,
          characters.character_name
         FROM
          characters
         WHERE
          characters.id <> '".$default_character_id."' AND
          characters.status_id = '1'
         ORDER BY
          characters.character_name"; 
       } else {
        $query = "SELECT
          characters.id,
          characters.character_name
         FROM
          characters
         INNER JOIN
             user_characters
             ON characters.id = user_characters.character_id      
         INNER JOIN
          user_accounts
             ON user_accounts.id = user_characters.user_id
         WHERE
          user_accounts.id = '".$user_id."' AND
          user_characters.character_id <> '".$default_character_id."' AND
          characters.status_id = '1'
         ORDER BY
          characters.character_name"; 
       }
       $result = mysqli_query ($dbc,$query);
       $num_rows = mysqli_num_rows ($result);
       if ($num_rows > 0) {
        if ($access_level_id == 2 || $access_level_id == 3) {
         print "<optgroup label=\"** Active Characters **\">";
        }
                    while ( $row = mysqli_fetch_array ( $result, MYSQL_ASSOC ) ) {
         print "<option value=\"".$row['id']."\">".$row['character_name']."</option>\r";
        }
       }
                if ($access_level_id == 2 || $access_level_id == 3) {
        $query = "SELECT
          characters.id,
          characters.character_name
         FROM
          characters
         WHERE
          characters.id <> '".$default_character_id."' AND
          characters.status_id = '2'
         ORDER BY
          characters.character_name"; 
       } else {
        $query = "SELECT
          characters.id,
          characters.character_name
         FROM
          characters
         LEFT JOIN
          user_characters
             ON characters.id = user_characters.character_id      
         LEFT JOIN
          user_accounts
             ON user_accounts.id = user_characters.user_id
                        WHERE
          user_accounts.id = '".$user_id."' AND
          user_characters.character_id <> '".$default_character_id."' AND
          characters.status_id = '2'
         ORDER BY
          characters.character_name"; 
       }
       $result = mysqli_query ($dbc,$query); 
       $num_nows = mysqli_num_rows($result);
       if ($num_rows > "0") {
        print "<optgroup label=\"** Inactive Characters **\">"; 
        while ( $row = mysqli_fetch_array ( $result, MYSQL_ASSOC ) ) {
            print "<option value=\"".$row['id']."\">".$row['character_name']."</option>\r";    
        }
       }
                ?>
       </select>
                </form>
            <?php
      } else {
       print "<h1>".$default_character_name."</h1>\n";
      }
            ?> 

Code: [Select]
<?php
/**
     * Get roster list
     *
     * @return object/NULL
     */
    function getRosterList()
    {
        $this->db->from('rosterList');
        $query = $this->db->get();
        if ($query->num_rows() > 0) 
        {
            return $query->result();
        }
        return null;
    }
    
    /**
     * Get list of roster by user ID
     *
     * @return object/NULL
     */
    function getRosterByUserID()
    {
        $this->db->from('rosterList');
        $this->db->where('userID', $userID);
        $query = $this->db->get();
        if ($query->num_rows() > 0) 
        {
            return $query->result();
        }
        return null;
    }  
?>

Hi all!

I am currently reprogramming my site with objects etc, making it better. I have some code below and am not sure upon how to make it better. loops, cases, classes, functions etc not sure what to do, currently looks like a jumble, here it is, am looking comments on how I can improve how it looks and maybe split it up more or someting, not su

#####  FIND OUT SQL TO SHOW RESULTS ##### 
// country results sql
if( $_GET['country'] != "" ){

$keyword = str_ireplace("_"," ",$_GET['country']);
$keyword = langCountryNum($keyword,"COUNTRY",138);

$sql = 'SELECT * FROM exchange WHERE `location` = "'.$keyword.'" ORDER BY FROM_UNIXTIME(lastOnline) DESC';
$urlText = "/xxxxx/".( in_array($lang,$_ENV['supportedLanguages']) ? $lang."/" : $nothing).HEADlanguage_exchange."/country/".HEADbefore_lang.constant("COUNTRY" .$keyword).HEADafter_lang;

//language results sql
}elseif( $_GET['language'] != "" ){
$keyword = str_ireplace("_"," ",$_GET['language']);
$keyword = langCountryNum($keyword,"Lang",130);
$sql = 'SELECT * FROM exchange WHERE `option` = "'.$keyword.'" ORDER BY FROM_UNIXTIME(lastOnline) DESC';
$urlText = "/xxxx/".( in_array($lang,$_ENV['supportedLanguages']) ? $lang."/" : $nothing).HEADlanguage_exchange."/language/".HEADbefore_lang.constant("Lang" .$keyword).HEADafter_lang;
// all members results sql 
}else{
   $sql = "SELECT * FROM exchange ORDER BY id DESC";
   $urlText = ( in_array($lang,$_ENV['supportedLanguages']) ? $lang."/" : $nothing).HEADall_penpals;
  }
#####  END FIND OUT SQL TO SHOW RESULTS ##### 

Hello,

My upload script is working for the most part and while I know that I need a couple of little fixes and will need help with those I also wouldn't mind some tips on how I could have written it better in the first place.

The 2 problems I am having.
1. If the copy image fails the script doesn't and still creates a database entry. I would like to stop it from doing that but can't seem to work it out.
2. My mate is getting file type errors even though he is trying to upload small .jpg files. I can't seem to recreate the problem. Maybe someone can see something that might be problematic??
Code: [Select]
<?
        $idir = "../rosysartworks/gallery/";   // Path To Images Directory
        $tdir = "../rosysartworks/gallery/thumbs/";   // Path To Thumbnails Directory
        $iwidth = "600";   // Maximum Width For Thumbnail Images
        $iheight = "600";   // Maximum Height For Thumbnail Images
        $twidth = "233";   // Maximum Width For Thumbnail Images
        $theight = "178";   // Maximum Height For Thumbnail Images
        ?>

          <?
        // Catching the inputs
$title = Trim(stripslashes($_POST['title']));
$paypal = Trim(stripslashes($_POST['paypal']));
        // Check if the form has been submitted.
if (isset ($_POST['submit'])) {
$problems = FALSE; // No problems so far.

// Check for each value.
if (empty ($title)) {
$problem = TRUE;
$problems = 'You forgot to enter a title!<br />';
}
if (empty ($paypal)) {
$problem = TRUE;
$problems = 'You forgot to enter a paypal link!<br />';
}
if (!$problem) { // If there are no problems...
       
        // Uploading/Resizing Script
        $url = $_FILES['imagefile']['name'];   // Set $url To Equal The Filename For Later Use
        if ($_FILES['imagefile']['type'] == "image/jpg" || $_FILES['imagefile']['type'] == "image/jpeg" || $_FILES['imagefile']['type'] == "image/pjpeg" || $_FILES['imagefile']['type'] == "image/JPG") {
          $file_ext = strrchr($_FILES['imagefile']['name'], '.');   // Get The File Extention In The Format Of , For Instance, .jpg, .gif or .php
          $copy = copy($_FILES['imagefile']['tmp_name'], "$idir" . $_FILES['imagefile']['name']);   // Move Image From Temporary Location To Permanent Location
         
         
          if ($copy) {   // If The Script Was Able To Copy The Image To It's Permanent Location
         
            // Resize for preview image.
            $simg = imagecreatefromjpeg("$idir" . $url);   // Make A New Temporary Image To Create The Thumbanil From
            $currwidth = imagesx($simg);   // Current Image Width
            $currheight = imagesy($simg);   // Current Image Height
           
            if ($currwidth > $iwidth && $currheight > $iheight) {
              $newwidth = $iwidth;
              $newheight = $newwidth * $currheight / $currwidth;
              if ($newheight > $iheight) {
                $newheight = $iheight;
                $newwidth = $newheight * $currwidth / $currheight; }

              $dimg = imagecreatetruecolor($newwidth, $newheight);   // Make New Image For Preview
              imagetruecolortopalette($simg, false, 256);   // Create New Color Pallete
              $palsize = ImageColorsTotal($simg);
              for ($i = 0; $i < $palsize; $i++) {   // Counting Colors In The Image
              $colors = ImageColorsForIndex($simg, $i);   // Number Of Colors Used
              ImageColorAllocate($dimg, $colors['red'], $colors['green'], $colors['blue']);   // Tell The Server What Colors This Image Will Use
              }
              imagecopyresampled($dimg, $simg, 0, 0, 0, 0, $newwidth, $newheight, $currwidth, $currheight);   // Copy Resized Image To The New Image (So We Can Save It)
              $success = imagejpeg($dimg, "$idir" . $url, 100);   // Saving The Image
              imagedestroy($simg);   // Destroying The Temporary Image
              imagedestroy($dimg);   // Destroying The Other Temporary Image

              if ($success) {
                print 'Preview image '.$url.' width: '.$newwidth.' height: '.$newheight.' created successfully.<br />';   // Resize successful for preview image
                unset($success);
              }
            } else {
              unset($simg, $currwidth, $currheight);
          }
           
           
              // Resize for thumbnail
              $simg = imagecreatefromjpeg("$idir" . $url);   // Make A New Temporary Image To Create The Thumbanil From
              $currwidth = imagesx($simg);   // Current Image Width
              $currheight = imagesy($simg);   // Current Image Height
           
              $newwidth = $twidth;
              $newheight = $newwidth * $currheight / $currwidth;
              if ($newheight > $theight) {
                $newheight = $theight;
                $newwidth = $newheight * $currwidth / $currheight; }
           
              // maxWidth: mw, maxHeight: mh, oldHeight: oh, oldWidth: ow, newHeight: nh, newWidth: nw.   
              // nw = mw; nh = nw * oh / ow;
              // if (nh > mh) { nh = mh; nw = nh * ow / oh }
         
              $dimg = imagecreatetruecolor($newwidth, $newheight);   // Make New Image For Thumbnail
              imagetruecolortopalette($simg, false, 256);   // Create New Color Pallete
              $palsize = ImageColorsTotal($simg);
              for ($i = 0; $i < $palsize; $i++) {   // Counting Colors In The Image
              $colors = ImageColorsForIndex($simg, $i);   // Number Of Colors Used
              ImageColorAllocate($dimg, $colors['red'], $colors['green'], $colors['blue']);   // Tell The Server What Colors This Image Will Use
              }
              imagecopyresampled($dimg, $simg, 0, 0, 0, 0, $newwidth, $newheight, $currwidth, $currheight);   // Copy Resized Image To The New Image (So We Can Save It)
              $success = imagejpeg($dimg, "$tdir" . $url, 100);   // Saving The Image
              imagedestroy($simg);   // Destroying The Temporary Image
              imagedestroy($dimg);   // Destroying The Other Temporary Image
             
              if ($success) {
              print 'Image thumbnail '.$url.' width: '.$newwidth.' height: '.$newheight.' created successfully.';   // Thumbnail created successfully
              }
            } else {
            print '<font color="#FF0000">ERROR: Unable to upload image.</font>';   // Error Message If Upload Failed
            } // End upload at copy failure
                 }  else {
                     print 'Failed to copy image to temp location.';
                   }
        } else {
          print '<font color="#FF0000">ERROR: Wrong filetype (has to be a .jpg or .jpeg. Yours is ';   // Error Message If Filetype Is Wrong
          print $file_ext;   // Show The Invalid File's Extention
          print '.</font>';
        } // End upload script

       
// Define the query.
  $add_new_session = $sql = "INSERT INTO  `gallery` (
  `id` ,
  `title` ,
  `image` ,
  `thumb` ,
  `width` ,
  `height` ,
  `paypal` ,
  `date_entered`
  )
  VALUES (
  0,
  '".mysql_real_escape_string(($title))."',
  '".mysql_real_escape_string(($url))."',
  '".mysql_real_escape_string(($url))."',
  '".mysql_real_escape_string(($newwidth))."',
  '".mysql_real_escape_string(($newheight))."',
  '".mysql_real_escape_string(($paypal))."',
  NOW()
  )";

  // execute the query.
  if (@mysql_query ($add_new_session)) {
  print "<p>The new gallery image $url has been added.</p>";
  unset($sessionName, $maxAttendees, $newwidth, $newheight);
  $hidden = 'hidden';
}
else{
  print '<a name="formTop"></a>'.'<p class="error">Your session has failed to upload. Please contact website support.</p>';
  echo $add_new_session;
}
} else { // Forgot a field.

// print '<p>Please try again!</p>';
$problems .= '<a name="formTop"></a>'.'Please try again!<br />';
if ($problem) {
print '<p class="error">' . $problems . '</p>';
}
}

// End of handle form IF
// Display the form

print '<h2>Upload New Image</h2>'
. '<p>Please only try uploading .jpg images</p>'
  . '<form method="post" action="index.php" enctype="multipart/form-data">'
  . '<label>Title:</label>'
      . '<input type="text" name="title" class="form">'
      . '<br />'
      . '<label>Image:</label>'
      . '<input type="file" name="imagefile" class="form">'
      . '<br />'
      . '<label>Paypal Link:</label>'
      . '<input type="text" name="paypal" class="form" size="50">'
      . '<br /><br />'
     
      . '<input name="submit" type="submit" value="Sumbit" class="form">'
      . '<input type="reset" value="Clear" class="form">'
  . '</form>';
?>

I am using this a modal window(jBox) - with a web Form in it, that requires the Form (just Name & Email) to be completed and Submitted in order to close the modal window - allowing access to the main page.

The Form uses this corresponding ../submit.php which this:

if (empty($_POST['name'])|| empty($_POST['email'])){
$response['success'] = false;
} else {
$response['success'] = true;
}

echo json_encode($response);

where, upon Form > submit, successfully shows 'error' if the Form fields are not populated, and 'success' when the Form fields are populated/submitted.

I'd like the Form to require a proper/valid email address and avoid spam and header injection
(maybe honeypot protection and implement a form of rate limiting (a single ip may not send more than x messages per day)).

Any assistance/guidance is appreciated