PHP - Mysql Request Suddenly Not Working Properly

This topic has been moved to Ajax Help.

http://www.phpfreaks.com/forums/index.php?topic=322771.0

helllo dear php-commmunity


new to Ruby - i need some advices -

i plan to do some requests in osm-files. (openstreetmap)

Question - how can i store the results on a Database -
eg mysql or - (if you prefer postgresql) -

note: my favorite db - at least at the moment is mysql


here the code

    require 'open-uri'
    require "net/http"
    require 'rexml/document'
     
    def query_overpass(object_type, left,bottom,right,top, key, value)
       base_url = "http://www.overpass-api.de/api/xapi?"
       query_string = "#{object_type}[bbox=#{left},#{bottom},#{right},#{top}][#{key}=#{value}]"
       url = "#{base_url}#{URI.encode(query_string)}"
       resp = Net::HTTP.get_response(URI.parse(url))
       data = resp.body
       return data
    end
     
    overpass_result = REXML::Document.new(query_overpass("node", 7.1,51.2,7.2,51.3,"amenity","restaurant|pub|ice_cream|food_court|fast_food|cafe|biergarten|bar|bakery|steak|pasta|pizza|sushi|asia|nightclub"))
     
    overpass_result.elements.each('osm/node') {|x|
      if !x.elements["tag[@k='name']"].nil?
        print x.elements["tag[@k='name']"].attributes["v"]
      end
      print " | "
     
      if !x.elements["tag[@k='addr:postcode']"].nil?
        print x.elements["tag[@k='addr:postcode']"].attributes["v"]
        print ", "
      end
      if !x.elements["tag[@k='addr:city']"].nil?
        print x.elements["tag[@k='addr:city']"].attributes["v"]
        print ", "
      end
      if !x.elements["tag[@k='addr:street']"].nil?
        print x.elements["tag[@k='addr:street']"].attributes["v"]
        print ", "
      end
      if !x.elements["tag[@k='addr:housenumber']"].nil?
        print x.elements["tag[@k='addr:housenumber']"].attributes["v"]
      end
      print " | "
      print x.attributes["lat"]
      print " | "
      print x.attributes["lon"]
      print " | "
      if !x.elements["tag[@k='website']"].nil?
        print x.elements["tag[@k='website']"].attributes["v"]
      end
      print " | "
      if !x.elements["tag[@k='amenity']"].nil?
        print x.elements["tag[@k='amenity']"].attributes["v"]
        print " | "
      end
      puts
    }

look forward to hear from you

again - i would love to store it on a mysql - database - if possible. If you would prefer postgresql - then i would
takte this one.... ;-)



look forward to hear from you

again - i would love to store it on a mysql - database - if possible. If you would prefer postgresql - then i would
takte this one.... ;-)

well - i guess that the answer to this will be the same no matter what language we are using.
If the db is a sql database we need to design the database schema and create the tables in the database.

The first step in accessing a db in our code is to get a connection to it.
If ruby is our choice of language, a search for "ruby sql connector" will give us
lots of options to read about.

Well - we also can do it in PHP. What do you think!?

Next, based on the schema we have designed, we need to create queries suitable for storing the data.
We will likely need to consider our transactional model.

Again, searching "ruby sql transactional model" will give us plenty of food for thought. Finally, we may want or need to close the connection to the database.

i have a dictionary  - THIS IS obviously a python dictionary

an this has approx 8 000 lines with records


[/CODE]

$ python printer.py
{'url': 'http://www.site1_com' 'cname': 'butcher', 'name': 'cheng', 'email': 'mail1@hotmail.com'}
{'url': 'http://www.site2_com' 'cname': 'dilbert', 'name': 'James', 'email': 'mail2@hotmail.com'}

[code=auto:0]i have a mysql-db up and runing in my opensuse

there i have created a db with the fields

url
cname
name
email



i use the

import MySQLdb

i studied this documentation he http://stackoverflow...abase-in-python

but i think this goes a bit over my head.


- well how can i get the data  ( in other words the dictionary) into the database?

love to hear from you

greetings

Okay, so I am trying to make a play.php file connected to my database, this database got a table named "webclientcreate".

When I go to play.php?id=1, it is showing the proper one (the 1st row wich got id 1 in it), however if I after that go to something random like play.php?fsfasd the ID 1s page still pops up..
I can also go to play.php?id=2 and still get the id 1's data.

I want to make it that every row got its own information (well it does, but the php file doesnt seem to recieve it correctly).

PHP version: 5.2.17
MySQL version: 5.1

Heres a picture of my table rows:


I've censored the MySQL connection information, I know it is working properly.

Code: [Select]
<?php

$connect = mysql_connect("mysql12.000webhost.com","****","******") or die(mysql_error());
mysql_select_db("***") or die(mysql_error());


$extract = mysql_query("SELECT * FROM webclientcreate");
$numrows = mysql_num_rows($extract);

while ($row = mysql_fetch_assoc($extract))
{
$id = $row['id'];
$server = $row['name'];
$ip   = $row['ip'];
$port = $row['port'];
$background = $row['background'];
}
if (isset($ip)&&isset($port)&&!empty($ip)&&!empty($port)) {

if (! $sock = @fsockopen($ip, $port, $num, $error, 1)) 
echo "";
else{ 
echo "<img src='fs/newyear/online.png'/>$ip on port $port is currently<B><FONT COLOR=lime> Online</b></FONT>"; 
fclose($sock);
}

}

?>
 <title>Playing <?php echo $server; ?> - ID <?php echo $id; ?> </title>

 <center>
 <body bgcolor="#000000">

 <applet name=client width=765 height=503 archive='<?php echo $jars; ?>' code='client.class'>

 <PARAM name='java_arguments' value='-Xmx700m'>

 <PARAM name='server_name' value='<?php echo $server; ?>'>

 <PARAM name='detail' value='low'>

 <PARAM name='ip' value='<?php echo $ip; ?>'>

 <PARAM name='port' value='<?php echo $port; ?>'>

 <PARAM name='background_image' value='<?php echo $background; ?>'>

 <PARAM name='headicons' value=''>

 </applet>
 </center>

Hi there, I have created an email script and i want it to email a different email depending on the subject chosen by raido boxes however the if's aren't doing what they should, If i select say recruitement it choses the last option and has the wrong subject here is my code:
<html>
<head>
</head>
<body>
<form action="contact.php" method="post">
<fieldset>
<legend>Contact Us</legend>
Your Email:*<br>
<input type="text" name="email"><br>
Subject:*<br>
Recruitment Enquiry:<input type="radio" name="subject" value="Recruitment">
Absense Notification:<input type="radio" name="subject" value="Absense">
General Enquiry<input type="radio" name="subject" value="Enquiry">
<br>
Message:*<br>
<textarea name="message" cols="50" rows="5"></textarea><br>

<input type="submit" value="Send Email">
</form>
Required fields are marked with a *<br><br>
<?php
if(isset($_POST))
{
$email = $_POST['email'];
$subject = $_POST['subject'];
$message = $_POST['message'];

//checcking that all relevent information is entered and correct

if(!$email || !$message)
{
$errmessage ="Please fill in all required fields.";
}
if($subject="Recruitment")
{
$to="email1";
}
if($subject="Notification")
{
$to="email2k";
}
if($subject="Enquiry")
{
$to="email3";
}
//Sending the email if nothing is wrong

if(!$errmessage)
{
header("location:send.php?to=".$to."&subject=".$subject."&email=".$email."&message=".$message."");
}else{
echo $errmessage;
}
}
?>
</body>
</html>
If anyone can help it would be greatly appriciated

Thanks,

blink359

This is the first time Im trying to use REGEXP, but cant get it working. It gives no error, just nothing..Anyone got idea why, please? Thanks

<?php
                  include ('connectToDatabase.php');
                  
                  $getSearch = $_REQUEST['getSearch'];
                  
                  $keywordSearchQuery = "SELECT shoeName, shoeSize, colour, price, gender, description WHERE
                  shoeName REGEXP '.*($getSearch).*' ||
                  shoeSize REGEXP '.*($getSearch).*' ||
                  colour REGEXP '.*($getSearch).*' ||
                  price REGEXP '.*($getSearch).*' ||
                  gender REGEXP '.*($getSearch).*' ||
                  description REGEXP '.*($getSearch).*"
                  ;
                  
                  $keywordSearchQueryResult = mysql_query($keywordSearchQuery);
                  
                  echo "$keywordSearchQueryResult";
               ?>

I'm trying to do a string match of a "what is my browser" return   I counted the indexes, there are 30   I have this code, I tested four different browsers, Internet Explorer, Chrome, Chromium, Firefox   Only chromium works, why? I counted the indexes for both Firefox and Chromium output, they are identical unless I miscounted   I don't have internet explorer or chrome, I had a friend test pull up the link that has this code

<?php
$browsee = get_browser(null,true);
$array = (array_slice($browsee,5,-24));

if(in_array("Firefox",$array)){
echo "your browser is firefox";
}else if(in_array("Chromium",$array)){
echo "your browser is chromium";
}else if(in_array("Chrome",$array)){
echo "your browser is chrome";
}else if(in_array("Explorer",$array)){
echo "your browser is Internet Explorer";
}else{
echo "your browser was not detected";
}
echo '<br>';
echo '<br>';
print_r($browsee);
?>

These are screenshots of the two browsers I use (I'm a Linux user)      chromium.png   125.92KB   0 downloads    firefox.png   137.44KB   0 downloads

Why is my code below not working properly? I've tried it with == instead of = and it still doesn't work. I've verified using echo statements that $row['name'] = $_POST['name'] and $row['password'] = $_POST['password'] for one of the people in my database, but it still gives the message "Login or password wrong!"

Thanks a lot for any help, here is the relevant part of my code (counterInt is defined to be 0 further up):

while($row = mysql_fetch_array( $result )) {
   


   if($row['name'] = $_POST['name'] &

$row['password'] = $_POST['password']) {
   $counterInt++;
   session_start();
   $_SESSION['name']=$row['name'];

}

   
}



if(counterInt == 1) {
   header( 'Location:

http://simbazeviangame.99k.org/game.php' );
}

if(counterInt == 0) {
   echo "Login or password wrong!";
}

Okay, the following php form is "somewhat" working. .I am not receiving all of the variables to my inbox.    This is the current form that i'm working on.   http://www.rodriguez...cr/schedule.php   The following fields are the ones are not passing through.   The Drop Down Menu: am, pm, the all day   Video   Case Option:   Additional Requests:    Firm Physical Address:    Fax No:    Here is the code

 <?php  
             
            function displayRequired($fieldName) { 
                echo " \".$fieldName\"is required.<br />n"; 
            } 
             
            function validateInput($data, $fieldName){ 
                global $errorCount; 
                if (empty($data)){ 
                    displayRequired($fieldName); 
                    ++$errorCount; 
                    $retval = ""; 
                } else { 
                    $retval = trim($data); 
                    $retval = stripslashes($retval); 
                } 
                return ($retval); 
            } 
             
            $Deposition = validateInput(safe($_POST['deposition']), "Deposition");
			$Time = validateInput(safe($_POST['time']), "Time");
			$Delivery = validateInput(safe($_POST['delivery']), "Delivery");
			$Witness = validateInput(safe($_POST['witness']), "Witness");
			$Location = validateInput(safe($_POST['location']), "Location");
			$Attorney = validateInput(safe($_POST['attorney']), "Attorney");
			$Name = validateInput(safe($_POST['name']), "First Name"); 
			$Firm = validateInput(safe($_POST['firm']), "Firm Name"); 
			$Phone = validateInput(safe($_POST['phone']), "Phone");
            $Email = validateInput(safe($_POST['email']), "Email"); 
           
			
            
             
             
            if ($errorCount>0){ 
                echo "Please re-enter the information below.<br />\n"; 
                redisplayForm($Deposition, $Time , $Ampm, $Timeday, $Delivery, $Video, $Co1, $Co2, $Witness, $Location, $Additional, $Attorney, $Name, $Firm, $Address, $Phone, $Fax, $Email); 
            } 
            else 
             
            {     
                $To = "service@rodriguezstudios.com"; 
                $Subject = "The test"; 
                $From = "Schedule a Deposition - Professional Court Reporters"; 
             
				 
				 $Message .= "Deposition Date:  " . $Deposition . "\n";
				 $Message .= "Time: " . $Time . $Ampm. $Timeday . "\n\n";
				 $Message .= "Transcript Delivery: " . $Delivery . "\n\n\n";
				 $Message .= "Video:  " . $Video . "\n\n\n\n";
				 $Message .= "Case Option: " . $Co1. "vs: " . $Co2 . "\n\n\n\n\n";
				 $Message .= "Witness: " . $Witness . "\n\n\n\n\n\n";
				 $Message .= "Location:  " . $Location . "\n\n\n\n\n\n\n";
				 $Message .= "Additional Requests: " . $Additional. "\n\n\n\n\n\n\n\n";
				 $Message .= "Attorney Name: " . $Attorney . "\n\n\n\n\n\n\n\n\n";
				 $Message .= "Your Name:  " . $Name . "\n\n\n\n\n\n\n\n\n\n";
				 $Message .= "Firm Name: " . $Firm. "\n\n\n\n\n\n\n\n\n\n\n";
				 $Message .= "Firm Physical Address: " . $Address . "\n\n\n\n\n\n\n\n\n\n\n\n";
				 $Message .= "Phone No:  " . $Phone . "\n\n\n\n\n\n\n\n\n\n\n\n\n";
				 $Message .= "Fax No: " . $Fax. "\n\n\n\n\n\n\n\n\n\n\n\n\n\n";
				 $Message .= "Email: " . $Email . "\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n";
				 
                $Headers = "From: ". $From . "<" . $To. ">\r\n";   
                $Headers .= "Reply-To: " . $Email . "\r\n";  
                $Headers .= "Return-path: ". $Email; 
                $result = mail($To, $Subject, $Message, $Headers); 
                if ($result) 
                    $resultMsg = "You message was sucessfully sent."; 
                    else 
                    $resultMsg = "There was a problem sending your message."; 
				
				/*insert anti spam fragement here */
				
             ?>
       <p style="line-height:200%; text-align:center; font-family:Verdana, Geneva, sans-serif; color:#000000">Your deposition has been scheduled<?php 
                        if(!empty($fieldName)) { 
                            echo " , {$fieldName}. {$resultMsg}"; 
                        } 
                         
                    echo "</p>"; 
                } 
                ?> 
     
            
         <?php 
               function redisplayForm($Deposition, $Time , $Ampm, $Timeday, $Delivery, $Video, $Co1, $Co2, $Witness, $Location, $Additional, $Attorney, $Name, $Firm, $Address, $Phone, $Fax, $Email){ 
             
            ?> 
            
            
            
             <form action="" method="POST">
     <fieldset class="first">
            <fieldset class="first">
    <p>
      <label class="labelone"for="deposition">*Deposition Date:</label>
      <input type="text" id="datepicker" name="deposition" value="<?php echo $Deposition; ?>" />
    </p>
    <p>
      <label for="*Time:" name="time">*Time: </label>
      <input type="text" name="time" value="<?php echo $Time; ?>">
      <select name="ampm" id="Ampm">
        <option value="am">A.M.</option>
        <option value="pm">P.M.</option>
      </select>
      <select name="timeday" id="Timeday">
        <option value="all">All Day</option>
        <option value="half">Half Day</option>
        <option value="hours">1-2 hrs</option>
      </select>
    </p>
    <p>
      <label for="*Transcript Delivery:" name="transcript"/>
      *Transcript Delivery:</label>
      <select>
        <option value="regular">Regular Delivery (10 day)</option>
        <option value="same">Same Day</option>
        <option value="1day">1 Day</option>
        <option value="2day">2 Day</option>
        <option value="3day">3 Day</option>
        <option value="4day">4 Day</option>
        <option value="5day">5 Day</option>
      </select>
    </p>
    <p>
      <label for="*Video" name="video">*Video:</label>
        <select name="video" id="video">
          <option value="yes">Yes</option>
          <option value="no">No</option>
        </select>
      </label>
    </p>
    <p>
      <label for ="caseoption">Case Option:</label>
      <input type="text" name="co1" value="<?php echo $Co1; ?>"/>
      vs.
      <input type="text" name="co2" value="<?php echo $Co2; ?>" />
    </p>
    <p>
      <label for ="witness">*Witness:</label>
      <input type="text" name="witness" value="<?php echo $Witness; ?>" />
    </p>
  </fieldset>
  <fieldset>
    <legend>LOCATION OF DEPOSITION, TELEPHONE NUMBER, AND NAME OF CONTACT PERSON:</legend>
    <p>
      <label for="location">*Location:</label>
      <textarea name="location" id="Location" value="<?php echo $Location; ?>"></textarea>
    </p>
    <p>
      <label for="additional">Addtional Requests (i.e. Realtime):</label>
      <input type="text" name="additional" value="<?php echo $Additional; ?>" />
    </p>
    <p>
      <label for ="attorney">*Attorney Name:</label>
      <input type="text" name="attorney" value="<?php echo $Attorney; ?>" />
    <p>
      <label for ="name">*Your Name:</label>
      <input type="text" name="name" value="<?php echo $Name; ?>" />
    </p>
    <label for ="firm">*Firm Name:</label>
    <input type="text" name="firm" value="<?php echo $Firm; ?>" />
    </p>
    <p>
      <label for ="firmaddress">Firm's Physical Address:</label>
      <input type="text" name="address" value="<?php echo $Address; ?>" />
    </p>
    <p>
      <label for ="phone">*Phone No:</label>
      <input type="text" name="phone" value="<?php echo $Phone; ?>"/>
    </p>
    <p>
      <label for ="fax">Fax No:</label>
      <input type="text" name="fax" value="<?php echo $Fax; ?>"/>
    </p>
    <p>
      <label for ="email">*Email:</label>
      <input type="text" name="email" value="<?php echo $Email; ?>" />
    </p>
  </fieldset>
  <fieldset>
    <input class="btn" name="submit" type="submit" value="Send Email"/>
    <input class="btn" name="reset" type="reset" value="Clear Form" />
  </fieldset>   
    </form>
     
		<?php 
            } 
            ?>


<?php 
function safe($string) 
	{ 
		$pattern = "/\r|\n|\%0a|\%0d|Content\-Type:|bcc:|to:|cc:/i"; 
		return preg_replace($pattern, '', $string); 
	}
?>

The extra pair of eyes would be greatly appreciated! 

Hi everyone,

my contact us form and script isn't working how it should.

On send the data is not sent to the db, a () is the ONLY thing shown in the browser too, can somebody help make this work?

Heres the form:

Code: [Select]
<form method="get" action="contact-send.php">
Name:<br />
<input type="text" name="name" id="name" size="30" /><br />
Email:<br />
<input type="email" name="email" id="email" size="30" /><br />
Your Question:<br />
<textarea name="question" id="question" rows="10" cols="50"></textarea><br />
<input type="submit" name="submit" value="send" />
</form

And the script to process:

Code: [Select]
<?PHP
 session_start();
 include ('php only scripts/db.php');


if ($db_found) {

$SQL = "INSERT INTO 'contact_us' (name, email, question)
VALUES ('" .$name. "', '" .$email. "', '" .$question. "')";
$result = mysql_query($query) or die(mysql_error());



header( 'Location: http://www.removalspace.com/contactconf.php' );


}
?>



Iv'e messed with it and had database NOT found before but since then, messed some more and before i go in circles i need some help :|

Thanks in advance for any help!

Here's the code with the function that won't work!

Code: [Select]
$itemsRaw = explode(" ", $player['inventory']);
foreach ($itemsRaw as $inv){
$contents = explode("-", $inv);
if(strlen($contents[0]) > 0 && strlen($contents[1]) > 0 && $contents[1] > 0)
echo getItemName($contents[0]) . " (" . number_format($contents[1]) . ")<br />";
}
Here's my function:

Code: [Select]
function getItemName($id_raw){
$id = $id_raw - 1;
$q = $db->query("SELECT * FROM items WHERE id = $id") or die(mysql_error());
$f = $db->fetch_assoc($q);
return $f['name'];
}
It stops the page when it gets to that point and won't load anything else and the function doesn't even work with it :/ What's wrong with it? If anything..

Hi, I'm having problems with a PHP mail handler and everything seems to be working fine except I get slashes in the message body from the form. If my input is "Please don't delete this" I get "Please don/'t delete this" in the message body, however it is striping the other tags. I'm not sure what is wrong and was hoping for a bit of help to figure this out.

Here is the code:
Code: [Select]
<?php
$owner_email = $_POST["owner_email"];
$headers = 'From:' . $_POST["email"];
$subject = 'Website contact inquiry from ' . $_POST["name"];
$messageBody = "";

$messageBody .= '<p>------------------ Contact Details ------------------' . '</p>' . "\n";
$messageBody .= '<p>Name: ' . $_POST["name"] . '</p>' . "\n";
$messageBody .= '<p>Email Address: ' . $_POST['email'] . '</p>' . "\n";
$messageBody .= '<p>Phone Number: ' . $_POST['phone'] . '</p>' . "\n";
$messageBody .= '<p>----------------------------------------------------------' . '</p>' . "\n";
$messageBody .= '<br>' . "\n";
$messageBody .= '<p>' . $_POST['message'] . '</p>' . "\n";

if($_POST["stripHTML"] == 'true'){
$messageBody = strip_tags($messageBody);
}

try{
if(!mail($owner_email, $subject, $messageBody, $headers)){
throw new Exception('mail failed');
}else{
echo 'mail sent';
}
}catch(Exception $e){
echo $e->getMessage() ."\n";
}
?>

hello..

In this script. if part is working properly. but elseif part not working i expect. it display only 1 category and its subjects.

Anybody can tell me what the mistake that I have did...

Here is my script

Code: [Select]
} elseif ( isset($_POST['category']) && ( sizeof( $_POST['category']) == 2 || sizeof( $_POST['category']) == 3 )) {

$q = 'SELECT * FROM category ORDER BY category_id';
$r = mysqli_query( $dbc, $q);

while($row = mysqli_fetch_array( $r, MYSQLI_ASSOC  )) {

foreach( $category as $value ) {

if ( $value == $row['category_id']) {

echo '<input type="radio" name="category[]" value="' . $row['category_id'] . '" class="radio" />';
echo '<label for="" class="radio">&nbsp;&nbsp;' . $row['category_name'] . ' <strong>: Mark this category as my "Main Category"</strong></label><br />';

$q = "SELECT category_subject.category_id, category_subject.subject_id, subjects
FROM category_subject
INNER JOIN category ON category_subject.category_id = category.category_id
INNER JOIN subject ON category_subject.subject_id = subject.subject_id
WHERE category_subject.category_id = {$row['category_id']}";

$r = mysqli_query( $dbc, $q);

$c = $i = 0;

echo '<table class="form_table" ><tr>';

while($info = mysqli_fetch_array( $r, MYSQLI_ASSOC  )){

// if remainder is zero after 2 iterations (for 2 columns) and when $c > 0, end row and start a new row: 
if( ($c % 2) == 0 && $c != 0){
echo "</tr><tr>";
}

echo '<td width="50%"><input type="checkbox" name="category[]"  value="' . $info['subject_id'] . '" />&nbsp;&nbsp;' . $info['subjects'] . '</td>';

$c++;

} // while..
// in case you need to fill a last empty cell:
if ( ( $i % 2 ) != 0 ){

// str_repeat() will be handy when you want more than 2 columns
  echo str_repeat( "<td>&nbsp;</td>", ( 2 - ( $i % 2 ) ) );
}
echo "</tr></table>";
}
}
}
}

$db->query( "UPDATE user_resources, user_buildings, user_units_nonbattle SET user_resources.uGold=user_resources.uGold+(user_buildings.uTownCenterLevel*(user_units_nonbattle.uMiner*10))" );

When the cron runs, it updates everyone the same regardless. Any idea what i'm doing wrong?

Hi everyone,

I am trying to implement an OAuth system in PHP. I've got the code working but the very first time a fresh, new browser window is opened, the code doesn't work. If I refresh the page and try again, then it works. I have a few suspicions as to where the problem might be but other than that I am stumped.

I have two classes: OAuthServer and OAuthClient. I create and store an object of the appropriate class in session variables. I know this is tricky but I am serializing and unserializing properly. To fetch responses from the Server, I am using curl. As curl uses a different session from the browser, I am doing a session_write_close before initializing curl and passing the appropriate parameters to curl.

But my code needed to further write session variables even after session_write_close was called and to achieve this, I am calling session_start(), once again, after the curl code is finished. I found that this works but PHP was throwing warnings saying that the header info had already been sent or something like that, but I have suppressed such warnings. I suspect the error has something to do with this but I'm not sure.

The part that doesn't work the very first time is that on the server-side, the session variable that is supposed to contain the OAuthServer object is NULL. But if I do a refresh of the page(flow: login_page->error_page), it works.

Can anyone tell me why I am encountering the above error and if I am doing things correctly or not. Any help would be greatly appreciated.

Thanks & Regards,
GarbageGigo