PHP - How To Avoid Using Globals In Function?

Well I heard that registering $GLOBALS is a bad practice in general since their values can be changed by anyone at anytime. However, the usage of $GLOBALS does simplify the script considerably at times when a certain column in a table needs to be retrieved repeatedly. A good example is user's money data stored in table prefix_users as shown below:

Code: [Select]
$result = mysql_query( "SELECT * FROM {$prefix}users WHERE uid = '$uid'");
$GLOBALS['usersettings'] = mysql_fetch_array($result);
$GLOBALS['money'] = $GLOBALS['usersettings']['money'];

If the above code is included in a function file, it will be possible to simply use $GLOBALS['money'] to retrieve user's money data without having to write lines of mysql commands everytime. So I was wondering, is there another way to retrieve database info from a certain column easily but not to register $GLOBALS? Just curious. 

This topic has been moved to Application Design.

http://www.phpfreaks.com/forums/index.php?topic=356029.0

I have been trying to better understand how php works on a more in depth level, and recently I have been tinkering with arrays.

Using print_r() I have been studying the $GLOBAL array, and I found something I can't seem to find an explanation for.

In my $GLOBALS array there are variables I have set in a configuration file, but never actually made into globals.

Take the following code, and its output for example.


echo "<pre>";
echo print_r($GLOBALS);
echo "</pre>";


The output:
Code: [Select]
Array
(
    [GLOBALS] => Array
 *RECURSION*
    [_POST] => Array
        (
        )

    [_GET] => Array
        (
        )

    [_COOKIE] => Array
        (
            [PHPSESSID] => fai4rtfgdt6o6iaihh62d0pa15
        )

    [_FILES] => Array
        (
        )

    [_SERVER] => Array
        (
            [HTTP_HOST] => DOMAIN
            [HTTP_USER_AGENT] => Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2.10) Gecko/20100914 Firefox/3.6.10
            [HTTP_ACCEPT] => text/html,application/xhtml+xml,application/xml;q=0.9,*/*;q=0.8
            [HTTP_ACCEPT_LANGUAGE] => en-us,en;q=0.5
            [HTTP_ACCEPT_ENCODING] => gzip,deflate
            [HTTP_ACCEPT_CHARSET] => ISO-8859-1,utf-8;q=0.7,*;q=0.7
            [HTTP_KEEP_ALIVE] => 115
            [HTTP_CONNECTION] => keep-alive
            [HTTP_REFERER] => http://DOMAIN/test.php
            [HTTP_COOKIE] => PHPSESSID=fai4rtfgdt6o6iaihh62d0pa15
            [HTTP_CACHE_CONTROL] => max-age=0
            [CONTENT_TYPE] => application/x-www-form-urlencoded
            [CONTENT_LENGTH] => 67
            [PATH] => /sbin:/usr/sbin:/bin:/usr/bin
            [SERVER_SIGNATURE] =>
            [SERVER_SOFTWARE] => Apache
            [SERVER_NAME] => DOMAIN
            [SERVER_ADDR] => IPADDRESS
            [SERVER_PORT] => 80
            [REMOTE_ADDR] => 198.65.168.24
            [DOCUMENT_ROOT] => /home/USER/www/DOMAIN
            [SERVER_ADMIN] => webmaster@DOMAIN
            [SCRIPT_FILENAME] => /home/USER/www/DOMAIN/test.php
            [REMOTE_PORT] => 43272
            [GATEWAY_INTERFACE] => CGI/1.1
            [SERVER_PROTOCOL] => HTTP/1.1
            [REQUEST_METHOD] => POST
            [QUERY_STRING] =>
            [REQUEST_URI] => /test.php
            [SCRIPT_NAME] => /test.php
            [PHP_SELF] => /test.php
            [REQUEST_TIME] => 1286050077
        )

    [date] => October 2, 2010
    [db_date] => 10/02/2010
    [error] => Array
        (
        )

)
1

The 3 items at the bottom.

Code: [Select]
    [date] => October 2, 2010
    [db_date] => 10/02/2010
    [error] => Array

Were set inside of a php config file. My question is, how did they end up in the $GLOBALS array?

Learning something new here so if anyone can tell me why I this wont return a value?

page1.php
Code: [Select]
<?php
require "page2.php";

getuserid();
echo $userID;
  
?>
page2.php
Code: [Select]
<?php
function getuserid() {
        $user =& JFactory::getUser();
        $userID = $user->id;
        global $userID;
    }
?>

Hi I'm currently experiencing problems with my super global outputs.   I'm using     $_SERVER['HTTP_X_MXIT_NICK'];

HI!

Can someone explain the variables $value and $key that are being produced  at the end of the output by the following code. It seems like the foreach loop is creating two extra variables.




<?php

$test_1 = "matt";
$test_2 = "kim";
$test_3 = "jessica";
$test_4 = "keri";


foreach ($GLOBALS as $key => $value) {
  echo $key . "- - -" . $value;
  echo "<br />";
}

?>


Output

GLOBALS- - -Array
_POST- - -Array
_GET- - -Array
_COOKIE- - -Array
_FILES- - -Array
test_1- - -matt
test_2- - -kim
test_3- - -jessica
test_4- - -keri
value- - -keri
key- - -value

Thanks!
steadythecourse

I am using a MVC framework and in my controller I have defined a class variable for configurations.  In my action I have a call to the configuration class to set the class variable to the current configurations.

Code: [Select]
public $configArray = array();

public function actionBuild($id)
{
$this->configArray=Config::model()->getConfigArray($id);

$this->buildStep1();
...
}




When I echo the configuration in the method it is 10 but when I echo in buildStep1 it is 11.  What is the proper way for configArray to be global and updated when I call getConfigArray for use in functions in the class? 

I just want to know how to create a global variable from within a function.

The reason I want to do this is I'm making mysql queries that may or may not have data in a function, if the data does indeed exist, I want to declare variables at that point.
My queries are grouped logically by year/month, and as a result I'm going to be appending data to existing variables if they exist so it makes more sense to just append it to what would be the global variable anyways instead of just passing large strings out of the function to just be appended anyways -- plus it prevents me from creating a bunch of pointless variables.

I intend additionally take the variables created inside the function and then store them in an encompassing global array (pre-defined outside of function) and at the end of the script do a foreach through it so I can iterate through the variables to grab my data knowing that there won't be pointless crap in there.

I'm trying to create global variables by using variable variables ($$whichever). The code giving me issues inside the function is just like this:
Code: [Select]
function SeekAndAppend ($vars, $being, $passed) {
   global $$whatever;         // Trying to define it here
   global $array;             // Calling predefined $array
   $array[] = "$$whatever";   // Passing just created global to the array for iteration later
}

When I iterate through the array the expected name of what would be the global variable name is there, but the global variable itself does not exist -- just at the function level.

If someone has a recommendation on a better way to do it, I'll listen, but please don't turn it into a lecture.   

EDIT: Grammar & Clarity

In the following code,

Code: [Select]
// Register Globals
if (ini_get('register_globals')) {
   ini_set('session.use_cookies', 'On');
   ini_set('session.use_trans_sid', 'Off');
     
   session_set_cookie_params(0, '/');
   session_start();
   
   $globals = array($_REQUEST, $_SESSION, $_SERVER, $_FILES);

   foreach ($globals as $global) {
      foreach(array_keys($global) as $key) {
         unset($$key);
      }
   }
}
the above destroys all globals if register_globals is on, as I understand it.

However, if it does destroy all globals, can a web form continue to work?

How do you allow form fields and other stuff to be used in a script even if you kill all the globals up front?

Many thanks

I have a sorting functionality, the code is he


<?php

$select_category = $_REQUEST['sort_category'];

$sort_date_var = $_REQUEST['sort_date'];

$sort_submit = $_POST['sortSubmit'];

// Connect to the database 
$dbc = mysqli_connect(DB_HOST, DB_USER, DB_PASSWORD, DB_NAME);

if (($select_category == 'All') || (!isset($select_category)) && (!isset($sort_date_var))) {

// Retrieve the chosen category from MySQL

$query

= "SELECT * FROM con";

$data = mysqli_query($dbc, $query);

//Loop through the array of data

while ($row = mysqli_fetch_array($data)) 

{

echo "<table class='knuffixTable'>";

// Display the score data

echo "<tr><td class='knuffix_name'>";

echo "<strong>" . htmlentities($row['name']) . "</strong><br /></td></tr>";

echo "<tr><td class='knuffix_contribution'><pre>" . $row['contribution'] . "</pre><br /></td></tr>";

echo "<tr><td class='knuffix_categoryDate'>" . $row['category'] . " | " . date('M d, Y', strtotime($row['contributed_date'])) . " </td></tr>";

echo "</table>";

}

mysqli_close($dbc);

} elseif (isset($select_category) && !isset($sort_date_var)) {

// Retrieve the chosen category from MySQL

$query = "SELECT * FROM con WHERE category = '$select_category'";

$data = mysqli_query($dbc, $query) or die (mysqli_error($dbc));

//Loop through the array of data

while ($row = mysqli_fetch_array($data)) 

{

echo "<table class='knuffixTable'>";

// Display the score data

echo "<tr><td class='knuffix_name'>";

echo "<strong>" . htmlentities($row['name']) . "</strong><br /></td></tr>";

echo "<tr><td class='knuffix_contribution'><pre>" . $row['contribution'] . "</pre><br /></td></tr>";

echo "<tr><td class='knuffix_categoryDate'>" . htmlentities($row['category']) . " | " . date('M d, Y', strtotime($row['contributed_date'])) . " </td></tr>";

echo "</table>";

}

mysqli_close($dbc);

} elseif (!isset($select_category) && isset($sort_date_var)) {

// Retrieve the chosen category from MySQL

$query = "SELECT * FROM con ORDER BY contributed_date $sort_date_var";

$data = mysqli_query($dbc, $query) or die (mysqli_error($dbc));

//Loop through the array of data

while ($row = mysqli_fetch_array($data)) 

{

echo "<table class='knuffixTable'>";

// Display the score data

echo "<tr><td class='knuffix_name'>";

echo "<strong>" . htmlentities($row['name']) . "</strong><br /></td></tr>";

echo "<tr><td class='knuffix_contribution'><pre>" . $row['contribution'] . "</pre><br /></td></tr>";

echo "<tr><td class='knuffix_categoryDate'>" . htmlentities($row['category']) . " | " . date('M d, Y', strtotime($row['contributed_date'])) . " </td></tr>";

echo "</table>";

}

mysqli_close($dbc);

} elseif (isset($select_category) && isset($sort_date_var)) {

// Retrieve the chosen category from MySQL

$query = "SELECT * FROM con WHERE category = '$select_category' ORDER BY contributed_date $sort_date_var";

$data = mysqli_query($dbc, $query) or die (mysqli_error($dbc));

//Loop through the array of data

while ($row = mysqli_fetch_array($data)) 

{

echo "<table class='knuffixTable'>";

// Display the score data

echo "<tr><td class='knuffix_name'>";

echo "<strong>" . htmlentities($row['name']) . "</strong><br /></td></tr>";

echo "<tr><td class='knuffix_contribution'><pre>" . $row['contribution'] . "</pre><br /></td></tr>";

echo "<tr><td class='knuffix_categoryDate'>" . htmlentities($row['category']) . " | " . date('M d, Y', strtotime($row['contributed_date'])) . " </td></tr>";

echo "</table>";

}

mysqli_close($dbc);

}

?>



With this code I'm able to:
- showcase every category by DEFAULT when someone comes to the page.
- sort only by category,
- sort only by date,
- sort by category AND date,

The problem is as you can see I have a lot of duplicate code, if I for example want to change the table that is being printed out, I have to change it on all of them. I'd like to ask how I could avoid this duplicate code. Can I for example just have the table ONE TIME at a separate place and then insert the REFERENCE _after_ the query in each if statement?

Like this:


if (($select_category == 'All') || (!isset($select_category)) && (!isset($sort_date_var))) {

// Retrieve the chosen category from MySQL

$query

= "SELECT * FROM con";

$data = mysqli_query($dbc, $query);

table_here();

} elseif (isset($select_category) && !isset($sort_date_var)) {

// Retrieve the chosen category from MySQL

$query = "SELECT * FROM con WHERE category = '$select_category'";

$data = mysqli_query($dbc, $query) or die (mysqli_error($dbc));

table_here();

}



I'm just coding since 2 month so I don't know how do it, maybe I can do it with functions?

I've tried doing it with functions, but I got an error since the function doesn't contain any query statement and only the table because it was trying to fetch.

it looked like this:



function table_here () {

//Loop through the array of data

while ($row = mysqli_fetch_array($data)) 

{

echo "<table class='knuffixTable'>";

// Display the score data

echo "<tr><td class='knuffix_name'>";

echo "<strong>" . htmlentities($row['name']) . "</strong><br /></td></tr>";

echo "<tr><td class='knuffix_contribution'><pre>" . $row['contribution'] . "</pre><br /></td></tr>";

echo "<tr><td class='knuffix_categoryDate'>" . $row['category'] . " | " . date('M d, Y', strtotime($row['contributed_date'])) . " </td></tr>";

echo "</table>";

}

mysqli_close($dbc);

}

Trying to make my code more secure.

This is what I currently have, which is not secure by any means:

Code: [Select]
$query1 = "SELECT COLUMN_NAME, DATA_TYPE, ORDINAL_POSITION, COLUMN_DEFAULT, CHARACTER_MAXIMUM_LENGTH, IS_NULLABLE
  FROM INFORMATION_SCHEMA.COLUMNS
  WHERE TABLE_NAME='$table'";
 
// Run PRO query

$qresult1 = sqlsrv_query($dbPRO, $query1);
if ($qresult1 === false) {
    exitWithSQLError('Retrieving schema failed.');
}
This is how I changed it,

Code: [Select]
$query1 = "SELECT COLUMN_NAME, DATA_TYPE, ORDINAL_POSITION, COLUMN_DEFAULT, CHARACTER_MAXIMUM_LENGTH, IS_NULLABLE
  FROM INFORMATION_SCHEMA.COLUMNS
  WHERE TABLE_NAME=?";
$params = array(1, $table);
 
// Run PRO query
$qresult1 = sqlsrv_query($dbPRO, $query1, $params);
if ($qresult1 === false) {
    exitWithSQLError('Retrieving schema failed.');
}
but I'm getting this error:

Code: [Select]
SQL-Status: 22018
Code: 245
Message: [Microsoft][SQL Server Native Client 10.0][SQL Server]Conversion failed when converting the nvarchar value 'sysrscols' to data type int
Please notice I am using sqlsrv_query function because my database engine is MS-SQL 2008. That's why I'm a bit confused. Most documentation online is pointed to MySQL.

exitWithSQLError is a customized function of mine, so please ignore. 

Any help or hints is appreciated,

Thanks,

Array ( [0] => Virender Sehwag|||http://abc.xyz.com/Virender-Sehwag [1] => Sachin Tendulkar|||http://abc.xyz.com/Sachin-Tendulkar )


foreach($array as $arr) {

                $topics=explode ('|||', $array);


echo '<li>'
                        .'<a rel="nofollow" target="_new" href="'.$topics[1].'"><span class="title">'.html_entity_decode($topics[0], ENT_NOQUOTES, "UTF-8").'</span></a>|</li>';



How to avoid '|' for the last element of any aaray. Also if array contains only 1 element '|' should not appear.

For eample,

In the browser it should display as "Virender Sehwag | Sachin Tendulkar".

If the array contains only 1 element then, In the browser it should display as Virender Sehwag

if array contains 3 elements,

Virender Sehwag | Sachin Tendulkar | someword

I'm just looking for some tips here. I am developing and selling an eccommerce shopping cart software package, and it has been received very well from the early adopters. There's just one small problem that prevents the software from being a truly out-of-the-box solution: the include path. Not all users have access to their php.ini file, and it's not always a php.ini file anyway. So this is something the installation is unable to set for the customer.

I'm using object-oriented PHP5 stuff, so I have a folder named "classes" with all the relevant stuff in there. I am unable to search for paths to the folder and hard-code those into source files (there are ajax calls and other fun stuff; hard to know the exact relation to the path).

I guess I could use set_include_path on the top of a bunch of files, but that is a small performance hit (and totally inelegant code). I could put the folder path in the database somewhere and query for it (and cache it so it's not a performance hit). None of this stuff seems good. The path seems like the best solution.

Unless you have better ideas....

Hello, I have a form that has a preview, before user can preview the form inputs he must login. If he is logedin, he can see preview and continue to editing form, but after user is finished with editing his values he is redirected to "preview" page for which he must be logged in. But the problem is that variables are "empty" after redirecting back to preview.

$_POST['email'] is received from login.php
$_SESSION['code'] is 5 digit code generated at start, it isn't important in this issue.

Here's the code:

preview.php
Code: [Select]
$id_user= 0;
$code = $_SESSION['code'];
    $email = $_POST['email'];
    $_SESSION['email_login'] = $email;
So now you can see that $email and $_SESSION['email_login'] are empty because when redirecting from "editing" to preview  $_POST['email'] can't be found...