PHP - Class Format Standards

Hello,

I am using a tutorial script for generating a basic bar graph. I have attempted to convert this script into an object-oriented script. However, upon attempting to define the graph, it is not successfully generated. Here is my code:

Code: [Select]
<?

class Graph
{
var $values;
var $image;
var $image_width = 450;
var $image_height = 300;
var $margin = 20;
var $bar_size = 20;
var $horizontal_lines = 20;

var $bar_colour;
var $border_colour;
var $background_colour;
var $line_colour;

function CreateGraph()
{
$this->image = imagecreate($this->image_width, $this->image_height);
}

function SetSize($width, $height)
{
$this->image_width = $width;
        $this->image_height = $height;
        }
       
        function SetMargin($size)
        {
        $this->margin = $size;
        }
       
        function SetBarSize($size)
        {
        $this->bar_size = $size;
        }
       
        function SetHorLines($size)
        {
        $this->horizontal_lines = $size;
        }
       
        function HexConvert($rgb)
        {
    return array(
        base_convert(substr($rgb, 0, 2), 16, 10),
        base_convert(substr($rgb, 2, 2), 16, 10),
        base_convert(substr($rgb, 4, 2), 16, 10),
    );
}
       
        function SetColours($bars, $background, $border, $line)
        {
        // This is hex based, similar to CSS, it is converted by HexConvert
        $bars = $this->HexConvert($bars);
        $background= $this->HexConvert($background);
        $border= $this->HexConvert($border);
        $line = $this->HexConvert($line);
       
        $this->bar_colour = imagecolorallocate($this->image, $bars[0], $bars[1], $bars[2]);
        $this->background_colour = imagecolorallocate($this->image, $background[0], $background[1], $background[2]);
        $this->border_colour = imagecolorallocate($this->image, $border[0], $border[1], $border[2]);
        $this->line_colour =imagecolorallocate($this->image, $line [0], $line [1], $line [2]);
        }
       
        function DrawBorders()
        {
        imagefilledrectangle($this->image,1,1,$this->image_width-2,$this->image_height-2,$this->border_colour);
imagefilledrectangle($this->image,$this->margin,$this->margin,$this->image_width-1-$this->margin,$this->image_height-1-$this->margin,$this->background_colour);
}

function DrawHorLines($horizontal_gap, $ratio)
{
for($i=1;$i<=$this->horizontal_lines;$i++)
{
$y = $this->image_height - $this->margin - $horizontal_gap * $i ;
imageline($this->image, $this->margin, $y, $this->image_width - $this->margin, $y, $this->line_colour);
$v = intval($horizontal_gap * $i / $ratio);
imagestring($this->image, 0, 5, $y-5, $v, $this->bar_colour);
}
}

function DrawBars($graph_height, $gap, $ratio)
{
for($i=0;$i< $total_bars; $i++)
{
list($key,$value)=each($this->values);
$x1= $this->margin + $gap + $i * ($gap+$this->bar_size) ;
$x2= $x1 + $this->bar_size;
$y1 = $this->margin +$graph_height- intval($value * $ratio) ;
$y2 = $this->image_height-$this->margin;
imagestring($this->image,0,$x1+3,$y1-10,$value,$this->bar_colour);
imagestring($this->image,0,$x1+3,$this->image_height-15,$key,$this->bar_colour);
imagefilledrectangle($this->image,$x1,$y1,$x2,$y2,$this->bar_colour);
}
}
       
        function DrawGraph()
        {
        $graph_width=$this->image_width - $this->margin * 2;
$graph_height=$this->image_height - $this->margin * 2;

$total_bars  = count($values);
$gap = ($graph_width- $total_bars * $this->bar_width ) / ($total_bars +1);

$this->DrawBorders();

$max_value=max($values);
$ratio = $graph_height / $max_value;

$horizontal_gap = $graph_height / $horizontal_lines;

$this->DrawHorLines($horizontal_gap, $ratio);

$this->DrawBars($graph_height, $gap, $ratio);
}

function OutputGraph()
{
header("Content-type:image/png");
imagepng($this->image);
}
}

?>
I expect this to be my misunderstanding of how object orientated codes work. I'm also open to any suggestions for improvement.

Edit: Here is the script where I use the class.
Code: [Select]
<?
include "bargraph.class.php";

$graph = new Graph;
$graph->SetSize(450, 300);
$graph->CreateGraph();
$graph->SetMargin(20);
$graph->SetBarSize(20);
$graph->SetHorLines(20);
$graph->SetColours("FFFFFF", "C0C0C0", "000000", "000000");
$graph->DrawGraph();
$graph->OutputGraph();
?>

OK, Here is the code

$sql = "SELECT
TrialListing.listingID AS Trial, TrialClass.classID AS Class, place.place_name AS Place,
CONCAT_WS(
' ',
pedigree.pretitle,
pedigree.`Name`) AS Hound,
CONCAT_WS(
' ',
ped2.pretitle,
ped2. NAME
)AS Sire,
CONCAT_WS(
' ',
ped3.pretitle,
ped3. NAME
)AS Dam,
pedigree.Breeder,
pedigree.`Owner`,
CASE
WHEN placement.place_id < 5 THEN
TRUNCATE(TrialClass.number_of_entrants / placement.place_id,2)
WHEN placement.place_id  = 5 THEN
''
ELSE
0
END

AS Score
FROM
TrialListing
Left Join TrialClass ON TrialListing.listingID = TrialClass.listingID

JOIN placement ON placement.event_id = TrialClass.trialClassID
JOIN pedigree ON pedigree.PedigreeId = placement.hound_id
LEFT OUTER JOIN pedigree AS ped2 ON pedigree.SireId = ped2.PedigreeId
LEFT OUTER JOIN pedigree AS ped3 ON pedigree.DamId = ped3.PedigreeId
LEFT JOIN place ON place.place_id = placement.place_id

WHERE
TrialListing.listingID = 11
ORDER BY Class, FIELD(place.place_id, '1', '2', '3', '4', '0')


";      // Database Query  

$result = mysql_query("$sql");  // Database Query result

$num_rows = mysql_num_rows($result);





// Starts the table
echo "<table class=\"clubList\">\n
<tr>
<th>trialID</th>
<th>ClassID</th>
<th>Place</th>
<th>Hound</th>
<th>Sire</th>
<th>Dam</th>
<th>Score</th>

</tr>";

// Create the contents of the table.
for( $i = 0; $i < $row = mysql_fetch_array($result); $i++){




echo "<tr>\n"
        ."<td>".$row["Trial"]."</td>\n" 
        ."<td>".$row["Class"]."</td>\n" 
        ."<td>".$row["Place"]."</td>\n"  
        ."<td>".$row["Hound"]."</td>\n"  
        ."<td>".$row["Sire"]."</td>\n"                
        ."<td>".$row["Dam"]."</td>\n"
        ."<td>".$row["Score"]."</td>\n"  
        ."</tr>";}



echo "</TABLE>";


Here is the output, I added the TrialID & ClassID for informational purposes, they do not need to be displayed in the live table.

trialID ClassID Place Hound Sire Dam Score 11 1 1st Eaton Brook Tug Hill Tatonka Eaton Brook Hickety Hawk Eaton Brook Gunner's Beulah 43.00 11 1 2nd FC North Bend Igloo FC DFJ Murphy White IFC Brad-Ju's Bella Donna 21.50 11 1 3rd FC North Bend Igloo FC DFJ Murphy White IFC Brad-Ju's Bella Donna 14.33 11 1 4th Rail Road Spike VI Elwell's Mike Elwell's Hannah 10.75 11 1 NBQ FC Fish Creek Spike Fish Creek Bull II Fish Creek Susie [H849395] 11 2 1st Enman Hill Sweet Poppy FTCH Straight Arrow Lucky of Coos 32.00 11 2 2nd Fishflakes Penny At Harehaven FTCH Jill's Fair-Isle Spud FTCH Millbridge Brownie 16.00 11 2 3rd Line Elm Flakers IFC Flakers Rex IFC Line Elm Ginger 10.66 11 2 4th FTCH Fareast Mookie FTCH Mellowrun Sly FTCH Cape Breton Maude 8.00 11 2 NBQ FTCH Mellowrun Sly Mellowrun Skylighter FTCH Mellowrun Becka 11 3 1st Bojangle V Lee Otworth Half Acre's Cocoa Candy 23.00 11 3 2nd Gay Doll Gay Roll II Gay Idol 11.50 11 3 3rd Bruce's Blue Lady FC Kilsock's Blue Creek Bart Bishopville's Zippy 7.66 11 3 4th FC Pearson Creek Barbin FC Pearson Creek Barbarian FC B-Line Stubby 5.75 11 3 NBQ Sims Creek Cricket Ronnie Joe Sims Creek Tiny 11 4 1st FTCH Fareast Mookie FTCH Mellowrun Sly FTCH Cape Breton Maude 26.00 11 4 2nd FTCH Mellowrun Sly Mellowrun Skylighter FTCH Mellowrun Becka 13.00 11 4 3rd Fishflakes Penny At Harehaven FTCH Jill's Fair-Isle Spud FTCH Millbridge Brownie 8.66 11 4 4th Enman Hill Sweet Poppy FTCH Straight Arrow Lucky of Coos 6.50 11 4 NBQ Line Elm Flakers IFC Flakers Rex IFC Line Elm Ginger
Below is what I would like to generate. How do I word or nest the proper PHP code/loops to accomplish this?

ClassID

Place Hound Sire Dam Score 1st Eaton Brook Tug Hill Tatonka Eaton Brook Hickety Hawk Eaton Brook Gunner's Beulah 43.00 2nd FC North Bend Igloo FC DFJ Murphy White IFC Brad-Ju's Bella Donna 21.50 3rd FC North Bend Igloo FC DFJ Murphy White IFC Brad-Ju's Bella Donna 14.33 4th Rail Road Spike VI Elwell's Mike Elwell's Hannah 10.75 NBQ FC Fish Creek Spike Fish Creek Bull II Fish Creek Susie [H849395]

ClassID

Place Hound Sire Dam Score 1st Enman Hill Sweet Poppy FTCH Straight Arrow Lucky of Coos 32.00 2nd Fishflakes Penny At Harehaven FTCH Jill's Fair-Isle Spud FTCH Millbridge Brownie 16.00 3rd Line Elm Flakers IFC Flakers Rex IFC Line Elm Ginger 10.66 4th FTCH Fareast Mookie FTCH Mellowrun Sly FTCH Cape Breton Maude 8.00 NBQ FTCH Mellowrun Sly Mellowrun Skylighter FTCH Mellowrun Becka

ClassID

Place Hound Sire Dam Score 1st Bojangle V Lee Otworth Half Acre's Cocoa Candy 23.00 2nd Gay Doll Gay Roll II Gay Idol 11.50 3rd Bruce's Blue Lady FC Kilsock's Blue Creek Bart Bishopville's Zippy 7.66 4th FC Pearson Creek Barbin FC Pearson Creek Barbarian FC B-Line Stubby 5.75 NBQ Sims Creek Cricket Ronnie Joe Sims Creek Tiny

ClassID

Place Hound Sire Dam Score 1st FTCH Fareast Mookie FTCH Mellowrun Sly FTCH Cape Breton Maude 26.00 2nd FTCH Mellowrun Sly Mellowrun Skylighter FTCH Mellowrun Becka 13.00 3rd Fishflakes Penny At Harehaven FTCH Jill's Fair-Isle Spud FTCH Millbridge Brownie 8.66 4th Enman Hill Sweet Poppy FTCH Straight Arrow Lucky of Coos 6.50 NBQ Line Elm Flakers IFC Flakers Rex IFC Line Elm Ginger

Hello All, 
  Need an advise in finishing this task please. 
 

function convertTimeFormat($time12Hour) {
// Initialized required variable to an empty string.
		$time24Hour = ""; 

// Used explode() function to break the string into an array and stored its value in $Split variable. 
		$Split = explode(":",$time12Hour); // print_r(explode (":", $time12Hour)); => Array ( [0] => 09 [1] => 50 [2] => 08AM )

// Retrieved only "hour" from the array and stored in $Hour variable. 
		$Hour = $Split[0];   

    $Split[2] = substr($Split[2],0,2);

// Used stripos() function to find the position of the first occurrence of a string inside another string.	
		if($Hour == '12' && strpos($time12Hour,"AM")!== FALSE) {
			// Code here 
		} elseif(strpos($time12Hour,"PM")!== FALSE && $Hour != "12") {
			// code here
		}
		return  $time24Hour;
	}
	$time12Hour = "09:50:08AM";
	$result = convertTimeFormat($time12Hour);
	print_r($result); 

/*
Input : "09:50:08AM";
Output : "21:50:08PM";
*/

 

I'm making forums at the minute and everything is going well, apart from these stupid errors that I can't seem to get rid of for the life of me. It is frustrating me so much! I've looked through the code and cannot find anything wrong.   The first error appears at the top of my forums whenever you're logged in about strict standards. This is what the error says:     Line 6 of viewthread.php is - require('../structure/forum.thread.php');;   Here is the code of the thread::canView() and thread::canView() that is located within my structure.   thread::canView function below

    public function canView($id, $username, $powerLevel)

     {

I am working in wordpress. I am using a switch statement to call a php page. It looks like this

Code: [Select]
$slider_type = $options['type'];
switch($slider_type) {
case "Half Page Slider" :
include('nivo-default.php');
break;
case "Full Page Slider" :
include('nivo-fullpage.php');
break;
default:
include('nivo-fullpage.php');
}


The code works fine. My question is this. I want to use the exact same code to call the css file that runs each page. So instead of inlcuding a php page, I would replace that with the css call. So is it a bad idea to use the variables in the head section and then again in the page a little further down? or should I change the names? What is the best coding practice here?