PHP - Moved: Regular Old Functions Vs. Classes (methods)?

This topic has been moved to Application Design.

http://www.phpfreaks.com/forums/index.php?topic=314249.0

So, I'm starting a new project and thought I would try a new approach at loading files and classes to process output.  I think my logic is correct, but for some reason I'm getting a blank page.  Basically instead of having seperate pages to output different functions and such, I store everything in one page.  It's the same deal as the switch case approach, but it uses a foreach loop to cycle through the actions, classes, and functions which are stored in an array.

Here's my index.php file:
Code: [Select]
<?php

require('config.php');
include('languages/english.php');
include('classes/Template.php');

$template = new Template;

$viewPages = array( 
'category' => array('classfile' => 'Category.php', 'classname' => 'category', 'functions' => array('create', 'delete', 'modify', 'merge')),
'questions' => array('classfile' => 'Question.php', 'classname' => 'Question', 'functions' => array('create', 'delete', 'modify', 'votegood', 'votebad'))
);


$currentPage = $_REQUEST['action'];

foreach($viewPages as $action => $settings){

if($currentPage == $action){
require(INCLUDE_ROOT.'/classes/'.$settings['classfile']);

$class = new $settings['classname'];
$function = $_REQUEST['do'];
$class->$function();

$template->loadTemplate($settings['classname']->viewFile, $vars = array());
if($template->message == FALSE){
die($template->message);
}

}

}

?>
Here's the Template class file:
Code: [Select]
<?php

class Template {

var $file;
var $vars;
var $message;

function loadTemplate($file, $vars){

if(empty($file) || empty($vars)){
$this->message = LANG_ERR_7;
} else if($file = file_get_contents(INCLUDE_ROOT.'/'.$file)){
$this->message = LANG_ERR_7;
} else {
foreach($vars as $key => $val)
$file = str_replace('{'.$key.'}', $val, $file);
}

$this->message = FALSE;
return $file;

}

}

?>
I tried visiting the category action(index.php?action=category;do=create).  This is the classfile for that
Code: [Select]
<?php

class category {

var $id;
var $title;
var $description;
var $uri;
var $message = array();
var $vars = array();
var $viewFile = '';

function create(){

if($_POST['submit']){

//Review the user input and make ure everything is ok
$messages = array();
if($this->title == FALSE){
$messages['title'] = LANG_ERR_1;
} else if(strlen($this->title) > 30 || strlen($this->title < 5)){
$messages['title'] = LANG_ERR_2;
} else if($this->description == FALSE){
$messages['description'] = LANG_ERR_3;
} else if(strlen($this->description) > 400 || strlen($this->description) < 10){
$messages['description'] = LANG_ERR_4;
} else {
$messages = FALSE;
}

if($messages != FALSE){
$this->messages = $messages;
$this->viewFile = INCLUDE_ROOT.'/template/index_body.tpl';
} else {
$this->title = htmlentities($this->title);
$this->title = stripslashes($this->title);
$this->title = htmlspecialchars($this->title);

$this->description = htmlentities($this->description);
$this->description = htmlspecialchars($this->description);
$this->description = nl2br($this->description);

$query = "
INSERT INTO categories
(c_title, c_desc)
VALUES('".$this->title."', '".$this->desscription."')";

if(mysql_query($query)){
$this->message['succes'] = LANG_ERR_5;
} else {
$this->message['fail'] = LANG_ERR_6;
}

$this->viewFile = INCLUDE_ROOT.'/template/message_body.tpl';

}

} else {

$this->viewFile = INCLUDE_ROOT.'/template/create_category.tpl';

}

}

}

?>
Now if you look at the Category class, the template file it sets is the "category_create.tpl" file, which I haven't created yet.  I'm expecting there to be an error associated with the template class and the file_get_contents function that calls the file, but like I said, I'm just getting a blank page.

I've never tried this approach before, so I have no idea what's causing this.  Any help would be greatly appreciated.

hello,

i have been following the php.net oop manual but im having a little trouble understanding something.

on this page in the manual: http://uk3.php.net/manual/en/language.oop5.basic.php
it shows this code and if i seperate it out i cant get it to echo the results i want. what am i doing wrong?
i have added a little extra code .

class Bear
Code: [Select]
class Bear {
    // define properties
    public $name;
    public $weight;
    public $age;
    public $sex;
    public $colour;

    // constructor
    public function __construct() {
       
                $this->name = "winny the poo";
$this->weight = 100;
$this->age = 0;
$this->sex = "male";
$this->colour = "brown";
    }

    // define methods

    public function eat($units) {
        echo $this->name." is eating ".$units." units of food... <br/>";
        $this->weight += $units;
    }

    public function run() {
        echo $this->name." is running... <br/>";
    }

    public function kill() {
        echo $this->name." is killing prey... <br/>";
    }

    public function sleep() {
        echo $this->name." is sleeping... <br/>";
    }


}

class PolarBear
Code: [Select]
class PolarBear extends Bear {

    // constructor
    public function __construct() {
        parent::__construct();
        $this->colour = "white";
        $this->weight = 600;
    }

function polarbar()
    {
        // Note: the next line will issue a warning if E_STRICT is enabled.
        Bear::bear();
    }

    // define methods
    public function swim() {
        echo $this->name." is swimming... ";
    }
}


now if i try to get back the results i have trouble.

this is fine
Code: [Select]
$bear = new Bear();

$bear->eat($units);
$bear->eat();
$bear->run();
$bear->kill();
$bear->sleep();

that echos back
Quote

//THE BEAR
winny the poo is eating 5 units of food...
winny the poo is eating units of food...
winny the poo is running...
winny the poo is killing prey...
winny the poo is sleeping...

//THE POLAR BEAR
winny the poo is eating 5 units of food...
winny the poo is eating units of food...
winny the poo is running...
winny the poo is killing prey...
winny the poo is sleeping...
winny the poo is swimming...



THAT FINE but how come i can echo out each of the properties?
why do these ways not work?

Code: [Select]
Bear::eat($units);
Bear::eat();
Bear::run();
Bear::kill();
Bear::sleep();

or

Code: [Select]
$bear = new Bear();
$bear->$name;
$bear->$weight;
$bear->$age;
$bear->$sex;
$bear->$colour;

or

Code: [Select]
echo Bear::eat($units);
echo Bear::eat();
echo Bear::run();
echo Bear::kill();
echo Bear::sleep();

or

Code: [Select]
$bear = new Bear();
echo $bear->$name;
echo $bear->$weight;
echo $bear->$age;
echo $bear->$sex;
echo $bear->$colour;

and the same goes for PolarBear

if i try and get back any of the properties on a page i get nothing ???

i even tried putting it in a loop and that didnt work
Code: [Select]
$bear = new Bear();

foreach ($bear as $bears){
echo $bears->$name;
echo $bears->$weight;
echo $bears->$age;
echo $bears->$sex;
echo $bears->$colour;
}

whats wrong.
why cant i get any results from these ?
thanks

Hi, I am trying to get my head around classes, interfaces and methods for different animals

 

this is what I have so far:

<?php 
interface animal {
  function walk();
  function fly();
  function swim();
}
class monkey implements animal{
  const interface1 = "I am from test class";

  function noise() {
    echo "ooh ooh ah ah!";
  } 

  function walk() { 
    echo "monkey is walking";
  }
  function fly() { 
    echo "monkey is Flying";
  }
  function swim() { 
    echo "monkey is Swimming";
  }
  public function display() {
    echo monkey::interface1;
    echo PHP_EOL;
  }

}

class bear implements animal{
  const interface1 = "I am from test class";

  function noise() {
    echo "Grrr!";
  } 

  function walk() { 
    echo "Bear is walking";
  }
  function fly() { 
    echo "Bear is Flying";
  }
  function swim() { 
    echo "Bear is Swimming";
  }
  public function display() {
    echo bear::interface1;
    echo PHP_EOL;
  }

}
$Obj = new monkey();
$Obj->display();
$Obj1 = new bear();
$Obj1->display();
?>

I'm a bit stumped as  animal interface not calling all functions?! please help

Currently I'm learning about objects and classes. I followed a tutorial about making a DB abstraction class (a mySQL select) and then I tried to adapt it and wrote a method to Insert a new name. However, then I had a problem: what if the value already exists in the DB?

So I thought maybe I could write a method for that too, and hopefully this would be re-usable for other purposes.

So I'm posting the code here and I hope someone could take a look at it, since I do not want to start any bad practices and start a habit of writing sloppy code. Would the code below be considered 'good code'?



<?php
// This file is called database.php

class database {

public $mysql;
function __construct() {
$this->mysql = new mysqli('localhost', 'root', 'password', 'db') or trigger_error('Database connection failed');
}

/* Function to check whether value: $queriedName already exists inside table: $table and column: $column  */
function findMatch($table, $column, $queriedName) {
if ($result = $this->mysql->query("SELECT * FROM $table WHERE $column='$queriedName'")) 
{
if (!$numberOfRows=$result->num_rows) {
return false;
}

else {
return true;
}
}
}

/* Function to select all records from table: $table */
function selectAll($table) {
if ($result = $this->mysql->query("SELECT * FROM $table") ) {
while($row=$result->fetch_object()) {
$nameFields[]=$row->names;
}
return $nameFields;
}
}

/* Function to insert a name: $newName into table: $table. Uses method finMatch to avoid doubles */
function insertName($table, $newName) {
if ($this->findMatch($table, 'names', $newName)) {
$result="Person already exists!";
return $result;
}

else {
$result = $this->mysql->query("INSERT INTO $table(names) VALUES ('$newName')");
return $result;
}

// 
}
}

?>

Main page:


// This file is called index.php
require('database.php');
$newName='Mary Jane';
$result=$myDb->insertname('mytable', $newName);
echo $result;