PHP - How To Supress/avoid Header Related Warning

I get an error stating that I cannot modify header information when I try to add a title to my login page.
Here's <?php
session_start();

require_once("includes/dbconn.php");

include("includes/htmlheader.php");

mysql_select_db(center);

$user = $_POST['username'];
$pass = $_POST['password'];

$sql = "select username, password from users";
$result = mysql_query($sql);
$row = mysql_fetch_array($result);

$isuser = $row['username'];
$ispass = $row['password'];

if(isset($_POST['submit'])){

if(($user==$isuser)&&($pass==$ispass)) {

$_SESSION['username'] = $user;

header("Location: home.php");
    }else{
    echo "Invalid Username or Password";
    }
}

   
?>


The htmlheader.php has the title string. Help is appreciated 

Hi All,

I just formatted my HD and had a WAMP setup.  I have not installed each component separately (newest versions).

When I type in a text box and press the submit button, I get:

Warning: Cannot modify header information - headers already sent by (output started at D:\Web\Apache\htdocs\projects\tms_new\functions\functions.js:304) in D:\Web\Apache\htdocs\projects\tms_new\apps\index.php on line 167

Line 304 in the functions.js file is:   </script>

Line 167 in index.php is:

 header('Location: index.php?lastname='.stripslashes($lastname));


It says I am sending header information before line 167, but there isn't any.  The .JS file only has JS code.

Can someone give me any suggestions?

Thanks everyone!!

I understand the warning, but I don't get the issue on my local server, only on my live server.
From what I can see in the outputted source is a space and also i'm assuming a newline, before the warning...

I've traced every route in my code, no output what-so-ever. I can't believe the hosts would insert such characters.
I've tried separate files within the root directory, an html and a php, neither output these characters.

Eventually I commented out the inclusion of modules one by one and found that the error should be in a specific one of these...

Now going through I can't find any 'echo' or 'print' statements.
Everything is within functions, and this error happens before anything is called, just included.
There are no erroneous spaces before or after php code tags.

What else would / could produce output? (and why no issue on local server?)


EDIT:

There is no use of 'output buffering' either...

<?php
header('Refresh: 5; URL=http://www.miraculousmedalapostolate.com');
exit();
?>

i dont know what to do with this!
i have tried using other hosting and the code was working fine... please help me, i have been stuck on this problem for 2 days now.

So last night I was changing the amount of posts I wanted on my Thesis Themed Wordpress blog. I went to click the Save button within wordpress and got this message on the next page.

"Warning: Cannot modify header information - headers already sent by (output started at /home/content/50/8403650/html/wp-content/themes/thesis_18/custom/custom_functions.php:2) in /home/content/50/8403650/html/wp-includes/pluggable.php on line 934"

Now my nav menu doesn't show up and when I go to archives, it gives me the same warning. Can someone please help me with this? Any help would be appreciated.

I've added both custom_functions.php and pluggable.php as an attachment, I don't think it has anything to do with pluggable but added just in case.

Thanks for your help.
Briannyc

[attachment deleted by admin]

Hello,

Im having a little trouble with this coding I need it to goto this page after an if statement but get this dreaded error

Warning: Cannot modify header information - headers already sent by (output started at /home/fightwa1/public_html/fightlivecommentaryrd1.php:15) in /home/fightwa1/public_html/fightlivecommentaryrd1.php on line 57


there are no whitespaces before or after the start and endin <?php, as previously read about.

Really struggling with this problem, if anyone can help will be much appreciated.

I am getting this error:
Warning: Cannot modify header information - headers already sent by
on my pvp.php script, this is it:
<?PHP
include('top.php');
if(!isset($_SESSION['UsersID']))
{
echo "You need to be logged into view this page.";
include('bottom.php');
exit;
}
if(isset($_POST['battleplayer']))
{
$battleplayer=$_POST['battleplayer'];
if($_POST['battlepick']=="username")
{
$Battling_Result=mysql_query("SELECT * FROM users WHERE Username='$battleplayer'");
$Battling_Rows=mysql_fetch_array($Battling_Result);
$battleplayer=$Battling_Rows['ID'];
}
elseif($_POST['battlepick']=="id")
{
$Battling_Result=mysql_query("SELECT * FROM users WHERE ID='$battleplayer'");
$Battling_Rows=mysql_fetch_array($Battling_Result);
}
if(!empty($Battling_Rows))
{
$Enemy_ID=$Battling_Rows['ID'];
$Enemy_Name=$Battling_Rows['Username'];
$Enemy_Level=$Battling_Rows['Level'];
$Enemy_HP=$Battling_Rows['HP'];
$Enemy_MHP=$Battling_Rows['Max_HP'];
$Enemy_Energy=$Battling_Rows['Energy'];
$Enemy_MEnergy=$Battling_Rows['Max_Energy'];
$Battling_Result2=mysql_query("SELECT * FROM items WHERE Owner='$battleplayer' AND Slot='1'");
$Battling_Rows2=mysql_fetch_array($Battling_Result2);
$Battling_Result3=mysql_query("SELECT * FROM items WHERE Owner='$battleplayer' AND Slot='2'");
$Battling_Rows3=mysql_fetch_array($Battling_Result3);
$Battling_Result4=mysql_query("SELECT * FROM items WHERE Owner='$battleplayer' AND Slot='3'");
$Battling_Rows4=mysql_fetch_array($Battling_Result4);
$Battling_Result5=mysql_query("SELECT * FROM items WHERE Owner='$battleplayer' AND Slot='4'");
$Battling_Rows5=mysql_fetch_array($Battling_Result5);
$Battling_Result6=mysql_query("SELECT * FROM items WHERE Owner='$battleplayer' AND Slot='5'");
$Battling_Rows6=mysql_fetch_array($Battling_Result6);
$Enemy_Attack1=$Battling_Rows2['Name'];
$Enemy_Attack2=$Battling_Rows3['Name'];
$Enemy_Attack3=$Battling_Rows4['Name'];
$Enemy_Attack4=$Battling_Rows5['Name'];
$Enemy_Attack5=$Battling_Rows6['Name'];
$Enemy_Power=$Battling_Rows['Power'];
$Enemy_Defense=$Battling_Rows['Defense'];
$Enemy_Magic=$Battling_Rows['Magic'];
$Enemy_Race=$Battling_Rows['Race'];
$Enemy_Class=$Battling_Rows['Class'];
$Battle_Start="No";
$User_ID=$_SESSION['UsersID'];
mysql_query("DELETE from battle_info WHERE User_ID='$User_ID'");
mysql_query("INSERT into battle_info(Enemy_ID, Enemy_Name, Enemy_Level, Enemy_HP, Enemy_MHP, Enemy_Energy, Enemy_MEnergy, Enemy_Attack1, Enemy_Attack2, Enemy_Attack3, Enemy_Attack4, Enemy_Attack5, Enemy_Power, Enemy_Defense, Enemy_Magic, Enemy_Race, Enemy_Class, Battle_Start, User_ID) VALUES('$Enemy_ID', '$Enemy_Name', '$Enemy_Level', '$Enemy_HP', '$Enemy_MHP', '$Enemy_Energy', '$Enemy_MEnergy', '$Enemy_Attack1', '$Enemy_Attack2', '$Enemy_Attack3', '$Enemy_Attack4', '$Enemy_Attack5', '$Enemy_Power', '$Enemy_Defense', '$Enemy_Magic', '$Enemy_Race', '$Enemy_Class', '$Battle_Start', '$User_ID')") or die(mysql_error());
header('Location: battle.php');
}
else
{
echo "This user does not exist.<br />";
echo "Enter the Username/ID of the person you want to battle below:";
echo "<br /><form method='POST'><input type='text' name='battleplayer'><select name='battlepick'><option value='username'>Username</option><option value='id'>ID</option></select>";
echo "<br /><input type='submit' name='Submit' id='Submit' value='Submit' onclick='this.disabled=true; this.form.submit;'>";
echo "</form>";
}
}
else
{
echo "Enter the Username/ID of the person you want to battle below:";
echo "<br /><form method='POST'><input type='text' name='battleplayer'><select name='battlepick'><option value='username'>Username</option><option value='id'>ID</option></select>";
echo "<br /><input type='submit' name='Submit' id='Submit' value='Submit' onclick='this.disabled=true; this.form.submit;'>";
echo "</form>";
}
include('bottom.php');
?>
and this is my top.php script:
<?PHP
include('connect.php');
$ID = $_SESSION['UsersID'];
$ID = mysql_real_escape_string($ID);
if (!isset($_SESSION['UsersID']))
{
echo "
<!DOCTYPE HTML PUBLIC \"-//W3C//DTD HTML 4.01 Transitional//EN\"
\"http://www.w3.org/TR/html4/loose.dtd\">
<font face='verdana'>
<head>
<link rel='stylesheet' type='text/css' href='style.css'>
</style>
</head>
<title>Shadow of the Eternal - Text Based RPG</title>
<body>
<div id='banner'><a href='index.php'><img src='banner.png'></a></div>
<div id='quicklinks'>Test</div>
<div id='leftmenu'>
<ul>
<li>Main
<ul>
<li><a href='index.php'>Home</a></li>
<li><a href='login.php'>Login</a></li>
<li><a href='signup.php'>Sign Up</a></li>
</ul>
</li>
</ul></div>
<div id='content'>
</font>";
}
else
{
echo "
<!DOCTYPE HTML PUBLIC \"-//W3C//DTD HTML 4.01 Transitional//EN\"
\"http://www.w3.org/TR/html4/loose.dtd\">
<font face='verdana'>
<head>
<link rel='stylesheet' type='text/css' href='style.css'>
</style>
</head>
<title>Shadow of the Eternal - Text Based RPG</title>
<body>
<div id='banner'><a href='index.php'><img src='banner.png'></a></div>
<div id='quicklinks'>Test</div>
<div id='leftmenu'>
<ul>
<li>CryptoWare
<ul>
<li><a href='http://furiousflash.com'>Furious Flash</a></li>
<li><a href='http://crypto-ware.com'>CryptoWare</a></li>
</ul>
</li>
<li>Main
<ul>
<li><a href='index.php'>Home</a></li>
<li><a href='viewcomments.php'>News Comments</a></li>
<li><a href='logout.php'>Logout</a></li>
<li><a href='http://furiousflash.com/forum'>Forums</a></li>
</ul>
</li>
</ul></div>
<div id='content'>
</font>";
}
?>
And just in case this is my connect.php script:
<?PHP
mysql_connect('localhost','*****','*****');
mysql_select_db('*****');
session_start();
?>
Any idea why?

I am having a problem with my login page when I set cookies I get this error.

Quote

Warning: Cannot modify header information - headers already sent by (output started at /login.php:10) in /loginform.php on line 66

Warning: Cannot modify header information - headers already sent by (output started at /login.php:10) in /loginform.php on line 67

Warning: Cannot modify header information - headers already sent by (output started at /login.php:10) in /loginform.php on line 68

Warning: Cannot modify header information - headers already sent by (output started at /login.php:10) in loginform.php on line 72



I do have ob_start() at the beginning and ob_flush() and the end but i still get the error

<?phpinclude('config.php');ob_start();@session_start();if (!isset($_POST['login'])) {?><form method="post" action="<?php $_SERVER['PHP_SELF'] ?>"> <fieldset> <legend>Login</legend> <table> <tr> <td>Email </td> <td><input type="text" name="email" /></td> </tr> <tr> <td>Password </td> <td><input type="password" name="password" /></td> </tr> <tr> <td><input type="submit" name="login" value="Login" /></td> </tr> <tr> <td><a href="<?=$siteurl?>/register.php">Register</a></td> </tr> </table> </fieldset></form><?php}else{ //Declare some variables $email = secure($_POST['email']); $password = secure($_POST['password']); //Check if the form is filled out if (!$email || !$password) { echo 'Please fill out the form completely'; echo '<a href="'. $siteurl .'/login.php">Go Back</a>'; } else { $user = mysql_query("SELECT * FROM `users` WHERE email = '$email'"); if (! mysql_num_rows($user)) { echo 'That user doe not exist'; } else { //Encrypt the password $encpass = sha1($password . $salt); //Find the user            $superquery = mysql_query("SELECT * FROM `users` WHERE email = '$email' AND password = '$encpass'");                        if (mysql_num_rows($superquery) == 1) {            //If the user is found, set the cookies                            setcookie("username", $email, 0);                setcookie("password", $encpass, 0);                setcookie("is_logged_in", true, 0);                //send the user to the home page header("Location: " . $siteurl . "members.php");          }           else           {           echo 'Password was incorrect. Please try again.';        } } }}ob_flush();?>()

what am i doing wrong?

Some of you may have seen one of my many posts about email issues.  Some users don't get them, and I have determined it is probably because we are marked as spam.   We are a service that grades sales team members on their phone skills.  Listening to pre-recorded calls, grading and uploading them to our site, and then another part of our business looks them over and sometimes leaves a message that then get's forwarded to this persons work email.   I have determined there is ways to get marked as spam as default by not having an opt out link.  This is not an option, these sales members employer has opted in, and the emails are going to work related accounts hosted at that employer.  Also, if one of these staff members is not so bright, or disgruntled they may mark us as spam anyways.  The bottom line is that we have very little control over whether we are or are not marked as spam.   So we want to start looking into sending text messages and this is where I start to question how good of an idea this is.   First off, if it was me, and the messages where being sent to a device that my employer did not provide, I would in no way want work related text messages coming to me.  Unless there is a vested interest in getting them.  IE, I'm the boss at this place and am always on the clock.  What if you are on the bottom?  It's just a job for you.   What if it is a pre-paid device, text messages cost money.  What then?  What if they don't even have, or want a cell phone?   The short of it is this.  If I'm at a job that is just another job, and this employer tells me that I have to get these messages.  I'm going to look for another job.  I see the organizations having continuous issues and complaints from their employees.  Thus us as a business having issues keeping clients.   What am I getting into here?  What are your opinions on this matter?  What are your recommendations as to alerting users of something on our site that we can rest assured are being received 100% of the time?   Thanks!   Nick

<?php
if(isset($_POST['submit'])){
$name = $_POST['name'];
}
?>
<form method="POST" action="hist1.php">
<br />
<input type="hidden" name="name" value="<?php echo $name ?>" />
<?php
$q = mysql_query("SELECT * FROM histact1 ORDER BY RAND() LIMIT 1");
while ($r1 = mysql_fetch_array($q)){
$id = $r1[0];
$question1 = $r1[1];
$opt1 = $r1[3];
$opt2 = $r1[4];
$opt3 = $r1[5]; 
?>


<div class="Qset" id="q1"><br /><br />
<label class="items">1st Question :</label> <br />
<center>
<textarea class="textareaQ" name="question1" readonly><?php echo $question1; ?></textarea>
</center>
<br /><br />
<p class="marA">
<input type="radio" name="rad1" value="<?php echo $opt1; ?>" />
<label class="lbl"><?php echo $opt1 ?></label><br />


<input type="radio" name="rad1" value="<?php echo $opt2; ?>" />
<label class="lbl"><?php echo $opt2 ?></label><br />


<input type="radio" name="rad1" value="<?php echo $opt3; ?>" />
<label class="lbl"><?php echo $opt3 ?></label><br />
</p>
</div>
<div class="lr">
<center>
<br /><br /><br /><br />
<a class="nxt"  href="#q2"><label title="Proceed to 2nd Question">Next</label></a>
</center> 
</div> 
<br /><br /><br />
<center><hr width="90%" /></center><br />
<?php } ?>


<br /><br />
<?php
$q = mysql_query("SELECT * FROM histact1 ORDER BY RAND() LIMIT 1");
while ($r1 = mysql_fetch_array($q)){
$id = $r1[0];
$question2 = $r1[1];
$opt1 = $r1[3];
$opt2 = $r1[4];
$opt3 = $r1[5]; 
?>


<div class="Qset" id="q2"><br /><br />
<label class="items">2nd Question :</label> <br />
<center>
<textarea class="textareaQ" name="q2" readonly><?php echo $question2; ?></textarea>
</center>
<br /><br />
<p class="marA">
<input type="radio" name="rad2" value="<?php echo $opt1; ?>" />
<label class="lbl"><?php echo $opt1 ?></label><br />


<input type="radio" name="rad2" value="<?php echo $opt2; ?>" />
<label class="lbl"><?php echo $opt2 ?></label><br />


<input type="radio" name="rad2" value="<?php echo $opt3; ?>" />
<label class="lbl"><?php echo $opt3 ?></label><br />
</p>
</div>
<div class="lr">
<center>
<br /><br /><br /><br />
<a class="nxt"  href="#q1"><label title="Proceed to 1st Question">Back</label></a> &nbsp;|&nbsp; 
<a class="nxt"  href="#q3"><label title="Proceed to 3rd Question">Next</label></a>
</center> 
</div> 
<br /><br /><br />
<center><hr width="90%" /></center><br />
<?php } ?>


<br /><br />
<?php
$q = mysql_query("SELECT * FROM histact1 ORDER BY RAND() LIMIT 1");
while ($r1 = mysql_fetch_array($q)){
$id = $r1[0];
$question3 = $r1[1];
$opt1 = $r1[3];
$opt2 = $r1[4];
$opt3 = $r1[5]; 
?>


<div class="Qset" id="q3"><br /><br />
<label class="items">3rd Question :</label> <br />
<center>
<textarea class="textareaQ" name="q3" readonly><?php echo $question3; ?></textarea>
</center>
<br /><br />
<p class="marA">
<input type="radio" name="rad3" value="<?php echo $opt1; ?>" />
<label class="lbl"><?php echo $opt1 ?></label><br />


<input type="radio" name="rad3" value="<?php echo $opt2; ?>" />
<label class="lbl"><?php echo $opt2 ?></label><br />


<input type="radio" name="rad3" value="<?php echo $opt3; ?>" />
<label class="lbl"><?php echo $opt3 ?></label><br />
</p>
</div>
<div class="lr">
<center>
<br /><br /><br /><br />
<a class="nxt"  href="#q2"><label title="Proceed to 2nd Question">Back</label></a> &nbsp;|&nbsp; 
<a class="nxt"  href="#q4"><label title="Proceed to 4th Question">Next</label></a>
</center> 
</div> 
<br /><br /><br />
<center><hr width="90%" /></center><br />
<?php } ?>


<br /><br />
<?php
$q = mysql_query("SELECT * FROM histact1 ORDER BY RAND() LIMIT 1");
while ($r1 = mysql_fetch_array($q)){
$id = $r1[0];
$question4 = $r1[1];
$opt1 = $r1[3];
$opt2 = $r1[4];
$opt3 = $r1[5]; 
?>


<div class="Qset" id="q4"><br /><br />
<label class="items">4th Question :</label> <br />
<center>
<textarea class="textareaQ" name="q4" readonly><?php echo $question4; ?></textarea>
</center>
<br /><br />
<p class="marA">
<input type="radio" name="rad4" value="<?php echo $opt1; ?>" />
<label class="lbl"><?php echo $opt1 ?></label><br />


<input type="radio" name="rad4" value="<?php echo $opt2; ?>" />
<label class="lbl"><?php echo $opt2 ?></label><br />


<input type="radio" name="rad4" value="<?php echo $opt3; ?>" />
<label class="lbl"><?php echo $opt3 ?></label><br />
</p>
</div>
<div class="lr">
<center>
<br /><br /><br /><br />
<a class="nxt"  href="#q3"><label title="Proceed to 3rd Question">Back</label></a> &nbsp;|&nbsp; 
<a class="nxt"  href="#q5"><label title="Proceed to 5th Question">Next</label></a>
</center> 
</div> 
<br /><br /><br />
<center><hr width="90%" /></center><br />
<?php } ?>


<br /><br />
<?php
$q = mysql_query("SELECT * FROM histact1 WHERE question != '$question1' AND question != '$question2' AND question != '$question3' AND question != '$question4' ORDER BY RAND() LIMIT 1");
while ($r1 = mysql_fetch_array($q)){
$id = $r1[0];
$question5 = $r1[1];
$opt1 = $r1[3];
$opt2 = $r1[4];
$opt3 = $r1[5]; 
?>


<div class="Qset" id="q5"><br /><br />
<label class="items">5th Question :</label> <br />
<center>
<textarea class="textareaQ" name="q5" readonly><?php echo $question5; ?></textarea>
</center>
<br /><br />
<p class="marA">
<input type="radio" name="rad5" value="<?php echo $opt1; ?>" />
<label class="lbl"><?php echo $opt1 ?></label><br />


<input type="radio" name="rad5" value="<?php echo $opt2; ?>" />
<label class="lbl"><?php echo $opt2 ?></label><br />


<input type="radio" name="rad5" value="<?php echo $opt3; ?>" />
<label class="lbl"><?php echo $opt3 ?></label><br />
</p>
</div>
<div class="lr">
<center>
<br /><br /><br /><br />
<a class="nxt"  href="#q4"><label title="Proceed to 4th Question">Back</label></a> &nbsp;|&nbsp; 
<input type="submit" title="Submit Answers" name="submit" class="submit" value=" Submit " onclick="return confirm('Are you sure you want to submit your answers?\nYou can review your answer by click the Back link')" />
</center> 
</div> 
<br /><br /><br />
<center><hr width="90%" /></center><br />
<?php } ?>
</form>

Edited by mac_gyver, 09 October 2014 - 10:51 AM.
code in code tags please

I am running to an issue that I have never delt with before and am not sure if there is even a possible solution:

I have two files:

fileA  and fileB


fileA contains a loop that loops 30 times each time its called. in the loop there is a 2second delay


$i = 1; 
do { 
   $i++; sleep(2);
   if(!isset($_SESSION['user'])
  {
        break;
   }
} while($i < 31);



if fileB i have a simple destroy session

$_SESSION = array();
session_destroy();


I call both files via ajax, and that is where i run into my problem.

if I call fileA first, then call fileB through ajax, the code in FileB does not execute until fileA has run its course.

Is it possible to get around this?

Like set the priority of one over the other?

Trying to make my code more secure.

This is what I currently have, which is not secure by any means:

Code: [Select]
$query1 = "SELECT COLUMN_NAME, DATA_TYPE, ORDINAL_POSITION, COLUMN_DEFAULT, CHARACTER_MAXIMUM_LENGTH, IS_NULLABLE
  FROM INFORMATION_SCHEMA.COLUMNS
  WHERE TABLE_NAME='$table'";
 
// Run PRO query

$qresult1 = sqlsrv_query($dbPRO, $query1);
if ($qresult1 === false) {
    exitWithSQLError('Retrieving schema failed.');
}
This is how I changed it,

Code: [Select]
$query1 = "SELECT COLUMN_NAME, DATA_TYPE, ORDINAL_POSITION, COLUMN_DEFAULT, CHARACTER_MAXIMUM_LENGTH, IS_NULLABLE
  FROM INFORMATION_SCHEMA.COLUMNS
  WHERE TABLE_NAME=?";
$params = array(1, $table);
 
// Run PRO query
$qresult1 = sqlsrv_query($dbPRO, $query1, $params);
if ($qresult1 === false) {
    exitWithSQLError('Retrieving schema failed.');
}
but I'm getting this error:

Code: [Select]
SQL-Status: 22018
Code: 245
Message: [Microsoft][SQL Server Native Client 10.0][SQL Server]Conversion failed when converting the nvarchar value 'sysrscols' to data type int
Please notice I am using sqlsrv_query function because my database engine is MS-SQL 2008. That's why I'm a bit confused. Most documentation online is pointed to MySQL.

exitWithSQLError is a customized function of mine, so please ignore. 

Any help or hints is appreciated,

Thanks,

Hello, I have a form that has a preview, before user can preview the form inputs he must login. If he is logedin, he can see preview and continue to editing form, but after user is finished with editing his values he is redirected to "preview" page for which he must be logged in. But the problem is that variables are "empty" after redirecting back to preview.

$_POST['email'] is received from login.php
$_SESSION['code'] is 5 digit code generated at start, it isn't important in this issue.

Here's the code:

preview.php
Code: [Select]
$id_user= 0;
$code = $_SESSION['code'];
    $email = $_POST['email'];
    $_SESSION['email_login'] = $email;
So now you can see that $email and $_SESSION['email_login'] are empty because when redirecting from "editing" to preview  $_POST['email'] can't be found...

I have a sorting functionality, the code is he


<?php

$select_category = $_REQUEST['sort_category'];

$sort_date_var = $_REQUEST['sort_date'];

$sort_submit = $_POST['sortSubmit'];

// Connect to the database 
$dbc = mysqli_connect(DB_HOST, DB_USER, DB_PASSWORD, DB_NAME);

if (($select_category == 'All') || (!isset($select_category)) && (!isset($sort_date_var))) {

// Retrieve the chosen category from MySQL

$query

= "SELECT * FROM con";

$data = mysqli_query($dbc, $query);

//Loop through the array of data

while ($row = mysqli_fetch_array($data)) 

{

echo "<table class='knuffixTable'>";

// Display the score data

echo "<tr><td class='knuffix_name'>";

echo "<strong>" . htmlentities($row['name']) . "</strong><br /></td></tr>";

echo "<tr><td class='knuffix_contribution'><pre>" . $row['contribution'] . "</pre><br /></td></tr>";

echo "<tr><td class='knuffix_categoryDate'>" . $row['category'] . " | " . date('M d, Y', strtotime($row['contributed_date'])) . " </td></tr>";

echo "</table>";

}

mysqli_close($dbc);

} elseif (isset($select_category) && !isset($sort_date_var)) {

// Retrieve the chosen category from MySQL

$query = "SELECT * FROM con WHERE category = '$select_category'";

$data = mysqli_query($dbc, $query) or die (mysqli_error($dbc));

//Loop through the array of data

while ($row = mysqli_fetch_array($data)) 

{

echo "<table class='knuffixTable'>";

// Display the score data

echo "<tr><td class='knuffix_name'>";

echo "<strong>" . htmlentities($row['name']) . "</strong><br /></td></tr>";

echo "<tr><td class='knuffix_contribution'><pre>" . $row['contribution'] . "</pre><br /></td></tr>";

echo "<tr><td class='knuffix_categoryDate'>" . htmlentities($row['category']) . " | " . date('M d, Y', strtotime($row['contributed_date'])) . " </td></tr>";

echo "</table>";

}

mysqli_close($dbc);

} elseif (!isset($select_category) && isset($sort_date_var)) {

// Retrieve the chosen category from MySQL

$query = "SELECT * FROM con ORDER BY contributed_date $sort_date_var";

$data = mysqli_query($dbc, $query) or die (mysqli_error($dbc));

//Loop through the array of data

while ($row = mysqli_fetch_array($data)) 

{

echo "<table class='knuffixTable'>";

// Display the score data

echo "<tr><td class='knuffix_name'>";

echo "<strong>" . htmlentities($row['name']) . "</strong><br /></td></tr>";

echo "<tr><td class='knuffix_contribution'><pre>" . $row['contribution'] . "</pre><br /></td></tr>";

echo "<tr><td class='knuffix_categoryDate'>" . htmlentities($row['category']) . " | " . date('M d, Y', strtotime($row['contributed_date'])) . " </td></tr>";

echo "</table>";

}

mysqli_close($dbc);

} elseif (isset($select_category) && isset($sort_date_var)) {

// Retrieve the chosen category from MySQL

$query = "SELECT * FROM con WHERE category = '$select_category' ORDER BY contributed_date $sort_date_var";

$data = mysqli_query($dbc, $query) or die (mysqli_error($dbc));

//Loop through the array of data

while ($row = mysqli_fetch_array($data)) 

{

echo "<table class='knuffixTable'>";

// Display the score data

echo "<tr><td class='knuffix_name'>";

echo "<strong>" . htmlentities($row['name']) . "</strong><br /></td></tr>";

echo "<tr><td class='knuffix_contribution'><pre>" . $row['contribution'] . "</pre><br /></td></tr>";

echo "<tr><td class='knuffix_categoryDate'>" . htmlentities($row['category']) . " | " . date('M d, Y', strtotime($row['contributed_date'])) . " </td></tr>";

echo "</table>";

}

mysqli_close($dbc);

}

?>



With this code I'm able to:
- showcase every category by DEFAULT when someone comes to the page.
- sort only by category,
- sort only by date,
- sort by category AND date,

The problem is as you can see I have a lot of duplicate code, if I for example want to change the table that is being printed out, I have to change it on all of them. I'd like to ask how I could avoid this duplicate code. Can I for example just have the table ONE TIME at a separate place and then insert the REFERENCE _after_ the query in each if statement?

Like this:


if (($select_category == 'All') || (!isset($select_category)) && (!isset($sort_date_var))) {

// Retrieve the chosen category from MySQL

$query

= "SELECT * FROM con";

$data = mysqli_query($dbc, $query);

table_here();

} elseif (isset($select_category) && !isset($sort_date_var)) {

// Retrieve the chosen category from MySQL

$query = "SELECT * FROM con WHERE category = '$select_category'";

$data = mysqli_query($dbc, $query) or die (mysqli_error($dbc));

table_here();

}



I'm just coding since 2 month so I don't know how do it, maybe I can do it with functions?

I've tried doing it with functions, but I got an error since the function doesn't contain any query statement and only the table because it was trying to fetch.

it looked like this:



function table_here () {

//Loop through the array of data

while ($row = mysqli_fetch_array($data)) 

{

echo "<table class='knuffixTable'>";

// Display the score data

echo "<tr><td class='knuffix_name'>";

echo "<strong>" . htmlentities($row['name']) . "</strong><br /></td></tr>";

echo "<tr><td class='knuffix_contribution'><pre>" . $row['contribution'] . "</pre><br /></td></tr>";

echo "<tr><td class='knuffix_categoryDate'>" . $row['category'] . " | " . date('M d, Y', strtotime($row['contributed_date'])) . " </td></tr>";

echo "</table>";

}

mysqli_close($dbc);

}

I'm just looking for some tips here. I am developing and selling an eccommerce shopping cart software package, and it has been received very well from the early adopters. There's just one small problem that prevents the software from being a truly out-of-the-box solution: the include path. Not all users have access to their php.ini file, and it's not always a php.ini file anyway. So this is something the installation is unable to set for the customer.

I'm using object-oriented PHP5 stuff, so I have a folder named "classes" with all the relevant stuff in there. I am unable to search for paths to the folder and hard-code those into source files (there are ajax calls and other fun stuff; hard to know the exact relation to the path).

I guess I could use set_include_path on the top of a bunch of files, but that is a small performance hit (and totally inelegant code). I could put the folder path in the database somewhere and query for it (and cache it so it's not a performance hit). None of this stuff seems good. The path seems like the best solution.

Unless you have better ideas....