PHP - Cannot Use Extended Class Functions Inside __construct.

Hi people!

class FirstOne{

public function FunctionOne($FirstInput){
//do stuff and output value
return $value1;
}

}


Then:-


class SecondOne{

public function FunctionTwo($AnotherInput){
//do stuff and output value
return $value2;
}

}


What I want to know is this, if I want to use FunctionOne() in Class SecondOne do I do it like this:-

(Assume as I have instantiated the first class using $Test = new FirstOne(); )


class SecondOne{

function SecondedFunction(){
global $Test;
return $Test->FunctionOne();
}

public function FunctionTwo($AnotherInput){
//do stuff and output value
return $value2;
}

public function FunctionThree(){

//some code here
$this->Test->SecondedFunction();<--I think as I can omit the $this-> reference
}
}


My point is: Do I have to do it this way or is there way of having this done through __construct() that would negate the need for a third party function?

I have a version working, I just think that it is a little convoluted in the way as I have done it, so I thought I would ask you guys.

Any help/advice is appreciated.

Cheers
Rw

OK, so I'm trying to create a central db class for data validation, etc.  I'm starting off with the data.

this code works for me, I just want to be sure that I'm not missing anything.  Will dbData be accessible globally?

Code: [Select]
class dbData{
    function regex_key_data($reg){
            $z = '/[a-z\s\'{1}]*/';
            $d=       array(  'domain'=>'/^[a-z0-9-.]+\.[a-z0-9]{2,4}$/i',
                        'email'=>'/^[a-z0-9._-]+@[a-z0-9._-]+\.[a-z]+$/i',
                        'GUID'=>'/[A-Z0-9]{8}-[A-Z0-9]{4}-[A-Z0-9]{4}-[A-Z0-9]{4}-[A-Z0-9]{12}/',
                        'html'=>'*htmlentities',
                        'int'=>'[0-9]',
                        'string'=>'*mysql_real_escape_string',
                        'fname'=>$z,
                        'lname'=>$z
                    );
            return $d[$reg];
    }
    function test($reg,$val){
       
        $z = preg_match(dbData::regex_key_data($reg),$val ,$dom);
        return ($z?$dom[0]:false);
    }
   
}
function clean_it($v,$type = 'none'){
    $v = urldecode($v);

    if(!empty($v)){

            switch($type){
                    case 'domain':
                           
                            return dbData::test('domain',$v);
                            break;
                    case 'email':
                            preg_match('/^[a-z0-9._-]+@[a-z0-9._-]+\.[a-z]+$/i', $v,$email);
                            if(empty($email[0])){return 'empty';}
                            else{return mysql_real_escape_string($email[0]);}
                            break;
                    case 'GUID':
                            return mysql_real_escape_string($v);
                            break;
                    case 'html':
                            return mysql_real_escape_string(htmlentities($v));
                            break;
                    case 'int':
                            if(is_numeric($v)){return $v;}
                            break;
                    case 'string':
                            return mysql_real_escape_string($v);
                            break;
            }

    }
    else{
        switch($type){
                case 'domain':
                case 'none':
                case 'string':
                case 'email':
                case 'GUID':
                case 'html':
                        return 'empty';
                        break;
                case 'int':
                        return 0;
                        break;
        }
    }
}
$br = '<br/>';
echo dbData::test('GUID','ASDFASDF-ASDF-ASDF-ASDF-ASDFASDFASDF').$br;
echo dbData::test('email','asdf@asdf.asd').$br;
echo clean_it('asdfsdf.com','domain');

I think I need to use $this, but I need to be able to add the two values returned from both of my functions.  How would I do that?

Code: [Select]
public function get_users_edge($uid)
{
$users_primary->get_users_primary_edge($uid);
$users_dynamic->get_users_dynamic_edge($uid);

echo $users_primary + $users_dynamic;
}

Hi!

I have a class with many functions/methods. I want to split this into different files so I can easily edit and add functions.
I want every functions to be able to call eachother and with that I mean, they have to be for example in same document.

My question is: I can't have a class and include functions like this:

Code: [Select]
class DB
{

include('select_functions.php'); //Only includes function's no class
include('insert_functions.php'); //Only includes function's no class
include('delete_functions.php'); //Only includes function's no class

function test()
{

}

}
The includes will output fatal errors...

How can I solve this so I can have all functions in different files but still use ONE object to call them!

Thanks!

hello

i have some normal php functions that i want to put into a oop class.

i cant seem to make the right changes to make it work. could some one help please. thanks

these are the php functions

Code: [Select]
<?php

  function hasChild($parent_id)
  {
    $sql = "SELECT COUNT(*) as count FROM category WHERE parent_id = '" . $parent_id . "'";
    $qry = mysql_query($sql);
    $rs = mysql_fetch_array($qry);
    return $rs['count'];
  }
  
  function CategoryTree($list,$parent,$append)
  {
    $list = '<li>'.$parent['name'].'</li>';
    
    if (hasChild($parent['id'])) // check if the id has a child
    {
      $append++;
      $list .= "<ul class='child child".$append."'>";
      $sql = "SELECT * FROM category WHERE parent_id = '" . $parent['id'] . "'";
      $qry = mysql_query($sql);
      $child = mysql_fetch_array($qry);
      do{
        $list .= CategoryTree($list,$child,$append);
      }while($child = mysql_fetch_array($qry));
      $list .= "</ul>";
    }
    return $list;
  }
  function CategoryList()
  {
    $list = "";
    
    $sql = "SELECT * FROM category WHERE (parent_id = 0 OR parent_id IS NULL)";
    $qry = mysql_query($sql);
    $parent = mysql_fetch_array($qry);
    $mainlist = "<ul class='parent'>";
    do{
      $mainlist .= CategoryTree($list,$parent,$append = 0);
    }while($parent = mysql_fetch_array($qry));
    $list .= "</ul>";
    return $mainlist;
  }
?>


this is the class


Code: [Select]
<?PHP
require_once(LIB_PATH.DS.'database.php');

class Menu extends DatabaseObject {

protected static $table_name="menu";

protected static $db_fields = array(
'id',
'parent_id',
'name'
);


public $id;
public $parent_id;
public $name;


// "new" is a reserved word so we use "make"(or "build")
public static function make(

$id,
$parent_id,
$name) {

if(!empty($id)) {

$kw = new Menu();
$kw->id = (int)$id;
$kw->parent_id = (int)$parent_id;
$kw->name = $name;

return $kw;
}else{
return false;
}
} //end function make


//PUT FUNCTIONS HERE......

  function hasChild($parent_id)
  {
    $sql = "SELECT COUNT(*) as count FROM category WHERE parent_id = '" . $parent_id . "'";
    $qry = mysql_query($sql);
    $rs = mysql_fetch_array($qry);
    return $rs['count'];
  }
 
  function CategoryTree($list,$parent,$append)
  {
    $list = '<li>'.$parent['name'].'</li>';
   
    if (hasChild($parent['id'])) // check if the id has a child
    {
      $append++;
      $list .= "<ul class='child child".$append."'>";
      $sql = "SELECT * FROM category WHERE parent_id = '" . $parent['id'] . "'";
      $qry = mysql_query($sql);
      $child = mysql_fetch_array($qry);
      do{
        $list .= CategoryTree($list,$child,$append);
      }while($child = mysql_fetch_array($qry));
      $list .= "</ul>";
    }
    return $list;
  }
  function CategoryList()
  {
    $list = "";
   
    $sql = "SELECT * FROM category WHERE (parent_id = 0 OR parent_id IS NULL)";
    $qry = mysql_query($sql);
    $parent = mysql_fetch_array($qry);
    $mainlist = "<ul class='parent'>";
    do{
      $mainlist .= CategoryTree($list,$parent,$append = 0);
    }while($parent = mysql_fetch_array($qry));
    $list .= "</ul>";
    return $mainlist;
  }
?>

Hi,    I'm struggling to understand how to load a PHP classes for my database into a php function.    My class in on another file, which is included into my page.    I then have a function that usings the class of $database->query in the function, but for some reason this doesn't work.    However the class works on the page outside of the function, is there someway I must load the class into my function?   Thanks for reading. 

Hi,
So as you might (or might not) have guessed I need to open/close new connections inside my functions.

Here's my current code:

Code: [Select]
<?PHP

/**
 * This function checks the ban status of the account.
 * @return      1 if banned
 */
function checkBan()
{
    mysql_close($con);
    require("./includes/wow.php");
    $result = mysql_query("SELECT * FROM wow_logon.accounts WHERE forum_acc= '.$user->data['user_id'].'");
    $row = mysql_fetch_array($result);
    if($row["banned"] == "1")
    {
        return 1;
        $ban_reason = $row["banreason"];
    }
    //$user->data['user_id']
     
    mysql_close($connect);       
    require("./includes/config.php");
}


?>
When trying to use the function:

checkBan();

if(checkban() == "1")
{
    echo'function works, and returns 1. Ban reason: '.$ban_reason.' ';
}

This gives a pretty good idea of what I try to accomplish I hope, if not, an explanation is below.
This code unfortunately returns:
Code: [Select]
[phpBB Debug] PHP Warning: in file /home/fusion/public_html/includes/functions_user.php on line 9: mysql_close() expects parameter 1 to be resource, null given
[phpBB Debug] PHP Warning: in file /home/fusion/public_html/includes/functions_user.php on line 12: mysql_fetch_array() expects parameter 1 to be resource, boolean given
[phpBB Debug] PHP Warning: in file /home/fusion/public_html/includes/functions_user.php on line 9: mysql_close() expects parameter 1 to be resource, null given
[phpBB Debug] PHP Warning: in file /home/fusion/public_html/includes/functions_user.php on line 12: mysql_fetch_array() expects parameter 1 to be resource, boolean given

Line 9 & 12:
mysql_close($con);
$row = mysql_fetch_array($result);


Explanation:
What I want to do is that I have a user account panel.
When the user log in, I want to call a function to check if the user is banned. If the user is banned then we have returned 1, and display some banned message, followed by the ban reason.
P.S. is it possible to use stored variables inside a function?

When I do this, I connect to another sql server, by first closing the existing connection (if any) and open a new one to execute my statements. Then close that connection and resume the old one.

I am currently building my own MVC Framework and I have run into an issue that I can't solve when attempting to use 2 methods from a single model. I know that this isn't an issue with the queries or information being return. I am unsure of the proper way that I can call 2 methods when checking to see if a user is logged in... The issue that I face is both methods are calling the DB and it throws a PDO error which I don't know how to get around the issue.. Any guidance would be nice as I have been banging my head over this issue. Thank you!

 

Fatal error: Uncaught Error: Call to undefined method PDO::Select() in C:\xampp\htdocs\PicWrist\app\models\user.class.php:318 Stack trace: #0 C:\xampp\htdocs\PicWrist\app\controllers\home.php(21): User->getUser('4') #1 C:\xampp\htdocs\PicWrist\app\core\app.php(36): Home->index() #2 C:\xampp\htdocs\PicWrist\app\init.php(47): App->__construct() #3 C:\xampp\htdocs\PicWrist\public\index.php(5): require('C:\\xampp\\htdocs...') #4 {main} thrown in C:\xampp\htdocs\PicWrist\app\models\user.class.php on line 318

 

//Controller

<?php 
	/**
	 * Load the View
	 */
	class Controller{

		public function view($view, $data = []) {
			if (file_exists('../app/views/' . $view . '.php')) {
				require_once '../app/views/' . $view . '.php';
			} 
		}

		public function model($model, $data = []) {

			if (file_exists('../app/models/' . $model . '.class.php')) {
				require_once '../app/models/' . $model . '.class.php';

				return new $model();

			} else 

				return false;
		}
	}

?>

//Home Controller
<?php 
Class Home extends Controller {

	public static $user;
	public $errors;

	public function __construct() {

		self::$user = $this->model('user');

	}

	public function index() {
		$userdata 			= [];
		$data				= [];

		show(self::$user);
		$isLoggedin	= self::$user->isLoggedin;
		show($isLoggedin);

		$userdata = self::$user->getUser($_SESSION['user_id']);
		show($userdata);

		$this->view('home', $data);
	}

}

?>
<?php 
/**
 * Users
 */
class User
{
	private $db;
	private $errors = '';
	public $isLoggedin = False;
	public $isAdmin = False;

	public function __construct() {
		$this->isLoggedIn();
	}

	public function isLoggedIn() {

		if(isset($_SESSION['user_id'])){

			$data['user_id'] = $_SESSION['user_id'];
			$db = Database::getInstance();
			$query = "SELECT * FROM users WHERE user_id = :user_id LIMIT 1";
			$results = $db->Select($query, $data);

			if (is_array($results)) {
				 $this->isLoggedIn = True;
			}
		}

	}


	public function getUser($id) {

		if(isset($id)) {

			$data['user_id']	= intval($id);
			$db 				= Database::getInstance();
			$query 				= 'SELECT * FROM users WHERE user_id = :user_id';

			$results = $db->Select($query, $data);

			if (is_array($results)) {
				return $results;
			} else {
				return False;
			}
		} else {
			return False;
		}
	}

//DB
<?php 
	/**
	 * Database Connection
	 */
	class Database	{
		private $dbHost = DB_HOST;
		private $dbUser = DB_USER;
		private $dbPass = DB_PASS;
		private $dbName = DB_NAME;

		private $statment;
		private static $dbHandler;
		private $error;

		public function __construct()
		{
			$conn = 'mysql:host=' . $this->dbHost . ';dbname=' . $this->dbName;

			$options = array(
				PDO::ATTR_PERSISTENT 	=> true,
				PDO::ATTR_ERRMODE 		=> PDO::ERRMODE_EXCEPTION
			);

			try {
				self::$dbHandler = new PDO($conn, $this->dbUser, $this->dbPass, $options);
			} catch (PDOException $e) {
				self::$error = $e->getMessage();
				echo self::$error;
			}
		}

		public static function getInstance() {

			if(self::$dbHandler) {
				return self::$dbHandler;
			}

			return $instance = new Self();
		}

		public function Select($query, $data = array()) {
			$statement = self::$dbHandler->prepare($query);
			$result	= $statement->execute($data);

			If($result) {
				$data = $statement->fetchAll(PDO::FETCH_OBJ);
					if(is_array($data)) {
						// show($data);
						return $data;
				}
			}

			return False;
		}

		public function Update($query, $data = array()) {
			$statement = self::$dbHandler->prepare($query);
			$result	= $statement->execute($data);

			If($result) {
				return True;
			} 
			
			return False;

		}

	}

?>

 

Edited July 14 by avargas94
Wrong Code

This is a bit of a more advanced question so I am hoping there are some advanced programmers online at this time . Anyways basically I want to be able to "queue" functions from a class in a single call and am wondering if I am doing it correctly or if there is a better way to do it. Here is my code:


<?php
class test {
     private static $one;
     private static $two;
     private static $three;

     public function callOne($val){
          $one .= $val;
          return $this;
     }
     
     public function callTwo($val){
          $two .= $val;
          return $this;
     }

     public function callThree($val){
           $three .= $val;
           return $this;
     }

     public function print(){
          echo $this->one.' '.$this->two.' '.$this->three;
     }
}
?>


now when I want to call this I can do:

$test = new test();
$test->callOne('one')->callTwo('two')->callThree('three');
$test->callOne('another one');
$test->print();


Is there a better way to do this or is there a different method of doing this? Just wanna make sure I am doing it right lol.

Was just wondering why some people choose NOT to make use of static functions when initializing objects via Factory Classes/Containers.

What are the benefits of initializing the Factory class when for all intensive purposes, it's only used to initialize new classes, etc? 
Does this have any impact on Dependency Injection?  I'm assuming that it doesn't since that would defeat the purpose.

---------

Also, I've noticed that there seems to be an intense stigma within the development community in regard to singletons. 
Are singletons necessarily a bad thing? 

What about database objects? 

One argument I've heard is that this can often impact the flexibility of your application in the event that a new instance of said class needs to be initialized(a second completely separate connection).

However, I was thinking that you could simply store these objects within a static member variable in the factory class; leaving the Database Class' __construct public in the event that you need to create that second/third/fourth connection.

Wouldn't this resolve the issue? 

This probably doesn't matter much, but I am using a 'Display' class for final output to the browser.

The class will display the obvious HTML header and then display either the full site or the mobile site.

It also displays the CSS / JS (which is previously selected in the page-specific controller code as there are variations based on server-side checks).

Basically it is the ONLY class that actually needs to send anything to the browser.

When I begin output and echo inside the class, that is the end of the script - there is no more server-side code to execute.

If I shouldn;t echo inside the class, is it that bad to do so?

Well in the class UserValidator I have a public method validate(), which checks the validation type and then calls specific private methods to execute the validation script. It gets a bit tricky here since the method validate() has to decide what private method to call. I am thinking about using call_user_func_array(), the script currently looks like this below:

Code: [Select]
public function validate(){
      // The core method validate, it sends requests to different private methods based on the type
      if(empty($this->type)) throw new Exception('The validation type is empty, something must be seriously wrong...');
      if(is_array($this->type) and !is_array($this->value)) throw new Exception('Cannot have scalar value if the type is an array.');
      if(!is_array($this->type) and is_array($this->value)) throw new Exception('Cannot have scalar type if the value is an array.');
     
      // Now we are validating our user data or input!
      $validarray = array("register", "login", "password", "session", "email", "reset", "profile", "contacts", "friends");
      foreach($this->type as $val){
         $method = "{$val}validate";
         if(in_array($val, $validarray)) call_user_func_array(array($this, $method), array());
      }     
  }

The method to execute depends on the validation type passed into the validator class, so it is somewhat like a dynamic function call. The problem is, well, I am not sure if I am using call_user_func_array() properly. I read it from php manual that it needs to accept a class instance, but there is no such instance inside a class method so I use $this in the argument. Is this the correct way of using call_user_func_array()? If not, how am I supposed to do this? thanks.

Hi,

Im wondering if there is an easy way to get items out of an array returned by a function inside a class.   A code example would be:

Code: [Select]
class modDB {

public function getPwdSalt() {
$arr = array("salt", "password");
return $arr;
}

}
?>
And what i would like to be able to do is something like:

Code: [Select]
$modDB = new modDB;

echo $modDB->getPwdSalt()->[1];
and just get returned 'password'.  Is something like that possible?

Many Thanks.

I tried these below,
Code: [Select]
class Site extends Controller
{
  function Site()
 {
    public $data = Array();
 }
}

but it fail?

Thanks in advanced.