PHP - Simple And Clean Or Bright And Confusing?

Hey guys

 I have a lot of inputs from my form. Is there a way I can do like a for each or something instead of of having to write

$myusername = stripslashes($_POST['name');
$mypassword = stripslashes($_POST['pass']);
$myusername = mysql_real_escape_string($myusername);
$mypassword = mysql_real_escape_string($mypassword);

.... for all 16 fields?

thanks

What is the cleanest way to write this if?

Code: [Select]
<div <?php if (!empty($otherfans)) {echo "class=\"newstext\"";} else {echo "class=\"newstext pts\""; } ?>>

Hi,

Here is a tiny bit of my code


$r = mysql_query ($query);

while ($row = mysql_fetch_array ($r, MYSQL_ASSOC)) {
 


echo "<tr>

<td align=\"center\">";  echo date("M-d-Y", mktime(0, 0, 0, $row['month'], $row['day'], $row['year'])); echo "</td> ";

    if ($row['presenter1status'] == '0')
              {
              echo "<td align=\"center\"><font color=\"#FF9900\">{$row['presenter1']}</font></td>";
              }
          elseif ($row['presenter1status'] == '1')
              {
              echo "<td align=\"center\"><font color=\"green\">{$row['presenter1']}</font></td>";
              }
          elseif ($row['presenter1status'] == '2')
              {
              echo "<td align=\"center\"><font color=\"red\">{$row['presenter1']}</font></td>";
              }


    if ($row['presenter2status'] == '0')
              {
              echo "<td align=\"center\"><font color=\"#FF9900\">{$row['presenter2']}</font></td>";
              }
          elseif ($row['presenter2status'] == '1')
              {
              echo "<td align=\"center\"><font color=\"green\">{$row['presenter2']}</font></td>";
              }
          elseif ($row['presenter2status'] == '2')
              {
              echo "<td align=\"center\"><font color=\"red\">{$row['presenter2']}</font></td>";
              }
            
            
             if ($row['engineerstatus'] == '0')
              {
              echo "<td align=\"center\"><font color=\"#FF9900\">{$row['engineer']}</font></td>";
              }
          elseif ($row['engineerstatus'] == '1')
              {
              echo "<td align=\"center\"><font color=\"green\">{$row['engineer']}</font></td>";
              }
          elseif ($row['engineerstatus'] == '2')
              {
              echo "<td align=\"center\"><font color=\"red\">{$row['engineer']}</font></td>";
              }
            
echo "</tr>


I was wondering if there is a better way of doing this as I think including this many ifesle statements in a while loop that could go round about 40 times might be very heavy on the resources.

Thanks

Rules:
1) It has to be legit and actually work and have a useful function in society/web world.
2) The code cannot be minimized into one line. It has to have line breaks. (Not necessarily for each new function or short hand property, but so it's partly readable)
3) It has to be written in PHP or Javascript.


For example, (Not my original code) but I'll start: A time_ago function:

function timeago($tm,$rcs = 0) {
    $cur_tm = time(); 
    $dif = $cur_tm-$tm;
    $pds = array('second','minute','hour','day','week','month','year','decade');
    $lngh = array(1,60,3600,86400,604800,2630880,31570560,315705600);

    for($v = sizeof($lngh)-1; ($v >= 0)&&(($no = $dif/$lngh[$v])<=1); $v--); if($v < 0) $v = 0; $_tm = $cur_tm-($dif%$lngh[$v]);
        $no = floor($no);
        if($no <> 1)
            $pds[$v] .='s';
        $x = sprintf("%d %s ",$no,$pds[$v]);
        if(($rcs == 1)&&($v >= 1)&&(($cur_tm-$_tm) > 0))
            $x .= time_ago($_tm);
        return $x;
    }

Your turn!
Edited by Monkuar, 24 January 2015 - 05:06 PM.

Hey all,

I would like to some how clean up an if statement to be a little cleaner.

Code: [Select]
if(condition && condition && (condition && condition) || (condition && condition) || (condition && condition))

How can I do that?

I've been messing around with clean urls in php and I've been having some trouble. I'm working on a private messaging system and when I go to "sitename.com/mail/view.php?page=inbox" it correctly displays the users inbox messages but when I put "sitename.com/mail/view/inbox/" it just displays the page like the GET value isn't set. Why is that?

this is the HTACCESS file for clean url

RewriteEngine on

RewriteCond %{REQUEST_FILENAME} !-d

RewriteCond %{REQUEST_FILENAME}\.php -f

RewriteRule ^view/([a-z]) view.php?page=$1 [NC,L]

 

Hi,

I am creating a website but am having trouble with the following:

I have an include file(db.inc) which contains the following:

function clean($input, $maxlength)
{
$input = substr($input, 0, $maxlength);
$input = EscapeShellCmd($input);
return ($input);
}

The file I am having the problem with is my view.php file. I get the following error:

Notice: Undefined variable: file in C:\wamp\www\fermpix\view.php on line 4

Line 4 contains the following:

$file = clean($file, 4);

My view.php does have the line:

include 'db.inc';


Does anybody have any idea what the issue might be?

Cheers
Paul

Hi

Im trying to write a script to clean up my image directory which has quite a lot of unused images that have built up over time.
In order to do this I am doing the following.

First Create a database table called 'image_clean' Then I'm searching through 3 tables and collecting all the image file names and dumping the names in the table 'image_clean'

Can do that no problem. So now I have all the images I need in this one table 'image_clean' I now want to go through my directory 'image_uploads' and delete anything thats not in the 'image_clean' table.

I know how to delete the files using unlink Im just unsure how to search through the directory file by file and check the file against the database. Im asumming I need to put them in an array. Could anyone give be a clue or two to get me started.

I have no problem checking a database against a directory but when its the other way round 'checking a directory against a database I'm lost. What I might do is pop the files to delete in a new database called 'image_delete' so that I can then check the images to delete before I write the unlink script. But I'm just not sure how to pick up each file and compare it to the table.

Thanks in advance.

Hi,

I'm just trying out some basic code and playing around with passing variables by reference and i was reading this on the php manual at this page http://php.net/manual/en/language.references.pass.php :


No other expressions should be passed by reference, as the result is undefined. For example, the following examples of passing by reference are invalid:

<?php
function foo(&$var)
{
    $var++;
}
function bar() // Note the missing &
{
    $a = 5;
    return $a;
}
foo(bar()); // Produces fatal error since PHP 5.0.5

foo($a = 5); // Expression, not variable
foo(5); // Produces fatal error
?>


So, i decided to try it out myself like i always do, and i noticed that i'm not getting an error when i do foo(bar()); i.e calling bar() without the & in the function declaration. Infact it works perfectly fine and returns an incremented $a after its passed to foo(). Likewise foo($a = 5); also works great and returns an incremented $a after being passed to foo(). Is this  a mistake in the manual or am i missing something?

Running PHP 5.3.2-1ubuntu4.5

I'm new to OOP and trying to write tiny classes to get practice.

The next class I want to create will be used to clean HTTP data from when a form gets submitted.

I'm embarrassed to say, but I'm scratching my head trying to figure out what types of things I should do as far as "sterilizing" POST and GET data?!   

Can someone get me started here?

Thanks,


TomTees

if any body copy and paste anything from word to editor some unwanted css also coming with that pasting. when we request the data same css also coming with that. so how to clean data  when we request
$desc =$_request['contents'];


how to solve this issue. please help me.

I currently use the following function to clean form inputs to prevent MySql injection,

Does this function do enough to prevent MySql injection? is there anything i have missed?

 
<?php

//Function to sanitize values received from the form. Prevents SQL injection
function clean($str) {
$str = @trim($str);
if(get_magic_quotes_gpc()) {
$str = stripslashes($str);
}
return mysql_real_escape_string($str);
}

?>

I am currently using my own error handler so i can log all mysql errors into a mysql table:
mysql_query('select data from table')or trigger_error(mysql_error(),256);

If there's an error i need to know the line number where the mysql_query function was called.

Is it possible to instead use this code:
mysql_query('select data from table');

but somehow transparently log a mysql error and the line number if there is an error in the query?

thanks

i have my form with 5 fields that are not required to be filled out.
Code: [Select]
<input class="inputbg" type="text" name="MAC[]"  />
<input class="inputbg" type="text" name="MAC[]"  />
<input class="inputbg" type="text" name="MAC[]"  />
<input class="inputbg" type="text" name="MAC[]"  />
<input class="inputbg" type="text" name="MAC[]"  />

On my process page I want to remove all of the empty index's that did not have data entered. I am new to sending array data via POST do I need to do anything else other then what is below?

Code: [Select]
           

    foreach($MAC as $key => $value) {
                  if($value == "") {
                     unset($MAC[$key]);
                   }
            }

            $mac_addresses = array_values($MAC);

  if(empty($mac_addresses)){
      $error = "You did not enter any MAC adresses.";
     $valid = "false";
    }

I've been using clean URLs and it's been giving my PHP sessions for my user system some trouble. I display the logged in users username on every page via a header.php file that I require on every page. Sometimes when I click a link to navigate to a page with a clean URL, the session information "disappears" and asks the user to login but if I navigate to another page from the clean url that the session "disappeared" on, the logged in users username is displayed at the top of the page like normal. Any idea certain pages cause the session to "disappear"

 

Header.php where the user info is displayed. $_SESSION['username'] is set on the login page

<?
session_start();

if (isset($_SESSION['username'])) {

	echo "Welcome back, " . $_SESSION['username'];
}
?>

 

Edited June 13, 2020 by Nematode128