PHP - Trim Not Working In My Php Code While Uploading Csv

Hey,


I have found a script off the net which uploads an image to a directory but even though it says the image was uploaded successfully - it didn't actually upload it.


The folder permission is 775 (im assuming that is correct).


The script i found is he


http://www.reconn.us/content/view/30/51/

Code: [Select]
<?php
//define a maxim size for the uploaded images in Kb
 define ("MAX_SIZE","100"); 

//This function reads the extension of the file. It is used to determine if the file  is an image by checking the extension.
 function getExtension($str) {
         $i = strrpos($str,".");
         if (!$i) { return ""; }
         $l = strlen($str) - $i;
         $ext = substr($str,$i+1,$l);
         return $ext;
 }

//This variable is used as a flag. The value is initialized with 0 (meaning no error  found)  
//and it will be changed to 1 if an errro occures.  
//If the error occures the file will not be uploaded.
 $errors=0;
//checks if the form has been submitted
 if(isset($_POST['Submit'])) 
 {
  //reads the name of the file the user submitted for uploading
  $image=$_FILES['image']['name'];
  //if it is not empty
  if ($image) 
  {
  //get the original name of the file from the clients machine
  $filename = stripslashes($_FILES['image']['name']);
  //get the extension of the file in a lower case format
   $extension = getExtension($filename);
  $extension = strtolower($extension);
  //if it is not a known extension, we will suppose it is an error and will not  upload the file,  
//otherwise we will do more tests
 if (($extension != "jpg") && ($extension != "jpeg") && ($extension != "png") && ($extension != "gif")) 
  {
//print error message
  echo '<h1>Unknown extension!</h1>';
  $errors=1;
  }
  else
  {
//get the size of the image in bytes
 //$_FILES['image']['tmp_name'] is the temporary filename of the file
 //in which the uploaded file was stored on the server
 $size=filesize($_FILES['image']['tmp_name']);

//compare the size with the maxim size we defined and print error if bigger
if ($size > MAX_SIZE*1024)
{
echo '<h1>You have exceeded the size limit!</h1>';
$errors=1;
}

//we will give an unique name, for example the time in unix time format
$image_name=time().'.'.$extension;
//the new name will be containing the full path where will be stored (images folder)
$newname="images/".$image_name;
//we verify if the image has been uploaded, and print error instead
$copied = copy($_FILES['image']['tmp_name'], $newname);
if (!$copied) 
{
echo '<h1>Copy unsuccessfull!</h1>';
$errors=1;
}}}}

//If no errors registred, print the success message
 if(isset($_POST['Submit']) && !$errors) 
 {
  echo "<h1>File Uploaded Successfully! Try again!</h1>";
 }

 ?>

 <!--next comes the form, you must set the enctype to "multipart/frm-data" and use an input type "file" -->
 <form name="newad" method="post" enctype="multipart/form-data"  action="">
 <table>
  <tr><td><input type="file" name="image"></td></tr>
  <tr><td><input name="Submit" type="submit" value="Upload image"></td></tr>
 </table>
 </form>
 


I was also wondering how do upload images to separate folders related to a UserID ?

Hello,

I am currently racking my brains trying to work this out. I am creating a basic CMS system and one of the functions is to give them the option of adding pictures to their gallery however at the moment the uploaded file is not uploading...at all, the FILES array seems to have no recollection of it actually being posted.

The script is meant to:

1. User types in specific details on the form and selects the picture for upload.
2. The script then validates the given details and checks the uploaded file is in fact a image.
3. The script then moves the uploaded file to the storage location on the server.
4. Some basic SQL is then run to transfer the given details and the storage location to the database.

Here is the main script:


<?php

require_once('../includes/Sentry.php');
$theSentry = new Sentry();
$loc = "http://" . $HTTP_HOST . $PATH_INFO;

if (!$theSentry->checkLogin(4) ){ header("Location: login.php?loc=".$loc.""); die(); }

// Get the PHP file containing the DbConnector class
require_once('../includes/DbConnector.php');
require_once('../includes/Validator.php');

// Create an instance of DbConnector
$connector = new DbConnector();

global $HTTP_POST_FILES;

// Check whether a form has been submitted. If so, carry on
if ($HTTP_POST_VARS){


// Validate the entries
$validator = new Validator();

$validator->validateTextOnly($HTTP_POST_VARS['title'],'Picture Title');
$validator->validateTextOnly($HTTP_POST_VARS['alttext'],'Alt Text');
$validator->validateFile($HTTP_POST_FILES['uploaded_file'],'Uploaded File');

// Check whether the validator found any problems
if ( $validator->foundErrors() ){
echo '<center>There was a problem with: <br/><br/>'.$validator->listErrors('<br></center'); // Show the errors, with a line between each
}else{

$target_path = "../images/Pictures/".basename( $_FILES['uploaded_file']['name'])."";


if (!file_exists($target_path)) {

if(move_uploaded_file($_FILES['uploaded_file']['tmp_name'], $target_path)) {
     echo "The file ".  basename( $_FILES['uploaded_file']['name']). 
     " has been uploaded";
 
echo "Upload: " . $_FILES["file"]["name"] . "<br />";
    echo "Type: " . $_FILES["file"]["type"] . "<br />";
    echo "Size: " . ($_FILES["file"]["size"] / 1024) . " Kb<br />";
    echo "Temp file: " . $_FILES["file"]["tmp_name"] . "<br />";

} else{
     echo "<center>There was an error uploading the file, please try again! <br/><br/></center>";
}

} else{
echo "<center>This file already exists, please rename file and try again. </center>";
}

// Create an SQL query (MySQL version)
// The 'addslashes' command is used 5 lines below for added security
// Remember to use 'stripslashes' later to remove them (they are inserted in front of any
// special characters

$insertQuery = "INSERT INTO cmspictures (Title,Alt Text,uploaded_file) VALUES (".
"'".$HTTP_POST_VARS['title']."', ".
"'".$HTTP_POST_VARS['alttext']."', ".
$target_path."')";

// Save the form data into the database 
if ($result = $connector->query($insertQuery)){

// It worked, give confirmation
echo '<center><b>Picture added to the database</b></center><br /><br />';
echo "<center><b>File Name:</b> ".$_FILES['uploaded_file']['name']."";

}else{

// It hasn't worked so stop. Better error handling code would be good here!
exit('<center>Sorry, there was an error saving to the database</center>');

}
}
}
?>

<body>
<form name="addPicture" method="post" action="newPicture.php" formenctype="multipart/form-data">
        <p>&nbsp;Title:
          <input name="title" type="text" id="title" />
        </p>
        <p>&nbsp;Alternative Text (If the picture fails to show e.g. Image of Cat):
          <input name="alttext" type="text" id="altext" />
        </p>
        <p>&nbsp;Image File:
        <input name="uploaded_file" id="uploaded_file" type="file" /> 

</p>
        <p align="center">
          <input type="submit" name="Submit" value="Upload Picture">
        </p>
</form>



And here is the validation script:


<?php
require_once 'SystemComponent.php';
class Validator extends SystemComponent {

var $errors; // A variable to store a list of error messages

// Validate something's been entered
// NOTE: Only this method does nothing to prevent SQL injection
// use with addslashes() command
function validateGeneral($theinput,$description = ''){
if (trim($theinput) != "") {
return true;
}else{
$this->errors[] = $description;
return false;
}
}

// Validate text only
function validateTextOnly($theinput,$description = ''){
$result = ereg ("^[A-Za-z0-9\ ]+$", $theinput );
if ($result){
return true;
}else{
$this->errors[] = $description;
return false; 
}
}

// Validate text only, no spaces allowed
function validateTextOnlyNoSpaces($theinput,$description = ''){
$result = ereg ("^[A-Za-z0-9]+$", $theinput );
if ($result){
return true;
}else{
$this->errors[] = $description;
return false; 
}
}


// Validate Filenames
function validateFile($theinput,$description = ''){
$allowedextensions = array("jpg", "png", "gif", "bmp", "tif", "JPG", "PNG", "GIF", "BMP", "TIF");
$file_ext = substr($theinput, strripos($theinput, '.')+1);
if (in_array($file_ext, $allowedextensions)) {
return true;
}else{
$this->errors[] = "<center>You can only upload picture files with the extensions .jpg, .png, .bmp, .tif<br/> Yours was: ".$file_ext."</center>";
return false;
}

}


// Validate email address
function validateEmail($themail,$description = ''){
$result = ereg ("^[^@ ]+@[^@ ]+\.[^@ \.]+$", $themail );
if ($result){
return true;
}else{
$this->errors[] = $description;
return false; 
}

}

// Validate numbers only
function validateNumber($theinput,$description = ''){
if (is_numeric($theinput)) {
return true; // The value is numeric, return true
}else{ 
$this->errors[] = $description; // Value not numeric! Add error description to list of errors
return false; // Return false
}
}

// Validate date
function validateDate($thedate,$description = ''){

if (strtotime($thedate) === -1 || $thedate == '') {
$this->errors[] = $description;
return false;
}else{
return true;
}
}

// Check whether any errors have been found (i.e. validation has returned false)
// since the object was created
function foundErrors() {
if (count($this->errors) > 0){
return true;
}else{
return false;
}
}

// Return a string containing a list of errors found,
// Seperated by a given deliminator
function listErrors($delim = ' '){
return implode($delim,$this->errors);
}

// Manually add something to the list of errors
function addError($description){
$this->errors[] = $description;
}

}
?>


Any help in resolving this issue would be greatly appreciated.

mrenigma

http://paste.ee/p/OhiWv   The above is a link to a readable version of my code.  The XMLHTTPREQUEST worked, and the array was pulled down.  Was able to print out the undecoded/unparsed array.  However, immediately afterwards, all code stops working.

		<script>  
			var xhr;
			 if (window.XMLHttpRequest) { // Mozilla, Safari, ...
				xhr = new XMLHttpRequest();
			} else if (window.ActiveXObject) { // IE 8 and older
				xhr = new ActiveXObject("Microsoft.XMLHTTP");
			} 
				xhr.open("POST", "PHPLibrary/selectMemberResults.php", true); 
				xhr.setRequestHeader("Content-Type", "application/x-www-form-urlencoded");                  
				xhr.send();
				xhr.onreadystatechange = display_data;
				var $phparray
				function display_data() {
				 if (xhr.readyState == 4) {
				  if (xhr.status == 200) {
				    //alert(xhr.responseText);	   
					$phparray = xhr.responseText;
					document.getElementById("suggestion").innerHTML = $phparray;
					//
					//
					//......................................................?
					// The above line of code is the last thing to print or 
					// to do anything that returns to the browser....
					//.......................................................?
					// All lines below do nothing............................?

					//
				  } else {
					//alert('There was a problem with the request.');
				  }
				 }
				}   
				document.write("Length of phparray Array :" + $phparray.length + "<");  
				var output = JSON.parse($phparray, function (key,val) {
					if ( typeof val === 'string' ) {
						// regular expression to remove extra white space
						if ( val.indexOf('\n') !== -1 ) {
							var re = /\s\s+/g;
							return val.replace(re, ' ');
						} else {
							return val;
						}
					}
					return val;
				} ); 
				document.write("Length of Array :" + $output.length + "<");
				for (var i=0; i < $output.length; i++)
					{
						document.getElementById("suggestion").innerHTML = $output[i].MEMBER_NAME;
					}  
		</script> 

i dont understand what is wrong plz help me. here is code

$name = "img/".rand(1,9999999).".png";
$myFile = $name;
$fh = fopen($myFile, 'w') or die("can't open file");
$stringData = $html;
fwrite($fh, $stringData);
fclose($fh);
$file=$name;
$fst=file_get_contents($file);
$im=imagecreatefromstring($fst);
imagefilter($im, IMG_FILTER_GRAYSCALE);
imagefilter($im, IMG_FILTER_NEGATE);
//Convert to Grey Scale
for($i=0;$i<123;$i++){
for($j=0;$j<50;$j++){
$px=imagecolorat($im,$i,$j);
if($px<0x303030){
imagesetpixel($im,$i,$j,0);
}else{
imagesetpixel($im,$i,$j,0xffffff);
}
}
}
$database = unserialize(@file_get_contents("db.txt"));
if($database === false) $database = array();
// modify the database if needed
if($_SERVER['REQUEST_METHOD'] == 'POST'){
	if($_POST['submit'] == 'Add')
		$database[$_POST['ident']] = substr($_POST['letter'], 0, 1);
	if($_POST['submit'] == 'Del')
		unset($database[$_POST['ident']]);
	if($fh = @fopen('db111.txt', 'w+')){
		fwrite($fh, serialize($database));
		fclose($fh);
}
}else{
$newimage = true;
}
$width   = 130;
$height  = 40;
$captcha_gridstart   =1;
$captcha_gridspace   =2;
$letters = findletters($im, $width, $height, $captcha_gridstart, $captcha_gridspace);
$count   = count($letters);
$cellw   = ($count > 0) ? intval(100 / $count) : 0;
//dispeckle the image and GET co-ordinates of the characters of captcha image and return them. 
function findletters($image, $width, $height, $gridstart, $gridspace){
	$offsets  = array(); $o = 0;
	$atstartx = true;
	for($x = 0; $x < $width; $x++){
		$blankx = true;
		for($y = 0; $y < $height; $y++){
			if(imagecolorat($image, $x, $y) == 0){
				$blankx = false;
				break;
			}
		}
		if(!$blankx && $atstartx){
			$offsets[$o]['startx'] = $x;
			$atstartx = !$atstartx;
		}else if($blankx && !$atstartx){
			$offsets[$o]['endx']   = $x;
			$atstartx = !$atstartx;
			$o++;
		}
	}
	$count = $o;
	for($o = 0; $o < $count; $o++){
		for($y = 0; $y < $height; $y++){
			$blanky = true;
			for($x = $offsets[$o]['startx']; $x < $offsets[$o]['endx']; $x++){
				if(imagecolorat($image, $x, $y) == 0){
					$blanky = false;
					break;
				}
			}
			if(!$blanky){
				$offsets[$o]['starty'] = $y;
				break;
			}
		}
		for($y = $height-1; $y > $offsets[$o]['starty']; $y--){
			$blanky = true;
			for($x = $offsets[$o]['startx']; $x < $offsets[$o]['endx']; $x++){
				if(imagecolorat($image, $x, $y) == 0){
					$blanky = false;
					break;
				}
			}
			if(!$blanky){
				$offsets[$o]['endy'] = $y;
				break;
			}
		}
	}
	for($o = 0; $o < $count; $o++){
		$offsets[$o]['ident'] = "";
		for($x = $offsets[$o]['startx'] + $gridstart; $x < $offsets[$o]['endx']; $x += $gridspace){
			for($y = $offsets[$o]['starty'] + $gridstart; $y < $offsets[$o]['endy']; $y += $gridspace){
				$offsets[$o]['ident'] .= ((imagecolorat($image, $x, $y) == 0) ? "0" : "1");
				#echo $offsets[$o]['ident'].'<br>';
			}
		}
	}
	return $offsets;
}
$a="";
foreach($letters as $letter){
$asciiletter = $database[$letter['ident']];
if(!empty($asciiletter)) {
$a.=$asciiletter;
}
}

Hello,

I have been messing around with this and can't seem to figure out what I'm doing wrong.  I'm pretty new to php, so it might be something silly.

Original code:
Code: [Select]
$a1=mysql_result($result,$i,"question"); //Question
$a2=mysql_result($result,$i,"answer"); //Answer
$a3=mysql_result($result,$i,"submission_id"); //submission id
$a4=mysql_result($result,$i,"category"); //submission id

echo "<a name=\"$a3\"></a><strong>$a1</strong>$a2";

Prints:

Question

Category

What I want is:

Question
Category

I have tried using the trim functions but nothing seems to help:

Code: [Select]
$a1=mysql_result($result,$i,"question"); //Question
$a2=mysql_result($result,$i,"answer"); //Answer
$a3=mysql_result($result,$i,"submission_id"); //submission id
$a4=mysql_result($result,$i,"category"); //submission id
$a1 = rtrim($a1);
$a2 = ltrim($a2);

echo "<a name=\"$a3\"></a><strong>$a1</strong>$a2";
Ideas?