PHP - Instantiating Alot Many Classes (code Review: Am I Doing It Right?)

I have been trying to figure out a somewhat complex set of functions to handle some product price calculations and display. I was thinking that building classes may be the best solution, but I don't completely know what I am doing with that either. I was hoping someone may be able to help me figure out the best solution for all this. This site is being built within wordpress.

The pages load as follows,

1. Site determines client level: If no user is logged in, it defaults to client_lvl = high, if user is logged in, client_lvl may be set to an alternate value. (high, med, low)

This should be loaded just once per site visit.

I created this function:

function get_client_lvl () {$user_id = get_current_user_id();
global $client_lvl;
If ($user_id == 0)
{$client_lvl= 'high';}
Else
{$client_lvl=get_user_meta($user_id, wpcf-client-lvl, true); }
}//End function

I tried converting it to a class, but I'm not sure I am doing it correctly.
 

class ClientLvl
{
 public  $client_lvl ='high';       
 private $user_id;        
 
 private function __construct()
 {
     $this->user_id= get_current_user_id();
     
 }
    public  function get_client_lvl () //check the client level from user meta-
          
    {
        $this->client_lvl
        If ($user_id != 0)
            {return get_user_meta($user_id, wpcf-client-lvl, true); }

The rest of the functions are based on the following arrangement. Collections have multiple products which have multiple variations.

The Products have a series of multiplier values attached to them. One for each client level. It also has a multiplier type (m_type)

The variants then have the item specific details such as cost of goods sold (cogs), Area, sku, and name.


2. This function is used to determine which multiplier value will be used in the calculation.
  Used on collection and product pages to determine which multiplier value to use for calculation based on client level   f

unction get_multiplier($client_lvl) {
$p_high= get_post_meta(get_the_ID(),'p_high','single');
$p_med= get_post_meta(get_the_ID(),'p_med','single');
$p_low =get_post_meta(get_the_ID(),'p_low','single');


if ($client_lvl == 'med')
{$prices=array('high'=>$p_high,'med'=> $p_med);}

elseif ($client_lvl == 'low')
{$prices=array('high'=>$p_high,'low'=> $p_low);}
else
{$prices=array('high'=>$p_high);}
}//End function

I am assuminng that if I made this a class, I should just define the p_high (med, low) values and then display them with another object creation in another function?


  3.These values will be used in another function to limit the number of images that a user can select for their product.

$img_min= get_post_meta(get_the_ID(),'img_min','single'); 
$img_max= get_post_meta(get_the_ID(),'img_max','single');

4. These are the formulas that are used to calculate the displayed price. I am not sure how to handle the image and image+commission options as they use the number of selected images to determine the price. But if no images are selected, I want it to display "This is the price/ image. One idea I thought of was to include the echo statements inside the switch options, but Im not sure how to handle the array. If the client level is High the function will only loop through once and will not have a was now price. but if it is anything else, then it will loop through twice and will have the was now echo statement. If I didnt have the special case in the image based calculations, then the was now function would work just fine. But I'm not sure where to put the conditional echo's for those functions.

function calculate_price($m_type)
{
global $cogs;
$cogs= get_post_meta(get_the_ID(),'cogs','single');
$img_cost=10;
$prices= get_multiplier();
Foreach($prices as $multiplier)
{
switch ($m_type) {

case 'Area':
$area= get_post_meta(get_the_ID(),'area','single');
$total[]= $multiplier * $area;
break;

case 'Image':
if(isset($img_count))
{$total[]= $multiplier * $cogs * $img_count;}
else
{$total[]= $multiplier * $cogs ;} // Displayed as $price/ Image using $img_count

break;

case 'Commission':

$total[]= $multiplier + $cogs;

break;

case 'Flat':

$total[]= $multiplier;

break;

case 'Commission+Image':
if(isset($img_count))
{$total[]= $multiplier + ($img_cost*$img_count);}
else 
{$total[]= $multiplier; } //Display "Price: ".$multiplier. "+".$img_cost ." /image"

break;

case 'Price':

$total[]= $multiplier * $cogs;

break;
}}}

5. Function that displays the price result from the previous function. Does not currently account for the image or image+commission statements. I need to create a similar function that finds the lowest calculated price of a particular product group to display on the archive page for products.

function was_now($client_lvl,$m_type)
{
$total=calculate_price($m_type);

$p1=number_format($total[0],2,'.',',');

If ($client_lvl == "high")
{

echo "is \${$p1}";
}
else {
$p2=number_format($total[1],2,'.',',');
echo "WAS: \${$p1}<br/>";
echo "NOW: \${$p2}";
}}

6.This is the subloop of the product page that displays the variants for that product. Not fully coded yet. (This code is currently displayed in the template file itself opposed to a function.

function uc_list_product($ID,$m_type)
{
get_page_children($ID);
         echo "<table>
";
                while ( have_posts() )
                {    the_post();
              
        ?>
       <tr><?php
        if($m_type=='Image'){
            $display= 'Price  '. was_now($client_lvl,$m_type);
            //if images are selected display price*img count

        }
        elseif($m_type=='Commission+Image'){
        $display= 'Price  '. was_now($client_lvl,$m_type);}
                //display multiplier, img cost, img count
        else
        {$display= 'Price  '. was_now($client_lvl,$m_type);}

        echo "<td>". the_title()."</td><td>Price ".$display ."</td><td><a href='#'>Select Product</a></td></tr>" ;
                     
        }
        echo "</table>";
        wp_reset_query();
        }

This will probably be doable with classes, but I I'm not entirely sure how to go about that. I hope someone can help me figure this out.      
Edited by jcc5018, 04 October 2014 - 10:09 PM.

I've been spending long hours learning about classes and their magic methods. I just came across a tutorial which showed a constructor like this:

class Device {
    //...
    public function  __construct(Battery $battery, $name) {
        // $battery can only be a valid Battery object
        $this->battery = $battery;
        $this->name = $name;
        // connect to the network
        $this->connect();
    }
    //...
}

the Battery part instantly caught my attention. Here had previously made a Battery class (and a more complete Device class) but the next thing he did really caught my interest:

$device = new Device(new Battery(), 'iMagic');
// iMagic connected
echo $device->name;
// iMagic

what the hell is going on here? Is this another way to include the methods and properties of one class into another class, in order words is this the same thing as:

class Device extends Battery

I don't think so because this new Battery() thing looks more like its creating an object inside the Device object. Previously the only way I could to that was to type $battery = new Battery() inside one of my methods. But this looks like hes doing something different. Can anyone explain whats going on here?   The whole tutorial is he http://code.tutsplus...-php--net-13085 in the main Device method he has a premade $battery variable to hold the Battery object. Sometimes I have multiple classes containing functions which I'd like to include in my main class. I can only extend one class, so I usually extent a class containing only properties, no methods. I still don't know what difference making that info class abstract is, I'd appreciate if anyone could tell me.   Also I'd love to know what the point in static methods is. I've never used them because I've never seen the point. Is it just to make it easier to call the methods because you don't need to create an object instance to call them? Sorry for the extra questions, the first one is what I'm really wondering about.    

Ok I found the culprit and it's easy!

Code: [Select]
function  timeAgo2($timestamp, $granularity=3, $format='d:H:i:s'){
        $difference = $timestamp;
        if($difference < 0) return '0 seconds ago';
        elseif($difference < 864000){
                   $periods = array('week' => 604800,'day' => 86400,'hours' => 3600,'min' => 60,'seconds' => 1);
                $output = '';
                foreach($periods as $key => $value){
                        if($difference >= $value){
                                $time = round($difference / $value);
                                $difference %= $value;
                                $output .= ($output ? ' ' : '').$time.' ';
                                $output .= (($time > 1 && $key == 'day') ? $key.'s' : $key);
                                $granularity--;
                        }
                        if($granularity == 0) break;
                }
                return ($output ? $output : '0 seconds').'';
        }
        else return date($format, $timestamp);
}

Now I will use:

Code: [Select]
timeAgo2(136622,5)
Which works and it will output:
2 days 14 hours 57 min 2 seconds


But, if I add another "1" to it like this:

Code: [Select]
timeAgo2(1136622,5)

It shows:
Code: [Select]
14:03:43:42
Which is not right, it needs to show, 14 Days, 3hours 43minutes and 42 seconds.... Thank you, I finally explained myself better here, hope you understand

Hi i am have this word which is styled using span like this
Code: [Select]
<span style="color:blue;">php</span><span style="color:green;">academy</span>i used this word often on my site but i have to all the time retype so i was wondering what would be the best way to use the php include one way i was thing is create a variable on my header
Quote

<php $phpacademy=<span style="color:blue;">php</span><span style="color:green;">academy</span> <?php

or is better to include in a file on its own.?
or are both the wrong way of doing if so what would be the best option just tired of having to style it everytime i need to use that word all the time!

I created a function with a lot of optional peramiters. I dont necissarily want to use every option peramiter. As i recall you can do something like this
Code: [Select]
<?php
function($param, $param2, {$optional='value', $optional2='value2'});
//or
function($param, $param2, {$optional='value', $optional2='value2'});
?>
but both break my code. And i cant seem to find the correct syntax anywhere... Am i mistaken in thinking you can do this?

why is it that when i try to submit it tells me add a picture but i did added

Code: [Select]
<?php 
//decarling some variables
$msg = "";

//begin if
if($_POST['submitbtn']){

$author = mysql_real_escape_string($_POST['author']);
$date = mysql_real_escape_string($_POST['date']);
$picture = $_FILES['picture']['name'];
$ext = strtolower(substr($name,strpos($name,'.')+1));
$size = $_FILES['picture']['size'];
$maxsize = 200000;
$type = $_FILES['picture']['type'];
$tmp = $_FILES['picture']['tmp_name'];
$review = mysql_real_escape_string($_POST['review']);

$move = "uploads/";

if(isset($author) && !empty($author)){
if(isset($date) && !empty($date)){
if(isset($picture) && !empty($picture)){
if($size <= $maxsize){
if($ext == 'jpg' || $ext == 'jpeg' || $ext == 'png'){
if(move_uploaded_file($tmp,$move.$name)){
if(isset($review) && !empty($review)){
$query = mysql_query(" INSERT INTO reviews ('',author,date,picture,review) VALUES ('',$author,$date,$picture,$review)");
}else
$msg = "Please write a review";
}else
$msg = "Error has happen try again later";
}else
$msg = "Image must be a jpg, jpeg, or png";
}else
$msg = "You must select a smaller image size";
}else
$msg = "Select a picture";
}else
$msg = "Please enter a date";
}else
$msg = "Please fill in the Authors name";
}
//ending the if here
?>

Heya folks, I came here in hope someone could shed some light on the situation I'm in, it's probably looking me straight in the face and I cant see it..

So basically, I've got my page sorted, I'll theme it for my website later, but it echo's out entry's from a SQL database (images to be reviewed) then it has the name, id and accept and reject buttons.

Currently I have the page echoing perfectly, the reject button removes from SQL but does not delete the actual image (that's where I need help)
The accept button currently has no function as I've tried INSERT INTO but I cant get it working, so here's some code I hope someone knows what's missing

Page that echo's from SQL;

Code: [Select]
<?php
$dbHost = "xxxxxxx";

$dbUser = "xxxxxxx";

$dbPass = "xxxxxxx";

$dbName = "xxxxxxxx";

$db = mysql_connect($dbHost,$dbUser,$dbPass);

mysql_select_db($dbName,$db);

$image_name='fullsize'

?>

<?php $result = mysql_query("SELECT id, fullsize FROM tblimages");
$filename['fullsize'] 
?>

<html>
<table>
  <tr>
    <td>Image Uploads</td>
  </tr>
  <?php while($row = mysql_fetch_array($result)) :
   $image = $row['fullsize']
   ?>
  <tr>
    <td><?php echo $row['id']; ?></td>
    <td><?php echo $row['fullsize']; ?></td>
<td><?php echo '<img src= "uploads/'.$row['fullsize'].'" width="180" height="180"/> '; ?> </td>


    <!-- and so on -->
    <td>
      <form action="delete.php" method="post">
        <input type="hidden" name="delete_id" value="<?php echo $row['id']; ?>" />
        <input type="submit" value="Reject" />
      </form>
  <form action="insert.php" method="post">
        <input type="hidden" name="insert_id" value="<?php echo $row['filename']; ?>" />
        <input type="submit" value="Accept" />
      </form>
    </td>
  </tr>
  <?php endwhile; ?>
</table>
</html>
The delete.php's code is;

Code: [Select]
<?php
if(isset($_POST['delete_id']) && !empty ($_POST['delete_id'])) {
  $delete_id = mysql_real_escape_string($_POST['delete_id']);
  mysql_query("DELETE FROM tblimages WHERE `id`=".$delete_id);
  header('Location: test.php');
}
?>
And my insert.php is currently faulty code, so but I used virtually the same as the delete.php but where 'delete_id' is I replaced with 'insert_id'

My database is laid out like this,

tblimages (this is where images that need to be reviewed are stored)
     [id, fullsize] <- columns stored inside
images (this is where images that have been accepted should be moved to)
     [filename] <-where images should be inserted to.

Hope someone can understand and help with this, if so, thank you very much ^_^

I've develped this small script to display user reviews stored in a my databases review table. The problem with the script though is that it seems to be looping ad nauseum. The wierd thing though, is that I've used a very similair script to display another list of items on this site, and it worked correctly without any issue. Could someone take a look at this for me and diagnose the error with the script.

The SQL table:

Code: [Select]
CREATE TABLE IF NOT EXISTS `rev` (
  `id` int(11) NOT NULL AUTO_INCREMENT,
  `rev_name` varchar(100) CHARACTER SET utf8mb4 COLLATE utf8mb4_unicode_ci NOT NULL,
  `usr_name` varchar(100) CHARACTER SET utf8mb4 COLLATE utf8mb4_unicode_ci NOT NULL,
  `text` varchar(600) CHARACTER SET utf8mb4 COLLATE utf8mb4_unicode_ci NOT NULL,
  PRIMARY KEY (`id`)
) ENGINE=InnoDB  DEFAULT CHARSET=latin1 AUTO_INCREMENT=4 ;
The PHP script:

Code: [Select]
User reviews for <? echo $member;?>
<br>

<table border="0">

<?php
for($count = 1; $count <= $revrows; $count++)
{
$sqlrev = "SELECT * FROM rev WHERE rev_name = '$member' ORDER BY id DESC";
$revresult = mysql_query($sqlrev) or die(mysql_error());
$revrows = mysql_fetch_row($revresult);
$revname = mysql_fetch_array($revresult);
?>

<tr>
<?php
print "Review by: " . $revname['usr_name'] . "<br>". $revname['text'];
?>
</tr>

<?php
}
?>
</table>

Not sure how to describe what I'm trying to do here in the title, but here goes with what I am trying to accomplish.

I've got a few hundred lines of code in total so far, so I'll try to keep it as short as I can. I've got an application that I am programming using classes for each module and right now I am coding the base classes that I need in order for it to run (database, errors, logging, etc). What I'm doing for my database class is I have a query factory and it extends the MySQLi class so I can process, clean and code the rest of my app faster. I also have another, unrelated class "Error", which will be used for processing errors I might come across.

I'd rather do it this way instead of having to call trigger_error and error_log every time there is an error. I'd also not like to have to call a new instance of an object every time I need to use something from that class. Is there any way I can call a class within a class and return it as an object for all the methods within the class?

I've tried the methods below, but no luck I've tried others, but I'm trying to keep it brief and get what I'm trying to do across.

<?php

class QueryFactory extends MySQLi {

public  $err = new error(); //Doesn't work.
public  $err = error(); //Nope.

#This is the function that I need the $err object for.
function set($fields, $newvals) {

if ( is_array($fields) && is_array($newvals) ) {

if ( count($fields) != count($newvals) ) {
//Instead of below, I want to do something like $err->('Array lengths must match for method', 256, $islogged = 1);
                              trigger_error('Array lengths must match for method', 256);
}

}
}

}


The thing is, I have a "run.inc.php" which does include and create new objects for running just the basic app and if I try to redeclare the error class in query.class.php, it gives me an error saying I can't do that, but if i try to call $err from the page that has all the classes defined it throws an error saying that my method is undeclared. I'd like my error class be available to every other class I create so I can display and log errors as needed. Any suggestions or links to point me where I'd like to go?

I've been maintaining my old site http://www.tomsfreelance.com even though it's kind of just a business card at this point. So I decided to implement some javascript stuff I had been working on for other reasons. So far it seems to I have some work to do in Firefox, but I think it's working pretty well otherwise.   This is a bit of an oddball of a site and just about 99% javascript.   Feedback is much appreciated!

Hello all. I'm a newbie to this site and PHP and trying to build a basic contact/info form for an insurance company. I've been testing what I've done in FF, IE, and Google Chrome, and it seems to be generating consistent results ... but I thought I'd run it past the EXPERTS here, so you can tell me all that I've done wrong. : )

Attached is the PHP page that is triggered by a basic HTML page with check boxes, etc. And below is what a resulting email looks like, which is fine by me (of course this is empty).

Thanks for any advice!
-RP

-------------------------------------------------

Name:
Tel:
Company:
State:
Website:
Employees:

===== Type of Business =====
Manufacturer:
Retailer:
Jobber/Restyler:
Distributor:
Motorsports:
Professional Services:

===== Insurance Needs =====
General Liability:
Garage/Keepers:
Property Building:
Property Equipment:
Loss of Income:
Worker's Comp.:
Internet Liability:
Life & Disability:
Product Liability:
Legal Liability:
Property Contents:
Cargo/Mobile Property:
Employee Dishonesty:
401K & Retirement:
Health:
Other:

Personal Comments:

=========================

hello dear community


i try to find a way to use  file_get_contents: a download of set of pages:  Can any body review my approach

.. and as i thought i can find all 790 resultpages within a certain range between Id= 0 and Id= 100000 i thought, that i can go the way with a loop:

http://www.foundationfinder.ch/ShowDetails.php?Id=11233&InterfaceLanguage=&Type=Html
http://www.foundationfinder.ch/ShowDetails.php?Id=927&InterfaceLanguage=1&Type=Html
http://www.foundationfinder.ch/ShowDetails.php?Id=949&InterfaceLanguage=1&Type=Html
http://www.foundationfinder.ch/ShowDetails.php?Id=20011&InterfaceLanguage=1&Type=Html
http://www.foundationfinder.ch/ShowDetails.php?Id=10579&InterfaceLanguage=1&Type=Html

How to mechanize with a loop from 0 to 10000 and throw out 404 responses
once you reach the page we then could use beautifulsoup to get the content (in our case the image file address)
but we also  could just loop trough the images directely with simple webrequests.

Well  - how to proceed:

like this:


<?php
// creating a stream!
$opts = array(
  'http'=>array(
    'method'=>"GET",
    'header'=>"Accept-language: en\r\n" .
              "Cookie: foo=bar\r\n"
  )
);

// opens a file

$file = file_get_contents('http://www.example.com/', false, $context);
?>


a typical page is http://www.foundationfinder.ch/ShowDetails.php?Id=134&InterfaceLanguage=&Type=Html
and the related image is at http://www.foundationfinder.ch/ShowDetails.php?Id=134&InterfaceLanguage=&Type=Image

after downloading the images we will need to OCR them to extract any useful info,
so at some stage we need to look at OCR libs.


I think google opensourced one, and since its google it has a good chance it has a python API


can anybody review the approach - look forward to hear from you

I have spent a little time lately developing a database class (not finished yet) that automatically will escape the data that is sent to it if used properly. I would like to get some input on it and see what some of you guys think of it. Mainly I would like to know if it is easy to use, if there is any potential issues so far, and if there are any suggestions on better ways to do things in the class. I have attached a copy of the class to this post. Here is an example of how to use it:

Code: [Select]
//create object
$db = new db();

//perform query
$users = $db->table('users')->select('*')->where("name='%s'")->vars("somename")->getResults();

//another way to perform the query above
$db->table('users')->select('*')->where("name='%s'")->vars(array("somename"));
$users = $db->getResults();

You will have to change the db connection properties at the top of the db.class.php file for your own connections. Please let me know of any suggestions, questions or issues that you have.

So I was working on this site past month. I know it is too much time for such simple website, but I am a perfectionist and I need to have everything perfect. It is using JQuery, Twitter Bootstrap (I am deep fan of TWBS and I am using it on almost every website I make) and Yeti(?probably, I forgot ) theme from Bootswatch. Of course also FontAwesome for YT, FB, Twitter an GitHub icons. On smaller resolutions it is looking epic (1024x768 etc etc), on mobile devices too, but I am not sure how it looks on HD, HD-ready resolutions (yes, I can use zoom-out in my browser, but it is misleading...). What do you think?   P.S.: Projects in "My Recent Work" are clickable and that will toggle description with some fancy fade effect (using jQuery.toggle()).   P.S.2: I am not sure if I should vertically-center contact text or let it be with big top and bottom padding. What do you think?   P.S.3: Oh, I almost forgot. Website link is here http://deathbeam.github.io/. Yes, I am using GitHub pages, I love git. And nope, I do not bought my own domain yet.   P.S.4: I accept "brutal" criticizm, feel free to be rude   P.S.5: (this is starting to be annoying lol): If you guys have time, can you please tell me what feeling do you have from my subsite http://deathbeam.git...fwphp/index.htm. I tried to keep everything as simple as possible, but I am not sure if it is not too much :/   P.S.6: I am really sorry for my English...
Edited by deathbeam, 08 September 2014 - 01:08 PM.

Hello guys,   I am an intermediate level PHP programmer and digging my way through this giant universe of programming,   During this term, I have been able to build logics for problems (simple ones though) using my own thinking etc etc..   Anyway, I fully understand that I still have a lot to learn and I dont have any teachers to guide me through. So I wanted to request that If i submit an application for a quick review, like what I missed, how should I do it next time and guidance like this will seriously help me through.   I know it will be a pain reviewing someone else's apps but i dont have elsewhere to go..