PHP - New To Php, Looking For A Couple Basic Fixes

Ok, so I'm trying to develop/remake a web based browser game that I used to play back in 2006.

I've got a fair amount set up, considering I knew nothing about php/mysql about a week ago.
However, I've made a registration process, login system, and the game pages (member only).
However, I was talking to some people the other day, and I'm using MD5 to encrypt the passwords. The suggestion given to me was to use SHA2 with Salt. The problem that I'm facing is that no matter what I try, I can't seem to get the system working.. I've followed the advice originally recieved: no success. I've followed a tutorial online: no success. SO, I was wondering if someone from here could help me.

My database has the extra 'salt' field setup..
and here's my uneddited working MD5 code:

Code: [Select]
<?php
   //Start session
   session_start();
   
   //Include database connection details
   require_once('config.php');
   
   //Array to store validation errors
   $errmsg_arr = array();
   
   //Validation error flag
   $errflag = false;
   
   //Connect to mysql server
   $link = mysql_connect(DB_HOST, DB_USER, DB_PASSWORD);
   if(!$link) {
      die('Failed to connect to server: ' . mysql_error());
   }
   
   //Select database
   $db = mysql_select_db(DB_DATABASE);
   if(!$db) {
      die("Unable to select database");
   }
   
   //Function to sanitize values received from the form. Prevents SQL injection
   function clean($str) {
      $str = @trim($str);
      if(get_magic_quotes_gpc()) {
         $str = stripslashes($str);
      }
      return mysql_real_escape_string($str);
   }
   
   //Sanitize the POST values
   $email = clean($_POST['email']);
   $login = clean($_POST['login']);
   $password = clean($_POST['password']);
   $cpassword = clean($_POST['cpassword']);
   $empire_name = clean($_POST['empire_name']);
   $race = clean($_POST['race']);
   $referrer = clean($_POST['referrer']);
   
   
   
   //Input Validations
   if($email == '') {
      $errmsg_arr[] = 'Email missing';
      $errflag = true;
   }
   if($login == '') {
      $errmsg_arr[] = 'Username missing';
      $errflag = true;
   }
   if($password == '') {
      $errmsg_arr[] = 'Password missing';
      $errflag = true;
   }
   if($cpassword == '') {
      $errmsg_arr[] = 'Confirm password missing';
      $errflag = true;
   }
   if( strcmp($password, $cpassword) != 0 ) {
      $errmsg_arr[] = 'Passwords do not match';
      $errflag = true;
   }
   if($empire_name == '') {
      $errmsg_arr[] = 'Empire Name missing';
      $errflag = true;
   }
   if($race == '') {
      $errmsg_arr[] = 'Race not selected';
      $errflag = true;
   }
   if(strlen($login) > 20) {
      $errmsg_arr[] = 'Username exceeds allowed charachter limit';
      $errflag = true;
   }
   if(strlen($empire_name) > 20) {
      $errmsg_arr[] = 'Empire Name exceeds allowed charachter limit';
      $errflag = true;
   }
   
     


   
   //Check for duplicate login ID
   if($login != '') {
      $qry = "SELECT * FROM members WHERE login='$login'";
      $result = mysql_query($qry); }
      if($result) {
         if(mysql_num_rows($result) > 0) {
            $errmsg_arr[] = 'Username already in use';
            $errflag = true;
         }
         @mysql_free_result($result);
      }
      else {
         die("Query failed");
      }
      
         //Check for duplicate Empire Name
   if($empire_name != '') {
      $qry = "SELECT * FROM members WHERE empire_name='$empire_name'";
      $result = mysql_query($qry); }
      if($result) {
         if(mysql_num_rows($result) > 0) {
            $errmsg_arr[] = 'Empire Name already in use';
            $errflag = true;
         }
         @mysql_free_result($result);
      }
      else {
         die("Query failed");
      }
   
   
   //If there are input validations, redirect back to the registration form
   if($errflag) {
      $_SESSION['ERRMSG_ARR'] = $errmsg_arr;
      session_write_close();
      header("location:register-form.php");
      exit();
   }

   //Create INSERT query
$qry = "INSERT INTO members(email, login, passwd, empire_name, race, referrer) VALUES('$email','$login','".md5($_POST['password'])."','$empire_name','$race','$referrer')";
   $result = @mysql_query($qry);
   
   //Check whether the query was successful or not
   if($result) {
      header("location: register-success.php");
      exit();
   }else {
      die("Query failed");
   }
?>

My second question is:
I've got a set of permissions in my members database.. These are guest, player, mod and admin.
I'm currently running my updates page by calling the updates from the database... How would i go about adding a link to the first page you come to (after logging in) that can only be seen by members who are in the admin permission?
Because I'd like to make an admincp with a page to submit a form to the database that updates the updates page.. However, I'd rather the link to it only showed up for me and was invisible to other members..

Again, I'm only asking because I cant seem to find any information online at any tutorials or worksheets that I've come across.. And believe me, I've been searching quite a bit.. :/

Any help would be very much appreciated..
Cheers,
/zythion/

Ok If anyone read my recent topics they will know I am making a forum system This system for users is currently about 1/3 complete and I now have a couple of issues.

Firstly:
When a user logs in I am using $_SESSION['RAYTH_MEMBER_ID'] to save their member ID for when they return. However every time the browser/page is closed it doesn't save and then they are logged out. How would I set it so it keeps them logged in until they personally logout?

Secondly:
Since It's a forum you expect there to be new lines and stuff when you Read posts in threads (like we do here). How would I set it when a user posts it replaces every return character from the input (enter/newline etc) and replace it with <br> in the mysql database?

Thanks for your help

This topic has been moved to JavaScript Help.

http://www.phpfreaks.com/forums/index.php?topic=330539.0

I am trying to store website address in a variable but when I do so the dots in the address are missing. I guess it takes it as string concatenation, for example:
$address='www.lottocomplete.com';
will actually give me: wwwlottocompletecom
How can I make sure these dots will be preserved?

I am also trying to store email address in a variable but I get error, something about @ symbol being in wrong spot, wonder how this can be resolved as well.

One more questions relates to the new line issue that I have when I concatenate string, for example if I do the following:

$string = "1\n";
$string .= "2\n";
$string .= "3\n";

I would think that each number would be printed on new line but instead it shows up as: 123

What am I doing wrong?

Having trouble figuring this out.

1) How can I check whether the user's input for a field is an integer with a value greater than 0?

Was thinking of using regular expressions using 1-9 but then 10 might result in an error and that's not wanted.

2) For a field that's a drop-down, how can I have an error show if they choose the default option (value of "none")

Thanks for the help.