PHP - Help With Namespace

I think I am close, but not sure if I am quite there.  Am I doing this correctly?

I have several entity classes which will use class type inheritance:

MyNamespace\MyApp\Vehicle\Vehicle
    MyNamespace\MyApp\Vehicle\AirVehicle\AirVehicle
        MyNamespace\MyApp\Vehicle\AirVehicle\Airplane\Airplane
        MyNamespace\MyApp\Vehicle\AirVehicle\Rocket\Rocket
    MyNamespace\MyApp\Vehicle\GroundVehicle\GroundVehicle
        MyNamespace\MyApp\Vehicle\GroundVehicle\Car\Car
        MyNamespace\MyApp\Vehicle\GroundVehicle\Train\Train
                
The entity meta data is as follows:

#MyNamespace.MyApp.Vehicle.Vehicle.dcm.yml
MyNamespace\MyApp\Vehicle\Vehicle:
    type: entity
    table: vehicle_table
    inheritanceType: JOINED
    discriminatorColumn:
        name: discriminator_column
        type: string
    discriminatorMap:
        vehicle: Vehicle
        groundVehicle: MyNamespace\MyApp\Vehicle\GroundVehicle\GroundVehicle
        airVehicle: MyNamespace\MyApp\Vehicle\AirVehicle\AirVehicle
    repositoryClass: Vehicle
    id:
        id:
            type: integer
            generator:
                strategy: AUTO
    fields:
        grandParentItem1:
            type: string
        grandParentItem2:
            type: string

#MyNamespace.MyApp.Vehicle.AirVehicle.AirVehicle.dcm.yml
MyNamespace\MyApp\Vehicle\AirVehicle\AirVehicle:
    type: entity
    table: air_vehicle
    extends: MyNamespace\MyApp\Vehicle\Vehicle
    inheritanceType: JOINED
    discriminatorMap:
        airVehicle: AirVehicle
        airplane: MyNamespace\MyApp\Vehicle\AirVehicle\Airplane\Airplane
        rocket: MyNamespace\MyApp\Vehicle\AirVehicle\Rocket\Rocket
    repositoryClass: AirVehicle
    id:
        id:
            associationKey: true
    fields:
        parentItem1:
            type: string
        parentItem2:
            type: string

#MyNamespace.MyApp.Vehicle.AirVehicle.Rocket.Rocket.dcm.yml
MyNamespace\MyApp\Vehicle\AirVehicle\Rocket\Rocket:
    extends: MyNamespace\MyApp\Vehicle\AirVehicle\AirVehicle
    type: entity
    table: rocket_table
    id:
        id:
            associationKey: true
    repositoryClass: Rocket
    fields:
        childItem1:
            type: string
        childItem2:
            type: string

I haven't shown GroundVehicle or Train, Car, and Airplane, but they are almost identical to AirVehicle and Rocket, respectively.

I've discovered that the barebone entities need to be manually created prior to using orm:generate-entities else I get class not found errors, and have created them as shown below.
        
inheritance_src/MyNamespace/MyApp/Vehicle/Vehicle.php
    inheritance_src/MyNamespace/MyApp/Vehicle/AirVehicle/AirVehicle.php
        inheritance_src/MyNamespace/MyApp/Vehicle/AirVehicle/Airplane/Airplane.php
        inheritance_src/MyNamespace/MyApp/Vehicle/AirVehicle/Rocket/Rocket.php
    inheritance_src/MyNamespace/MyApp/Vehicle/GroundVehicle/GroundVehicle.php
        inheritance_src/MyNamespace/MyApp/Vehicle/GroundVehicle/Car/Car.php
        inheritance_src/MyNamespace/MyApp/Vehicle/GroundVehicle/Train/Train.php

[michael@devserver doctrine]$ find inheritance_src -name "*.php" -exec cat {} \;
<?php
namespace MyNamespace\MyApp\Vehicle\AirVehicle\Airplane;
class Airplane extends \MyNamespace\MyApp\Vehicle\AirVehicle\AirVehicle{}
<?php
namespace MyNamespace\MyApp\Vehicle\AirVehicle\Rocket;
class Rocket extends \MyNamespace\MyApp\Vehicle\AirVehicle\AirVehicle{}
<?php
namespace MyNamespace\MyApp\Vehicle\AirVehicle;
abstract class AirVehicle extends \MyNamespace\MyApp\Vehicle\Vehicle{}
<?php
namespace MyNamespace\MyApp\Vehicle\GroundVehicle\Car;
class Car extends \MyNamespace\MyApp\Vehicle\GroundVehicle\GroundVehicle{}
<?php
namespace MyNamespace\MyApp\Vehicle\GroundVehicle\Train;
class Train extends \MyNamespace\MyApp\Vehicle\GroundVehicle\GroundVehicle{}
<?php
namespace MyNamespace\MyApp\Vehicle\GroundVehicle;
abstract class GroundVehicle extends \MyNamespace\MyApp\Vehicle\Vehicle{}
<?php
namespace MyNamespace\MyApp\Vehicle;
abstract class Vehicle{}

I then am able to successfully create the entities using orm:generate-entities, schema using orm:schema-tool:create, and repositories using orm:generate-repositories.

Does everything seem correct?

A couple of issues which I have my doubts:

Locating the classes in inheritance_src/MyNamespace/MyApp instead of inheritance_src/MyApp.  I tried to do the later and modify my psr-4 autoloader to use "MyNamespace\\": "inheritance_src/", but could not get it working without first creating the entities, editing them to add the "abstract" and "extend" portions, and then moving them to one directory lower. Needing to manually create the barebone classes in the first place.  My meta-data definitions includes "extends: MyNamespace\MyApp\Vehicle\Vehicle", so I would thought it would not be necessary. Locate both the entities and repositories in the same folder.  For that matter, I will probably be locating my service in the same folder as well.  It seems that most frameworks will locate all the entities in one folder (with of course subdirectories), repositories in another, services in another, etc.  The way I am doing seems to be organized domain modules as described by https://mnapoli.fr/organizing-code-into-domain-modules/.  Any compelling reasons to do it one way or the other?

Thank you
 

I am assuming doing the following is bad practice as the short name "Account" is both for the repository and account.  Agree?  Appears that use always takes precedent over namespace and just Account\User is always short for \NotionCommotion\Domain\Entity\Account\User and not \NotionCommotion\Api\Account\User.  Still sees like it could easily result in confusion.

namespace NotionCommotion\Domain\Repository\Account;
use NotionCommotion\Domain\Entity\Account;
class AccountRepository
{
    public function getUser(string $mainKey, int $userId):?Account\User {
        //
    }
}

Would it be better to do something like the following?  Interestingly, it worked fine on the below class but when I tried to do so on the above AccountRepository class, it resulted in AccountDir\User class not found error.  Is there any logic reason why that might/should happen, or is it more likely I just have some error elsewhere?

namespace NotionCommotion\Api\Account;
use NotionCommotion\Domain\Entity\Account as AccountDir;
class AccountService
{
    public function read():AccountDir\Account {
        //
    }
}

I have here what I would refer to as doozy. I'm not sure anyone is going to be able to help as there is allot involved.

The issue could be in a number of locations, I am using PHPUnit as a test suite (and this is how I have found the issue) and PHP5.4rc5. The problem could be in either, or it could be in my code.

I am also using a cascading filesystem (explained here) and while I'm confident this isn't the issue. It has the potential to be involved I guess. If you need to see how this is implemented it is see he https://github.com/proem/proem/blob/develop/lib/Proem/Api/Autoloader.php#L108

I have narrowed the problem down to two classes:

https://github.com/proem/proem/blob/develop/lib/Proem/Api/Chain.php & https://github.com/proem/proem/blob/develop/lib/Proem/Api/Proem.php

The tests that test these classes a

https://github.com/proem/proem/blob/develop/tests/lib/Proem/Tests/ChainTest.php & https://github.com/proem/proem/blob/develop/tests/lib/Proem/Tests/ProemTest.php

As the code stands right now, everything is fine and all tests pass. However, I am about to start some more work on the Proem\Api\Proem class and it needs access to the Proem\Api\Chain class.

To do this, I add the line "use Proem\Chain;", the code becomes:


<?php

/**
 * @namespace Proem\Api
 */
namespace Proem\Api;

use Proem\Chain;

/**
 * Proem\Api\Proem
 *
 * The Proem boostrap wrapper (eventually)
 */
class Proem
{
    const VERSION = '0.1.0';
}


As soon as I do this the tests fail with:

Quote

Fatal error: Cannot use Proem\Chain as Chain because the name is already in use in /home/thorpe/src/proem/lib/Proem/Api/Proem.php on line 32


If I alias the namespace ( "use Proem\Chain as C;" ) the tests pass again. The issue is I shouldn't have to use an alias here.

from the manual:
Quote

Note:

Importing rules are per file basis, meaning included files will NOT inherit the parent file's importing rules.


Writing this post I have come to realise that the issue is likely that both the Chain class and the Proem class are in the same namespace yet I am trying to force the Chain class to be loaded from Proem\Chain instead of Proem\Api\Chain (this is part of the cascading filesystem setup).

Anyway, if anyone has some ideas I would be grateful if you could take a look. Otherwise, it looks like I might need to do some re-shuffling.

Iv'e created a ticket for this bug if anyone wan't to chip in. See here