PHP - Sql Query Issues

Hello,   I am trying to run a report as per the below mssql query:  

$query = "SELECT tblWJCItem.AddedDescription, tblWJC.WJCPrefix, tblWJC.WJCNo, tblWJCItem.MaterialName, tblStockFamily.StockFamily, tblWJCItem.WeightToSend, tblWJC.DateCreated, tblWJC.WJCStatusID FROM tblWJC INNER JOIN tblCustomer ON tblWJC.CustomerID = tblCustomer.CustomerID INNER JOIN tblWJCStockStatus ON tblWJC.WJCStockStatusID = tblWJCStockStatus.WJCStockStatusID INNER JOIN tblStockStatus ON tblWJC.WJCID = tblStockStatus.WJCID LEFT OUTER JOIN tblWJCProductLine ON tblWJC.WJCID = tblWJCProductLine.WJCID
LEFT OUTER JOIN tblWJCStockItem ON tblWJCProductLine.WJCProductLineID = tblWJCStockItem.tblWJCStockItem INNER JOIN tblStockFamily ON tblWJCItem.ProductFamilyID = tblStockFamily.StockFamilyID WHERE tblCustomer.CustomerName = 'NAME' AND tblWJCStockStatus.WJCStockStatus <> 'Stock Usage Confirmed' ORDER BY tblWJC.WJCID";

I get this error when I run the query:  and I have no idea how to fix..  I have been staring at this for days.


Warning: mysqli_fetch_assoc() expects parameter 1 to be mysqli_result, null given in /onlinebanking/viewtransactions.php on line 65

This is my view transactions page
Code: [Select]
<?php
 //viewtransaction 
  require_once('../websiteconfig.inc.php');
    require_once(ABSOLUTE_PATH . 'class/database.class.php');
require_once(ABSOLUTE_PATH . 'class/person.class.php'); 
require_once(ABSOLUTE_PATH . 'class/bankaccount.class.php');



/*START SESSION*/
session_start();

$currentMember = unserialize($_SESSION['currentMember']);
$currentMember->connection = $conn;

/*Database*/
$db = new Database;
$conn = $db->connection;

$bank_account = $_GET['q'];

?>


       
        </div>
        <link href="../_assets/stylesheets/css_dd_bankingnav.css" rel="stylesheet" type="text/css" />
        <link href="../_assets/stylesheets/style.css" rel="stylesheet" type="text/css" />
        <div class="container" id="shadow">
        <div>
      <?php 

                include(ABSOLUTE_PATH . 'header.inc.php');
            ?>


                <div>
                <h1 class="body" align="center">Accounts</h1>
               
                <?php
                include(ABSOLUTE_PATH . 'onlinebanking/onlinebankingnav.inc.php');
               ?>
               
               

                <table id="accounts" summary="Bank Account Balance Information" border="3" align="center">
                <thead>
                <tr>
                        <th bgcolor="#CCCCCC">Account ID</th>
                        <th bgcolor="#CCCCCC">Transaction Date</th>
                        <th bgcolor="#CCCCCC">Transaction Type</th>
                        <th bgcolor="#CCCCCC">Transaction Amount</th>
                        <th bgcolor="#CCCCCC">Current Balance</th>
                     </tr>                     
                </thead>
                <tbody>
<?php

$bankaccount = new Bankaccount($account['BankAccountID']);
$bankaccount->connection = $conn;

/*Loop thorugh account - Grabs data*/
while($transaction = mysqli_fetch_assoc($transactionbalance)) {
$transactionbalance = $bankaccount->retrieve_transactions($transaction['BankAccountID']);

//looks for account data
$querydata = mysqli_num_rows($transactionbalance);

//Looks for transcations
if ($querydata == 0) {
echo ('There is no transaction history on this account');
}
else {
}
echo '<tr>' . "\n";
echo "\t" . '<td>' . $transaction['BankAccountID'] . '</td>' . "\n";
echo "\t" . '<td>' . $accounttype['TransactionDate'] . '</td>' . "\n";
echo "\t" . '<td>' . $accounttype['TransactionType'] . '</td>' . "\n";
echo "\t" . '<td>$' . number_format($accounttype['TransactionAmount'], 2) . '</td>' . "\n";
echo "\t" . '<td>$' . number_format($transaction['CurrentBalance'], 2) . '</td>' . "\n";
echo '<tr>' . "\n";

}


/*Close DB*/
mysqli_close($db->connection);
?>

</tbody>
        </table>
        <br>

               
                </div><!--End of main content-->
<?php 
                include(ABSOLUTE_PATH . 'footer.inc.php');
            ?>

</div><!--end of header-->




This is my bankaccount.class page


Code: [Select]
<?php
/*Bankaccount Class*/
class Bankaccount {

/*attributes for the first and last name of the class*/
private $accountid;
private $memberid;
private $accounttypeid;
private $accounttypename;
public  $connection;

/*Constructs the function*/
function __construct($accountid, $accounttypeid){
$this->accountid = $accountid;
$this->accounttypeid = $accounttypeid;
} //end constructor

/*Destroys the function*/
function __destruct(){
} //ends destructor 

/*Get funtion*/
public function __get($name) {
return $this->$name;
} // Ends get funtction

/*Use the set function*/
public function __set($name, $value) {
$this->$name=$value;
} //End set function


/*This is what retrieves the values from memmory*/
public function retrieve_current_balance() {
$balance_query = "SELECT CurrentBalance UserID FROM BankAccount WHERE BankAccountID = " . $this->accountid . " LIMIT 0,1";
$result = mysqli_query($this->connection, $balance_query);
return $result;
}

This is the part of my bankaccount.class that actually involves viewing my transactions
Code: [Select]
<?php
//query for transactions
public function retrieve_transactions() {
$transaction_query = "SELECT tl.TransactionDate, tt.TransactionType, tl.TransactionAmount FROM TransactionLog tl INNER JOIN TransactionType tt ON tl.TransactionTypeID = tt.TransactionTypeID WHERE BankAccountID = " . $this->accountid . " LIMIT 0,1";
$result = mysqli_query($this->connection, $transaction_query);
$db_array = mysqli_fetch_array($results);
return $result;
}
?>
Code: [Select]
<?php
/*Function validates user account for user ID*/
public function validate_useraccount(){
$account_query = "SELECT UserID FROM BankAccount WHERE UserID = " . $this->accountid;
$results = mysqli_query($this->connection, $account_query);
$db_array = mysqli_fetch_array($results);
$return_value = 1;

if(count($db_array()) < 1) 
{ 
$return_value = 0; 
}  
return $return_value;
}

/*Deposit*/
public function deposit($UserID=0, $BankAccountID=0, $DepositAmount=0){
$getbalance = mysqli_fetch_assoc($this->retrieve_current_balance()); $currentbalance = $getbalance['CurrentBalance'];
$today = date('Y-m-d', mktime());

/*Deposit Funds*/
$newbalance = $currentbalance + $DepositAmount;
$deposit = mysqli_query($this->connection, "UPDATE BankAccount SET CurrentBalance = $newbalance WHERE BankAccountID = $BankAccountID");

if($deposit){ //transaction completed

/*Update Transaction log*/
$log_query = "INSERT INTO TransactionLog (TransactionTypeID, BankAccountID, UserID, TransactionAmount, TransactionDate) VALUES (1, $BankAccountID, $UserID, $DepositAmount, $today')";

mysqli_query($this->connection, $log_query);
}

/*New Balance*/
return $newbalance;

}
} //End of class

?>

Hey all,

First off, if this is in the wrong section I apologize. I wasn't sure if it should be here or the mySQL section.

What's going on is, I'm in the process of learning the Prepared Statement way of doing things and am changing / updating my code to reflect the changes. Everything was going fine until I attempted to do what I could do using old MySQL methods and that is display the queried results on the same page.


I can place a query and display the results as they should be displayed if I only use one block of code. However, if I try to do any additional queries on the same page, they get killed and do not display anything even though I know the query is fine because I can test the exact same syntax below one a different page and it works.

Here's a code snippet for an example:
Code: [Select]

Code:
<table>
<tr>
<td>
// The below code will display a selection box containing various strings such as "hello world", "great to be here", "Wowserz", "this is mind blowing" etc. that are stored in the database.

<?php

   echo "<select = \"SpecialConditions\">";
   if($stmt->num_rows == NULL){
      echo "No results found.";
   }else{
      while($stmt->fetch()){
   
       echo "<option value=\"$specialId\">$specialcondition</option>";
   }
}
   echo "</select>";
?>
</td>
<td>
// If I place another fetch query below the above fetch() query, this one will not show up. This one is supposed to display values 1 - 20 that have been stored in the DB.

<?php
echo "<select = \"NumberSets\">";
   if($stmt->num_rows == NULL){
      echo "No results found.";
   }else{
      while($stmt->fetch()){
      
          echo "<option value=\"".$numbers."\">".$numbers."</option>";
      }
   }
echo "</select>";

?>

</td>
</tr>
</table>


What am I doing wrong with this? When I use regular SQL queries I can display multiple results on the same page.

The results are being pulled from two separate joined tables but I don't think that's the issue.

Here is my code:
// Start MySQL Query for Records
$query = "SELECT codes_update_no_join_1b" .
"SET orig_code_1 = new_code_1,
       orig_code_2 = new_code_2" .
"WHERE concat(orig_code_1, orig_code_2) = concat(old_code_1, old_code_2)";
$results = mysql_query($query) or die(mysql_error());
// End MySQL Query for Records


This query runs perfectly fine when run direct as SQL in phpMyAdmin, but throws this error when running in my script??? Why is this???

Code: [Select]
You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '= new_code_1, orig_code_2 = new_code_2WHERE concat(orig_code_1, orig_c' at line 1

Hello all,   Based on the suggestion of you wonderful folks here, I went away for a few days (to learn about PDO and Prepared Statements) in order to replace the MySQLi commands in my code. That's gone pretty well thus far...with me having learnt and successfully replaced most of my "bad" code with elegant, SQL-Injection-proof code (or so I hope).   The one-and-only problem I'm having (for now at least) is that I'm having trouble understanding how to execute an UPDATE query within the resultset of a SELECT query (using PDO and prepared statements, of course).   Let me explain (my scenario), and since a picture speaks a thousand words I've also inlcuded a screenshot to show you guys my setup:   In my table I have two columns (which are essentially flags i.e. Y/N), one for "items alreay purchased" and the other for "items to be purchased later". The first flag, if/when set ON (Y) will highlight row(s) in red...and the second flag will highlight row(s) in blue (when set ON).   I initially had four buttons, two each for setting the flags/columns to "Y", and another two to reverse the columns/flags to "N". That was when I had my delete functionality as a separate operation on a separate tab/list item, and that was fine.   Now that I've realized I can include both operations (update and delete) on just the one tab, I've also figured it would be better to pare down those four buttons (into just two), and set them up as a toggle feature i.e. if the value is currently "Y" then the button will set it to "N", and vice versa.   So, looking at my attached picture, if a person selects (using the checkboxes) the first four rows and clicks the first button (labeled "Toggle selected items as Purchased/Not Purchased") then the following must happen:   1. The purchased_flag for rows # 2 and 4 must be switched OFF (set to N)...so they will no longer be highlighted in red. 2. The purchased_flag for row # 3 must be switched ON (set to Y)...so that row will now be highlighted in red. 3. Nothing must be done to rows # 1 and 5 since: a) row 5 was not selected/checked to begin with, and b) row # 1 has its purchase_later_flag set ON (to Y), so it must be skipped over.   Looking at my code below, I'm guessing (and here's where I need the help) that there's something wrong in the code within the section that says "/*** loop through the results/collection of checked items ***/". I've probably made it more complex than it should be, and that's due to the fact that I have no idea what I'm doing (or rather, how I should be doing it), and this has driven me insane for the last 2 days...which prompted me to "throw in the towel" and seek the help of you very helpful and intellegent folks. BTW, I am a newbie at this, so if I could be provided the exact code, that would be most wonderful, and much highly appreciated.   Thanks to you folks, I'm feeling real good (with a great sense of achievement) after having come here and got the great advice to learn PDO and prepared statements.   Just this one nasty little hurdle is stopping me from getting to "end-of-job" on my very first WebApp. BTW, sorry about the long post...this is the best/only way I could clearly explaing my situation.   Cheers guys!

case "update-delete":
	if(isset($_POST['highlight-purchased'])) 
		{
			// ****** Setup customized query to obtain only items that are checked ******
			$sql = "SELECT * FROM shoplist WHERE";
					for($i=0; $i < count($_POST['checkboxes']); $i++)
						{
							$sql=$sql . " idnumber=" . $_POST['checkboxes'][$i] . " or";
						}
					$sql= rtrim($sql, "or");
											
			$statement = $conn->prepare($sql);
			$statement->execute();
																						
			// *** fetch results for all checked items (1st query) *** //
			$result = $statement->fetchAll();

			$statement->closeCursor();
											
			// Setup query that will change the purchased flag to "N", if it's currently set to "Y"
			$sqlSetToN = "UPDATE shoplist SET purchased = 'N' WHERE purchased = 'Y'";
											
			// Setup query that will change the purchased flag to "Y", if it's currently set to "N", "", or NULL
			$sqlSetToY = "UPDATE shoplist SET purchased = 'Y' WHERE purchased = 'N' OR purchased = '' OR purchased IS NULL";

			$statementSetToN = $conn->prepare($sqlSetToN);
			$statementSetToY = $conn->prepare($sqlSetToY);
											
			/*** loop through the results/collection of checked items ***/
			foreach($result as $row)
				{
					if ($row["purchased"] != "Y")
						{
							// *** fetch one row at a time pertaining to the 2nd query *** //
							$resultSetToY = $statementSetToY->fetch();
															
							foreach($resultSetToY as $row)
								{															
									$statementSetToY->execute();																
								}
						}
					else
						{
							// *** fetch one row at a time pertaining to the 2nd query *** //
							$resultSetToN = $statementSetToN->fetch();
															
							foreach($resultSetToN as $row)
								{															
									$statementSetToN->execute();																
								}
						}
				}
				break;
		}

 CRUD Queston.png   20.68KB   0 downloads